fix: address PR-57 CodeRabbit findings and CI failures

- use filtered word counts in media detail session token aggregation - cancel fullscreen refresh burst on exit via updateLinuxMpvFullscreenOverlayRefreshBurst - guard Hyprland JSON.parse in try/catch; exclude windowtitle from geometry events - narrow focus suppression from :focus to :focus-visible - apply JLPT lock selectors to word-name-match tokens (N1–N5)
2026-05-13 20:12:54 -07:00 · 2026-05-12 00:28:48 -07:00
parent 6e666d7ca5
commit 6bf905140c
12 changed files with 206 additions and 14 deletions
@@ -0,0 +1,40 @@
+---
+id: TASK-347
+title: Address PR 57 CodeRabbit review round after stats session fix
+status: In Progress
+assignee:
+  - codex
+created_date: '2026-05-12 07:02'
+updated_date: '2026-05-12 07:02'
+labels:
+  - pr-review
+  - coderabbit
+  - ci
+dependencies: []
+references:
+  - 'https://github.com/ksyasuda/SubMiner/pull/57'
+priority: high
+---
+
+## Description
+
+<!-- SECTION:DESCRIPTION:BEGIN -->
+Assess and address the 2026-05-12 CodeRabbit review on PR #57 plus the current red GitHub Actions check. Latest comments cover stats session detail token aggregation, Linux fullscreen overlay refresh scheduling, Hyprland title-event polling, malformed Hyprland monitor JSON handling, and JLPT-lock test coverage for name matches.
+<!-- SECTION:DESCRIPTION:END -->
+
+## Acceptance Criteria
+<!-- AC:BEGIN -->
+- [ ] #1 Still-valid latest CodeRabbit findings on PR #57 are fixed or documented as skipped with rationale.
+- [ ] #2 CI failure context is inspected and any repo-relevant failing tests or formatting issues are fixed.
+- [ ] #3 Regression coverage is added for behavior changes where practical before production edits.
+- [ ] #4 Relevant local verification passes.
+<!-- AC:END -->
+
+## Implementation Plan
+
+<!-- SECTION:PLAN:BEGIN -->
+1. Inspect failing GitHub Actions log and current code around each latest CodeRabbit finding.
+2. Add or update focused regression tests first for behavior changes: stats token aggregation, fullscreen refresh exit cancellation, Hyprland monitor parse failure, and title-only event filtering.
+3. Apply minimal production fixes for still-valid findings, plus the subtitle-render duplicate test coverage item.
+4. Run targeted tests first, then format/typecheck and broader relevant gates; update the task with results.
+<!-- SECTION:PLAN:END -->
@@ -0,0 +1,56 @@
+---
+id: TASK-348
+title: Fix PR 57 coverage CI focus chrome failure
+status: Done
+assignee:
+  - '@codex'
+created_date: '2026-05-12 07:02'
+updated_date: '2026-05-12 07:11'
+labels:
+  - ci
+  - bug
+dependencies: []
+references:
+  - 'https://github.com/ksyasuda/SubMiner/pull/57'
+  - 'https://github.com/ksyasuda/SubMiner/actions/runs/25718536412'
+priority: high
+---
+
+## Description
+
+<!-- SECTION:DESCRIPTION:BEGIN -->
+Investigate and fix current GitHub Actions `build-test-audit` failure on PR #57 (`tokenizer-updates`). CI fails during `bun run test:coverage:src` in the maintained source lane: `renderer stylesheet hides focus chrome on top-level overlay focus targets`.
+<!-- SECTION:DESCRIPTION:END -->
+
+## Acceptance Criteria
+<!-- AC:BEGIN -->
+- [x] #1 Root cause of the focus chrome coverage failure is identified from CI/local test output.
+- [x] #2 A focused fix is applied without broad unrelated changes.
+- [x] #3 Relevant local coverage/test command passes.
+- [x] #4 Remote PR check status is rechecked or next CI action is documented.
+<!-- AC:END -->
+
+## Implementation Plan
+
+<!-- SECTION:PLAN:BEGIN -->
+1. Reproduce the CI failure locally with `bun test src/renderer/overlay-legacy-cleanup.test.ts`.
+2. Update the stale legacy cleanup assertion to expect top-level `:focus-visible` suppression and reject broad `:focus` suppression.
+3. Run the targeted test and `bun run test:coverage:src` to match CI's failing lane.
+4. Recheck PR checks or document that CI needs a push/rerun.
+<!-- SECTION:PLAN:END -->
+
+## Implementation Notes
+
+<!-- SECTION:NOTES:BEGIN -->
+CI/local root cause: `src/renderer/style.css` was intentionally changed to `html/body/#overlay:focus-visible`, but `src/renderer/overlay-legacy-cleanup.test.ts` still required broad `:focus` selectors. The stale assertion fails in `test:coverage:src`.
+
+Additional coverage-lane failure after first fix: `src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts` imported `updateLinuxMpvFullscreenOverlayRefreshBurst`, but `src/main/runtime/linux-mpv-fullscreen-overlay-refresh.ts` did not export/implement it. Added the helper to cancel existing bursts and schedule only while fullscreen is true.
+
+Verification passed: `bun test src/renderer/overlay-legacy-cleanup.test.ts`; `bun test src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts`; `bun run test:coverage:src`; `bun run format:check:src`. `gh pr checks 57` still reports the old failed `build-test-audit` run at run 25718536412; branch needs push/rerun for remote green.
+<!-- SECTION:NOTES:END -->
+
+## Final Summary
+
+<!-- SECTION:FINAL_SUMMARY:BEGIN -->
+Fixed current PR #57 `build-test-audit` CI blockers. Updated the stale overlay legacy cleanup assertion to expect `:focus-visible` top-level focus suppression and guard against reintroducing broad `:focus` suppression. Added the missing `updateLinuxMpvFullscreenOverlayRefreshBurst` export used by the Linux fullscreen overlay refresh tests. Verification passed locally: focused overlay legacy cleanup test, focused Linux fullscreen refresh test, `bun run test:coverage:src`, and `bun run format:check:src`. Remote PR checks still show the old failed `build-test-audit` run until these local changes are pushed and CI reruns.
+<!-- SECTION:FINAL_SUMMARY:END -->