mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-05-13 08:12:54 -07:00
6bf905140c
- use filtered word counts in media detail session token aggregation - cancel fullscreen refresh burst on exit via updateLinuxMpvFullscreenOverlayRefreshBurst - guard Hyprland JSON.parse in try/catch; exclude windowtitle from geometry events - narrow focus suppression from :focus to :focus-visible - apply JLPT lock selectors to word-name-match tokens (N1–N5)
1.7 KiB
1.7 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-347 | Address PR 57 CodeRabbit review round after stats session fix | In Progress |
|
2026-05-12 07:02 | 2026-05-12 07:02 |
|
|
high |
Description
Assess and address the 2026-05-12 CodeRabbit review on PR #57 plus the current red GitHub Actions check. Latest comments cover stats session detail token aggregation, Linux fullscreen overlay refresh scheduling, Hyprland title-event polling, malformed Hyprland monitor JSON handling, and JLPT-lock test coverage for name matches.
Acceptance Criteria
- #1 Still-valid latest CodeRabbit findings on PR #57 are fixed or documented as skipped with rationale.
- #2 CI failure context is inspected and any repo-relevant failing tests or formatting issues are fixed.
- #3 Regression coverage is added for behavior changes where practical before production edits.
- #4 Relevant local verification passes.
Implementation Plan
- Inspect failing GitHub Actions log and current code around each latest CodeRabbit finding.
- Add or update focused regression tests first for behavior changes: stats token aggregation, fullscreen refresh exit cancellation, Hyprland monitor parse failure, and title-only event filtering.
- Apply minimal production fixes for still-valid findings, plus the subtitle-render duplicate test coverage item.
- Run targeted tests first, then format/typecheck and broader relevant gates; update the task with results.