sudacode
6bf905140c
- use filtered word counts in media detail session token aggregation - cancel fullscreen refresh burst on exit via updateLinuxMpvFullscreenOverlayRefreshBurst - guard Hyprland JSON.parse in try/catch; exclude windowtitle from geometry events - narrow focus suppression from :focus to :focus-visible - apply JLPT lock selectors to word-name-match tokens (N1–N5)
3.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | |||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-348 | Fix PR 57 coverage CI focus chrome failure | Done |
|
2026-05-12 07:02 | 2026-05-12 07:11 |
|
|
high |
Description
Investigate and fix current GitHub Actions build-test-audit failure on PR #57 (tokenizer-updates). CI fails during bun run test:coverage:src in the maintained source lane: renderer stylesheet hides focus chrome on top-level overlay focus targets.
Acceptance Criteria
- #1 Root cause of the focus chrome coverage failure is identified from CI/local test output.
- #2 A focused fix is applied without broad unrelated changes.
- #3 Relevant local coverage/test command passes.
- #4 Remote PR check status is rechecked or next CI action is documented.
Implementation Plan
- Reproduce the CI failure locally with
bun test src/renderer/overlay-legacy-cleanup.test.ts. - Update the stale legacy cleanup assertion to expect top-level
:focus-visiblesuppression and reject broad:focussuppression. - Run the targeted test and
bun run test:coverage:srcto match CI's failing lane. - Recheck PR checks or document that CI needs a push/rerun.
Implementation Notes
CI/local root cause: src/renderer/style.css was intentionally changed to html/body/#overlay:focus-visible, but src/renderer/overlay-legacy-cleanup.test.ts still required broad :focus selectors. The stale assertion fails in test:coverage:src.
Additional coverage-lane failure after first fix: src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts imported updateLinuxMpvFullscreenOverlayRefreshBurst, but src/main/runtime/linux-mpv-fullscreen-overlay-refresh.ts did not export/implement it. Added the helper to cancel existing bursts and schedule only while fullscreen is true.
Verification passed: bun test src/renderer/overlay-legacy-cleanup.test.ts; bun test src/main/runtime/linux-mpv-fullscreen-overlay-refresh.test.ts; bun run test:coverage:src; bun run format:check:src. gh pr checks 57 still reports the old failed build-test-audit run at run 25718536412; branch needs push/rerun for remote green.
Final Summary
Fixed current PR #57 build-test-audit CI blockers. Updated the stale overlay legacy cleanup assertion to expect :focus-visible top-level focus suppression and guard against reintroducing broad :focus suppression. Added the missing updateLinuxMpvFullscreenOverlayRefreshBurst export used by the Linux fullscreen overlay refresh tests. Verification passed locally: focused overlay legacy cleanup test, focused Linux fullscreen refresh test, bun run test:coverage:src, and bun run format:check:src. Remote PR checks still show the old failed build-test-audit run until these local changes are pushed and CI reruns.