Release 1.41.0 (#309)

* Improve allocations by account

* Eliminate accounts from PortfolioPosition

* Ignore cash assets in the allocation chart by sector, continent and country

* Add missing accounts to portfolio details

* Update changelog

.eslintrc.json

@@ -44,7 +44,7 @@
           }
         ],
         "@typescript-eslint/member-ordering": "error",
-        "@typescript-eslint/naming-convention": "error",
+        "@typescript-eslint/naming-convention": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-empty-interface": "error",
         "@typescript-eslint/no-inferrable-types": [

CHANGELOG.md

@@ -5,6 +5,167 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.41.0 - 21.08.2021
+
+### Added
+
+- Added a link to the system status page
+
+### Changed
+
+- Improved the wording for the _Restricted View_: _Presenter View_
+- Improved the styling of the tables
+- Ignored cash assets in the allocation chart by sector, continent and country
+
+### Fixed
+
+- Fixed an issue in the allocation chart by account (wrong calculation)
+- Fixed an issue in the allocation chart by account (missing cash accounts)
+
+## 1.40.0 - 19.08.2021
+
+### Changed
+
+- Improved the fault tolerance of the portfolio details endpoint
+
+### Fixed
+
+- Fixed the node engine version mismatch in `package.json`
+- Fixed an issue on the buy date in the position detail dialog
+- Fixed an issue with the currency inconsistency in the _Yahoo Finance_ service (convert from `GBp` to `GBP`)
+
+## 1.39.0 - 16.08.2021
+
+### Added
+
+- Added an option to hide absolute values like performances and quantities (_Restricted View_)
+
+### Changed
+
+- Restructured the allocations page
+
+### Fixed
+
+- Fixed an issue with the performance in the portfolio summary tab on the home page (impersonation mode)
+- Fixed various values in the impersonation mode which have not been nullified
+
+### Removed
+
+- Removed the current net performance
+- Removed the read foreign portfolio permission
+
+### Todo
+
+- Apply data migration (`yarn database:push`)
+
+## 1.38.0 - 14.08.2021
+
+### Added
+
+- Added the overview menu item on mobile
+
+### Changed
+
+- Refactored the exchange rate service
+- Improved the users table in the admin control panel
+
+## 1.37.0 - 13.08.2021
+
+### Added
+
+- Added the calculated net worth to the portfolio summary tab on the home page
+- Added the calculated time in market to the portfolio summary tab on the home page
+
+### Changed
+
+- Improved the usability of the tabs on the home page
+- Restructured the portfolio summary tab on the home page
+- Upgraded `angular-material-css-vars` from version `2.1.0` to `2.1.2`
+
+### Fixed
+
+- Fixed the position detail chart if there are missing historical data around the first buy date
+- Fixed the snack bar background color in dark mode
+- Fixed the search functionality for symbols (filter for supported currencies)
+
+## 1.36.0 - 09.08.2021
+
+### Changed
+
+- Improved the data gathering handling on server restart
+- Respected the cash balance on the allocations page
+- Eliminated the name from the scraper configuration
+
+### Fixed
+
+- Fixed hidden cryptocurrency holdings
+
+## 1.35.0 - 08.08.2021
+
+### Changed
+
+- Hid the pagination of tabs
+- Improved the classification of assets
+- Improved the support for future transactions (drafts)
+- Optimized the accounts table for mobile
+- Upgraded `chart.js` from version `3.3.2` to `3.5.0`
+
+### Fixed
+
+- Added a fallback if the exchange rate service has not been initialized correctly
+
+### Todo
+
+- Apply data migration (`yarn database:push`)
+
+## 1.34.0 - 07.08.2021
+
+### Changed
+
+- Restructured the page hierarchy
+
+### Fixed
+
+- Fixed an issue with the currency conversion of the market price in the position detail dialog
+- Fixed the chart and missing data of positions from the past in the position detail dialog
+
+## 1.33.0 - 05.08.2021
+
+### Fixed
+
+- Fixed an issue of a division by zero in the portfolio calculations
+- Fixed an issue with the currency conversion in the position detail dialog
+
+## 1.32.0 - 04.08.2021
+
+### Added
+
+- Added the name to the position detail dialog when opened from the transactions table
+- Added a screenshot to the blog posts
+
+### Fixed
+
+- Fixed the missing market state in the positions tab
+- Fixed the chart of positions with differing currency from user
+
+## 1.31.1 - 01.08.2021
+
+### Fixed
+
+- Fixed an issue with the currency conversion in the portfolio calculations
+
+## 1.31.0 - 01.08.2021
+
+### Added
+
+- Added more data points to the chart
+
+### Changed
+
+- Rewritten the core engine for the portfolio calculations
+  - Switched to [Time-Weighted Rate of Return](https://www.investopedia.com/terms/t/time-weightedror.asp) (TWR) for the performance calculation
+  - Improved the performance of the portfolio calculations
+
 ## 1.30.0 - 31.07.2021
 
 ### Added

README.md

@@ -12,7 +12,7 @@
     <strong>Open Source Wealth Management Software made for Humans</strong>
   </p>
   <p>
-    <a href="https://ghostfol.io"><strong>Live Demo</strong></a>
+    <a href="https://ghostfol.io"><strong>Live Demo</strong></a> | <a href="https://ghostfol.io/pricing"><strong>Ghostfolio Premium</strong></a> | <a href="https://ghostfol.io/en/blog/2021/07/hello-ghostfolio"><strong>Blog</strong></a> | <a href="https://twitter.com/ghostfolio_"><strong>Twitter</strong></a>
   </p>
   <p>
     <a href="#contributing">
@@ -26,6 +26,10 @@
 
 **Ghostfolio** is an open source wealth management software built with web technology. The application empowers busy people to keep track of their wealth like stocks, ETFs or cryptocurrencies and make solid, data-driven investment decisions.
 
+<div align="center">
+  <img src="./apps/client/src/assets/images/screenshot.png" width="300">
+</div>
+
 ## Ghostfolio Premium
 
 Our official **[Ghostfolio Premium](https://ghostfol.io/pricing)** cloud offering is the easiest way to get started. Due to the time it saves, this will be the best option for most people. The revenue is used for covering the hosting costs.

apps/api/src/app/access/access.service.ts

@@ -5,7 +5,7 @@ import { Prisma } from '@prisma/client';
 
 @Injectable()
 export class AccessService {
-  public constructor(private prisma: PrismaService) {}
+  public constructor(private readonly prismaService: PrismaService) {}
 
   public async accesses(params: {
     include?: Prisma.AccessInclude;
@@ -17,7 +17,7 @@ export class AccessService {
   }): Promise<AccessWithGranteeUser[]> {
     const { include, skip, take, cursor, where, orderBy } = params;
 
-    return this.prisma.access.findMany({
+    return this.prismaService.access.findMany({
       cursor,
       include,
       orderBy,

apps/api/src/app/account/account.controller.ts

@@ -1,3 +1,4 @@
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { nullifyValuesInObjects } from '@ghostfolio/api/helper/object.helper';
 import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
 import {
@@ -33,7 +34,8 @@ export class AccountController {
   public constructor(
     private readonly accountService: AccountService,
     private readonly impersonationService: ImpersonationService,
-    @Inject(REQUEST) private readonly request: RequestWithUser
+    @Inject(REQUEST) private readonly request: RequestWithUser,
+    private readonly userService: UserService
   ) {}
 
   @Delete(':id')
@@ -84,25 +86,22 @@ export class AccountController {
   public async getAllAccounts(
     @Headers('impersonation-id') impersonationId
   ): Promise<AccountModel[]> {
-    const impersonationUserId = await this.impersonationService.validateImpersonationId(
-      impersonationId,
-      this.request.user.id
+    const impersonationUserId =
+      await this.impersonationService.validateImpersonationId(
+        impersonationId,
+        this.request.user.id
+      );
+
+    let accounts = await this.accountService.getAccounts(
+      impersonationUserId || this.request.user.id
     );
 
-    let accounts = await this.accountService.accounts({
-      include: { Order: true, Platform: true },
-      orderBy: { name: 'asc' },
-      where: { userId: impersonationUserId || this.request.user.id }
-    });
-
     if (
-      impersonationUserId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationUserId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
       accounts = nullifyValuesInObjects(accounts, [
+        'balance',
         'fee',
         'quantity',
         'unitPrice'

apps/api/src/app/account/account.module.ts

@@ -1,32 +1,26 @@
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
+import { UserModule } from '@ghostfolio/api/app/user/user.module';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
+import { ImpersonationModule } from '@ghostfolio/api/services/impersonation.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
-import { RedisCacheModule } from '../redis-cache/redis-cache.module';
 import { AccountController } from './account.controller';
 import { AccountService } from './account.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataProviderModule,
+    ExchangeRateDataModule,
+    ImpersonationModule,
+    RedisCacheModule,
+    PrismaModule,
+    UserModule
+  ],
   controllers: [AccountController],
-  providers: [
-    AccountService,
-    AlphaVantageService,
-    ConfigurationService,
-    DataProviderService,
-    ExchangeRateDataService,
-    GhostfolioScraperApiService,
-    ImpersonationService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [AccountService]
 })
 export class AccountModule {}

apps/api/src/app/account/account.service.ts

@@ -1,23 +1,21 @@
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Injectable } from '@nestjs/common';
-import { Account, Currency, Order, Prisma } from '@prisma/client';
+import { Account, Currency, Order, Platform, Prisma } from '@prisma/client';
 
-import { RedisCacheService } from '../redis-cache/redis-cache.service';
 import { CashDetails } from './interfaces/cash-details.interface';
 
 @Injectable()
 export class AccountService {
   public constructor(
-    private exchangeRateDataService: ExchangeRateDataService,
-    private readonly redisCacheService: RedisCacheService,
-    private prisma: PrismaService
+    private readonly exchangeRateDataService: ExchangeRateDataService,
+    private readonly prismaService: PrismaService
   ) {}
 
   public async account(
     accountWhereUniqueInput: Prisma.AccountWhereUniqueInput
   ): Promise<Account | null> {
-    return this.prisma.account.findUnique({
+    return this.prismaService.account.findUnique({
       where: accountWhereUniqueInput
     });
   }
@@ -30,7 +28,7 @@ export class AccountService {
       Order?: Order[];
     }
   > {
-    return this.prisma.account.findUnique({
+    return this.prismaService.account.findUnique({
       include: accountInclude,
       where: accountWhereUniqueInput
     });
@@ -43,10 +41,15 @@ export class AccountService {
     cursor?: Prisma.AccountWhereUniqueInput;
     where?: Prisma.AccountWhereInput;
     orderBy?: Prisma.AccountOrderByInput;
-  }): Promise<Account[]> {
+  }): Promise<
+    (Account & {
+      Order?: Order[];
+      Platform?: Platform;
+    })[]
+  > {
     const { include, skip, take, cursor, where, orderBy } = params;
 
-    return this.prisma.account.findMany({
+    return this.prismaService.account.findMany({
       cursor,
       include,
       orderBy,
@@ -60,7 +63,7 @@ export class AccountService {
     data: Prisma.AccountCreateInput,
     aUserId: string
   ): Promise<Account> {
-    return this.prisma.account.create({
+    return this.prismaService.account.create({
       data
     });
   }
@@ -69,13 +72,27 @@ export class AccountService {
     where: Prisma.AccountWhereUniqueInput,
     aUserId: string
   ): Promise<Account> {
-    this.redisCacheService.remove(`${aUserId}.portfolio`);
-
-    return this.prisma.account.delete({
+    return this.prismaService.account.delete({
       where
     });
   }
 
+  public async getAccounts(aUserId: string) {
+    const accounts = await this.accounts({
+      include: { Order: true, Platform: true },
+      orderBy: { name: 'asc' },
+      where: { userId: aUserId }
+    });
+
+    return accounts.map((account) => {
+      const result = { ...account, transactionCount: account.Order.length };
+
+      delete result.Order;
+
+      return result;
+    });
+  }
+
   public async getCashDetails(
     aUserId: string,
     aCurrency: Currency
@@ -105,7 +122,7 @@ export class AccountService {
     aUserId: string
   ): Promise<Account> {
     const { data, where } = params;
-    return this.prisma.account.update({
+    return this.prismaService.account.update({
       data,
       where
     });

apps/api/src/app/admin/admin.module.ts

@@ -1,31 +1,22 @@
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
 import { AdminController } from './admin.controller';
 import { AdminService } from './admin.service';
 
 @Module({
-  imports: [],
+  imports: [
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    ExchangeRateDataModule,
+    PrismaModule
+  ],
   controllers: [AdminController],
-  providers: [
-    AdminService,
-    AlphaVantageService,
-    ConfigurationService,
-    DataGatheringService,
-    DataProviderService,
-    ExchangeRateDataService,
-    GhostfolioScraperApiService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [AdminService]
 })
 export class AdminModule {}

apps/api/src/app/admin/admin.service.ts

@@ -1,14 +1,17 @@
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { AdminData } from '@ghostfolio/common/interfaces';
 import { Injectable } from '@nestjs/common';
 import { Currency } from '@prisma/client';
+import { differenceInDays } from 'date-fns';
 
 @Injectable()
 export class AdminService {
   public constructor(
-    private exchangeRateDataService: ExchangeRateDataService,
-    private prisma: PrismaService
+    private readonly dataGatheringService: DataGatheringService,
+    private readonly exchangeRateDataService: ExchangeRateDataService,
+    private readonly prismaService: PrismaService
   ) {}
 
   public async get(): Promise<AdminData> {
@@ -61,24 +64,22 @@ export class AdminService {
         }
       ],
       lastDataGathering: await this.getLastDataGathering(),
-      transactionCount: await this.prisma.order.count(),
-      userCount: await this.prisma.user.count(),
+      transactionCount: await this.prismaService.order.count(),
+      userCount: await this.prismaService.user.count(),
       users: await this.getUsersWithAnalytics()
     };
   }
 
   private async getLastDataGathering() {
-    const lastDataGathering = await this.prisma.property.findUnique({
-      where: { key: 'LAST_DATA_GATHERING' }
-    });
+    const lastDataGathering =
+      await this.dataGatheringService.getLastDataGathering();
 
-    if (lastDataGathering?.value) {
-      return new Date(lastDataGathering.value);
+    if (lastDataGathering) {
+      return lastDataGathering;
     }
 
-    const dataGatheringInProgress = await this.prisma.property.findUnique({
-      where: { key: 'LOCKED_DATA_GATHERING' }
-    });
+    const dataGatheringInProgress =
+      await this.dataGatheringService.getIsInProgress();
 
     if (dataGatheringInProgress) {
       return 'IN_PROGRESS';
@@ -87,8 +88,8 @@ export class AdminService {
     return null;
   }
 
-  private async getUsersWithAnalytics() {
-    return await this.prisma.user.findMany({
+  private async getUsersWithAnalytics(): Promise<AdminData['users']> {
+    const usersWithAnalytics = await this.prismaService.user.findMany({
       orderBy: {
         Analytics: {
           updatedAt: 'desc'
@@ -115,5 +116,23 @@ export class AdminService {
         }
       }
     });
+
+    return usersWithAnalytics.map(
+      ({ _count, alias, Analytics, createdAt, id }) => {
+        const daysSinceRegistration =
+          differenceInDays(new Date(), createdAt) + 1;
+        const engagement = Analytics.activityCount / daysSinceRegistration;
+
+        return {
+          alias,
+          createdAt,
+          engagement,
+          id,
+          accountCount: _count.Account || 0,
+          lastActivity: Analytics.updatedAt,
+          transactionCount: _count.Order || 0
+        };
+      }
+    );
   }
 }

apps/api/src/app/app.controller.ts

@@ -1,12 +1,12 @@
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { Controller } from '@nestjs/common';
 
-import { PrismaService } from '../services/prisma.service';
 import { RedisCacheService } from './redis-cache/redis-cache.service';
 
 @Controller()
 export class AppController {
   public constructor(
-    private prisma: PrismaService,
+    private readonly dataGatheringService: DataGatheringService,
     private readonly redisCacheService: RedisCacheService
   ) {
     this.initialize();
@@ -15,17 +15,12 @@ export class AppController {
   private async initialize() {
     this.redisCacheService.reset();
 
-    const isDataGatheringLocked = await this.prisma.property.findUnique({
-      where: { key: 'LOCKED_DATA_GATHERING' }
-    });
+    const isDataGatheringInProgress =
+      await this.dataGatheringService.getIsInProgress();
 
-    if (!isDataGatheringLocked) {
-      // Prepare for automatical data gather if not locked
-      await this.prisma.property.deleteMany({
-        where: {
-          OR: [{ key: 'LAST_DATA_GATHERING' }, { key: 'LOCKED_DATA_GATHERING' }]
-        }
-      });
+    if (isDataGatheringInProgress) {
+      // Prepare for automatical data gathering, if hung up in progress state
+      await this.dataGatheringService.reset();
     }
   }
 }

apps/api/src/app/app.module.ts

@@ -1,21 +1,18 @@
 import { join } from 'path';
 
 import { AuthDeviceModule } from '@ghostfolio/api/app/auth-device/auth-device.module';
+import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { CronService } from '@ghostfolio/api/services/cron.service';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 import { ConfigModule } from '@nestjs/config';
 import { ScheduleModule } from '@nestjs/schedule';
 import { ServeStaticModule } from '@nestjs/serve-static';
 
-import { ConfigurationService } from '../services/configuration.service';
-import { CronService } from '../services/cron.service';
-import { DataGatheringService } from '../services/data-gathering.service';
-import { DataProviderService } from '../services/data-provider.service';
-import { AlphaVantageService } from '../services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '../services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '../services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '../services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ExchangeRateDataService } from '../services/exchange-rate-data.service';
-import { PrismaService } from '../services/prisma.service';
 import { AccessModule } from './access/access.module';
 import { AccountModule } from './account/account.module';
 import { AdminModule } from './admin/admin.module';
@@ -28,7 +25,6 @@ import { ImportModule } from './import/import.module';
 import { InfoModule } from './info/info.module';
 import { OrderModule } from './order/order.module';
 import { PortfolioModule } from './portfolio/portfolio.module';
-import { RedisCacheModule } from './redis-cache/redis-cache.module';
 import { SubscriptionModule } from './subscription/subscription.module';
 import { SymbolModule } from './symbol/symbol.module';
 import { UserModule } from './user/user.module';
@@ -42,12 +38,17 @@ import { UserModule } from './user/user.module';
     AuthModule,
     CacheModule,
     ConfigModule.forRoot(),
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    ExchangeRateDataModule,
     ExperimentalModule,
     ExportModule,
     ImportModule,
     InfoModule,
     OrderModule,
     PortfolioModule,
+    PrismaModule,
     RedisCacheModule,
     ScheduleModule.forRoot(),
     ServeStaticModule.forRoot({
@@ -69,17 +70,6 @@ import { UserModule } from './user/user.module';
     UserModule
   ],
   controllers: [AppController],
-  providers: [
-    AlphaVantageService,
-    ConfigurationService,
-    CronService,
-    DataGatheringService,
-    DataProviderService,
-    ExchangeRateDataService,
-    GhostfolioScraperApiService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [CronService]
 })
 export class AppModule {}

apps/api/src/app/auth-device/auth-device.service.ts

@@ -7,13 +7,13 @@ import { AuthDevice, Prisma } from '@prisma/client';
 export class AuthDeviceService {
   public constructor(
     private readonly configurationService: ConfigurationService,
-    private prisma: PrismaService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async authDevice(
     where: Prisma.AuthDeviceWhereUniqueInput
   ): Promise<AuthDevice | null> {
-    return this.prisma.authDevice.findUnique({
+    return this.prismaService.authDevice.findUnique({
       where
     });
   }
@@ -26,7 +26,7 @@ export class AuthDeviceService {
     orderBy?: Prisma.AuthDeviceOrderByInput;
   }): Promise<AuthDevice[]> {
     const { skip, take, cursor, where, orderBy } = params;
-    return this.prisma.authDevice.findMany({
+    return this.prismaService.authDevice.findMany({
       skip,
       take,
       cursor,
@@ -38,7 +38,7 @@ export class AuthDeviceService {
   public async createAuthDevice(
     data: Prisma.AuthDeviceCreateInput
   ): Promise<AuthDevice> {
-    return this.prisma.authDevice.create({
+    return this.prismaService.authDevice.create({
       data
     });
   }
@@ -49,7 +49,7 @@ export class AuthDeviceService {
   }): Promise<AuthDevice> {
     const { data, where } = params;
 
-    return this.prisma.authDevice.update({
+    return this.prismaService.authDevice.update({
       data,
       where
     });
@@ -58,7 +58,7 @@ export class AuthDeviceService {
   public async deleteAuthDevice(
     where: Prisma.AuthDeviceWhereUniqueInput
   ): Promise<AuthDevice> {
-    return this.prisma.authDevice.delete({
+    return this.prismaService.authDevice.delete({
       where
     });
   }

apps/api/src/app/auth/auth.module.ts

@@ -1,11 +1,11 @@
 import { AuthDeviceService } from '@ghostfolio/api/app/auth-device/auth-device.service';
 import { WebAuthService } from '@ghostfolio/api/app/auth/web-auth.service';
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Module } from '@nestjs/common';
 import { JwtModule } from '@nestjs/jwt';
 
-import { UserService } from '../user/user.service';
 import { AuthController } from './auth.controller';
 import { AuthService } from './auth.service';
 import { GoogleStrategy } from './google.strategy';

apps/api/src/app/auth/auth.service.ts

@@ -1,8 +1,8 @@
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { Injectable, InternalServerErrorException } from '@nestjs/common';
 import { JwtService } from '@nestjs/jwt';
 
-import { UserService } from '../user/user.service';
 import { ValidateOAuthLoginParams } from './interfaces/interfaces';
 
 @Injectable()

apps/api/src/app/auth/jwt.strategy.ts

@@ -1,16 +1,15 @@
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Injectable, UnauthorizedException } from '@nestjs/common';
 import { PassportStrategy } from '@nestjs/passport';
 import { ExtractJwt, Strategy } from 'passport-jwt';
 
-import { UserService } from '../user/user.service';
-
 @Injectable()
 export class JwtStrategy extends PassportStrategy(Strategy, 'jwt') {
   public constructor(
     readonly configurationService: ConfigurationService,
-    private prisma: PrismaService,
+    private readonly prismaService: PrismaService,
     private readonly userService: UserService
   ) {
     super({
@@ -24,7 +23,7 @@ export class JwtStrategy extends PassportStrategy(Strategy, 'jwt') {
       const user = await this.userService.user({ id });
 
       if (user) {
-        await this.prisma.analytics.upsert({
+        await this.prismaService.analytics.upsert({
           create: { User: { connect: { id: user.id } } },
           update: { activityCount: { increment: 1 }, updatedAt: new Date() },
           where: { userId: user.id }

apps/api/src/app/auth/web-auth.service.ts

@@ -1,5 +1,6 @@
 import { AuthDeviceDto } from '@ghostfolio/api/app/auth-device/auth-device.dto';
 import { AuthDeviceService } from '@ghostfolio/api/app/auth-device/auth-device.service';
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { RequestWithUser } from '@ghostfolio/common/types';
 import {
@@ -22,7 +23,6 @@ import {
   verifyAttestationResponse
 } from '@simplewebauthn/server';
 
-import { UserService } from '../user/user.service';
 import {
   AssertionCredentialJSON,
   AttestationCredentialJSON

apps/api/src/app/cache/cache.controller.ts

@@ -1,11 +1,10 @@
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
+import { RedisCacheService } from '@ghostfolio/api/app/redis-cache/redis-cache.service';
 import { RequestWithUser } from '@ghostfolio/common/types';
 import { Controller, Inject, Post, UseGuards } from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { AuthGuard } from '@nestjs/passport';
 
-import { RedisCacheService } from '../redis-cache/redis-cache.service';
-import { CacheService } from './cache.service';
-
 @Controller('cache')
 export class CacheController {
   public constructor(
@@ -21,6 +20,6 @@ export class CacheController {
   public async flushCache(): Promise<void> {
     this.redisCacheService.reset();
 
-    return this.cacheService.flush(this.request.user.id);
+    return this.cacheService.flush();
   }
 }

apps/api/src/app/cache/cache.module.ts

@@ -1,13 +1,30 @@
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
+import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
+import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
+import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
+import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
+import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
+import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Module } from '@nestjs/common';
 
-import { RedisCacheModule } from '../redis-cache/redis-cache.module';
 import { CacheController } from './cache.controller';
-import { CacheService } from './cache.service';
 
 @Module({
   imports: [RedisCacheModule],
   controllers: [CacheController],
-  providers: [CacheService, PrismaService]
+  providers: [
+    AlphaVantageService,
+    CacheService,
+    ConfigurationService,
+    DataGatheringService,
+    DataProviderService,
+    GhostfolioScraperApiService,
+    PrismaService,
+    RakutenRapidApiService,
+    YahooFinanceService
+  ]
 })
 export class CacheModule {}

apps/api/src/app/cache/cache.service.ts

@@ -1,16 +1,14 @@
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { Injectable } from '@nestjs/common';
 
 @Injectable()
 export class CacheService {
-  public constructor(private prisma: PrismaService) {}
+  public constructor(
+    private readonly dataGaterhingService: DataGatheringService
+  ) {}
 
-  public async flush(aUserId: string): Promise<void> {
-    await this.prisma.property.deleteMany({
-      where: {
-        OR: [{ key: 'LAST_DATA_GATHERING' }, { key: 'LOCKED_DATA_GATHERING' }]
-      }
-    });
+  public async flush(): Promise<void> {
+    await this.dataGaterhingService.reset();
 
     return;
   }

apps/api/src/app/experimental/experimental.controller.ts

@@ -1,4 +1,5 @@
 import { baseCurrency, benchmarks } from '@ghostfolio/common/config';
+import { DATE_FORMAT } from '@ghostfolio/common/helper';
 import { isApiTokenAuthorized } from '@ghostfolio/common/permissions';
 import { RequestWithUser } from '@ghostfolio/common/types';
 import {
@@ -65,26 +66,4 @@ export class ExperimentalController {
 
     return marketData;
   }
-
-  @Post('value/:dateString?')
-  public async getValue(
-    @Body() orders: CreateOrderDto[],
-    @Headers('Authorization') apiToken: string,
-    @Param('dateString') dateString: string
-  ): Promise<Data> {
-    if (!isApiTokenAuthorized(apiToken)) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    let date = new Date();
-
-    if (dateString) {
-      date = parse(dateString, 'yyyy-MM-dd', new Date());
-    }
-
-    return this.experimentalService.getValue(orders, date, baseCurrency);
-  }
 }

apps/api/src/app/experimental/experimental.module.ts

@@ -1,34 +1,23 @@
 import { AccountService } from '@ghostfolio/api/app/account/account.service';
 import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
-import { RulesService } from '@ghostfolio/api/services/rules.service';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
 import { ExperimentalController } from './experimental.controller';
 import { ExperimentalService } from './experimental.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataProviderModule,
+    ExchangeRateDataModule,
+    RedisCacheModule,
+    PrismaModule
+  ],
   controllers: [ExperimentalController],
-  providers: [
-    AccountService,
-    AlphaVantageService,
-    ConfigurationService,
-    DataProviderService,
-    ExchangeRateDataService,
-    ExperimentalService,
-    GhostfolioScraperApiService,
-    PrismaService,
-    RakutenRapidApiService,
-    RulesService,
-    YahooFinanceService
-  ]
+  providers: [AccountService, ExperimentalService]
 })
 export class ExperimentalModule {}

apps/api/src/app/experimental/experimental.service.ts

@@ -1,16 +1,8 @@
 import { AccountService } from '@ghostfolio/api/app/account/account.service';
-import { Portfolio } from '@ghostfolio/api/models/portfolio';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
-import { RulesService } from '@ghostfolio/api/services/rules.service';
-import { OrderWithAccount } from '@ghostfolio/common/types';
 import { Injectable } from '@nestjs/common';
-import { Currency, Type } from '@prisma/client';
-import { parseISO } from 'date-fns';
-
-import { CreateOrderDto } from './create-order.dto';
-import { Data } from './interfaces/data.interface';
 
 @Injectable()
 export class ExperimentalService {
@@ -18,52 +10,14 @@ export class ExperimentalService {
     private readonly accountService: AccountService,
     private readonly dataProviderService: DataProviderService,
     private readonly exchangeRateDataService: ExchangeRateDataService,
-    private prisma: PrismaService,
-    private readonly rulesService: RulesService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async getBenchmark(aSymbol: string) {
-    return this.prisma.marketData.findMany({
+    return this.prismaService.marketData.findMany({
       orderBy: { date: 'asc' },
       select: { date: true, marketPrice: true },
       where: { symbol: aSymbol }
     });
   }
-
-  public async getValue(
-    aOrders: CreateOrderDto[],
-    aDate: Date,
-    aBaseCurrency: Currency
-  ): Promise<Data> {
-    const ordersWithPlatform: OrderWithAccount[] = aOrders.map((order) => {
-      return {
-        ...order,
-        accountId: undefined,
-        accountUserId: undefined,
-        createdAt: new Date(),
-        dataSource: undefined,
-        date: parseISO(order.date),
-        fee: 0,
-        id: undefined,
-        platformId: undefined,
-        symbolProfileId: undefined,
-        type: Type.BUY,
-        updatedAt: undefined,
-        userId: undefined
-      };
-    });
-
-    const portfolio = new Portfolio(
-      this.accountService,
-      this.dataProviderService,
-      this.exchangeRateDataService,
-      this.rulesService
-    );
-    await portfolio.setOrders(ordersWithPlatform);
-
-    return {
-      currency: aBaseCurrency,
-      value: portfolio.getValue(aDate)
-    };
-  }
 }

apps/api/src/app/export/export.module.ts

@@ -1,32 +1,23 @@
 import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
 import { ExportController } from './export.controller';
 import { ExportService } from './export.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    PrismaModule,
+    RedisCacheModule
+  ],
   controllers: [ExportController],
-  providers: [
-    AlphaVantageService,
-    CacheService,
-    ConfigurationService,
-    DataGatheringService,
-    DataProviderService,
-    ExportService,
-    GhostfolioScraperApiService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [CacheService, ExportService]
 })
 export class ExportModule {}

apps/api/src/app/export/export.service.ts

@@ -5,10 +5,10 @@ import { Injectable } from '@nestjs/common';
 
 @Injectable()
 export class ExportService {
-  public constructor(private prisma: PrismaService) {}
+  public constructor(private readonly prismaService: PrismaService) {}
 
   public async export({ userId }: { userId: string }): Promise<Export> {
-    const orders = await this.prisma.order.findMany({
+    const orders = await this.prismaService.order.findMany({
       orderBy: { date: 'desc' },
       select: {
         currency: true,

apps/api/src/app/import/import.module.ts

@@ -1,34 +1,24 @@
 import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { OrderService } from '@ghostfolio/api/app/order/order.service';
 import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
 import { ImportController } from './import.controller';
 import { ImportService } from './import.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    PrismaModule,
+    RedisCacheModule
+  ],
   controllers: [ImportController],
-  providers: [
-    AlphaVantageService,
-    CacheService,
-    ConfigurationService,
-    DataGatheringService,
-    DataProviderService,
-    GhostfolioScraperApiService,
-    ImportService,
-    OrderService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [CacheService, ImportService, OrderService]
 })
 export class ImportModule {}

apps/api/src/app/import/import.service.ts

@@ -24,20 +24,17 @@ export class ImportService {
       type,
       unitPrice
     } of orders) {
-      await this.orderService.createOrder(
-        {
-          currency,
-          dataSource,
-          fee,
-          quantity,
-          symbol,
-          type,
-          unitPrice,
-          date: parseISO(<string>(<unknown>date)),
-          User: { connect: { id: userId } }
-        },
-        userId
-      );
+      await this.orderService.createOrder({
+        currency,
+        dataSource,
+        fee,
+        quantity,
+        symbol,
+        type,
+        unitPrice,
+        date: parseISO(<string>(<unknown>date)),
+        User: { connect: { id: userId } }
+      });
     }
   }
 }

apps/api/src/app/info/info.module.ts

@@ -1,4 +1,10 @@
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
+import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
+import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
+import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
+import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Module } from '@nestjs/common';
 import { JwtModule } from '@nestjs/jwt';
@@ -14,6 +20,16 @@ import { InfoService } from './info.service';
     })
   ],
   controllers: [InfoController],
-  providers: [ConfigurationService, InfoService, PrismaService]
+  providers: [
+    AlphaVantageService,
+    ConfigurationService,
+    DataGatheringService,
+    DataProviderService,
+    GhostfolioScraperApiService,
+    InfoService,
+    PrismaService,
+    RakutenRapidApiService,
+    YahooFinanceService
+  ]
 })
 export class InfoModule {}

apps/api/src/app/info/info.service.ts

@@ -1,4 +1,5 @@
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { InfoItem } from '@ghostfolio/common/interfaces';
 import { Subscription } from '@ghostfolio/common/interfaces/subscription.interface';
@@ -15,13 +16,14 @@ export class InfoService {
 
   public constructor(
     private readonly configurationService: ConfigurationService,
-    private jwtService: JwtService,
-    private prisma: PrismaService
+    private readonly dataGatheringService: DataGatheringService,
+    private readonly jwtService: JwtService,
+    private readonly prismaService: PrismaService
   ) {}
 
   public async get(): Promise<InfoItem> {
     const info: Partial<InfoItem> = {};
-    const platforms = await this.prisma.platform.findMany({
+    const platforms = await this.prismaService.platform.findMany({
       orderBy: { name: 'asc' },
       select: { id: true, name: true }
     });
@@ -63,7 +65,7 @@ export class InfoService {
   }
 
   private async countActiveUsers(aDays: number) {
-    return await this.prisma.user.count({
+    return await this.prismaService.user.count({
       orderBy: {
         Analytics: {
           updatedAt: 'desc'
@@ -116,11 +118,10 @@ export class InfoService {
   }
 
   private async getLastDataGathering() {
-    const lastDataGathering = await this.prisma.property.findUnique({
-      where: { key: 'LAST_DATA_GATHERING' }
-    });
+    const lastDataGathering =
+      await this.dataGatheringService.getLastDataGathering();
 
-    return lastDataGathering?.value ? new Date(lastDataGathering.value) : null;
+    return lastDataGathering ?? null;
   }
 
   private async getStatistics() {
@@ -144,7 +145,7 @@ export class InfoService {
       return undefined;
     }
 
-    const stripeConfig = await this.prisma.property.findUnique({
+    const stripeConfig = await this.prismaService.property.findUnique({
       where: { key: 'STRIPE_CONFIG' }
     });
 

apps/api/src/app/order/order.controller.ts

@@ -1,3 +1,4 @@
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { nullifyValuesInObjects } from '@ghostfolio/api/helper/object.helper';
 import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
 import {
@@ -34,7 +35,8 @@ export class OrderController {
   public constructor(
     private readonly impersonationService: ImpersonationService,
     private readonly orderService: OrderService,
-    @Inject(REQUEST) private readonly request: RequestWithUser
+    @Inject(REQUEST) private readonly request: RequestWithUser,
+    private readonly userService: UserService
   ) {}
 
   @Delete(':id')
@@ -52,15 +54,12 @@ export class OrderController {
       );
     }
 
-    return this.orderService.deleteOrder(
-      {
-        id_userId: {
-          id,
-          userId: this.request.user.id
-        }
-      },
-      this.request.user.id
-    );
+    return this.orderService.deleteOrder({
+      id_userId: {
+        id,
+        userId: this.request.user.id
+      }
+    });
   }
 
   @Get()
@@ -80,6 +79,11 @@ export class OrderController {
           include: {
             Platform: true
           }
+        },
+        SymbolProfile: {
+          select: {
+            name: true
+          }
         }
       },
       orderBy: { date: 'desc' },
@@ -87,11 +91,8 @@ export class OrderController {
     });
 
     if (
-      impersonationUserId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationUserId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
       orders = nullifyValuesInObjects(orders, ['fee', 'quantity', 'unitPrice']);
     }
@@ -130,33 +131,30 @@ export class OrderController {
     const accountId = data.accountId;
     delete data.accountId;
 
-    return this.orderService.createOrder(
-      {
-        ...data,
-        Account: {
-          connect: {
-            id_userId: { id: accountId, userId: this.request.user.id }
-          }
-        },
-        date,
-        SymbolProfile: {
-          connectOrCreate: {
-            where: {
-              dataSource_symbol: {
-                dataSource: data.dataSource,
-                symbol: data.symbol
-              }
-            },
-            create: {
+    return this.orderService.createOrder({
+      ...data,
+      Account: {
+        connect: {
+          id_userId: { id: accountId, userId: this.request.user.id }
+        }
+      },
+      date,
+      SymbolProfile: {
+        connectOrCreate: {
+          where: {
+            dataSource_symbol: {
               dataSource: data.dataSource,
               symbol: data.symbol
             }
+          },
+          create: {
+            dataSource: data.dataSource,
+            symbol: data.symbol
           }
-        },
-        User: { connect: { id: this.request.user.id } }
+        }
       },
-      this.request.user.id
-    );
+      User: { connect: { id: this.request.user.id } }
+    });
   }
 
   @Put(':id')
@@ -193,26 +191,23 @@ export class OrderController {
     const accountId = data.accountId;
     delete data.accountId;
 
-    return this.orderService.updateOrder(
-      {
-        data: {
-          ...data,
-          date,
-          Account: {
-            connect: {
-              id_userId: { id: accountId, userId: this.request.user.id }
-            }
-          },
-          User: { connect: { id: this.request.user.id } }
-        },
-        where: {
-          id_userId: {
-            id,
-            userId: this.request.user.id
+    return this.orderService.updateOrder({
+      data: {
+        ...data,
+        date,
+        Account: {
+          connect: {
+            id_userId: { id: accountId, userId: this.request.user.id }
           }
-        }
+        },
+        User: { connect: { id: this.request.user.id } }
       },
-      this.request.user.id
-    );
+      where: {
+        id_userId: {
+          id,
+          userId: this.request.user.id
+        }
+      }
+    });
   }
 }

apps/api/src/app/order/order.module.ts

@@ -1,34 +1,28 @@
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
+import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
+import { UserModule } from '@ghostfolio/api/app/user/user.module';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ImpersonationModule } from '@ghostfolio/api/services/impersonation.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
-import { CacheService } from '../cache/cache.service';
-import { RedisCacheModule } from '../redis-cache/redis-cache.module';
 import { OrderController } from './order.controller';
 import { OrderService } from './order.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    ImpersonationModule,
+    PrismaModule,
+    RedisCacheModule,
+    UserModule
+  ],
   controllers: [OrderController],
-  providers: [
-    AlphaVantageService,
-    CacheService,
-    ConfigurationService,
-    DataGatheringService,
-    DataProviderService,
-    GhostfolioScraperApiService,
-    ImpersonationService,
-    OrderService,
-    PrismaService,
-    RakutenRapidApiService,
-    YahooFinanceService
-  ]
+  providers: [CacheService, OrderService],
+  exports: [OrderService]
 })
 export class OrderModule {}

apps/api/src/app/order/order.service.ts

@@ -1,3 +1,4 @@
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { OrderWithAccount } from '@ghostfolio/common/types';
@@ -5,22 +6,18 @@ import { Injectable } from '@nestjs/common';
 import { DataSource, Order, Prisma } from '@prisma/client';
 import { endOfToday, isAfter } from 'date-fns';
 
-import { CacheService } from '../cache/cache.service';
-import { RedisCacheService } from '../redis-cache/redis-cache.service';
-
 @Injectable()
 export class OrderService {
   public constructor(
     private readonly cacheService: CacheService,
     private readonly dataGatheringService: DataGatheringService,
-    private readonly redisCacheService: RedisCacheService,
-    private prisma: PrismaService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async order(
     orderWhereUniqueInput: Prisma.OrderWhereUniqueInput
   ): Promise<Order | null> {
-    return this.prisma.order.findUnique({
+    return this.prismaService.order.findUnique({
       where: orderWhereUniqueInput
     });
   }
@@ -35,7 +32,7 @@ export class OrderService {
   }): Promise<OrderWithAccount[]> {
     const { include, skip, take, cursor, where, orderBy } = params;
 
-    return this.prisma.order.findMany({
+    return this.prismaService.order.findMany({
       cursor,
       include,
       orderBy,
@@ -45,13 +42,10 @@ export class OrderService {
     });
   }
 
-  public async createOrder(
-    data: Prisma.OrderCreateInput,
-    aUserId: string
-  ): Promise<Order> {
-    this.redisCacheService.remove(`${aUserId}.portfolio`);
+  public async createOrder(data: Prisma.OrderCreateInput): Promise<Order> {
+    const isDraft = isAfter(data.date as Date, endOfToday());
 
-    if (!isAfter(data.date as Date, endOfToday())) {
+    if (!isDraft) {
       // Gather symbol data of order in the background, if not draft
       this.dataGatheringService.gatherSymbols([
         {
@@ -64,48 +58,75 @@ export class OrderService {
 
     this.dataGatheringService.gatherProfileData([data.symbol]);
 
-    await this.cacheService.flush(aUserId);
+    await this.cacheService.flush();
 
-    return this.prisma.order.create({
-      data
+    return this.prismaService.order.create({
+      data: {
+        ...data,
+        isDraft
+      }
     });
   }
 
   public async deleteOrder(
-    where: Prisma.OrderWhereUniqueInput,
-    aUserId: string
+    where: Prisma.OrderWhereUniqueInput
   ): Promise<Order> {
-    this.redisCacheService.remove(`${aUserId}.portfolio`);
-
-    return this.prisma.order.delete({
+    return this.prismaService.order.delete({
       where
     });
   }
 
-  public async updateOrder(
-    params: {
-      where: Prisma.OrderWhereUniqueInput;
-      data: Prisma.OrderUpdateInput;
-    },
-    aUserId: string
-  ): Promise<Order> {
+  public getOrders({
+    includeDrafts = false,
+    userId
+  }: {
+    includeDrafts?: boolean;
+    userId: string;
+  }) {
+    const where: Prisma.OrderWhereInput = { userId };
+
+    if (includeDrafts === false) {
+      where.isDraft = false;
+    }
+
+    return this.orders({
+      where,
+      include: {
+        // eslint-disable-next-line @typescript-eslint/naming-convention
+        Account: true,
+        // eslint-disable-next-line @typescript-eslint/naming-convention
+        SymbolProfile: true
+      },
+      orderBy: { date: 'asc' }
+    });
+  }
+
+  public async updateOrder(params: {
+    where: Prisma.OrderWhereUniqueInput;
+    data: Prisma.OrderUpdateInput;
+  }): Promise<Order> {
     const { data, where } = params;
 
-    this.redisCacheService.remove(`${aUserId}.portfolio`);
+    const isDraft = isAfter(data.date as Date, endOfToday());
 
-    // Gather symbol data of order in the background
-    this.dataGatheringService.gatherSymbols([
-      {
-        dataSource: <DataSource>data.dataSource,
-        date: <Date>data.date,
-        symbol: <string>data.symbol
-      }
-    ]);
+    if (!isDraft) {
+      // Gather symbol data of order in the background, if not draft
+      this.dataGatheringService.gatherSymbols([
+        {
+          dataSource: <DataSource>data.dataSource,
+          date: <Date>data.date,
+          symbol: <string>data.symbol
+        }
+      ]);
+    }
 
-    await this.cacheService.flush(aUserId);
+    await this.cacheService.flush();
 
-    return this.prisma.order.update({
-      data,
+    return this.prismaService.order.update({
+      data: {
+        ...data,
+        isDraft
+      },
       where
     });
   }

apps/api/src/app/portfolio/current-rate.service.spec.ts

@@ -0,0 +1,129 @@
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
+import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { Currency, MarketData } from '@prisma/client';
+
+import { CurrentRateService } from './current-rate.service';
+import { MarketDataService } from './market-data.service';
+
+jest.mock('./market-data.service', () => {
+  return {
+    MarketDataService: jest.fn().mockImplementation(() => {
+      return {
+        get: (date: Date, symbol: string) => {
+          return Promise.resolve<MarketData>({
+            date,
+            symbol,
+            createdAt: date,
+            id: 'aefcbe3a-ee10-4c4f-9f2d-8ffad7b05584',
+            marketPrice: 1847.839966
+          });
+        },
+        getRange: ({
+          dateRangeEnd,
+          dateRangeStart,
+          symbols
+        }: {
+          dateRangeEnd: Date;
+          dateRangeStart: Date;
+          symbols: string[];
+        }) => {
+          return Promise.resolve<MarketData[]>([
+            {
+              createdAt: dateRangeStart,
+              date: dateRangeStart,
+              id: '8fa48fde-f397-4b0d-adbc-fb940e830e6d',
+              marketPrice: 1841.823902,
+              symbol: symbols[0]
+            },
+            {
+              createdAt: dateRangeEnd,
+              date: dateRangeEnd,
+              id: '082d6893-df27-4c91-8a5d-092e84315b56',
+              marketPrice: 1847.839966,
+              symbol: symbols[0]
+            }
+          ]);
+        }
+      };
+    })
+  };
+});
+
+jest.mock('@ghostfolio/api/services/exchange-rate-data.service', () => {
+  return {
+    ExchangeRateDataService: jest.fn().mockImplementation(() => {
+      return {
+        initialize: () => Promise.resolve(),
+        toCurrency: (value: number) => {
+          return 1 * value;
+        }
+      };
+    })
+  };
+});
+
+describe('CurrentRateService', () => {
+  let currentRateService: CurrentRateService;
+  let dataProviderService: DataProviderService;
+  let exchangeRateDataService: ExchangeRateDataService;
+  let marketDataService: MarketDataService;
+
+  beforeAll(async () => {
+    dataProviderService = new DataProviderService(
+      null,
+      null,
+      null,
+      null,
+      null,
+      null
+    );
+    exchangeRateDataService = new ExchangeRateDataService(null);
+    marketDataService = new MarketDataService(null);
+
+    await exchangeRateDataService.initialize();
+
+    currentRateService = new CurrentRateService(
+      dataProviderService,
+      exchangeRateDataService,
+      marketDataService
+    );
+  });
+
+  it('getValue', async () => {
+    expect(
+      await currentRateService.getValue({
+        currency: Currency.USD,
+        date: new Date(Date.UTC(2020, 0, 1, 0, 0, 0)),
+        symbol: 'AMZN',
+        userCurrency: Currency.CHF
+      })
+    ).toMatchObject({
+      marketPrice: 1847.839966
+    });
+  });
+
+  it('getValues', async () => {
+    expect(
+      await currentRateService.getValues({
+        currencies: { AMZN: Currency.USD },
+        dateQuery: {
+          lt: new Date(Date.UTC(2020, 0, 2, 0, 0, 0)),
+          gte: new Date(Date.UTC(2020, 0, 1, 0, 0, 0))
+        },
+        symbols: ['AMZN'],
+        userCurrency: Currency.CHF
+      })
+    ).toMatchObject([
+      {
+        date: undefined,
+        marketPrice: 1841.823902,
+        symbol: 'AMZN'
+      },
+      {
+        date: undefined,
+        marketPrice: 1847.839966,
+        symbol: 'AMZN'
+      }
+    ]);
+  });
+});

apps/api/src/app/portfolio/current-rate.service.ts

@@ -0,0 +1,128 @@
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
+import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { resetHours } from '@ghostfolio/common/helper';
+import { Injectable } from '@nestjs/common';
+import { isBefore, isToday } from 'date-fns';
+import { flatten } from 'lodash';
+
+import { GetValueObject } from './interfaces/get-value-object.interface';
+import { GetValueParams } from './interfaces/get-value-params.interface';
+import { GetValuesParams } from './interfaces/get-values-params.interface';
+import { MarketDataService } from './market-data.service';
+
+@Injectable()
+export class CurrentRateService {
+  public constructor(
+    private readonly dataProviderService: DataProviderService,
+    private readonly exchangeRateDataService: ExchangeRateDataService,
+    private readonly marketDataService: MarketDataService
+  ) {}
+
+  public async getValue({
+    currency,
+    date,
+    symbol,
+    userCurrency
+  }: GetValueParams): Promise<GetValueObject> {
+    if (isToday(date)) {
+      const dataProviderResult = await this.dataProviderService.get([symbol]);
+      return {
+        date: resetHours(date),
+        marketPrice: dataProviderResult?.[symbol]?.marketPrice ?? 0,
+        symbol: symbol
+      };
+    }
+
+    const marketData = await this.marketDataService.get({
+      date,
+      symbol
+    });
+
+    if (marketData) {
+      return {
+        date: marketData.date,
+        marketPrice: this.exchangeRateDataService.toCurrency(
+          marketData.marketPrice,
+          currency,
+          userCurrency
+        ),
+        symbol: marketData.symbol
+      };
+    }
+
+    throw new Error(`Value not found for ${symbol} at ${resetHours(date)}`);
+  }
+
+  public async getValues({
+    currencies,
+    dateQuery,
+    symbols,
+    userCurrency
+  }: GetValuesParams): Promise<GetValueObject[]> {
+    const includeToday =
+      (!dateQuery.lt || isBefore(new Date(), dateQuery.lt)) &&
+      (!dateQuery.gte || isBefore(dateQuery.gte, new Date())) &&
+      (!dateQuery.in || this.containsToday(dateQuery.in));
+
+    const promises: Promise<
+      {
+        date: Date;
+        marketPrice: number;
+        symbol: string;
+      }[]
+    >[] = [];
+
+    if (includeToday) {
+      const today = resetHours(new Date());
+      promises.push(
+        this.dataProviderService.get(symbols).then((dataResultProvider) => {
+          const result = [];
+          for (const symbol of symbols) {
+            result.push({
+              symbol,
+              date: today,
+              marketPrice: this.exchangeRateDataService.toCurrency(
+                dataResultProvider?.[symbol]?.marketPrice ?? 0,
+                dataResultProvider?.[symbol]?.currency,
+                userCurrency
+              )
+            });
+          }
+          return result;
+        })
+      );
+    }
+
+    promises.push(
+      this.marketDataService
+        .getRange({
+          dateQuery,
+          symbols
+        })
+        .then((data) => {
+          return data.map((marketDataItem) => {
+            return {
+              date: marketDataItem.date,
+              marketPrice: this.exchangeRateDataService.toCurrency(
+                marketDataItem.marketPrice,
+                currencies[marketDataItem.symbol],
+                userCurrency
+              ),
+              symbol: marketDataItem.symbol
+            };
+          });
+        })
+    );
+
+    return flatten(await Promise.all(promises));
+  }
+
+  private containsToday(dates: Date[]): boolean {
+    for (const date of dates) {
+      if (isToday(date)) {
+        return true;
+      }
+    }
+    return false;
+  }
+}

apps/api/src/app/portfolio/interfaces/current-positions.interface.ts

@@ -0,0 +1,11 @@
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
+import Big from 'big.js';
+
+export interface CurrentPositions {
+  hasErrors: boolean;
+  positions: TimelinePosition[];
+  grossPerformance: Big;
+  grossPerformancePercentage: Big;
+  currentValue: Big;
+  totalInvestment: Big;
+}

apps/api/src/app/portfolio/interfaces/date-query.interface.ts

@@ -0,0 +1,5 @@
+export interface DateQuery {
+  gte?: Date;
+  in?: Date[];
+  lt?: Date;
+}

apps/api/src/app/portfolio/interfaces/get-value-object.interface.ts

@@ -0,0 +1,5 @@
+export interface GetValueObject {
+  date: Date;
+  marketPrice: number;
+  symbol: string;
+}

apps/api/src/app/portfolio/interfaces/get-value-params.interface.ts

@@ -0,0 +1,8 @@
+import { Currency } from '@prisma/client';
+
+export interface GetValueParams {
+  currency: Currency;
+  date: Date;
+  symbol: string;
+  userCurrency: Currency;
+}

apps/api/src/app/portfolio/interfaces/get-values-params.interface.ts

@@ -0,0 +1,10 @@
+import { Currency } from '@prisma/client';
+
+import { DateQuery } from './date-query.interface';
+
+export interface GetValuesParams {
+  currencies: { [symbol: string]: Currency };
+  dateQuery: DateQuery;
+  symbols: string[];
+  userCurrency: Currency;
+}

apps/api/src/app/portfolio/interfaces/portfolio-order.interface.ts

@@ -0,0 +1,13 @@
+import { OrderType } from '@ghostfolio/api/models/order-type';
+import { Currency } from '@prisma/client';
+import Big from 'big.js';
+
+export interface PortfolioOrder {
+  currency: Currency;
+  date: string;
+  name: string;
+  quantity: Big;
+  symbol: string;
+  type: OrderType;
+  unitPrice: Big;
+}

apps/api/src/app/portfolio/interfaces/portfolio-positions.interface.ts

@@ -0,0 +1,5 @@
+import { Position } from '@ghostfolio/common/interfaces';
+
+export interface PortfolioPositions {
+  positions: Position[];
+}

apps/api/src/app/portfolio/interfaces/timeline-period.interface.ts

@@ -0,0 +1,8 @@
+import Big from 'big.js';
+
+export interface TimelinePeriod {
+  date: string;
+  grossPerformance: Big;
+  investment: Big;
+  value: Big;
+}

apps/api/src/app/portfolio/interfaces/timeline-specification.interface.ts

@@ -0,0 +1,6 @@
+export type Accuracy = 'day' | 'month' | 'year';
+
+export interface TimelineSpecification {
+  accuracy: Accuracy;
+  start: string;
+}

apps/api/src/app/portfolio/interfaces/transaction-point-symbol.interface.ts

@@ -0,0 +1,11 @@
+import { Currency } from '@prisma/client';
+import Big from 'big.js';
+
+export interface TransactionPointSymbol {
+  currency: Currency;
+  firstBuyDate: string;
+  investment: Big;
+  quantity: Big;
+  symbol: string;
+  transactionCount: number;
+}

apps/api/src/app/portfolio/interfaces/transaction-point.interface.ts

@@ -0,0 +1,6 @@
+import { TransactionPointSymbol } from './transaction-point-symbol.interface';
+
+export interface TransactionPoint {
+  date: string;
+  items: TransactionPointSymbol[];
+}

apps/api/src/app/portfolio/market-data.service.ts

@@ -0,0 +1,51 @@
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { resetHours } from '@ghostfolio/common/helper';
+import { Injectable } from '@nestjs/common';
+import { MarketData } from '@prisma/client';
+
+import { DateQuery } from './interfaces/date-query.interface';
+
+@Injectable()
+export class MarketDataService {
+  public constructor(private readonly prismaService: PrismaService) {}
+
+  public async get({
+    date,
+    symbol
+  }: {
+    date: Date;
+    symbol: string;
+  }): Promise<MarketData> {
+    return await this.prismaService.marketData.findFirst({
+      where: {
+        symbol,
+        date: resetHours(date)
+      }
+    });
+  }
+
+  public async getRange({
+    dateQuery,
+    symbols
+  }: {
+    dateQuery: DateQuery;
+    symbols: string[];
+  }): Promise<MarketData[]> {
+    return await this.prismaService.marketData.findMany({
+      orderBy: [
+        {
+          date: 'asc'
+        },
+        {
+          symbol: 'asc'
+        }
+      ],
+      where: {
+        date: dateQuery,
+        symbol: {
+          in: symbols
+        }
+      }
+    });
+  }
+}

apps/api/src/app/portfolio/portfolio-calculator.ts

@@ -0,0 +1,568 @@
+import { OrderType } from '@ghostfolio/api/models/order-type';
+import { DATE_FORMAT, parseDate, resetHours } from '@ghostfolio/common/helper';
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
+import { Currency } from '@prisma/client';
+import Big from 'big.js';
+import {
+  addDays,
+  addMonths,
+  addYears,
+  endOfDay,
+  format,
+  isAfter,
+  isBefore,
+  max,
+  min
+} from 'date-fns';
+import { flatten } from 'lodash';
+
+import { CurrentRateService } from './current-rate.service';
+import { CurrentPositions } from './interfaces/current-positions.interface';
+import { GetValueObject } from './interfaces/get-value-object.interface';
+import { PortfolioOrder } from './interfaces/portfolio-order.interface';
+import { TimelinePeriod } from './interfaces/timeline-period.interface';
+import {
+  Accuracy,
+  TimelineSpecification
+} from './interfaces/timeline-specification.interface';
+import { TransactionPointSymbol } from './interfaces/transaction-point-symbol.interface';
+import { TransactionPoint } from './interfaces/transaction-point.interface';
+
+export class PortfolioCalculator {
+  private transactionPoints: TransactionPoint[];
+
+  public constructor(
+    private currentRateService: CurrentRateService,
+    private currency: Currency
+  ) {}
+
+  public computeTransactionPoints(orders: PortfolioOrder[]) {
+    orders.sort((a, b) => a.date.localeCompare(b.date));
+
+    this.transactionPoints = [];
+    const symbols: { [symbol: string]: TransactionPointSymbol } = {};
+
+    let lastDate: string = null;
+    let lastTransactionPoint: TransactionPoint = null;
+    for (const order of orders) {
+      const currentDate = order.date;
+
+      let currentTransactionPointItem: TransactionPointSymbol;
+      const oldAccumulatedSymbol = symbols[order.symbol];
+
+      const factor = this.getFactor(order.type);
+      const unitPrice = new Big(order.unitPrice);
+      if (oldAccumulatedSymbol) {
+        const newQuantity = order.quantity
+          .mul(factor)
+          .plus(oldAccumulatedSymbol.quantity);
+        currentTransactionPointItem = {
+          currency: order.currency,
+          firstBuyDate: oldAccumulatedSymbol.firstBuyDate,
+          investment: newQuantity.eq(0)
+            ? new Big(0)
+            : unitPrice
+                .mul(order.quantity)
+                .mul(factor)
+                .add(oldAccumulatedSymbol.investment),
+          quantity: newQuantity,
+          symbol: order.symbol,
+          transactionCount: oldAccumulatedSymbol.transactionCount + 1
+        };
+      } else {
+        currentTransactionPointItem = {
+          currency: order.currency,
+          firstBuyDate: order.date,
+          investment: unitPrice.mul(order.quantity).mul(factor),
+          quantity: order.quantity.mul(factor),
+          symbol: order.symbol,
+          transactionCount: 1
+        };
+      }
+
+      symbols[order.symbol] = currentTransactionPointItem;
+
+      const items = lastTransactionPoint?.items ?? [];
+      const newItems = items.filter(
+        (transactionPointItem) => transactionPointItem.symbol !== order.symbol
+      );
+      newItems.push(currentTransactionPointItem);
+      newItems.sort((a, b) => a.symbol.localeCompare(b.symbol));
+      if (lastDate !== currentDate || lastTransactionPoint === null) {
+        lastTransactionPoint = {
+          date: currentDate,
+          items: newItems
+        };
+        this.transactionPoints.push(lastTransactionPoint);
+      } else {
+        lastTransactionPoint.items = newItems;
+      }
+      lastDate = currentDate;
+    }
+  }
+
+  public getTransactionPoints(): TransactionPoint[] {
+    return this.transactionPoints;
+  }
+
+  public setTransactionPoints(transactionPoints: TransactionPoint[]) {
+    this.transactionPoints = transactionPoints;
+  }
+
+  public async getCurrentPositions(start: Date): Promise<CurrentPositions> {
+    if (!this.transactionPoints?.length) {
+      return {
+        hasErrors: false,
+        positions: [],
+        grossPerformance: new Big(0),
+        grossPerformancePercentage: new Big(0),
+        currentValue: new Big(0),
+        totalInvestment: new Big(0)
+      };
+    }
+
+    const lastTransactionPoint =
+      this.transactionPoints[this.transactionPoints.length - 1];
+
+    // use Date.now() to use the mock for today
+    const today = new Date(Date.now());
+
+    let firstTransactionPoint: TransactionPoint = null;
+    let firstIndex = this.transactionPoints.length;
+    const dates = [];
+    const symbols = new Set<string>();
+    const currencies: { [symbol: string]: Currency } = {};
+
+    dates.push(resetHours(start));
+    for (const item of this.transactionPoints[firstIndex - 1].items) {
+      symbols.add(item.symbol);
+      currencies[item.symbol] = item.currency;
+    }
+    for (let i = 0; i < this.transactionPoints.length; i++) {
+      if (
+        !isBefore(parseDate(this.transactionPoints[i].date), start) &&
+        firstTransactionPoint === null
+      ) {
+        firstTransactionPoint = this.transactionPoints[i];
+        firstIndex = i;
+      }
+      if (firstTransactionPoint !== null) {
+        dates.push(resetHours(parseDate(this.transactionPoints[i].date)));
+      }
+    }
+
+    dates.push(resetHours(today));
+
+    const marketSymbols = await this.currentRateService.getValues({
+      currencies,
+      dateQuery: {
+        in: dates
+      },
+      symbols: Array.from(symbols),
+      userCurrency: this.currency
+    });
+
+    const marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    } = {};
+    for (const marketSymbol of marketSymbols) {
+      const date = format(marketSymbol.date, DATE_FORMAT);
+      if (!marketSymbolMap[date]) {
+        marketSymbolMap[date] = {};
+      }
+      if (marketSymbol.marketPrice) {
+        marketSymbolMap[date][marketSymbol.symbol] = new Big(
+          marketSymbol.marketPrice
+        );
+      }
+    }
+
+    let hasErrors = false;
+    const startString = format(start, DATE_FORMAT);
+
+    const holdingPeriodReturns: { [symbol: string]: Big } = {};
+    const grossPerformance: { [symbol: string]: Big } = {};
+    const todayString = format(today, DATE_FORMAT);
+
+    if (firstIndex > 0) {
+      firstIndex--;
+    }
+    const invalidSymbols = [];
+    const lastInvestments: { [symbol: string]: Big } = {};
+    const lastQuantities: { [symbol: string]: Big } = {};
+    const initialValues: { [symbol: string]: Big } = {};
+
+    for (let i = firstIndex; i < this.transactionPoints.length; i++) {
+      const currentDate =
+        i === firstIndex ? startString : this.transactionPoints[i].date;
+      const nextDate =
+        i + 1 < this.transactionPoints.length
+          ? this.transactionPoints[i + 1].date
+          : todayString;
+
+      const items = this.transactionPoints[i].items;
+      for (const item of items) {
+        let oldHoldingPeriodReturn = holdingPeriodReturns[item.symbol];
+        if (!oldHoldingPeriodReturn) {
+          oldHoldingPeriodReturn = new Big(1);
+        }
+        if (!marketSymbolMap[nextDate]?.[item.symbol]) {
+          invalidSymbols.push(item.symbol);
+          hasErrors = true;
+          console.error(
+            `Missing value for symbol ${item.symbol} at ${nextDate}`
+          );
+          continue;
+        }
+        let lastInvestment: Big = new Big(0);
+        let lastQuantity: Big = item.quantity;
+        if (lastInvestments[item.symbol] && lastQuantities[item.symbol]) {
+          lastInvestment = item.investment.minus(lastInvestments[item.symbol]);
+          lastQuantity = lastQuantities[item.symbol];
+        }
+
+        const itemValue = marketSymbolMap[currentDate]?.[item.symbol];
+        let initialValue = itemValue?.mul(lastQuantity);
+        let investedValue = itemValue?.mul(item.quantity);
+        if (!isAfter(parseDate(currentDate), parseDate(item.firstBuyDate))) {
+          initialValue = item.investment;
+          investedValue = item.investment;
+        }
+        if (i === firstIndex || !initialValues[item.symbol]) {
+          initialValues[item.symbol] = initialValue;
+        }
+        if (!item.quantity.eq(0)) {
+          if (!initialValue) {
+            invalidSymbols.push(item.symbol);
+            hasErrors = true;
+            console.error(
+              `Missing value for symbol ${item.symbol} at ${currentDate}`
+            );
+            continue;
+          }
+
+          const cashFlow = lastInvestment;
+          const endValue = marketSymbolMap[nextDate][item.symbol].mul(
+            item.quantity
+          );
+
+          const holdingPeriodReturn = endValue.div(initialValue.plus(cashFlow));
+          holdingPeriodReturns[item.symbol] =
+            oldHoldingPeriodReturn.mul(holdingPeriodReturn);
+          let oldGrossPerformance = grossPerformance[item.symbol];
+          if (!oldGrossPerformance) {
+            oldGrossPerformance = new Big(0);
+          }
+          const currentPerformance = endValue.minus(investedValue);
+          grossPerformance[item.symbol] =
+            oldGrossPerformance.plus(currentPerformance);
+        }
+        lastInvestments[item.symbol] = item.investment;
+        lastQuantities[item.symbol] = item.quantity;
+      }
+    }
+
+    const positions: TimelinePosition[] = [];
+
+    for (const item of lastTransactionPoint.items) {
+      const marketValue = marketSymbolMap[todayString]?.[item.symbol];
+      const isValid = invalidSymbols.indexOf(item.symbol) === -1;
+      positions.push({
+        averagePrice: item.quantity.eq(0)
+          ? new Big(0)
+          : item.investment.div(item.quantity),
+        currency: item.currency,
+        firstBuyDate: item.firstBuyDate,
+        grossPerformance: isValid
+          ? grossPerformance[item.symbol] ?? null
+          : null,
+        grossPerformancePercentage:
+          isValid && holdingPeriodReturns[item.symbol]
+            ? holdingPeriodReturns[item.symbol].minus(1)
+            : null,
+        investment: item.investment,
+        marketPrice: marketValue?.toNumber() ?? null,
+        quantity: item.quantity,
+        symbol: item.symbol,
+        transactionCount: item.transactionCount
+      });
+    }
+    const overall = this.calculateOverallGrossPerformance(
+      positions,
+      initialValues
+    );
+
+    return {
+      ...overall,
+      positions,
+      hasErrors: hasErrors || overall.hasErrors
+    };
+  }
+
+  public getInvestments(): { date: string; investment: Big }[] {
+    if (this.transactionPoints.length === 0) {
+      return [];
+    }
+
+    return this.transactionPoints.map((transactionPoint) => {
+      return {
+        date: transactionPoint.date,
+        investment: transactionPoint.items.reduce(
+          (investment, transactionPointSymbol) =>
+            investment.add(transactionPointSymbol.investment),
+          new Big(0)
+        )
+      };
+    });
+  }
+
+  public async calculateTimeline(
+    timelineSpecification: TimelineSpecification[],
+    endDate: string
+  ): Promise<TimelinePeriod[]> {
+    if (timelineSpecification.length === 0) {
+      return [];
+    }
+
+    const startDate = timelineSpecification[0].start;
+    const start = parseDate(startDate);
+    const end = parseDate(endDate);
+
+    const timelinePeriodPromises: Promise<TimelinePeriod[]>[] = [];
+    let i = 0;
+    let j = -1;
+    for (
+      let currentDate = start;
+      !isAfter(currentDate, end);
+      currentDate = this.addToDate(
+        currentDate,
+        timelineSpecification[i].accuracy
+      )
+    ) {
+      if (this.isNextItemActive(timelineSpecification, currentDate, i)) {
+        i++;
+      }
+      while (
+        j + 1 < this.transactionPoints.length &&
+        !isAfter(parseDate(this.transactionPoints[j + 1].date), currentDate)
+      ) {
+        j++;
+      }
+
+      let periodEndDate = currentDate;
+      if (timelineSpecification[i].accuracy === 'day') {
+        let nextEndDate = end;
+        if (j + 1 < this.transactionPoints.length) {
+          nextEndDate = parseDate(this.transactionPoints[j + 1].date);
+        }
+        periodEndDate = min([
+          addMonths(currentDate, 3),
+          max([currentDate, nextEndDate])
+        ]);
+      }
+      const timePeriodForDates = this.getTimePeriodForDate(
+        j,
+        currentDate,
+        endOfDay(periodEndDate)
+      );
+      currentDate = periodEndDate;
+      if (timePeriodForDates != null) {
+        timelinePeriodPromises.push(timePeriodForDates);
+      }
+    }
+
+    const timelinePeriods: TimelinePeriod[][] = await Promise.all(
+      timelinePeriodPromises
+    );
+
+    return flatten(timelinePeriods);
+  }
+
+  private calculateOverallGrossPerformance(
+    positions: TimelinePosition[],
+    initialValues: { [p: string]: Big }
+  ) {
+    let hasErrors = false;
+    let currentValue = new Big(0);
+    let totalInvestment = new Big(0);
+    let grossPerformance = new Big(0);
+    let grossPerformancePercentage = new Big(0);
+    let completeInitialValue = new Big(0);
+    for (const currentPosition of positions) {
+      if (currentPosition.marketPrice) {
+        currentValue = currentValue.add(
+          new Big(currentPosition.marketPrice).mul(currentPosition.quantity)
+        );
+      } else {
+        hasErrors = true;
+      }
+      totalInvestment = totalInvestment.add(currentPosition.investment);
+      if (currentPosition.grossPerformance) {
+        grossPerformance = grossPerformance.plus(
+          currentPosition.grossPerformance
+        );
+      } else if (!currentPosition.quantity.eq(0)) {
+        hasErrors = true;
+      }
+
+      if (
+        currentPosition.grossPerformancePercentage &&
+        initialValues[currentPosition.symbol]
+      ) {
+        const currentInitialValue = initialValues[currentPosition.symbol];
+        completeInitialValue = completeInitialValue.plus(currentInitialValue);
+        grossPerformancePercentage = grossPerformancePercentage.plus(
+          currentPosition.grossPerformancePercentage.mul(currentInitialValue)
+        );
+      } else if (!currentPosition.quantity.eq(0)) {
+        console.error(
+          `Initial value is missing for symbol ${currentPosition.symbol}`
+        );
+        hasErrors = true;
+      }
+    }
+
+    if (!completeInitialValue.eq(0)) {
+      grossPerformancePercentage =
+        grossPerformancePercentage.div(completeInitialValue);
+    }
+
+    return {
+      currentValue,
+      grossPerformance,
+      grossPerformancePercentage,
+      hasErrors,
+      totalInvestment
+    };
+  }
+
+  private async getTimePeriodForDate(
+    j: number,
+    startDate: Date,
+    endDate: Date
+  ): Promise<TimelinePeriod[]> {
+    let investment: Big = new Big(0);
+
+    const marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    } = {};
+    if (j >= 0) {
+      const currencies: { [name: string]: Currency } = {};
+      const symbols: string[] = [];
+
+      for (const item of this.transactionPoints[j].items) {
+        currencies[item.symbol] = item.currency;
+        symbols.push(item.symbol);
+        investment = investment.add(item.investment);
+      }
+
+      let marketSymbols: GetValueObject[] = [];
+      if (symbols.length > 0) {
+        try {
+          marketSymbols = await this.currentRateService.getValues({
+            dateQuery: {
+              gte: startDate,
+              lt: endOfDay(endDate)
+            },
+            symbols,
+            currencies,
+            userCurrency: this.currency
+          });
+        } catch (error) {
+          console.error(
+            `Failed to fetch info for date ${startDate} with exception`,
+            error
+          );
+          return null;
+        }
+      }
+
+      for (const marketSymbol of marketSymbols) {
+        const date = format(marketSymbol.date, DATE_FORMAT);
+        if (!marketSymbolMap[date]) {
+          marketSymbolMap[date] = {};
+        }
+        if (marketSymbol.marketPrice) {
+          marketSymbolMap[date][marketSymbol.symbol] = new Big(
+            marketSymbol.marketPrice
+          );
+        }
+      }
+    }
+
+    const results = [];
+    for (
+      let currentDate = startDate;
+      isBefore(currentDate, endDate);
+      currentDate = addDays(currentDate, 1)
+    ) {
+      let value = new Big(0);
+      const currentDateAsString = format(currentDate, DATE_FORMAT);
+      let invalid = false;
+      if (j >= 0) {
+        for (const item of this.transactionPoints[j].items) {
+          if (
+            !marketSymbolMap[currentDateAsString]?.hasOwnProperty(item.symbol)
+          ) {
+            invalid = true;
+            break;
+          }
+          value = value.add(
+            item.quantity.mul(marketSymbolMap[currentDateAsString][item.symbol])
+          );
+        }
+      }
+      if (!invalid) {
+        const result = {
+          date: currentDateAsString,
+          grossPerformance: value.minus(investment),
+          investment,
+          value
+        };
+        results.push(result);
+      }
+    }
+
+    return results;
+  }
+
+  private getFactor(type: OrderType) {
+    let factor: number;
+
+    switch (type) {
+      case OrderType.Buy:
+        factor = 1;
+        break;
+      case OrderType.Sell:
+        factor = -1;
+        break;
+      default:
+        factor = 0;
+        break;
+    }
+
+    return factor;
+  }
+
+  private addToDate(date: Date, accuracy: Accuracy): Date {
+    switch (accuracy) {
+      case 'day':
+        return addDays(date, 1);
+      case 'month':
+        return addMonths(date, 1);
+      case 'year':
+        return addYears(date, 1);
+    }
+  }
+
+  private isNextItemActive(
+    timelineSpecification: TimelineSpecification[],
+    currentDate: Date,
+    i: number
+  ) {
+    return (
+      i + 1 < timelineSpecification.length &&
+      !isBefore(currentDate, parseDate(timelineSpecification[i + 1].start))
+    );
+  }
+}

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -1,21 +1,16 @@
+import { UserService } from '@ghostfolio/api/app/user/user.service';
 import {
   hasNotDefinedValuesInObject,
   nullifyValuesInObject
 } from '@ghostfolio/api/helper/object.helper';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
 import {
-  PortfolioItem,
-  PortfolioOverview,
+  PortfolioDetails,
   PortfolioPerformance,
-  PortfolioPosition,
-  PortfolioReport
+  PortfolioReport,
+  PortfolioSummary
 } from '@ghostfolio/common/interfaces';
-import {
-  getPermissions,
-  hasPermission,
-  permissions
-} from '@ghostfolio/common/permissions';
+import { InvestmentItem } from '@ghostfolio/common/interfaces/investment-item.interface';
 import { RequestWithUser } from '@ghostfolio/common/types';
 import {
   Controller,
@@ -37,50 +32,43 @@ import {
   HistoricalDataItem,
   PortfolioPositionDetail
 } from './interfaces/portfolio-position-detail.interface';
+import { PortfolioPositions } from './interfaces/portfolio-positions.interface';
 import { PortfolioService } from './portfolio.service';
 
 @Controller('portfolio')
 export class PortfolioController {
   public constructor(
     private readonly exchangeRateDataService: ExchangeRateDataService,
-    private readonly impersonationService: ImpersonationService,
-    private portfolioService: PortfolioService,
-    @Inject(REQUEST) private readonly request: RequestWithUser
+    private readonly portfolioService: PortfolioService,
+    @Inject(REQUEST) private readonly request: RequestWithUser,
+    private readonly userService: UserService
   ) {}
 
-  @Get()
+  @Get('investments')
   @UseGuards(AuthGuard('jwt'))
   public async findAll(
     @Headers('impersonation-id') impersonationId
-  ): Promise<PortfolioItem[]> {
-    let portfolio = await this.portfolioService.findAll(impersonationId);
+  ): Promise<InvestmentItem[]> {
+    let investments = await this.portfolioService.getInvestments(
+      impersonationId
+    );
 
     if (
-      impersonationId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
-      portfolio = portfolio.map((portfolioItem) => {
-        Object.keys(portfolioItem.positions).forEach((symbol) => {
-          portfolioItem.positions[symbol].investment =
-            portfolioItem.positions[symbol].investment > 0 ? 1 : 0;
-          portfolioItem.positions[symbol].investmentInOriginalCurrency =
-            portfolioItem.positions[symbol].investmentInOriginalCurrency > 0
-              ? 1
-              : 0;
-          portfolioItem.positions[symbol].quantity =
-            portfolioItem.positions[symbol].quantity > 0 ? 1 : 0;
-        });
+      const maxInvestment = investments.reduce(
+        (investment, item) => Math.max(investment, item.investment),
+        1
+      );
 
-        portfolioItem.investment = null;
-
-        return portfolioItem;
-      });
+      investments = investments.map((item) => ({
+        date: item.date,
+        investment: item.investment / maxInvestment
+      }));
     }
 
-    return portfolio;
+    return investments;
   }
 
   @Get('chart')
@@ -108,11 +96,8 @@ export class PortfolioController {
     }
 
     if (
-      impersonationId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
       let maxValue = 0;
 
@@ -139,45 +124,25 @@ export class PortfolioController {
     @Headers('impersonation-id') impersonationId,
     @Query('range') range,
     @Res() res: Response
-  ): Promise<{ [symbol: string]: PortfolioPosition }> {
-    let details: { [symbol: string]: PortfolioPosition } = {};
+  ): Promise<PortfolioDetails> {
+    const { accounts, holdings, hasErrors } =
+      await this.portfolioService.getDetails(impersonationId, range);
 
-    const impersonationUserId =
-      await this.impersonationService.validateImpersonationId(
-        impersonationId,
-        this.request.user.id
-      );
-
-    const portfolio = await this.portfolioService.createPortfolio(
-      impersonationUserId || this.request.user.id
-    );
-
-    try {
-      details = await portfolio.getDetails(range);
-    } catch (error) {
-      console.error(error);
-
-      res.status(StatusCodes.ACCEPTED);
-    }
-
-    if (hasNotDefinedValuesInObject(details)) {
+    if (hasErrors || hasNotDefinedValuesInObject(holdings)) {
       res.status(StatusCodes.ACCEPTED);
     }
 
     if (
-      impersonationId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
-      const totalInvestment = Object.values(details)
+      const totalInvestment = Object.values(holdings)
         .map((portfolioPosition) => {
           return portfolioPosition.investment;
         })
         .reduce((a, b) => a + b, 0);
 
-      const totalValue = Object.values(details)
+      const totalValue = Object.values(holdings)
         .map((portfolioPosition) => {
           return this.exchangeRateDataService.toCurrency(
             portfolioPosition.quantity * portfolioPosition.marketPrice,
@@ -187,50 +152,21 @@ export class PortfolioController {
         })
         .reduce((a, b) => a + b, 0);
 
-      for (const [symbol, portfolioPosition] of Object.entries(details)) {
+      for (const [symbol, portfolioPosition] of Object.entries(holdings)) {
         portfolioPosition.grossPerformance = null;
         portfolioPosition.investment =
           portfolioPosition.investment / totalInvestment;
 
-        for (const [account, { current, original }] of Object.entries(
-          portfolioPosition.accounts
-        )) {
-          portfolioPosition.accounts[account].current = current / totalValue;
-          portfolioPosition.accounts[account].original =
-            original / totalInvestment;
-        }
-
         portfolioPosition.quantity = null;
       }
+
+      for (const [name, { current, original }] of Object.entries(accounts)) {
+        accounts[name].current = current / totalValue;
+        accounts[name].original = original / totalInvestment;
+      }
     }
 
-    return <any>res.json(details);
-  }
-
-  @Get('overview')
-  @UseGuards(AuthGuard('jwt'))
-  public async getOverview(
-    @Headers('impersonation-id') impersonationId
-  ): Promise<PortfolioOverview> {
-    let overview = await this.portfolioService.getOverview(impersonationId);
-
-    if (
-      impersonationId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
-    ) {
-      overview = nullifyValuesInObject(overview, [
-        'cash',
-        'committedFunds',
-        'fees',
-        'totalBuy',
-        'totalSell'
-      ]);
-    }
-
-    return overview;
+    return <any>res.json({ accounts, holdings });
   }
 
   @Get('performance')
@@ -240,32 +176,22 @@ export class PortfolioController {
     @Query('range') range,
     @Res() res: Response
   ): Promise<PortfolioPerformance> {
-    const impersonationUserId =
-      await this.impersonationService.validateImpersonationId(
-        impersonationId,
-        this.request.user.id
-      );
-
-    const portfolio = await this.portfolioService.createPortfolio(
-      impersonationUserId || this.request.user.id
+    const performanceInformation = await this.portfolioService.getPerformance(
+      impersonationId,
+      range
     );
 
-    let performance = await portfolio.getPerformance(range);
-
-    if (hasNotDefinedValuesInObject(performance)) {
+    if (performanceInformation?.hasErrors) {
       res.status(StatusCodes.ACCEPTED);
     }
 
+    let performance = performanceInformation.performance;
     if (
-      impersonationId &&
-      !hasPermission(
-        getPermissions(this.request.user.role),
-        permissions.readForeignPortfolio
-      )
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
     ) {
       performance = nullifyValuesInObject(performance, [
         'currentGrossPerformance',
-        'currentNetPerformance',
         'currentValue'
       ]);
     }
@@ -273,6 +199,64 @@ export class PortfolioController {
     return <any>res.json(performance);
   }
 
+  @Get('positions')
+  @UseGuards(AuthGuard('jwt'))
+  public async getPositions(
+    @Headers('impersonation-id') impersonationId,
+    @Query('range') range,
+    @Res() res: Response
+  ): Promise<PortfolioPositions> {
+    const result = await this.portfolioService.getPositions(
+      impersonationId,
+      range
+    );
+
+    if (result?.hasErrors) {
+      res.status(StatusCodes.ACCEPTED);
+    }
+
+    if (
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
+    ) {
+      result.positions = result.positions.map((position) => {
+        return nullifyValuesInObject(position, [
+          'grossPerformance',
+          'investment',
+          'quantity'
+        ]);
+      });
+    }
+
+    return <any>res.json(result);
+  }
+
+  @Get('summary')
+  @UseGuards(AuthGuard('jwt'))
+  public async getSummary(
+    @Headers('impersonation-id') impersonationId
+  ): Promise<PortfolioSummary> {
+    let summary = await this.portfolioService.getSummary(impersonationId);
+
+    if (
+      impersonationId ||
+      this.userService.isRestrictedView(this.request.user)
+    ) {
+      summary = nullifyValuesInObject(summary, [
+        'cash',
+        'committedFunds',
+        'currentGrossPerformance',
+        'currentValue',
+        'fees',
+        'netWorth',
+        'totalBuy',
+        'totalSell'
+      ]);
+    }
+
+    return summary;
+  }
+
   @Get('position/:symbol')
   @UseGuards(AuthGuard('jwt'))
   public async getPosition(
@@ -286,13 +270,14 @@ export class PortfolioController {
 
     if (position) {
       if (
-        impersonationId &&
-        !hasPermission(
-          getPermissions(this.request.user.role),
-          permissions.readForeignPortfolio
-        )
+        impersonationId ||
+        this.userService.isRestrictedView(this.request.user)
       ) {
-        position = nullifyValuesInObject(position, ['grossPerformance']);
+        position = nullifyValuesInObject(position, [
+          'grossPerformance',
+          'investment',
+          'quantity'
+        ]);
       }
 
       return position;
@@ -309,16 +294,6 @@ export class PortfolioController {
   public async getReport(
     @Headers('impersonation-id') impersonationId
   ): Promise<PortfolioReport> {
-    const impersonationUserId =
-      await this.impersonationService.validateImpersonationId(
-        impersonationId,
-        this.request.user.id
-      );
-
-    const portfolio = await this.portfolioService.createPortfolio(
-      impersonationUserId || this.request.user.id
-    );
-
-    return await portfolio.getReport();
+    return await this.portfolioService.getReport(impersonationId);
   }
 }

apps/api/src/app/portfolio/portfolio.module.ts

@@ -1,44 +1,40 @@
 import { AccountService } from '@ghostfolio/api/app/account/account.service';
-import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
-import { OrderService } from '@ghostfolio/api/app/order/order.service';
-import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
-import { UserService } from '@ghostfolio/api/app/user/user.service';
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
-import { RulesService } from '@ghostfolio/api/services/rules.service';
+import { OrderModule } from '@ghostfolio/api/app/order/order.module';
+import { UserModule } from '@ghostfolio/api/app/user/user.module';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
+import { ImpersonationModule } from '@ghostfolio/api/services/impersonation.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
+import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
 import { Module } from '@nestjs/common';
 
+import { CurrentRateService } from './current-rate.service';
+import { MarketDataService } from './market-data.service';
 import { PortfolioController } from './portfolio.controller';
 import { PortfolioService } from './portfolio.service';
+import { RulesService } from './rules.service';
 
 @Module({
-  imports: [RedisCacheModule],
+  imports: [
+    ConfigurationModule,
+    DataGatheringModule,
+    DataProviderModule,
+    ExchangeRateDataModule,
+    ImpersonationModule,
+    OrderModule,
+    PrismaModule,
+    UserModule
+  ],
   controllers: [PortfolioController],
   providers: [
     AccountService,
-    AlphaVantageService,
-    CacheService,
-    ConfigurationService,
-    DataGatheringService,
-    DataProviderService,
-    ExchangeRateDataService,
-    GhostfolioScraperApiService,
-    ImpersonationService,
-    OrderService,
+    CurrentRateService,
+    MarketDataService,
     PortfolioService,
-    PrismaService,
-    RakutenRapidApiService,
     RulesService,
-    UserService,
-    YahooFinanceService
+    SymbolProfileService
   ]
 })
 export class PortfolioModule {}

apps/api/src/app/portfolio/rules.service.ts

@@ -0,0 +1,23 @@
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { Rule } from '@ghostfolio/api/models/rule';
+import { Injectable } from '@nestjs/common';
+import { Currency } from '@prisma/client';
+
+@Injectable()
+export class RulesService {
+  public constructor() {}
+
+  public async evaluate<T extends RuleSettings>(
+    aRules: Rule<T>[],
+    aUserSettings: { baseCurrency: Currency }
+  ) {
+    return aRules
+      .filter((rule) => {
+        return rule.getSettings(aUserSettings)?.isActive;
+      })
+      .map((rule) => {
+        const evaluationResult = rule.evaluate(rule.getSettings(aUserSettings));
+        return { ...evaluationResult, name: rule.getName() };
+      });
+  }
+}

apps/api/src/app/subscription/subscription.service.ts

@@ -10,7 +10,7 @@ export class SubscriptionService {
 
   public constructor(
     private readonly configurationService: ConfigurationService,
-    private prisma: PrismaService
+    private readonly prismaService: PrismaService
   ) {
     this.stripe = new Stripe(
       this.configurationService.get('STRIPE_SECRET_KEY'),
@@ -68,7 +68,7 @@ export class SubscriptionService {
         aCheckoutSessionId
       );
 
-      await this.prisma.subscription.create({
+      await this.prismaService.subscription.create({
         data: {
           expiresAt: addDays(new Date(), 365),
           User: {

apps/api/src/app/symbol/interfaces/lookup-item.interface.ts

@@ -1,6 +1,7 @@
-import { DataSource } from '@prisma/client';
+import { Currency, DataSource } from '@prisma/client';
 
 export interface LookupItem {
+  currency: Currency;
   dataSource: DataSource;
   name: string;
   symbol: string;

apps/api/src/app/symbol/symbol.module.ts

@@ -1,27 +1,14 @@
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
-import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { Module } from '@nestjs/common';
 
 import { SymbolController } from './symbol.controller';
 import { SymbolService } from './symbol.service';
 
 @Module({
-  imports: [],
+  imports: [ConfigurationModule, DataProviderModule, PrismaModule],
   controllers: [SymbolController],
-  providers: [
-    AlphaVantageService,
-    ConfigurationService,
-    DataProviderService,
-    GhostfolioScraperApiService,
-    PrismaService,
-    RakutenRapidApiService,
-    SymbolService,
-    YahooFinanceService
-  ]
+  providers: [SymbolService]
 })
 export class SymbolModule {}

apps/api/src/app/symbol/symbol.service.ts

@@ -1,6 +1,5 @@
-import { DataProviderService } from '@ghostfolio/api/services/data-provider.service';
-import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { convertFromYahooSymbol } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
+import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { Injectable } from '@nestjs/common';
 import { Currency, DataSource } from '@prisma/client';
 
@@ -11,7 +10,7 @@ import { SymbolItem } from './interfaces/symbol-item.interface';
 export class SymbolService {
   public constructor(
     private readonly dataProviderService: DataProviderService,
-    private readonly ghostfolioScraperApiService: GhostfolioScraperApiService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async get(aSymbol: string): Promise<SymbolItem> {
@@ -37,16 +36,29 @@ export class SymbolService {
       results.items = items;
 
       // Add custom symbols
-      const scraperConfigurations = await this.ghostfolioScraperApiService.getScraperConfigurations();
-      scraperConfigurations.forEach((scraperConfiguration) => {
-        if (scraperConfiguration.name.toLowerCase().startsWith(aQuery)) {
-          results.items.push({
-            dataSource: DataSource.GHOSTFOLIO,
-            name: scraperConfiguration.name,
-            symbol: scraperConfiguration.symbol
-          });
-        }
-      });
+      const ghostfolioSymbolProfiles =
+        await this.prismaService.symbolProfile.findMany({
+          select: {
+            currency: true,
+            dataSource: true,
+            name: true,
+            symbol: true
+          },
+          where: {
+            AND: [
+              {
+                dataSource: DataSource.GHOSTFOLIO,
+                name: {
+                  startsWith: aQuery
+                }
+              }
+            ]
+          }
+        });
+
+      for (const ghostfolioSymbolProfile of ghostfolioSymbolProfiles) {
+        results.items.push(ghostfolioSymbolProfile);
+      }
 
       return results;
     } catch (error) {

apps/api/src/app/user/interfaces/user-settings.interface.ts

@@ -0,0 +1,3 @@
+export interface UserSettings {
+  isRestrictedView?: boolean;
+}

apps/api/src/app/user/update-user-setting.dto.ts

@@ -0,0 +1,6 @@
+import { IsBoolean } from 'class-validator';
+
+export class UpdateUserSettingDto {
+  @IsBoolean()
+  isRestrictedView?: boolean;
+}

apps/api/src/app/user/user.controller.ts

@@ -26,6 +26,8 @@ import { StatusCodes, getReasonPhrase } from 'http-status-codes';
 
 import { UserItem } from './interfaces/user-item.interface';
 import { UserSettingsParams } from './interfaces/user-settings-params.interface';
+import { UserSettings } from './interfaces/user-settings.interface';
+import { UpdateUserSettingDto } from './update-user-setting.dto';
 import { UpdateUserSettingsDto } from './update-user-settings.dto';
 import { UserService } from './user.service';
 
@@ -78,6 +80,32 @@ export class UserController {
     };
   }
 
+  @Put('setting')
+  @UseGuards(AuthGuard('jwt'))
+  public async updateUserSetting(@Body() data: UpdateUserSettingDto) {
+    if (
+      !hasPermission(
+        getPermissions(this.request.user.role),
+        permissions.updateUserSettings
+      )
+    ) {
+      throw new HttpException(
+        getReasonPhrase(StatusCodes.FORBIDDEN),
+        StatusCodes.FORBIDDEN
+      );
+    }
+
+    const userSettings: UserSettings = {
+      ...(<UserSettings>this.request.user.Settings.settings),
+      ...data
+    };
+
+    return await this.userService.updateUserSetting({
+      userSettings,
+      userId: this.request.user.id
+    });
+  }
+
   @Put('settings')
   @UseGuards(AuthGuard('jwt'))
   public async updateUserSettings(@Body() data: UpdateUserSettingsDto) {

apps/api/src/app/user/user.module.ts

@@ -14,6 +14,7 @@ import { UserService } from './user.service';
     })
   ],
   controllers: [UserController],
-  providers: [ConfigurationService, PrismaService, UserService]
+  providers: [ConfigurationService, PrismaService, UserService],
+  exports: [UserService]
 })
 export class UserModule {}

apps/api/src/app/user/user.service.ts

@@ -9,6 +9,7 @@ import { Currency, Prisma, Provider, User, ViewMode } from '@prisma/client';
 import { isBefore } from 'date-fns';
 
 import { UserSettingsParams } from './interfaces/user-settings-params.interface';
+import { UserSettings } from './interfaces/user-settings.interface';
 
 const crypto = require('crypto');
 
@@ -18,7 +19,7 @@ export class UserService {
 
   public constructor(
     private readonly configurationService: ConfigurationService,
-    private prisma: PrismaService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async getUser({
@@ -29,7 +30,7 @@ export class UserService {
     Settings,
     subscription
   }: UserWithSettings): Promise<IUser> {
-    const access = await this.prisma.access.findMany({
+    const access = await this.prismaService.access.findMany({
       include: {
         User: true
       },
@@ -50,6 +51,7 @@ export class UserService {
       }),
       accounts: Account,
       settings: {
+        ...(<UserSettings>Settings.settings),
         locale,
         baseCurrency: Settings?.currency ?? UserService.DEFAULT_CURRENCY,
         viewMode: Settings?.viewMode ?? ViewMode.DEFAULT
@@ -57,10 +59,14 @@ export class UserService {
     };
   }
 
+  public isRestrictedView(aUser: UserWithSettings) {
+    return (aUser.Settings.settings as UserSettings)?.isRestrictedView ?? false;
+  }
+
   public async user(
     userWhereUniqueInput: Prisma.UserWhereUniqueInput
   ): Promise<UserWithSettings | null> {
-    const userFromDatabase = await this.prisma.user.findUnique({
+    const userFromDatabase = await this.prismaService.user.findUnique({
       include: { Account: true, Settings: true, Subscription: true },
       where: userWhereUniqueInput
     });
@@ -84,6 +90,7 @@ export class UserService {
       // Set default settings if needed
       userFromDatabase.Settings = {
         currency: UserService.DEFAULT_CURRENCY,
+        settings: null,
         updatedAt: new Date(),
         userId: userFromDatabase?.id,
         viewMode: ViewMode.DEFAULT
@@ -129,7 +136,7 @@ export class UserService {
     orderBy?: Prisma.UserOrderByInput;
   }): Promise<User[]> {
     const { skip, take, cursor, where, orderBy } = params;
-    return this.prisma.user.findMany({
+    return this.prismaService.user.findMany({
       skip,
       take,
       cursor,
@@ -146,7 +153,7 @@ export class UserService {
   }
 
   public async createUser(data?: Prisma.UserCreateInput): Promise<User> {
-    let user = await this.prisma.user.create({
+    let user = await this.prismaService.user.create({
       data: {
         ...data,
         Account: {
@@ -169,7 +176,7 @@ export class UserService {
         process.env.ACCESS_TOKEN_SALT
       );
 
-      user = await this.prisma.user.update({
+      user = await this.prismaService.user.update({
         data: { accessToken: hashedAccessToken },
         where: { id: user.id }
       });
@@ -185,46 +192,75 @@ export class UserService {
     data: Prisma.UserUpdateInput;
   }): Promise<User> {
     const { where, data } = params;
-    return this.prisma.user.update({
+    return this.prismaService.user.update({
       data,
       where
     });
   }
 
   public async deleteUser(where: Prisma.UserWhereUniqueInput): Promise<User> {
-    await this.prisma.access.deleteMany({
+    await this.prismaService.access.deleteMany({
       where: { OR: [{ granteeUserId: where.id }, { userId: where.id }] }
     });
 
-    await this.prisma.account.deleteMany({
+    await this.prismaService.account.deleteMany({
       where: { userId: where.id }
     });
 
-    await this.prisma.analytics.delete({
+    await this.prismaService.analytics.delete({
       where: { userId: where.id }
     });
 
-    await this.prisma.order.deleteMany({
+    await this.prismaService.order.deleteMany({
       where: { userId: where.id }
     });
 
     try {
-      await this.prisma.settings.delete({
+      await this.prismaService.settings.delete({
         where: { userId: where.id }
       });
     } catch {}
 
-    return this.prisma.user.delete({
+    return this.prismaService.user.delete({
       where
     });
   }
 
+  public async updateUserSetting({
+    userId,
+    userSettings
+  }: {
+    userId: string;
+    userSettings: UserSettings;
+  }) {
+    const settings = userSettings as Prisma.JsonObject;
+
+    await this.prismaService.settings.upsert({
+      create: {
+        settings,
+        User: {
+          connect: {
+            id: userId
+          }
+        }
+      },
+      update: {
+        settings
+      },
+      where: {
+        userId: userId
+      }
+    });
+
+    return;
+  }
+
   public async updateUserSettings({
     currency,
     userId,
     viewMode
   }: UserSettingsParams) {
-    await this.prisma.settings.upsert({
+    await this.prismaService.settings.upsert({
       create: {
         currency,
         User: {

apps/api/src/models/interfaces/portfolio.interface.ts

@@ -5,13 +5,9 @@ import { Order } from '../order';
 export interface PortfolioInterface {
   get(aDate?: Date): PortfolioItem[];
 
-  getCommittedFunds(): number;
-
   getFees(): number;
 
-  getPositions(
-    aDate: Date
-  ): {
+  getPositions(aDate: Date): {
     [symbol: string]: Position;
   };
 

apps/api/src/models/interfaces/rule-settings.interface.ts

@@ -0,0 +1,3 @@
+export interface RuleSettings {
+  isActive: boolean;
+}

apps/api/src/models/interfaces/rule.interface.ts

@@ -1,15 +1,10 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
 
 import { EvaluationResult } from './evaluation-result.interface';
 
-export interface RuleInterface {
-  evaluate(
-    aPortfolioPositionMap: {
-      [symbol: string]: PortfolioPosition;
-    },
-    aFees: number,
-    aRuleSettingsMap: {
-      [key: string]: any;
-    }
-  ): EvaluationResult;
+export interface RuleInterface<T extends RuleSettings> {
+  evaluate(aRuleSettings: T): EvaluationResult;
+
+  getSettings(aUserSettings: UserSettings): T;
 }

apps/api/src/models/interfaces/user-settings.interface.ts

@@ -0,0 +1,5 @@
+import { Currency } from '@prisma/client';
+
+export interface UserSettings {
+  baseCurrency: Currency;
+}

apps/api/src/models/order.ts

@@ -1,5 +1,4 @@
 import { Account, Currency, SymbolProfile } from '@prisma/client';
-import { endOfToday, isAfter, parseISO } from 'date-fns';
 import { v4 as uuidv4 } from 'uuid';
 
 import { IOrder } from '../services/interfaces/interfaces';
@@ -11,6 +10,7 @@ export class Order {
   private fee: number;
   private date: string;
   private id: string;
+  private isDraft: boolean;
   private quantity: number;
   private symbol: string;
   private symbolProfile: SymbolProfile;
@@ -24,6 +24,7 @@ export class Order {
     this.fee = data.fee;
     this.date = data.date;
     this.id = data.id || uuidv4();
+    this.isDraft = data.isDraft;
     this.quantity = data.quantity;
     this.symbol = data.symbol;
     this.symbolProfile = data.symbolProfile;
@@ -54,7 +55,7 @@ export class Order {
   }
 
   public getIsDraft() {
-    return isAfter(parseISO(this.date), endOfToday());
+    return this.isDraft;
   }
 
   public getQuantity() {

apps/api/src/models/portfolio.spec.ts

@@ -1,704 +0,0 @@
-import { AccountService } from '@ghostfolio/api/app/account/account.service';
-import { UNKNOWN_KEY, baseCurrency } from '@ghostfolio/common/config';
-import { getUtc, getYesterday } from '@ghostfolio/common/helper';
-import {
-  AccountType,
-  Currency,
-  DataSource,
-  Role,
-  Type,
-  ViewMode
-} from '@prisma/client';
-import { format } from 'date-fns';
-
-import { DataProviderService } from '../services/data-provider.service';
-import { ExchangeRateDataService } from '../services/exchange-rate-data.service';
-import { MarketState } from '../services/interfaces/interfaces';
-import { RulesService } from '../services/rules.service';
-import { Portfolio } from './portfolio';
-
-jest.mock('../app/account/account.service', () => {
-  return {
-    AccountService: jest.fn().mockImplementation(() => {
-      return {
-        getCashDetails: () => Promise.resolve({ accounts: [], balance: 0 })
-      };
-    })
-  };
-});
-
-jest.mock('../services/data-provider.service', () => {
-  return {
-    DataProviderService: jest.fn().mockImplementation(() => {
-      const today = format(new Date(), 'yyyy-MM-dd');
-      const yesterday = format(getYesterday(), 'yyyy-MM-dd');
-
-      return {
-        get: () => {
-          return Promise.resolve({
-            BTCUSD: {
-              currency: Currency.USD,
-              dataSource: DataSource.YAHOO,
-              exchange: UNKNOWN_KEY,
-              marketPrice: 57973.008,
-              marketState: MarketState.open,
-              name: 'Bitcoin USD',
-              type: 'Cryptocurrency'
-            },
-            ETHUSD: {
-              currency: Currency.USD,
-              dataSource: DataSource.YAHOO,
-              exchange: UNKNOWN_KEY,
-              marketPrice: 3915.337,
-              marketState: MarketState.open,
-              name: 'Ethereum USD',
-              type: 'Cryptocurrency'
-            }
-          });
-        },
-        getHistorical: () => {
-          return Promise.resolve({
-            BTCUSD: {
-              [yesterday]: 56710.122,
-              [today]: 57973.008
-            },
-            ETHUSD: {
-              [yesterday]: 3641.984,
-              [today]: 3915.337
-            }
-          });
-        }
-      };
-    })
-  };
-});
-
-jest.mock('../services/exchange-rate-data.service', () => {
-  return {
-    ExchangeRateDataService: jest.fn().mockImplementation(() => {
-      return {
-        initialize: () => Promise.resolve(),
-        toCurrency: (value: number) => value
-      };
-    })
-  };
-});
-
-jest.mock('../services/data-provider.service');
-jest.mock('../services/exchange-rate-data.service');
-jest.mock('../services/rules.service');
-
-const DEFAULT_ACCOUNT_ID = '693a834b-eb89-42c9-ae47-35196c25d269';
-const USER_ID = 'ca6ce867-5d31-495a-bce9-5942bbca9237';
-
-describe('Portfolio', () => {
-  let accountService: AccountService;
-  let dataProviderService: DataProviderService;
-  let exchangeRateDataService: ExchangeRateDataService;
-  let portfolio: Portfolio;
-  let rulesService: RulesService;
-
-  beforeAll(async () => {
-    accountService = new AccountService(null, null, null);
-    dataProviderService = new DataProviderService(
-      null,
-      null,
-      null,
-      null,
-      null,
-      null
-    );
-    exchangeRateDataService = new ExchangeRateDataService(null);
-    rulesService = new RulesService();
-
-    await exchangeRateDataService.initialize();
-
-    portfolio = new Portfolio(
-      accountService,
-      dataProviderService,
-      exchangeRateDataService,
-      rulesService
-    );
-    portfolio.setUser({
-      accessToken: null,
-      Account: [
-        {
-          accountType: AccountType.SECURITIES,
-          balance: 0,
-          createdAt: new Date(),
-          currency: Currency.USD,
-          id: DEFAULT_ACCOUNT_ID,
-          isDefault: true,
-          name: 'Default Account',
-          platformId: null,
-          updatedAt: new Date(),
-          userId: USER_ID
-        }
-      ],
-      alias: 'Test',
-      authChallenge: null,
-      createdAt: new Date(),
-      id: USER_ID,
-      provider: null,
-      role: Role.USER,
-      Settings: {
-        currency: Currency.CHF,
-        updatedAt: new Date(),
-        userId: USER_ID,
-        viewMode: ViewMode.DEFAULT
-      },
-      thirdPartyId: null,
-      updatedAt: new Date()
-    });
-  });
-
-  describe('works with no orders', () => {
-    it('should return []', () => {
-      expect(portfolio.get(new Date())).toEqual([]);
-      expect(portfolio.getFees()).toEqual(0);
-      expect(portfolio.getPositions(new Date())).toEqual({});
-    });
-
-    it('should return empty details', async () => {
-      const details = await portfolio.getDetails('1d');
-      expect(details).toMatchObject({
-        _GF_CASH: {
-          accounts: {},
-          allocationCurrent: NaN, // TODO
-          allocationInvestment: NaN, // TODO
-          countries: [],
-          currency: 'CHF',
-          grossPerformance: 0,
-          grossPerformancePercent: 0,
-          investment: 0,
-          marketPrice: 0,
-          marketState: 'open',
-          name: 'Cash',
-          quantity: 0,
-          sectors: [],
-          symbol: '_GF_CASH',
-          transactionCount: 0,
-          type: 'Cash',
-          value: 0
-        }
-      });
-    });
-
-    it('should return empty details', async () => {
-      const details = await portfolio.getDetails('max');
-      expect(details).toMatchObject({
-        _GF_CASH: {
-          accounts: {},
-          allocationCurrent: NaN, // TODO
-          allocationInvestment: NaN, // TODO
-          countries: [],
-          currency: 'CHF',
-          grossPerformance: 0,
-          grossPerformancePercent: 0,
-          investment: 0,
-          marketPrice: 0,
-          marketState: 'open',
-          name: 'Cash',
-          quantity: 0,
-          sectors: [],
-          symbol: '_GF_CASH',
-          transactionCount: 0,
-          type: 'Cash',
-          value: 0
-        }
-      });
-    });
-
-    it('should return zero performance for 1d', async () => {
-      const performance = await portfolio.getPerformance('1d');
-      expect(performance).toEqual({
-        currentGrossPerformance: 0,
-        currentGrossPerformancePercent: 0,
-        currentNetPerformance: 0,
-        currentNetPerformancePercent: 0,
-        currentValue: 0
-      });
-    });
-
-    it('should return zero performance for max', async () => {
-      const performance = await portfolio.getPerformance('max');
-      expect(performance).toEqual({
-        currentGrossPerformance: 0,
-        currentGrossPerformancePercent: 0,
-        currentNetPerformance: 0,
-        currentNetPerformancePercent: 0,
-        currentValue: 0
-      });
-    });
-  });
-
-  describe(`works with today's orders`, () => {
-    it('should return ["BTC"]', async () => {
-      await portfolio.setOrders([
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 0,
-          date: new Date(),
-          id: '8d999347-dee2-46ee-88e1-26b344e71fcc',
-          quantity: 1,
-          symbol: 'BTCUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 49631.24,
-          updatedAt: null,
-          userId: USER_ID
-        }
-      ]);
-
-      expect(portfolio.getCommittedFunds()).toEqual(
-        exchangeRateDataService.toCurrency(
-          1 * 49631.24,
-          Currency.USD,
-          baseCurrency
-        )
-      );
-
-      const details = await portfolio.getDetails('1d');
-      expect(details).toMatchObject({
-        BTCUSD: {
-          accounts: {
-            [UNKNOWN_KEY]: {
-              /*current: exchangeRateDataService.toCurrency(
-                1 * 49631.24,
-                Currency.USD,
-                baseCurrency
-              ),*/
-              original: exchangeRateDataService.toCurrency(
-                1 * 49631.24,
-                Currency.USD,
-                baseCurrency
-              )
-            }
-          },
-          allocationCurrent: 1,
-          allocationInvestment: 1,
-          countries: [],
-          currency: Currency.USD,
-          exchange: UNKNOWN_KEY,
-          grossPerformance: 0,
-          grossPerformancePercent: 0,
-          investment: exchangeRateDataService.toCurrency(
-            1 * 49631.24,
-            Currency.USD,
-            baseCurrency
-          ),
-          marketPrice: 57973.008,
-          marketState: MarketState.open,
-          name: 'Bitcoin USD',
-          quantity: 1,
-          symbol: 'BTCUSD',
-          transactionCount: 1,
-          type: 'Cryptocurrency'
-        }
-      });
-
-      expect(portfolio.getFees()).toEqual(0);
-
-      /*const performance1d = await portfolio.getPerformance('1d');
-      expect(performance1d).toEqual({
-        currentGrossPerformance: 0,
-        currentGrossPerformancePercent: 0,
-        currentNetPerformance: 0,
-        currentNetPerformancePercent: 0,
-        currentValue: exchangeRateDataService.toBaseCurrency(
-          1 * 49631.24,
-          Currency.USD,
-          baseCurrency
-        )
-      });*/
-
-      /*const performanceMax = await portfolio.getPerformance('max');
-      expect(performanceMax).toEqual({
-        currentGrossPerformance: 0,
-        currentGrossPerformancePercent: 0,
-        currentNetPerformance: 0,
-        currentNetPerformancePercent: 0,
-        currentValue: exchangeRateDataService.toBaseCurrency(
-          1 * 49631.24,
-          Currency.USD,
-          baseCurrency
-        )
-      });*/
-
-      expect(portfolio.getPositions(getYesterday())).toMatchObject({});
-
-      expect(portfolio.getSymbols(getYesterday())).toEqual([]);
-
-      expect(portfolio.getSymbols(new Date())).toEqual(['BTCUSD']);
-    });
-  });
-
-  describe('works with orders', () => {
-    it('should return ["ETHUSD"]', async () => {
-      await portfolio.setOrders([
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 0,
-          date: new Date(getUtc('2018-01-05')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fb',
-          quantity: 0.2,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 991.49,
-          updatedAt: null,
-          userId: USER_ID
-        }
-      ]);
-
-      expect(portfolio.getCommittedFunds()).toEqual(
-        exchangeRateDataService.toCurrency(
-          0.2 * 991.49,
-          Currency.USD,
-          baseCurrency
-        )
-      );
-
-      /*const details = await portfolio.getDetails('1d');
-      expect(details).toMatchObject({
-        ETHUSD: {
-          accounts: {
-            [UNKNOWN_KEY]: {
-              current: exchangeRateDataService.toCurrency(
-                0.2 * 991.49,
-                Currency.USD,
-                baseCurrency
-              ),
-              original: exchangeRateDataService.toCurrency(
-                0.2 * 991.49,
-                Currency.USD,
-                baseCurrency
-              )
-            }
-          },
-          // allocationCurrent: 1,
-          allocationInvestment: 1,
-          countries: [],
-          currency: Currency.USD,
-          exchange: UNKNOWN_KEY,
-          // grossPerformance: 0,
-          // grossPerformancePercent: 0,
-          investment: exchangeRateDataService.toCurrency(
-            0.2 * 991.49,
-            Currency.USD,
-            baseCurrency
-          ),
-          marketPrice: 3915.337,
-          name: 'Ethereum USD',
-          quantity: 0.2,
-          transactionCount: 1,
-          symbol: 'ETHUSD',
-          type: 'Cryptocurrency'
-        }
-      });*/
-
-      expect(portfolio.getFees()).toEqual(0);
-
-      /*const performance = await portfolio.getPerformance('max');
-      expect(performance).toEqual({
-        currentGrossPerformance: 0,
-        currentGrossPerformancePercent: 0,
-        currentNetPerformance: 0,
-        currentNetPerformancePercent: 0,
-        currentValue: 0
-      });*/
-
-      expect(portfolio.getPositions(getYesterday())).toMatchObject({
-        ETHUSD: {
-          averagePrice: 991.49,
-          currency: Currency.USD,
-          firstBuyDate: '2018-01-05T00:00:00.000Z',
-          investment: exchangeRateDataService.toCurrency(
-            0.2 * 991.49,
-            Currency.USD,
-            baseCurrency
-          ),
-          investmentInOriginalCurrency: 0.2 * 991.49,
-          // marketPrice: 3915.337,
-          quantity: 0.2
-        }
-      });
-
-      expect(portfolio.getSymbols(getYesterday())).toEqual(['ETHUSD']);
-    });
-
-    it('should return ["ETHUSD"]', async () => {
-      await portfolio.setOrders([
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 0,
-          date: new Date(getUtc('2018-01-05')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fb',
-          quantity: 0.2,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 991.49,
-          updatedAt: null,
-          userId: USER_ID
-        },
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 0,
-          date: new Date(getUtc('2018-01-28')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fc',
-          quantity: 0.3,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 1050,
-          updatedAt: null,
-          userId: USER_ID
-        }
-      ]);
-
-      expect(portfolio.getCommittedFunds()).toEqual(
-        exchangeRateDataService.toCurrency(
-          0.2 * 991.49,
-          Currency.USD,
-          baseCurrency
-        ) +
-          exchangeRateDataService.toCurrency(
-            0.3 * 1050,
-            Currency.USD,
-            baseCurrency
-          )
-      );
-
-      expect(portfolio.getFees()).toEqual(0);
-
-      expect(portfolio.getPositions(getYesterday())).toMatchObject({
-        ETHUSD: {
-          averagePrice: (0.2 * 991.49 + 0.3 * 1050) / (0.2 + 0.3),
-          currency: Currency.USD,
-          firstBuyDate: '2018-01-05T00:00:00.000Z',
-          investment:
-            exchangeRateDataService.toCurrency(
-              0.2 * 991.49,
-              Currency.USD,
-              baseCurrency
-            ) +
-            exchangeRateDataService.toCurrency(
-              0.3 * 1050,
-              Currency.USD,
-              baseCurrency
-            ),
-          investmentInOriginalCurrency: 0.2 * 991.49 + 0.3 * 1050,
-          // marketPrice: 3641.984,
-          quantity: 0.5
-        }
-      });
-
-      expect(portfolio.getSymbols(getYesterday())).toEqual(['ETHUSD']);
-    });
-
-    it('should return ["BTCUSD", "ETHUSD"]', async () => {
-      await portfolio.setOrders([
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.EUR,
-          dataSource: DataSource.YAHOO,
-          date: new Date(getUtc('2017-08-16')),
-          fee: 2.99,
-          id: 'd96795b2-6ae6-420e-aa21-fabe5e45d475',
-          quantity: 0.05614682,
-          symbol: 'BTCUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 3562.089535970158,
-          updatedAt: null,
-          userId: USER_ID
-        },
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 2.99,
-          date: new Date(getUtc('2018-01-05')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fb',
-          quantity: 0.2,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 991.49,
-          updatedAt: null,
-          userId: USER_ID
-        }
-      ]);
-
-      expect(portfolio.getCommittedFunds()).toEqual(
-        exchangeRateDataService.toCurrency(
-          0.05614682 * 3562.089535970158,
-          Currency.EUR,
-          baseCurrency
-        ) +
-          exchangeRateDataService.toCurrency(
-            0.2 * 991.49,
-            Currency.USD,
-            baseCurrency
-          )
-      );
-
-      expect(portfolio.getFees()).toEqual(
-        exchangeRateDataService.toCurrency(2.99, Currency.EUR, baseCurrency) +
-          exchangeRateDataService.toCurrency(2.99, Currency.USD, baseCurrency)
-      );
-
-      expect(portfolio.getPositions(getYesterday())).toMatchObject({
-        BTCUSD: {
-          averagePrice: 3562.089535970158,
-          currency: Currency.EUR,
-          firstBuyDate: '2017-08-16T00:00:00.000Z',
-          investment: exchangeRateDataService.toCurrency(
-            0.05614682 * 3562.089535970158,
-            Currency.EUR,
-            baseCurrency
-          ),
-          investmentInOriginalCurrency: 0.05614682 * 3562.089535970158,
-          // marketPrice: 0,
-          quantity: 0.05614682
-        },
-        ETHUSD: {
-          averagePrice: 991.49,
-          currency: Currency.USD,
-          firstBuyDate: '2018-01-05T00:00:00.000Z',
-          investment: exchangeRateDataService.toCurrency(
-            0.2 * 991.49,
-            Currency.USD,
-            baseCurrency
-          ),
-          investmentInOriginalCurrency: 0.2 * 991.49,
-          // marketPrice: 0,
-          quantity: 0.2
-        }
-      });
-
-      expect(portfolio.getSymbols(getYesterday())).toEqual([
-        'BTCUSD',
-        'ETHUSD'
-      ]);
-    });
-
-    it('should work with buy and sell', async () => {
-      await portfolio.setOrders([
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 1.0,
-          date: new Date(getUtc('2018-01-05')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fb',
-          quantity: 0.2,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 991.49,
-          updatedAt: null,
-          userId: USER_ID
-        },
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 1.0,
-          date: new Date(getUtc('2018-01-28')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fc',
-          quantity: 0.1,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.SELL,
-          unitPrice: 1050,
-          updatedAt: null,
-          userId: USER_ID
-        },
-        {
-          accountId: DEFAULT_ACCOUNT_ID,
-          accountUserId: USER_ID,
-          createdAt: null,
-          currency: Currency.USD,
-          dataSource: DataSource.YAHOO,
-          fee: 1.0,
-          date: new Date(getUtc('2018-01-31')),
-          id: '4a5a5c6e-659d-45cc-9fd4-fd6c873b50fc',
-          quantity: 0.2,
-          symbol: 'ETHUSD',
-          symbolProfileId: null,
-          type: Type.BUY,
-          unitPrice: 1050,
-          updatedAt: null,
-          userId: USER_ID
-        }
-      ]);
-
-      expect(portfolio.getCommittedFunds()).toEqual(
-        exchangeRateDataService.toCurrency(
-          0.2 * 991.49,
-          Currency.USD,
-          baseCurrency
-        ) -
-          exchangeRateDataService.toCurrency(
-            0.1 * 1050,
-            Currency.USD,
-            baseCurrency
-          ) +
-          exchangeRateDataService.toCurrency(
-            0.2 * 1050,
-            Currency.USD,
-            baseCurrency
-          )
-      );
-
-      expect(portfolio.getFees()).toEqual(
-        exchangeRateDataService.toCurrency(3, Currency.USD, baseCurrency)
-      );
-
-      expect(portfolio.getPositions(getYesterday())).toMatchObject({
-        ETHUSD: {
-          averagePrice:
-            (0.2 * 991.49 - 0.1 * 1050 + 0.2 * 1050) / (0.2 - 0.1 + 0.2),
-          currency: Currency.USD,
-          firstBuyDate: '2018-01-05T00:00:00.000Z',
-          investment: exchangeRateDataService.toCurrency(
-            0.2 * 991.49 - 0.1 * 1050 + 0.2 * 1050,
-            Currency.USD,
-            baseCurrency
-          ),
-          investmentInOriginalCurrency: 0.2 * 991.49 - 0.1 * 1050 + 0.2 * 1050,
-          // marketPrice: 0,
-          quantity: 0.2 - 0.1 + 0.2
-        }
-      });
-
-      expect(portfolio.getSymbols(getYesterday())).toEqual(['ETHUSD']);
-    });
-  });
-});

apps/api/src/models/portfolio.ts

@@ -1,961 +0,0 @@
-import { AccountService } from '@ghostfolio/api/app/account/account.service';
-import { CashDetails } from '@ghostfolio/api/app/account/interfaces/cash-details.interface';
-import { UNKNOWN_KEY, ghostfolioCashSymbol } from '@ghostfolio/common/config';
-import { getToday, getYesterday, resetHours } from '@ghostfolio/common/helper';
-import {
-  PortfolioItem,
-  PortfolioPerformance,
-  PortfolioPosition,
-  PortfolioReport,
-  Position,
-  UserWithSettings
-} from '@ghostfolio/common/interfaces';
-import { Country } from '@ghostfolio/common/interfaces/country.interface';
-import { Sector } from '@ghostfolio/common/interfaces/sector.interface';
-import { DateRange, OrderWithAccount } from '@ghostfolio/common/types';
-import { Currency, Prisma } from '@prisma/client';
-import { continents, countries } from 'countries-list';
-import {
-  add,
-  format,
-  getDate,
-  getMonth,
-  getYear,
-  isAfter,
-  isBefore,
-  isSameDay,
-  isToday,
-  isYesterday,
-  parseISO,
-  setDate,
-  setMonth,
-  sub
-} from 'date-fns';
-import { cloneDeep, isEmpty } from 'lodash';
-import * as roundTo from 'round-to';
-
-import { DataProviderService } from '../services/data-provider.service';
-import { ExchangeRateDataService } from '../services/exchange-rate-data.service';
-import { IOrder, MarketState, Type } from '../services/interfaces/interfaces';
-import { RulesService } from '../services/rules.service';
-import { PortfolioInterface } from './interfaces/portfolio.interface';
-import { Order } from './order';
-import { OrderType } from './order-type';
-import { AccountClusterRiskCurrentInvestment } from './rules/account-cluster-risk/current-investment';
-import { AccountClusterRiskInitialInvestment } from './rules/account-cluster-risk/initial-investment';
-import { AccountClusterRiskSingleAccount } from './rules/account-cluster-risk/single-account';
-import { CurrencyClusterRiskBaseCurrencyCurrentInvestment } from './rules/currency-cluster-risk/base-currency-current-investment';
-import { CurrencyClusterRiskBaseCurrencyInitialInvestment } from './rules/currency-cluster-risk/base-currency-initial-investment';
-import { CurrencyClusterRiskCurrentInvestment } from './rules/currency-cluster-risk/current-investment';
-import { CurrencyClusterRiskInitialInvestment } from './rules/currency-cluster-risk/initial-investment';
-import { FeeRatioInitialInvestment } from './rules/fees/fee-ratio-initial-investment';
-
-export class Portfolio implements PortfolioInterface {
-  private orders: Order[] = [];
-  private portfolioItems: PortfolioItem[] = [];
-  private user: UserWithSettings;
-
-  public constructor(
-    private accountService: AccountService,
-    private dataProviderService: DataProviderService,
-    private exchangeRateDataService: ExchangeRateDataService,
-    private rulesService: RulesService
-  ) {}
-
-  public async addCurrentPortfolioItems() {
-    const currentData = await this.dataProviderService.get(this.getSymbols());
-
-    const currentDate = new Date();
-
-    const year = getYear(currentDate);
-    const month = getMonth(currentDate);
-    const day = getDate(currentDate);
-
-    const today = new Date(Date.UTC(year, month, day));
-    const yesterday = getYesterday();
-
-    const [portfolioItemsYesterday] = this.get(yesterday);
-
-    const positions: { [symbol: string]: Position } = {};
-
-    this.getSymbols().forEach((symbol) => {
-      positions[symbol] = {
-        averagePrice: portfolioItemsYesterday?.positions[symbol]?.averagePrice,
-        currency: portfolioItemsYesterday?.positions[symbol]?.currency,
-        firstBuyDate: portfolioItemsYesterday?.positions[symbol]?.firstBuyDate,
-        investment: portfolioItemsYesterday?.positions[symbol]?.investment,
-        investmentInOriginalCurrency:
-          portfolioItemsYesterday?.positions[symbol]
-            ?.investmentInOriginalCurrency,
-        marketPrice:
-          currentData[symbol]?.marketPrice ??
-          portfolioItemsYesterday.positions[symbol]?.marketPrice,
-        quantity: portfolioItemsYesterday?.positions[symbol]?.quantity,
-        transactionCount:
-          portfolioItemsYesterday?.positions[symbol]?.transactionCount
-      };
-    });
-
-    if (portfolioItemsYesterday?.investment) {
-      const portfolioItemsLength = this.portfolioItems.push(
-        cloneDeep({
-          date: today.toISOString(),
-          grossPerformancePercent: 0,
-          investment: portfolioItemsYesterday?.investment,
-          positions: positions,
-          value: 0
-        })
-      );
-
-      // Set value after pushing today's portfolio items
-      this.portfolioItems[portfolioItemsLength - 1].value =
-        this.getValue(today);
-    }
-
-    return this;
-  }
-
-  public async addFuturePortfolioItems() {
-    let investment = this.getInvestment(new Date());
-
-    this.getOrders()
-      .filter((order) => order.getIsDraft() === true)
-      .forEach((order) => {
-        investment += this.exchangeRateDataService.toCurrency(
-          order.getTotal(),
-          order.getCurrency(),
-          this.user.Settings.currency
-        );
-
-        const portfolioItem = this.portfolioItems.find((item) => {
-          return item.date === order.getDate();
-        });
-
-        if (portfolioItem) {
-          portfolioItem.investment = investment;
-        } else {
-          this.portfolioItems.push({
-            investment,
-            date: order.getDate(),
-            grossPerformancePercent: 0,
-            positions: {},
-            value: 0
-          });
-        }
-      });
-
-    return this;
-  }
-
-  public createFromData({
-    orders,
-    portfolioItems,
-    user
-  }: {
-    orders: IOrder[];
-    portfolioItems: PortfolioItem[];
-    user: UserWithSettings;
-  }): Portfolio {
-    orders.forEach(
-      ({
-        account,
-        currency,
-        fee,
-        date,
-        id,
-        quantity,
-        symbol,
-        symbolProfile,
-        type,
-        unitPrice
-      }) => {
-        this.orders.push(
-          new Order({
-            account,
-            currency,
-            fee,
-            date,
-            id,
-            quantity,
-            symbol,
-            symbolProfile,
-            type,
-            unitPrice
-          })
-        );
-      }
-    );
-
-    portfolioItems.forEach(
-      ({ date, grossPerformancePercent, investment, positions, value }) => {
-        this.portfolioItems.push({
-          date,
-          grossPerformancePercent,
-          investment,
-          positions,
-          value
-        });
-      }
-    );
-
-    this.setUser(user);
-
-    return this;
-  }
-
-  public get(aDate?: Date): PortfolioItem[] {
-    if (aDate) {
-      const filteredPortfolio = this.portfolioItems.find((item) => {
-        return isSameDay(aDate, new Date(item.date));
-      });
-
-      if (filteredPortfolio) {
-        return [cloneDeep(filteredPortfolio)];
-      }
-
-      return [];
-    }
-
-    return cloneDeep(this.portfolioItems);
-  }
-
-  public getCommittedFunds() {
-    return this.getTotalBuy() - this.getTotalSell();
-  }
-
-  public async getDetails(
-    aDateRange: DateRange = 'max'
-  ): Promise<{ [symbol: string]: PortfolioPosition }> {
-    const dateRangeDate = this.convertDateRangeToDate(
-      aDateRange,
-      this.getMinDate()
-    );
-
-    const [portfolioItemsBefore] = this.get(dateRangeDate);
-
-    const [portfolioItemsNow] = await this.get(new Date());
-
-    const cashDetails = await this.accountService.getCashDetails(
-      this.user.id,
-      this.user.Settings.currency
-    );
-    const investment = this.getInvestment(new Date()) + cashDetails.balance;
-    const portfolioItems = this.get(new Date());
-    const symbols = this.getSymbols(new Date());
-    const value = this.getValue() + cashDetails.balance;
-
-    const details: { [symbol: string]: PortfolioPosition } = {};
-
-    const data = await this.dataProviderService.get(symbols);
-
-    symbols.forEach((symbol) => {
-      const accounts: PortfolioPosition['accounts'] = {};
-      let countriesOfSymbol: Country[];
-      let sectorsOfSymbol: Sector[];
-      const [portfolioItem] = portfolioItems;
-
-      const ordersBySymbol = this.getOrders().filter((order) => {
-        return order.getSymbol() === symbol;
-      });
-
-      ordersBySymbol.forEach((orderOfSymbol) => {
-        let currentValueOfSymbol = this.exchangeRateDataService.toCurrency(
-          orderOfSymbol.getQuantity() *
-            portfolioItemsNow.positions[symbol].marketPrice,
-          orderOfSymbol.getCurrency(),
-          this.user.Settings.currency
-        );
-        let originalValueOfSymbol = this.exchangeRateDataService.toCurrency(
-          orderOfSymbol.getQuantity() * orderOfSymbol.getUnitPrice(),
-          orderOfSymbol.getCurrency(),
-          this.user.Settings.currency
-        );
-
-        if (orderOfSymbol.getType() === 'SELL') {
-          currentValueOfSymbol *= -1;
-          originalValueOfSymbol *= -1;
-        }
-
-        if (
-          accounts[orderOfSymbol.getAccount()?.name || UNKNOWN_KEY]?.current
-        ) {
-          accounts[orderOfSymbol.getAccount()?.name || UNKNOWN_KEY].current +=
-            currentValueOfSymbol;
-          accounts[orderOfSymbol.getAccount()?.name || UNKNOWN_KEY].original +=
-            originalValueOfSymbol;
-        } else {
-          accounts[orderOfSymbol.getAccount()?.name || UNKNOWN_KEY] = {
-            current: currentValueOfSymbol,
-            original: originalValueOfSymbol
-          };
-        }
-
-        countriesOfSymbol = (
-          (orderOfSymbol.getSymbolProfile()?.countries as Prisma.JsonArray) ??
-          []
-        ).map((country) => {
-          const { code, weight } = country as Prisma.JsonObject;
-
-          return {
-            code: code as string,
-            continent:
-              continents[countries[code as string]?.continent] ?? UNKNOWN_KEY,
-            name: countries[code as string]?.name ?? UNKNOWN_KEY,
-            weight: weight as number
-          };
-        });
-
-        sectorsOfSymbol = (
-          (orderOfSymbol.getSymbolProfile()?.sectors as Prisma.JsonArray) ?? []
-        ).map((sector) => {
-          const { name, weight } = sector as Prisma.JsonObject;
-
-          return {
-            name: (name as string) ?? UNKNOWN_KEY,
-            weight: weight as number
-          };
-        });
-      });
-
-      let now = portfolioItemsNow.positions[symbol].marketPrice;
-
-      // 1d
-      let before = portfolioItemsBefore?.positions[symbol].marketPrice;
-
-      if (aDateRange === 'ytd') {
-        before =
-          portfolioItemsBefore.positions[symbol].marketPrice ||
-          portfolioItemsNow.positions[symbol].averagePrice;
-      } else if (
-        aDateRange === '1y' ||
-        aDateRange === '5y' ||
-        aDateRange === 'max'
-      ) {
-        before = portfolioItemsNow.positions[symbol].averagePrice;
-      }
-
-      if (
-        !isBefore(
-          parseISO(portfolioItemsNow.positions[symbol].firstBuyDate),
-          parseISO(portfolioItemsBefore?.date)
-        )
-      ) {
-        // Trade was not before the date of portfolioItemsBefore, then override it with average price
-        // (e.g. on same day)
-        before = portfolioItemsNow.positions[symbol].averagePrice;
-      }
-
-      if (isToday(parseISO(portfolioItemsNow.positions[symbol].firstBuyDate))) {
-        now = portfolioItemsNow.positions[symbol].averagePrice;
-      }
-
-      details[symbol] = {
-        ...data[symbol],
-        accounts,
-        symbol,
-        allocationCurrent:
-          this.exchangeRateDataService.toCurrency(
-            portfolioItem.positions[symbol].quantity * now,
-            data[symbol]?.currency,
-            this.user.Settings.currency
-          ) / value,
-        allocationInvestment:
-          portfolioItem.positions[symbol].investment / investment,
-        countries: countriesOfSymbol,
-        grossPerformance: roundTo(
-          portfolioItemsNow.positions[symbol].quantity * (now - before),
-          2
-        ),
-        grossPerformancePercent: roundTo((now - before) / before, 4),
-        investment: portfolioItem.positions[symbol].investment,
-        quantity: portfolioItem.positions[symbol].quantity,
-        sectors: sectorsOfSymbol,
-        transactionCount: portfolioItem.positions[symbol].transactionCount,
-        value: this.exchangeRateDataService.toCurrency(
-          portfolioItem.positions[symbol].quantity * now,
-          data[symbol]?.currency,
-          this.user.Settings.currency
-        )
-      };
-    });
-
-    details[ghostfolioCashSymbol] = await this.getCashPosition({
-      cashDetails,
-      investment,
-      value
-    });
-
-    return details;
-  }
-
-  public getFees(aDate = new Date(0)) {
-    return this.orders
-      .filter((order) => {
-        // Filter out all orders before given date
-        return isBefore(aDate, new Date(order.getDate()));
-      })
-      .map((order) => {
-        return this.exchangeRateDataService.toCurrency(
-          order.getFee(),
-          order.getCurrency(),
-          this.user.Settings.currency
-        );
-      })
-      .reduce((previous, current) => previous + current, 0);
-  }
-
-  public getInvestment(aDate: Date): number {
-    return this.get(aDate)[0]?.investment || 0;
-  }
-
-  public getMinDate() {
-    const orders = this.getOrders().filter(
-      (order) => order.getIsDraft() === false
-    );
-
-    if (orders.length > 0) {
-      return new Date(this.orders[0].getDate());
-    }
-
-    return null;
-  }
-
-  public async getPerformance(
-    aDateRange: DateRange = 'max'
-  ): Promise<PortfolioPerformance> {
-    const dateRangeDate = this.convertDateRangeToDate(
-      aDateRange,
-      this.getMinDate()
-    );
-
-    const currentInvestment = this.getInvestment(new Date());
-    const currentValue = await this.getValue();
-
-    let originalInvestment = currentInvestment;
-    let originalValue = this.getCommittedFunds();
-
-    if (dateRangeDate) {
-      originalInvestment = this.getInvestment(dateRangeDate);
-      originalValue = (await this.getValue(dateRangeDate)) || originalValue;
-    }
-
-    const fees = this.getFees(dateRangeDate);
-
-    const currentGrossPerformance =
-      currentValue - currentInvestment - (originalValue - originalInvestment);
-
-    // https://www.skillsyouneed.com/num/percent-change.html
-    const currentGrossPerformancePercent =
-      currentGrossPerformance / originalInvestment || 0;
-
-    const currentNetPerformance = currentGrossPerformance - fees;
-
-    // https://www.skillsyouneed.com/num/percent-change.html
-    const currentNetPerformancePercent =
-      currentNetPerformance / originalInvestment || 0;
-
-    return {
-      currentGrossPerformance,
-      currentGrossPerformancePercent,
-      currentNetPerformance,
-      currentNetPerformancePercent,
-      currentValue
-    };
-  }
-
-  public getPositions(aDate: Date) {
-    const [portfolioItem] = this.get(aDate);
-
-    if (portfolioItem) {
-      return portfolioItem.positions;
-    }
-
-    return {};
-  }
-
-  public getPortfolioItems() {
-    return this.portfolioItems;
-  }
-
-  public async getReport(): Promise<PortfolioReport> {
-    const details = await this.getDetails();
-
-    if (isEmpty(details)) {
-      return {
-        rules: {}
-      };
-    }
-
-    return {
-      rules: {
-        accountClusterRisk: await this.rulesService.evaluate(
-          this,
-          [
-            new AccountClusterRiskInitialInvestment(
-              this.exchangeRateDataService
-            ),
-            new AccountClusterRiskCurrentInvestment(
-              this.exchangeRateDataService
-            ),
-            new AccountClusterRiskSingleAccount(this.exchangeRateDataService)
-          ],
-          { baseCurrency: this.user.Settings.currency }
-        ),
-        currencyClusterRisk: await this.rulesService.evaluate(
-          this,
-          [
-            new CurrencyClusterRiskBaseCurrencyInitialInvestment(
-              this.exchangeRateDataService
-            ),
-            new CurrencyClusterRiskBaseCurrencyCurrentInvestment(
-              this.exchangeRateDataService
-            ),
-            new CurrencyClusterRiskInitialInvestment(
-              this.exchangeRateDataService
-            ),
-            new CurrencyClusterRiskCurrentInvestment(
-              this.exchangeRateDataService
-            )
-          ],
-          { baseCurrency: this.user.Settings.currency }
-        ),
-        fees: await this.rulesService.evaluate(
-          this,
-          [new FeeRatioInitialInvestment(this.exchangeRateDataService)],
-          { baseCurrency: this.user.Settings.currency }
-        )
-      }
-    };
-  }
-
-  public getSymbols(aDate?: Date) {
-    let symbols: string[] = [];
-
-    if (aDate) {
-      const positions = this.getPositions(aDate);
-
-      for (const symbol in positions) {
-        if (positions[symbol].quantity > 0) {
-          symbols.push(symbol);
-        }
-      }
-    } else {
-      symbols = this.orders
-        .filter((order) => order.getIsDraft() === false)
-        .map((order) => {
-          return order.getSymbol();
-        });
-    }
-
-    // unique values
-    return Array.from(new Set(symbols));
-  }
-
-  public getTotalBuy() {
-    return this.orders
-      .filter(
-        (order) => order.getIsDraft() === false && order.getType() === 'BUY'
-      )
-      .map((order) => {
-        return this.exchangeRateDataService.toCurrency(
-          order.getTotal(),
-          order.getCurrency(),
-          this.user.Settings.currency
-        );
-      })
-      .reduce((previous, current) => previous + current, 0);
-  }
-
-  public getTotalSell() {
-    return this.orders
-      .filter(
-        (order) => order.getIsDraft() === false && order.getType() === 'SELL'
-      )
-      .map((order) => {
-        return this.exchangeRateDataService.toCurrency(
-          order.getTotal(),
-          order.getCurrency(),
-          this.user.Settings.currency
-        );
-      })
-      .reduce((previous, current) => previous + current, 0);
-  }
-
-  public getOrders(aSymbol?: string) {
-    if (aSymbol) {
-      return this.orders.filter((order) => {
-        return order.getSymbol() === aSymbol;
-      });
-    }
-
-    return this.orders;
-  }
-
-  public getValue(aDate = getToday()) {
-    const positions = this.getPositions(aDate);
-    let value = 0;
-
-    const [portfolioItem] = this.get(aDate);
-
-    for (const symbol in positions) {
-      if (portfolioItem.positions[symbol]?.quantity > 0) {
-        if (
-          isBefore(
-            aDate,
-            parseISO(portfolioItem.positions[symbol]?.firstBuyDate)
-          ) ||
-          portfolioItem.positions[symbol]?.marketPrice === 0
-        ) {
-          value += this.exchangeRateDataService.toCurrency(
-            portfolioItem.positions[symbol]?.quantity *
-              portfolioItem.positions[symbol]?.averagePrice,
-            portfolioItem.positions[symbol]?.currency,
-            this.user.Settings.currency
-          );
-        } else {
-          value += this.exchangeRateDataService.toCurrency(
-            portfolioItem.positions[symbol]?.quantity *
-              portfolioItem.positions[symbol]?.marketPrice,
-            portfolioItem.positions[symbol]?.currency,
-            this.user.Settings.currency
-          );
-        }
-      }
-    }
-
-    return isFinite(value) ? value : null;
-  }
-
-  public async setOrders(aOrders: OrderWithAccount[]) {
-    this.orders = [];
-
-    // Map data
-    aOrders.forEach((order) => {
-      this.orders.push(
-        new Order({
-          account: order.Account,
-          currency: order.currency,
-          date: order.date.toISOString(),
-          fee: order.fee,
-          quantity: order.quantity,
-          symbol: order.symbol,
-          symbolProfile: order.SymbolProfile,
-          type: <OrderType>order.type,
-          unitPrice: order.unitPrice
-        })
-      );
-    });
-
-    await this.update();
-
-    return this;
-  }
-
-  public setUser(aUser: UserWithSettings) {
-    this.user = aUser;
-
-    return this;
-  }
-
-  private async getCashPosition({
-    cashDetails,
-    investment,
-    value
-  }: {
-    cashDetails: CashDetails;
-    investment: number;
-    value: number;
-  }) {
-    const accounts = {};
-    const cashValue = cashDetails.balance;
-
-    cashDetails.accounts.forEach((account) => {
-      accounts[account.name] = {
-        current: account.balance,
-        original: account.balance
-      };
-    });
-
-    return {
-      accounts,
-      allocationCurrent: cashValue / value,
-      allocationInvestment: cashValue / investment,
-      countries: [],
-      currency: Currency.CHF,
-      grossPerformance: 0,
-      grossPerformancePercent: 0,
-      investment: cashValue,
-      marketPrice: 0,
-      marketState: MarketState.open,
-      name: Type.Cash,
-      quantity: 0,
-      sectors: [],
-      symbol: ghostfolioCashSymbol,
-      type: Type.Cash,
-      transactionCount: 0,
-      value: cashValue
-    };
-  }
-
-  /**
-   * TODO: Refactor
-   */
-  private async update() {
-    this.portfolioItems = [];
-
-    let currentDate = this.getMinDate();
-
-    if (!currentDate) {
-      return;
-    }
-
-    // Set current date to first of month
-    currentDate = setDate(currentDate, 1);
-
-    const historicalData = await this.dataProviderService.getHistorical(
-      this.getSymbols(),
-      'month',
-      currentDate,
-      new Date()
-    );
-
-    while (isBefore(currentDate, Date.now())) {
-      const positions: { [symbol: string]: Position } = {};
-      this.getSymbols().forEach((symbol) => {
-        positions[symbol] = {
-          averagePrice: 0,
-          currency: undefined,
-          firstBuyDate: null,
-          investment: 0,
-          investmentInOriginalCurrency: 0,
-          marketPrice:
-            historicalData[symbol]?.[format(currentDate, 'yyyy-MM-dd')]
-              ?.marketPrice || 0,
-          quantity: 0,
-          transactionCount: 0
-        };
-      });
-
-      if (!isYesterday(currentDate) && !isToday(currentDate)) {
-        // Add to portfolio (ignore yesterday and today because they are added later)
-        this.portfolioItems.push(
-          cloneDeep({
-            date: currentDate.toISOString(),
-            grossPerformancePercent: 0,
-            investment: 0,
-            positions: positions,
-            value: 0
-          })
-        );
-      }
-
-      const year = getYear(currentDate);
-      const month = getMonth(currentDate);
-      const day = getDate(currentDate);
-
-      // Count month one up for iteration
-      currentDate = new Date(Date.UTC(year, month + 1, day, 0));
-    }
-
-    const yesterday = getYesterday();
-
-    let positions: { [symbol: string]: Position } = {};
-
-    if (isAfter(yesterday, this.getMinDate())) {
-      // Add yesterday
-      this.getSymbols().forEach((symbol) => {
-        positions[symbol] = {
-          averagePrice: 0,
-          currency: undefined,
-          firstBuyDate: null,
-          investment: 0,
-          investmentInOriginalCurrency: 0,
-          marketPrice:
-            historicalData[symbol]?.[format(yesterday, 'yyyy-MM-dd')]
-              ?.marketPrice || 0,
-          quantity: 0,
-          transactionCount: 0
-        };
-      });
-
-      this.portfolioItems.push(
-        cloneDeep({
-          positions,
-          date: yesterday.toISOString(),
-          grossPerformancePercent: 0,
-          investment: 0,
-          value: 0
-        })
-      );
-    }
-
-    this.updatePortfolioItems();
-  }
-
-  private convertDateRangeToDate(aDateRange: DateRange, aMinDate: Date) {
-    let currentDate = new Date();
-
-    const normalizedMinDate =
-      getDate(aMinDate) === 1
-        ? aMinDate
-        : add(setDate(aMinDate, 1), { months: 1 });
-
-    const year = getYear(currentDate);
-    const month = getMonth(currentDate);
-    const day = getDate(currentDate);
-
-    currentDate = new Date(Date.UTC(year, month, day, 0));
-
-    switch (aDateRange) {
-      case '1d':
-        return sub(currentDate, {
-          days: 1
-        });
-      case 'ytd':
-        currentDate = setDate(currentDate, 1);
-        currentDate = setMonth(currentDate, 0);
-        return isAfter(currentDate, normalizedMinDate)
-          ? currentDate
-          : undefined;
-      case '1y':
-        currentDate = setDate(currentDate, 1);
-        currentDate = sub(currentDate, {
-          years: 1
-        });
-        return isAfter(currentDate, normalizedMinDate)
-          ? currentDate
-          : undefined;
-      case '5y':
-        currentDate = setDate(currentDate, 1);
-        currentDate = sub(currentDate, {
-          years: 5
-        });
-        return isAfter(currentDate, normalizedMinDate)
-          ? currentDate
-          : undefined;
-      default:
-        // Gets handled as all data
-        return undefined;
-    }
-  }
-
-  private updatePortfolioItems() {
-    let currentDate = new Date();
-
-    const year = getYear(currentDate);
-    const month = getMonth(currentDate);
-    const day = getDate(currentDate);
-
-    currentDate = new Date(Date.UTC(year, month, day, 0));
-
-    if (this.portfolioItems?.length === 1) {
-      // At least one portfolio items is needed, keep it but change the date to today.
-      // This happens if there are only orders from today
-      this.portfolioItems[0].date = currentDate.toISOString();
-    } else {
-      // Only keep entries which are not before first buy date
-      this.portfolioItems = this.portfolioItems.filter((portfolioItem) => {
-        return (
-          isSameDay(parseISO(portfolioItem.date), this.getMinDate()) ||
-          isAfter(parseISO(portfolioItem.date), this.getMinDate())
-        );
-      });
-    }
-
-    this.orders.forEach((order) => {
-      if (order.getIsDraft() === false) {
-        let index = this.portfolioItems.findIndex((item) => {
-          const dateOfOrder = setDate(parseISO(order.getDate()), 1);
-          return isSameDay(parseISO(item.date), dateOfOrder);
-        });
-
-        if (index === -1) {
-          // if not found, we only have one order, which means we do not loop below
-          index = 0;
-        }
-
-        for (let i = index; i < this.portfolioItems.length; i++) {
-          // Set currency
-          this.portfolioItems[i].positions[order.getSymbol()].currency =
-            order.getCurrency();
-
-          this.portfolioItems[i].positions[
-            order.getSymbol()
-          ].transactionCount += 1;
-
-          if (order.getType() === 'BUY') {
-            if (
-              !this.portfolioItems[i].positions[order.getSymbol()].firstBuyDate
-            ) {
-              this.portfolioItems[i].positions[order.getSymbol()].firstBuyDate =
-                resetHours(parseISO(order.getDate())).toISOString();
-            }
-
-            this.portfolioItems[i].positions[order.getSymbol()].quantity +=
-              order.getQuantity();
-            this.portfolioItems[i].positions[order.getSymbol()].investment +=
-              this.exchangeRateDataService.toCurrency(
-                order.getTotal(),
-                order.getCurrency(),
-                this.user.Settings.currency
-              );
-            this.portfolioItems[i].positions[
-              order.getSymbol()
-            ].investmentInOriginalCurrency += order.getTotal();
-
-            this.portfolioItems[i].investment +=
-              this.exchangeRateDataService.toCurrency(
-                order.getTotal(),
-                order.getCurrency(),
-                this.user.Settings.currency
-              );
-          } else if (order.getType() === 'SELL') {
-            this.portfolioItems[i].positions[order.getSymbol()].quantity -=
-              order.getQuantity();
-
-            if (
-              this.portfolioItems[i].positions[order.getSymbol()].quantity === 0
-            ) {
-              this.portfolioItems[i].positions[
-                order.getSymbol()
-              ].investment = 0;
-              this.portfolioItems[i].positions[
-                order.getSymbol()
-              ].investmentInOriginalCurrency = 0;
-            } else {
-              this.portfolioItems[i].positions[order.getSymbol()].investment -=
-                this.exchangeRateDataService.toCurrency(
-                  order.getTotal(),
-                  order.getCurrency(),
-                  this.user.Settings.currency
-                );
-              this.portfolioItems[i].positions[
-                order.getSymbol()
-              ].investmentInOriginalCurrency -= order.getTotal();
-            }
-
-            this.portfolioItems[i].investment -=
-              this.exchangeRateDataService.toCurrency(
-                order.getTotal(),
-                order.getCurrency(),
-                this.user.Settings.currency
-              );
-          }
-
-          this.portfolioItems[i].positions[order.getSymbol()].averagePrice =
-            this.portfolioItems[i].positions[order.getSymbol()]
-              .investmentInOriginalCurrency /
-            this.portfolioItems[i].positions[order.getSymbol()].quantity;
-
-          const currentValue = this.getValue(
-            parseISO(this.portfolioItems[i].date)
-          );
-
-          this.portfolioItems[i].grossPerformancePercent =
-            currentValue / this.portfolioItems[i].investment - 1 || 0;
-          this.portfolioItems[i].value = currentValue;
-        }
-      }
-    });
-  }
-}

apps/api/src/models/rule.ts

@@ -1,16 +1,18 @@
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { groupBy } from '@ghostfolio/common/helper';
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
 import { Currency } from '@prisma/client';
 
-import { ExchangeRateDataService } from '../services/exchange-rate-data.service';
 import { EvaluationResult } from './interfaces/evaluation-result.interface';
 import { RuleInterface } from './interfaces/rule.interface';
 
-export abstract class Rule implements RuleInterface {
+export abstract class Rule<T extends RuleSettings> implements RuleInterface<T> {
   private name: string;
 
   public constructor(
-    public exchangeRateDataService: ExchangeRateDataService,
+    protected exchangeRateDataService: ExchangeRateDataService,
     {
       name
     }: {
@@ -20,44 +22,38 @@ export abstract class Rule implements RuleInterface {
     this.name = name;
   }
 
-  public abstract evaluate(
-    aPortfolioPositionMap: {
-      [symbol: string]: PortfolioPosition;
-    },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ): EvaluationResult;
-
   public getName() {
     return this.name;
   }
 
-  public groupPositionsByAttribute(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aAttribute: keyof PortfolioPosition,
-    aBaseCurrency: Currency
+  public groupCurrentPositionsByAttribute(
+    positions: TimelinePosition[],
+    attribute: keyof TimelinePosition,
+    baseCurrency: Currency
   ) {
-    return Array.from(
-      groupBy(aAttribute, Object.values(aPositions)).entries()
-    ).map(([attributeValue, objs]) => ({
-      groupKey: attributeValue,
-      investment: objs.reduce(
-        (previousValue, currentValue) =>
-          previousValue + currentValue.investment,
-        0
-      ),
-      value: objs.reduce(
-        (previousValue, currentValue) =>
-          previousValue +
-          this.exchangeRateDataService.toCurrency(
-            currentValue.quantity * currentValue.marketPrice,
-            currentValue.currency,
-            aBaseCurrency
-          ),
-        0
-      )
-    }));
+    return Array.from(groupBy(attribute, positions).entries()).map(
+      ([attributeValue, objs]) => ({
+        groupKey: attributeValue,
+        investment: objs.reduce(
+          (previousValue, currentValue) =>
+            previousValue + currentValue.investment.toNumber(),
+          0
+        ),
+        value: objs.reduce(
+          (previousValue, currentValue) =>
+            previousValue +
+            this.exchangeRateDataService.toCurrency(
+              currentValue.quantity.mul(currentValue.marketPrice).toNumber(),
+              currentValue.currency,
+              baseCurrency
+            ),
+          0
+        )
+      })
+    );
   }
+
+  public abstract evaluate(aRuleSettings: T): EvaluationResult;
+
+  public abstract getSettings(aUserSettings: UserSettings): T;
 }

apps/api/src/models/rules/account-cluster-risk/current-investment.ts

@@ -1,43 +1,36 @@
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import {
+  PortfolioDetails,
+  PortfolioPosition
+} from '@ghostfolio/common/interfaces';
 
 import { Rule } from '../../rule';
 
-export class AccountClusterRiskCurrentInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class AccountClusterRiskCurrentInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private accounts: PortfolioDetails['accounts']
+  ) {
     super(exchangeRateDataService, {
       name: 'Current Investment'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[AccountClusterRiskCurrentInvestment.name];
-
+  public evaluate(ruleSettings: Settings) {
     const accounts: {
       [symbol: string]: Pick<PortfolioPosition, 'name'> & {
         investment: number;
       };
     } = {};
 
-    Object.values(aPositions).forEach((position) => {
-      for (const [account, { current }] of Object.entries(position.accounts)) {
-        if (accounts[account]?.investment) {
-          accounts[account].investment += current;
-        } else {
-          accounts[account] = {
-            investment: current,
-            name: account
-          };
-        }
-      }
-    });
+    for (const account of Object.keys(this.accounts)) {
+      accounts[account] = {
+        name: account,
+        investment: this.accounts[account].current
+      };
+    }
 
     let maxItem;
     let totalInvestment = 0;
@@ -78,4 +71,17 @@ export class AccountClusterRiskCurrentInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true,
+      threshold: 0.5
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: string;
+  threshold: number;
 }

apps/api/src/models/rules/account-cluster-risk/initial-investment.ts

@@ -1,43 +1,36 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import {
+  PortfolioDetails,
+  PortfolioPosition
+} from '@ghostfolio/common/interfaces';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class AccountClusterRiskInitialInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class AccountClusterRiskInitialInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private accounts: PortfolioDetails['accounts']
+  ) {
     super(exchangeRateDataService, {
       name: 'Initial Investment'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[AccountClusterRiskInitialInvestment.name];
-
+  public evaluate(ruleSettings?: Settings) {
     const platforms: {
       [symbol: string]: Pick<PortfolioPosition, 'name'> & {
         investment: number;
       };
     } = {};
 
-    Object.values(aPositions).forEach((position) => {
-      for (const [account, { original }] of Object.entries(position.accounts)) {
-        if (platforms[account]?.investment) {
-          platforms[account].investment += original;
-        } else {
-          platforms[account] = {
-            investment: original,
-            name: account
-          };
-        }
-      }
-    });
+    for (const account of Object.keys(this.accounts)) {
+      platforms[account] = {
+        name: account,
+        investment: this.accounts[account].original
+      };
+    }
 
     let maxItem;
     let totalInvestment = 0;
@@ -78,4 +71,18 @@ export class AccountClusterRiskInitialInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true,
+      threshold: 0.5
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: string;
+  isActive: boolean;
+  threshold: number;
 }

apps/api/src/models/rules/account-cluster-risk/single-account.ts

@@ -1,25 +1,22 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { PortfolioDetails } from '@ghostfolio/common/interfaces';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class AccountClusterRiskSingleAccount extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class AccountClusterRiskSingleAccount extends Rule<RuleSettings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private accounts: PortfolioDetails['accounts']
+  ) {
     super(exchangeRateDataService, {
       name: 'Single Account'
     });
   }
 
-  public evaluate(positions: { [symbol: string]: PortfolioPosition }) {
-    const accounts: string[] = [];
-
-    Object.values(positions).forEach((position) => {
-      for (const [account] of Object.entries(position.accounts)) {
-        if (!accounts.includes(account)) {
-          accounts.push(account);
-        }
-      }
-    });
+  public evaluate() {
+    const accounts: string[] = Object.keys(this.accounts);
 
     if (accounts.length === 1) {
       return {
@@ -33,4 +30,10 @@ export class AccountClusterRiskSingleAccount extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): RuleSettings {
+    return {
+      isActive: true
+    };
+  }
 }

apps/api/src/models/rules/currency-cluster-risk/base-currency-current-investment.ts

@@ -1,27 +1,25 @@
+import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { Currency } from '@prisma/client';
 
 import { Rule } from '../../rule';
 
-export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private currentPositions: CurrentPositions
+  ) {
     super(exchangeRateDataService, {
       name: 'Current Investment: Base Currency'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[CurrencyClusterRiskBaseCurrencyCurrentInvestment.name];
-
-    const positionsGroupedByCurrency = this.groupPositionsByAttribute(
-      aPositions,
+  public evaluate(ruleSettings: Settings) {
+    const positionsGroupedByCurrency = this.groupCurrentPositionsByAttribute(
+      this.currentPositions.positions,
       'currency',
       ruleSettings.baseCurrency
     );
@@ -61,4 +59,15 @@ export class CurrencyClusterRiskBaseCurrencyCurrentInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: Currency;
 }

apps/api/src/models/rules/currency-cluster-risk/base-currency-initial-investment.ts

@@ -1,27 +1,24 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { Currency } from '@prisma/client';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class CurrencyClusterRiskBaseCurrencyInitialInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class CurrencyClusterRiskBaseCurrencyInitialInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private currentPositions: CurrentPositions
+  ) {
     super(exchangeRateDataService, {
       name: 'Initial Investment: Base Currency'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[CurrencyClusterRiskBaseCurrencyInitialInvestment.name];
-
-    const positionsGroupedByCurrency = this.groupPositionsByAttribute(
-      aPositions,
+  public evaluate(ruleSettings: Settings) {
+    const positionsGroupedByCurrency = this.groupCurrentPositionsByAttribute(
+      this.currentPositions.positions,
       'currency',
       ruleSettings.baseCurrency
     );
@@ -62,4 +59,15 @@ export class CurrencyClusterRiskBaseCurrencyInitialInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: Currency;
 }

apps/api/src/models/rules/currency-cluster-risk/current-investment.ts

@@ -1,27 +1,24 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { Currency } from '@prisma/client';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class CurrencyClusterRiskCurrentInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class CurrencyClusterRiskCurrentInvestment extends Rule<Settings> {
+  public constructor(
+    public exchangeRateDataService: ExchangeRateDataService,
+    private currentPositions: CurrentPositions
+  ) {
     super(exchangeRateDataService, {
       name: 'Current Investment'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[CurrencyClusterRiskCurrentInvestment.name];
-
-    const positionsGroupedByCurrency = this.groupPositionsByAttribute(
-      aPositions,
+  public evaluate(ruleSettings: Settings) {
+    const positionsGroupedByCurrency = this.groupCurrentPositionsByAttribute(
+      this.currentPositions.positions,
       'currency',
       ruleSettings.baseCurrency
     );
@@ -61,4 +58,17 @@ export class CurrencyClusterRiskCurrentInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true,
+      threshold: 0.5
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: Currency;
+  threshold: number;
 }

apps/api/src/models/rules/currency-cluster-risk/initial-investment.ts

@@ -1,27 +1,24 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { Currency } from '@prisma/client';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class CurrencyClusterRiskInitialInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class CurrencyClusterRiskInitialInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private currentPositions: CurrentPositions
+  ) {
     super(exchangeRateDataService, {
       name: 'Initial Investment'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings =
-      aRuleSettingsMap[CurrencyClusterRiskInitialInvestment.name];
-
-    const positionsGroupedByCurrency = this.groupPositionsByAttribute(
-      aPositions,
+  public evaluate(ruleSettings: Settings) {
+    const positionsGroupedByCurrency = this.groupCurrentPositionsByAttribute(
+      this.currentPositions.positions,
       'currency',
       ruleSettings.baseCurrency
     );
@@ -61,4 +58,17 @@ export class CurrencyClusterRiskInitialInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true,
+      threshold: 0.5
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: Currency;
+  threshold: number;
 }

apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts

@@ -1,38 +1,23 @@
-import { PortfolioPosition } from '@ghostfolio/common/interfaces';
+import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
+import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
+import { Currency } from '@prisma/client';
 import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 
-export class FeeRatioInitialInvestment extends Rule {
-  public constructor(public exchangeRateDataService: ExchangeRateDataService) {
+export class FeeRatioInitialInvestment extends Rule<Settings> {
+  public constructor(
+    protected exchangeRateDataService: ExchangeRateDataService,
+    private totalInvestment: number,
+    private fees: number
+  ) {
     super(exchangeRateDataService, {
       name: 'Initial Investment'
     });
   }
 
-  public evaluate(
-    aPositions: { [symbol: string]: PortfolioPosition },
-    aFees: number,
-    aRuleSettingsMap?: {
-      [key: string]: any;
-    }
-  ) {
-    const ruleSettings = aRuleSettingsMap[FeeRatioInitialInvestment.name];
-
-    const positionsGroupedByCurrency = this.groupPositionsByAttribute(
-      aPositions,
-      'currency',
-      ruleSettings.baseCurrency
-    );
-
-    let totalInvestment = 0;
-
-    positionsGroupedByCurrency.forEach((groupItem) => {
-      // Calculate total investment
-      totalInvestment += groupItem.investment;
-    });
-
-    const feeRatio = aFees / totalInvestment;
+  public evaluate(ruleSettings: Settings) {
+    const feeRatio = this.fees / this.totalInvestment;
 
     if (feeRatio > ruleSettings.threshold) {
       return {
@@ -50,4 +35,17 @@ export class FeeRatioInitialInvestment extends Rule {
       value: true
     };
   }
+
+  public getSettings(aUserSettings: UserSettings): Settings {
+    return {
+      baseCurrency: aUserSettings.baseCurrency,
+      isActive: true,
+      threshold: 0.01
+    };
+  }
+}
+
+interface Settings extends RuleSettings {
+  baseCurrency: Currency;
+  threshold: number;
 }

apps/api/src/services/configuration.module.ts

@@ -0,0 +1,8 @@
+import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { Module } from '@nestjs/common';
+
+@Module({
+  providers: [ConfigurationService],
+  exports: [ConfigurationService]
+})
+export class ConfigurationModule {}

apps/api/src/services/data-gathering.module.ts

@@ -0,0 +1,12 @@
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
+import { Module } from '@nestjs/common';
+
+@Module({
+  imports: [ConfigurationModule, DataProviderModule, PrismaModule],
+  providers: [DataGatheringService],
+  exports: [DataGatheringService]
+})
+export class DataGatheringModule {}

apps/api/src/services/data-gathering.service.ts

@@ -1,8 +1,8 @@
 import { benchmarks, currencyPairs } from '@ghostfolio/common/config';
 import {
+  DATE_FORMAT,
   getUtc,
   isGhostfolioScraperApiSymbol,
-  isRakutenRapidApiSymbol,
   resetHours
 } from '@ghostfolio/common/helper';
 import { Injectable } from '@nestjs/common';
@@ -19,7 +19,7 @@ import {
 } from 'date-fns';
 
 import { ConfigurationService } from './configuration.service';
-import { DataProviderService } from './data-provider.service';
+import { DataProviderService } from './data-provider/data-provider.service';
 import { GhostfolioScraperApiService } from './data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
 import { IDataGatheringItem } from './interfaces/interfaces';
 import { PrismaService } from './prisma.service';
@@ -30,7 +30,7 @@ export class DataGatheringService {
     private readonly configurationService: ConfigurationService,
     private readonly dataProviderService: DataProviderService,
     private readonly ghostfolioScraperApi: GhostfolioScraperApiService,
-    private prisma: PrismaService
+    private readonly prismaService: PrismaService
   ) {}
 
   public async gather7Days() {
@@ -40,7 +40,7 @@ export class DataGatheringService {
       console.log('7d data gathering has been started.');
       console.time('7d-data-gathering');
 
-      await this.prisma.property.create({
+      await this.prismaService.property.create({
         data: {
           key: 'LOCKED_DATA_GATHERING',
           value: new Date().toISOString()
@@ -52,7 +52,7 @@ export class DataGatheringService {
       try {
         await this.gatherSymbols(symbols);
 
-        await this.prisma.property.upsert({
+        await this.prismaService.property.upsert({
           create: {
             key: 'LAST_DATA_GATHERING',
             value: new Date().toISOString()
@@ -64,7 +64,7 @@ export class DataGatheringService {
         console.error(error);
       }
 
-      await this.prisma.property.delete({
+      await this.prismaService.property.delete({
         where: {
           key: 'LOCKED_DATA_GATHERING'
         }
@@ -76,7 +76,7 @@ export class DataGatheringService {
   }
 
   public async gatherMax() {
-    const isDataGatheringLocked = await this.prisma.property.findUnique({
+    const isDataGatheringLocked = await this.prismaService.property.findUnique({
       where: { key: 'LOCKED_DATA_GATHERING' }
     });
 
@@ -84,7 +84,7 @@ export class DataGatheringService {
       console.log('Max data gathering has been started.');
       console.time('max-data-gathering');
 
-      await this.prisma.property.create({
+      await this.prismaService.property.create({
         data: {
           key: 'LOCKED_DATA_GATHERING',
           value: new Date().toISOString()
@@ -96,7 +96,7 @@ export class DataGatheringService {
       try {
         await this.gatherSymbols(symbols);
 
-        await this.prisma.property.upsert({
+        await this.prismaService.property.upsert({
           create: {
             key: 'LAST_DATA_GATHERING',
             value: new Date().toISOString()
@@ -108,7 +108,7 @@ export class DataGatheringService {
         console.error(error);
       }
 
-      await this.prisma.property.delete({
+      await this.prismaService.property.delete({
         where: {
           key: 'LOCKED_DATA_GATHERING'
         }
@@ -134,18 +134,21 @@ export class DataGatheringService {
 
     const currentData = await this.dataProviderService.get(symbols);
 
-    for (const [symbol, { currency, dataSource, name }] of Object.entries(
-      currentData
-    )) {
+    for (const [
+      symbol,
+      { assetClass, currency, dataSource, name }
+    ] of Object.entries(currentData)) {
       try {
-        await this.prisma.symbolProfile.upsert({
+        await this.prismaService.symbolProfile.upsert({
           create: {
+            assetClass,
             currency,
             dataSource,
             name,
             symbol
           },
           update: {
+            assetClass,
             currency,
             name
           },
@@ -193,16 +196,16 @@ export class DataGatheringService {
           )
         ) {
           if (
-            historicalData[symbol]?.[format(currentDate, 'yyyy-MM-dd')]
+            historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
               ?.marketPrice
           ) {
             lastMarketPrice =
-              historicalData[symbol]?.[format(currentDate, 'yyyy-MM-dd')]
+              historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
                 ?.marketPrice;
           }
 
           try {
-            await this.prisma.marketData.create({
+            await this.prismaService.marketData.create({
               data: {
                 symbol,
                 date: currentDate,
@@ -247,6 +250,34 @@ export class DataGatheringService {
     });
   }
 
+  public async getIsInProgress() {
+    return await this.prismaService.property.findUnique({
+      where: { key: 'LOCKED_DATA_GATHERING' }
+    });
+  }
+
+  public async getLastDataGathering() {
+    const lastDataGathering = await this.prismaService.property.findUnique({
+      where: { key: 'LAST_DATA_GATHERING' }
+    });
+
+    if (lastDataGathering?.value) {
+      return new Date(lastDataGathering.value);
+    }
+
+    return undefined;
+  }
+
+  public async reset() {
+    console.log('Data gathering has been reset.');
+
+    await this.prismaService.property.deleteMany({
+      where: {
+        OR: [{ key: 'LAST_DATA_GATHERING' }, { key: 'LOCKED_DATA_GATHERING' }]
+      }
+    });
+  }
+
   private getBenchmarksToGather(startDate: Date): IDataGatheringItem[] {
     const benchmarksToGather = benchmarks.map(({ dataSource, symbol }) => {
       return {
@@ -270,7 +301,7 @@ export class DataGatheringService {
   private async getSymbols7D(): Promise<IDataGatheringItem[]> {
     const startDate = subDays(resetHours(new Date()), 7);
 
-    const distinctOrders = await this.prisma.order.findMany({
+    const distinctOrders = await this.prismaService.order.findMany({
       distinct: ['symbol'],
       orderBy: [{ symbol: 'asc' }],
       select: { dataSource: true, symbol: true },
@@ -302,9 +333,8 @@ export class DataGatheringService {
       }
     );
 
-    const customSymbolsToGather = await this.getCustomSymbolsToGather(
-      startDate
-    );
+    const customSymbolsToGather =
+      await this.ghostfolioScraperApi.getCustomSymbolsToGather(startDate);
 
     return [
       ...this.getBenchmarksToGather(startDate),
@@ -317,9 +347,8 @@ export class DataGatheringService {
   private async getSymbolsMax(): Promise<IDataGatheringItem[]> {
     const startDate = new Date(getUtc('2015-01-01'));
 
-    const customSymbolsToGather = await this.getCustomSymbolsToGather(
-      startDate
-    );
+    const customSymbolsToGather =
+      await this.ghostfolioScraperApi.getCustomSymbolsToGather(startDate);
 
     const currencyPairsToGather = currencyPairs.map(
       ({ dataSource, symbol }) => {
@@ -331,7 +360,7 @@ export class DataGatheringService {
       }
     );
 
-    const distinctOrders = await this.prisma.order.findMany({
+    const distinctOrders = await this.prismaService.order.findMany({
       distinct: ['symbol'],
       orderBy: [{ date: 'asc' }],
       select: { dataSource: true, date: true, symbol: true },
@@ -353,7 +382,7 @@ export class DataGatheringService {
   private async getSymbolsProfileData(): Promise<IDataGatheringItem[]> {
     const startDate = subDays(resetHours(new Date()), 7);
 
-    const distinctOrders = await this.prisma.order.findMany({
+    const distinctOrders = await this.prismaService.order.findMany({
       distinct: ['symbol'],
       orderBy: [{ symbol: 'asc' }],
       select: { dataSource: true, symbol: true }
@@ -370,18 +399,13 @@ export class DataGatheringService {
   }
 
   private async isDataGatheringNeeded() {
-    const lastDataGathering = await this.prisma.property.findUnique({
-      where: { key: 'LAST_DATA_GATHERING' }
-    });
+    const lastDataGathering = await this.getLastDataGathering();
 
-    const isDataGatheringLocked = await this.prisma.property.findUnique({
+    const isDataGatheringLocked = await this.prismaService.property.findUnique({
       where: { key: 'LOCKED_DATA_GATHERING' }
     });
 
-    const diffInHours = differenceInHours(
-      new Date(),
-      new Date(lastDataGathering?.value)
-    );
+    const diffInHours = differenceInHours(new Date(), lastDataGathering);
 
     return (diffInHours >= 1 || !lastDataGathering) && !isDataGatheringLocked;
   }

apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts

@@ -1,10 +1,11 @@
 import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
+import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { DATE_FORMAT } from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Injectable } from '@nestjs/common';
 import { DataSource } from '@prisma/client';
 import { isAfter, isBefore, parse } from 'date-fns';
 
-import { ConfigurationService } from '../../configuration.service';
 import { DataProviderInterface } from '../../interfaces/data-provider.interface';
 import {
   IDataProviderHistoricalResponse,
@@ -66,8 +67,8 @@ export class AlphaVantageService implements DataProviderInterface {
         historicalData['Time Series (Digital Currency Daily)']
       ).sort()) {
         if (
-          isAfter(from, parse(key, 'yyyy-MM-dd', new Date())) &&
-          isBefore(to, parse(key, 'yyyy-MM-dd', new Date()))
+          isAfter(from, parse(key, DATE_FORMAT, new Date())) &&
+          isBefore(to, parse(key, DATE_FORMAT, new Date()))
         ) {
           response[symbol][key] = {
             marketPrice: parseFloat(timeSeries['4a. close (USD)'])

apps/api/src/services/data-provider/data-provider.module.ts

@@ -0,0 +1,22 @@
+import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
+import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
+import { RakutenRapidApiService } from '@ghostfolio/api/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
+import { YahooFinanceService } from '@ghostfolio/api/services/data-provider/yahoo-finance/yahoo-finance.service';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
+import { Module } from '@nestjs/common';
+
+import { AlphaVantageService } from './alpha-vantage/alpha-vantage.service';
+import { DataProviderService } from './data-provider.service';
+
+@Module({
+  imports: [ConfigurationModule, PrismaModule],
+  providers: [
+    AlphaVantageService,
+    DataProviderService,
+    GhostfolioScraperApiService,
+    RakutenRapidApiService,
+    YahooFinanceService
+  ],
+  exports: [DataProviderService, GhostfolioScraperApiService]
+})
+export class DataProviderModule {}

apps/api/src/services/data-provider/data-provider.service.ts

@@ -1,4 +1,13 @@
+import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
+import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import {
+  IDataGatheringItem,
+  IDataProviderHistoricalResponse,
+  IDataProviderResponse
+} from '@ghostfolio/api/services/interfaces/interfaces';
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import {
+  DATE_FORMAT,
   isGhostfolioScraperApiSymbol,
   isRakutenRapidApiSymbol
 } from '@ghostfolio/common/helper';
@@ -7,17 +16,10 @@ import { Injectable } from '@nestjs/common';
 import { DataSource, MarketData } from '@prisma/client';
 import { format } from 'date-fns';
 
-import { ConfigurationService } from './configuration.service';
-import { AlphaVantageService } from './data-provider/alpha-vantage/alpha-vantage.service';
-import { GhostfolioScraperApiService } from './data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
-import { RakutenRapidApiService } from './data-provider/rakuten-rapid-api/rakuten-rapid-api.service';
-import { YahooFinanceService } from './data-provider/yahoo-finance/yahoo-finance.service';
-import {
-  IDataGatheringItem,
-  IDataProviderHistoricalResponse,
-  IDataProviderResponse
-} from './interfaces/interfaces';
-import { PrismaService } from './prisma.service';
+import { AlphaVantageService } from './alpha-vantage/alpha-vantage.service';
+import { GhostfolioScraperApiService } from './ghostfolio-scraper-api/ghostfolio-scraper-api.service';
+import { RakutenRapidApiService } from './rakuten-rapid-api/rakuten-rapid-api.service';
+import { YahooFinanceService } from './yahoo-finance/yahoo-finance.service';
 
 @Injectable()
 export class DataProviderService {
@@ -25,11 +27,11 @@ export class DataProviderService {
     private readonly alphaVantageService: AlphaVantageService,
     private readonly configurationService: ConfigurationService,
     private readonly ghostfolioScraperApiService: GhostfolioScraperApiService,
-    private prisma: PrismaService,
+    private readonly prismaService: PrismaService,
     private readonly rakutenRapidApiService: RakutenRapidApiService,
     private readonly yahooFinanceService: YahooFinanceService
   ) {
-    this.rakutenRapidApiService.setPrisma(this.prisma);
+    this.rakutenRapidApiService?.setPrisma(this.prismaService);
   }
 
   public async get(
@@ -100,9 +102,9 @@ export class DataProviderService {
 
     const rangeQuery =
       from && to
-        ? `AND date >= '${format(from, 'yyyy-MM-dd')}' AND date <= '${format(
+        ? `AND date >= '${format(from, DATE_FORMAT)}' AND date <= '${format(
             to,
-            'yyyy-MM-dd'
+            DATE_FORMAT
           )}'`
         : '';
 
@@ -111,16 +113,15 @@ export class DataProviderService {
         `','`
       )}') ${granularityQuery} ${rangeQuery} ORDER BY date;`;
 
-      const marketDataByGranularity: MarketData[] = await this.prisma.$queryRaw(
-        queryRaw
-      );
+      const marketDataByGranularity: MarketData[] =
+        await this.prismaService.$queryRaw(queryRaw);
 
       response = marketDataByGranularity.reduce((r, marketData) => {
         const { date, marketPrice, symbol } = marketData;
 
         r[symbol] = {
           ...(r[symbol] || {}),
-          [format(new Date(date), 'yyyy-MM-dd')]: { marketPrice }
+          [format(new Date(date), DATE_FORMAT)]: { marketPrice }
         };
 
         return r;
@@ -166,10 +167,19 @@ export class DataProviderService {
     return result;
   }
 
-  public async search(aSymbol: string) {
-    return this.getDataProvider(
+  public async search(aSymbol: string): Promise<{ items: LookupItem[] }> {
+    const { items } = await this.getDataProvider(
       <DataSource>this.configurationService.get('DATA_SOURCES')[0]
     ).search(aSymbol);
+
+    const filteredItems = items.filter((item) => {
+      // Only allow symbols with supported currency
+      return item.currency ? true : false;
+    });
+
+    return {
+      items: filteredItems
+    };
   }
 
   private getDataProvider(providerName: DataSource) {

apps/api/src/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service.ts

@@ -1,4 +1,7 @@
+import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import {
+  DATE_FORMAT,
   getYesterday,
   isGhostfolioScraperApiSymbol
 } from '@ghostfolio/common/helper';
@@ -11,18 +14,18 @@ import { format } from 'date-fns';
 
 import { DataProviderInterface } from '../../interfaces/data-provider.interface';
 import {
+  IDataGatheringItem,
   IDataProviderHistoricalResponse,
   IDataProviderResponse,
   MarketState
 } from '../../interfaces/interfaces';
-import { PrismaService } from '../../prisma.service';
 import { ScraperConfig } from './interfaces/scraper-config.interface';
 
 @Injectable()
 export class GhostfolioScraperApiService implements DataProviderInterface {
   private static NUMERIC_REGEXP = /[-]{0,1}[\d]*[.,]{0,1}[\d]+/g;
 
-  public constructor(private prisma: PrismaService) {}
+  public constructor(private readonly prismaService: PrismaService) {}
 
   public canHandle(symbol: string) {
     return isGhostfolioScraperApiSymbol(symbol);
@@ -40,7 +43,7 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
 
       const scraperConfig = await this.getScraperConfigurationBySymbol(symbol);
 
-      const { marketPrice } = await this.prisma.marketData.findFirst({
+      const { marketPrice } = await this.prismaService.marketData.findFirst({
         orderBy: {
           date: 'desc'
         },
@@ -54,8 +57,7 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
           marketPrice,
           currency: scraperConfig?.currency,
           dataSource: DataSource.GHOSTFOLIO,
-          marketState: MarketState.delayed,
-          name: scraperConfig?.name
+          marketState: MarketState.delayed
         }
       };
     } catch (error) {
@@ -65,6 +67,25 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
     return {};
   }
 
+  public async getCustomSymbolsToGather(
+    startDate?: Date
+  ): Promise<IDataGatheringItem[]> {
+    const ghostfolioSymbolProfiles =
+      await this.prismaService.symbolProfile.findMany({
+        where: {
+          dataSource: DataSource.GHOSTFOLIO
+        }
+      });
+
+    return ghostfolioSymbolProfiles.map(({ dataSource, symbol }) => {
+      return {
+        dataSource,
+        symbol,
+        date: startDate
+      };
+    });
+  }
+
   public async getHistorical(
     aSymbols: string[],
     aGranularity: Granularity = 'day',
@@ -95,7 +116,7 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
 
       return {
         [symbol]: {
-          [format(getYesterday(), 'yyyy-MM-dd')]: {
+          [format(getYesterday(), DATE_FORMAT)]: {
             marketPrice: value
           }
         }
@@ -109,14 +130,13 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
 
   public async getScraperConfigurations(): Promise<ScraperConfig[]> {
     try {
-      const {
-        value: scraperConfigString
-      } = await this.prisma.property.findFirst({
-        select: {
-          value: true
-        },
-        where: { key: 'SCRAPER_CONFIG' }
-      });
+      const { value: scraperConfigString } =
+        await this.prismaService.property.findFirst({
+          select: {
+            value: true
+          },
+          where: { key: 'SCRAPER_CONFIG' }
+        });
 
       return JSON.parse(scraperConfigString);
     } catch {}
@@ -124,7 +144,7 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
     return [];
   }
 
-  public async search(aSymbol: string) {
+  public async search(aSymbol: string): Promise<{ items: LookupItem[] }> {
     return { items: [] };
   }
 

apps/api/src/services/data-provider/ghostfolio-scraper-api/interfaces/scraper-config.interface.ts

@@ -2,7 +2,6 @@ import { Currency } from '@prisma/client';
 
 export interface ScraperConfig {
   currency: Currency;
-  name: string;
   selector: string;
   symbol: string;
   url: string;

apps/api/src/services/data-provider/rakuten-rapid-api/rakuten-rapid-api.service.ts

@@ -1,4 +1,8 @@
+import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
+import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import {
+  DATE_FORMAT,
   getToday,
   getYesterday,
   isRakutenRapidApiSymbol
@@ -9,20 +13,18 @@ import { DataSource } from '@prisma/client';
 import * as bent from 'bent';
 import { format, subMonths, subWeeks, subYears } from 'date-fns';
 
-import { ConfigurationService } from '../../configuration.service';
 import { DataProviderInterface } from '../../interfaces/data-provider.interface';
 import {
   IDataProviderHistoricalResponse,
   IDataProviderResponse,
   MarketState
 } from '../../interfaces/interfaces';
-import { PrismaService } from '../../prisma.service';
 
 @Injectable()
 export class RakutenRapidApiService implements DataProviderInterface {
   public static FEAR_AND_GREED_INDEX_NAME = 'Fear & Greed Index';
 
-  private prisma: PrismaService;
+  private prismaService: PrismaService;
 
   public constructor(
     private readonly configurationService: ConfigurationService
@@ -88,7 +90,7 @@ export class RakutenRapidApiService implements DataProviderInterface {
           // TODO: can be removed after all data from the last year has been gathered
           // (introduced on 27.03.2021)
 
-          await this.prisma.marketData.create({
+          await this.prismaService.marketData.create({
             data: {
               symbol,
               date: subWeeks(getToday(), 1),
@@ -96,7 +98,7 @@ export class RakutenRapidApiService implements DataProviderInterface {
             }
           });
 
-          await this.prisma.marketData.create({
+          await this.prismaService.marketData.create({
             data: {
               symbol,
               date: subMonths(getToday(), 1),
@@ -104,7 +106,7 @@ export class RakutenRapidApiService implements DataProviderInterface {
             }
           });
 
-          await this.prisma.marketData.create({
+          await this.prismaService.marketData.create({
             data: {
               symbol,
               date: subYears(getToday(), 1),
@@ -117,7 +119,7 @@ export class RakutenRapidApiService implements DataProviderInterface {
 
         return {
           'GF.FEAR_AND_GREED_INDEX': {
-            [format(getYesterday(), 'yyyy-MM-dd')]: {
+            [format(getYesterday(), DATE_FORMAT)]: {
               marketPrice: fgi.previousClose.value
             }
           }
@@ -128,12 +130,12 @@ export class RakutenRapidApiService implements DataProviderInterface {
     return {};
   }
 
-  public async search(aSymbol: string) {
+  public async search(aSymbol: string): Promise<{ items: LookupItem[] }> {
     return { items: [] };
   }
 
   public setPrisma(aPrismaService: PrismaService) {
-    this.prisma = aPrismaService;
+    this.prismaService = aPrismaService;
   }
 
   private async getFearAndGreedIndex(): Promise<{

apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

@@ -1,10 +1,16 @@
 import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
 import { UNKNOWN_KEY } from '@ghostfolio/common/config';
-import { isCrypto, isCurrency, parseCurrency } from '@ghostfolio/common/helper';
+import {
+  DATE_FORMAT,
+  isCrypto,
+  isCurrency,
+  parseCurrency
+} from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Injectable } from '@nestjs/common';
-import { DataSource } from '@prisma/client';
+import { AssetClass, Currency, DataSource } from '@prisma/client';
 import * as bent from 'bent';
+import Big from 'big.js';
 import { format } from 'date-fns';
 import * as yahooFinance from 'yahoo-finance';
 
@@ -12,8 +18,7 @@ import { DataProviderInterface } from '../../interfaces/data-provider.interface'
 import {
   IDataProviderHistoricalResponse,
   IDataProviderResponse,
-  MarketState,
-  Type
+  MarketState
 } from '../../interfaces/interfaces';
 import {
   IYahooFinanceHistoricalResponse,
@@ -56,6 +61,7 @@ export class YahooFinanceService implements DataProviderInterface {
         const symbol = convertFromYahooSymbol(yahooSymbol);
 
         response[symbol] = {
+          assetClass: this.parseAssetClass(value.price?.quoteType),
           currency: parseCurrency(value.price?.currency),
           dataSource: DataSource.YAHOO,
           exchange: this.parseExchange(value.price?.exchangeName),
@@ -64,10 +70,19 @@ export class YahooFinanceService implements DataProviderInterface {
               ? MarketState.open
               : MarketState.closed,
           marketPrice: value.price?.regularMarketPrice || 0,
-          name: value.price?.longName || value.price?.shortName || symbol,
-          type: this.parseType(this.getType(symbol, value))
+          name: value.price?.longName || value.price?.shortName || symbol
         };
 
+        if (value.price?.currency === 'GBp') {
+          // Convert GBp (pence) to GBP
+          response[symbol].currency = Currency.GBP;
+          response[symbol].marketPrice = new Big(
+            value.price?.regularMarketPrice ?? 0
+          )
+            .div(100)
+            .toNumber();
+        }
+
         const url = value.summaryProfile?.website;
         if (url) {
           response[symbol].url = url;
@@ -103,8 +118,8 @@ export class YahooFinanceService implements DataProviderInterface {
         [symbol: string]: IYahooFinanceHistoricalResponse[];
       } = await yahooFinance.historical({
         symbols: yahooSymbols,
-        from: format(from, 'yyyy-MM-dd'),
-        to: format(to, 'yyyy-MM-dd')
+        from: format(from, DATE_FORMAT),
+        to: format(to, DATE_FORMAT)
       });
 
       const response: {
@@ -117,7 +132,7 @@ export class YahooFinanceService implements DataProviderInterface {
         response[symbol] = {};
 
         timeSeries.forEach((timeSerie) => {
-          response[symbol][format(timeSerie.date, 'yyyy-MM-dd')] = {
+          response[symbol][format(timeSerie.date, DATE_FORMAT)] = {
             marketPrice: timeSerie.close,
             performance: timeSerie.open - timeSerie.close
           };
@@ -133,7 +148,7 @@ export class YahooFinanceService implements DataProviderInterface {
   }
 
   public async search(aSymbol: string): Promise<{ items: LookupItem[] }> {
-    let items = [];
+    let items: LookupItem[] = [];
 
     try {
       const get = bent(
@@ -143,8 +158,23 @@ export class YahooFinanceService implements DataProviderInterface {
         200
       );
 
-      const result = await get();
-      items = result.quotes
+      const searchResult = await get();
+
+      const symbols: string[] = searchResult.quotes
+        .filter((quote) => {
+          // filter out undefined symbols
+          return quote.symbol;
+        })
+        .filter(({ quoteType }) => {
+          return quoteType === 'EQUITY' || quoteType === 'ETF';
+        })
+        .map(({ symbol }) => {
+          return symbol;
+        });
+
+      const marketData = await this.get(symbols);
+
+      items = searchResult.quotes
         .filter((quote) => {
           return quote.isYahooFinance;
         })
@@ -158,13 +188,14 @@ export class YahooFinanceService implements DataProviderInterface {
         .filter(({ quoteType, symbol }) => {
           if (quoteType === 'CRYPTOCURRENCY') {
             // Only allow cryptocurrencies in USD
-            return symbol.includes('USD');
+            return symbol.includes(Currency.USD);
           }
 
           return true;
         })
         .map(({ longname, shortname, symbol }) => {
           return {
+            currency: marketData[symbol]?.currency,
             dataSource: DataSource.YAHOO,
             name: longname || shortname,
             symbol: convertFromYahooSymbol(symbol)
@@ -198,14 +229,20 @@ export class YahooFinanceService implements DataProviderInterface {
     return aSymbol;
   }
 
-  private getType(aSymbol: string, aValue: IYahooFinanceQuoteResponse): Type {
-    if (isCrypto(aSymbol)) {
-      return Type.Cryptocurrency;
-    } else if (aValue.price?.quoteType.toLowerCase() === 'equity') {
-      return Type.Stock;
+  private parseAssetClass(aString: string): AssetClass {
+    let assetClass: AssetClass;
+
+    switch (aString?.toLowerCase()) {
+      case 'cryptocurrency':
+        assetClass = AssetClass.CASH;
+        break;
+      case 'equity':
+      case 'etf':
+        assetClass = AssetClass.EQUITY;
+        break;
     }
 
-    return aValue.price?.quoteType.toLowerCase();
+    return assetClass;
   }
 
   private parseExchange(aString: string): string {
@@ -215,18 +252,6 @@ export class YahooFinanceService implements DataProviderInterface {
 
     return aString;
   }
-
-  private parseType(aString: string): Type {
-    if (aString?.toLowerCase() === 'cryptocurrency') {
-      return Type.Cryptocurrency;
-    } else if (aString?.toLowerCase() === 'etf') {
-      return Type.ETF;
-    } else if (aString?.toLowerCase() === 'stock') {
-      return Type.Stock;
-    }
-
-    return Type.Unknown;
-  }
 }
 
 export const convertFromYahooSymbol = (aSymbol: string) => {

apps/api/src/services/exchange-rate-data.module.ts

@@ -0,0 +1,10 @@
+import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
+import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { Module } from '@nestjs/common';
+
+@Module({
+  imports: [DataProviderModule],
+  providers: [ExchangeRateDataService],
+  exports: [ExchangeRateDataService]
+})
+export class ExchangeRateDataModule {}

apps/api/src/services/exchange-rate-data.service.ts

@@ -1,35 +1,35 @@
-import { getYesterday } from '@ghostfolio/common/helper';
+import { currencyPairs } from '@ghostfolio/common/config';
+import { DATE_FORMAT, getYesterday } from '@ghostfolio/common/helper';
 import { Injectable } from '@nestjs/common';
 import { Currency } from '@prisma/client';
 import { format } from 'date-fns';
+import { isNumber } from 'lodash';
 
-import { DataProviderService } from './data-provider.service';
+import { DataProviderService } from './data-provider/data-provider.service';
 
 @Injectable()
 export class ExchangeRateDataService {
-  private currencies = {};
-  private pairs: string[] = [];
+  private currencyPairs: string[] = [];
+  private exchangeRates: { [currencyPair: string]: number } = {};
 
   public constructor(private dataProviderService: DataProviderService) {
     this.initialize();
   }
 
   public async initialize() {
-    this.pairs = [];
+    this.currencyPairs = [];
+    this.exchangeRates = {};
 
-    this.addPairs(Currency.CHF, Currency.EUR);
-    this.addPairs(Currency.CHF, Currency.GBP);
-    this.addPairs(Currency.CHF, Currency.USD);
-    this.addPairs(Currency.EUR, Currency.GBP);
-    this.addPairs(Currency.EUR, Currency.USD);
-    this.addPairs(Currency.GBP, Currency.USD);
+    for (const { currency1, currency2 } of currencyPairs) {
+      this.addCurrencyPairs(currency1, currency2);
+    }
 
     await this.loadCurrencies();
   }
 
   public async loadCurrencies() {
     const result = await this.dataProviderService.getHistorical(
-      this.pairs,
+      this.currencyPairs,
       'day',
       getYesterday(),
       getYesterday()
@@ -49,20 +49,21 @@ export class ExchangeRateDataService {
       };
     });
 
-    this.pairs.forEach((pair) => {
+    this.currencyPairs.forEach((pair) => {
       const [currency1, currency2] = pair.match(/.{1,3}/g);
-      const date = format(getYesterday(), 'yyyy-MM-dd');
+      const date = format(getYesterday(), DATE_FORMAT);
 
-      this.currencies[pair] = resultExtended[pair]?.[date]?.marketPrice;
+      this.exchangeRates[pair] = resultExtended[pair]?.[date]?.marketPrice;
 
-      if (!this.currencies[pair]) {
+      if (!this.exchangeRates[pair]) {
         // Not found, calculate indirectly via USD
-        this.currencies[pair] =
+        this.exchangeRates[pair] =
           resultExtended[`${currency1}${Currency.USD}`]?.[date]?.marketPrice *
           resultExtended[`${Currency.USD}${currency2}`]?.[date]?.marketPrice;
 
         // Calculate the opposite direction
-        this.currencies[`${currency2}${currency1}`] = 1 / this.currencies[pair];
+        this.exchangeRates[`${currency2}${currency1}`] =
+          1 / this.exchangeRates[pair];
       }
     });
   }
@@ -72,7 +73,7 @@ export class ExchangeRateDataService {
     aFromCurrency: Currency,
     aToCurrency: Currency
   ) {
-    if (isNaN(this.currencies[`${Currency.USD}${Currency.CHF}`])) {
+    if (isNaN(this.exchangeRates[`${Currency.USD}${Currency.CHF}`])) {
       // Reinitialize if data is not loaded correctly
       this.initialize();
     }
@@ -80,14 +81,32 @@ export class ExchangeRateDataService {
     let factor = 1;
 
     if (aFromCurrency !== aToCurrency) {
-      factor = this.currencies[`${aFromCurrency}${aToCurrency}`];
+      if (this.exchangeRates[`${aFromCurrency}${aToCurrency}`]) {
+        factor = this.exchangeRates[`${aFromCurrency}${aToCurrency}`];
+      } else {
+        // Calculate indirectly via USD
+        const factor1 = this.exchangeRates[`${aFromCurrency}${Currency.USD}`];
+        const factor2 = this.exchangeRates[`${Currency.USD}${aToCurrency}`];
+
+        factor = factor1 * factor2;
+
+        this.exchangeRates[`${aFromCurrency}${aToCurrency}`] = factor;
+      }
     }
 
-    return factor * aValue;
+    if (isNumber(factor)) {
+      return factor * aValue;
+    }
+
+    // Fallback with error, if currencies are not available
+    console.error(
+      `No exchange rate has been found for ${aFromCurrency}${aToCurrency}`
+    );
+    return aValue;
   }
 
-  private addPairs(aCurrency1: Currency, aCurrency2: Currency) {
-    this.pairs.push(`${aCurrency1}${aCurrency2}`);
-    this.pairs.push(`${aCurrency2}${aCurrency1}`);
+  private addCurrencyPairs(aCurrency1: Currency, aCurrency2: Currency) {
+    this.currencyPairs.push(`${aCurrency1}${aCurrency2}`);
+    this.currencyPairs.push(`${aCurrency2}${aCurrency1}`);
   }
 }

apps/api/src/services/impersonation.module.ts

@@ -0,0 +1,10 @@
+import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
+import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
+import { Module } from '@nestjs/common';
+
+@Module({
+  imports: [PrismaModule],
+  providers: [ImpersonationService],
+  exports: [ImpersonationService]
+})
+export class ImpersonationModule {}

apps/api/src/services/impersonation.service.ts

@@ -4,10 +4,10 @@ import { PrismaService } from './prisma.service';
 
 @Injectable()
 export class ImpersonationService {
-  public constructor(private prisma: PrismaService) {}
+  public constructor(private readonly prismaService: PrismaService) {}
 
   public async validateImpersonationId(aId = '', aUserId: string) {
-    const accessObject = await this.prisma.access.findFirst({
+    const accessObject = await this.prismaService.access.findFirst({
       where: { GranteeUser: { id: aUserId }, id: aId }
     });
 

apps/api/src/services/interfaces/interfaces.ts

@@ -1,5 +1,10 @@
-import { UNKNOWN_KEY } from '@ghostfolio/common/config';
-import { Account, Currency, DataSource, SymbolProfile } from '@prisma/client';
+import {
+  Account,
+  AssetClass,
+  Currency,
+  DataSource,
+  SymbolProfile
+} from '@prisma/client';
 
 import { OrderType } from '../../models/order-type';
 
@@ -9,20 +14,13 @@ export const MarketState = {
   open: 'open'
 };
 
-export const Type = {
-  Cash: 'Cash',
-  Cryptocurrency: 'Cryptocurrency',
-  ETF: 'ETF',
-  Stock: 'Stock',
-  Unknown: UNKNOWN_KEY
-};
-
 export interface IOrder {
   account: Account;
   currency: Currency;
   date: string;
   fee: number;
   id?: string;
+  isDraft: boolean;
   quantity: number;
   symbol: string;
   symbolProfile: SymbolProfile;
@@ -36,6 +34,7 @@ export interface IDataProviderHistoricalResponse {
 }
 
 export interface IDataProviderResponse {
+  assetClass?: AssetClass;
   currency: Currency;
   dataSource: DataSource;
   exchange?: string;
@@ -43,8 +42,7 @@ export interface IDataProviderResponse {
   marketChangePercent?: number;
   marketPrice: number;
   marketState: MarketState;
-  name: string;
-  type?: Type;
+  name?: string;
   url?: string;
 }
 
@@ -55,5 +53,3 @@ export interface IDataGatheringItem {
 }
 
 export type MarketState = typeof MarketState[keyof typeof MarketState];
-
-export type Type = typeof Type[keyof typeof Type];

apps/api/src/services/interfaces/symbol-profile.interface.ts

@@ -0,0 +1,16 @@
+import { Country } from '@ghostfolio/common/interfaces/country.interface';
+import { Sector } from '@ghostfolio/common/interfaces/sector.interface';
+import { AssetClass, Currency, DataSource } from '@prisma/client';
+
+export interface EnhancedSymbolProfile {
+  assetClass: AssetClass;
+  createdAt: Date;
+  currency: Currency | null;
+  dataSource: DataSource;
+  id: string;
+  name: string | null;
+  updatedAt: Date;
+  symbol: string;
+  countries: Country[];
+  sectors: Sector[];
+}

apps/api/src/services/prisma.module.ts

@@ -0,0 +1,8 @@
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { Module } from '@nestjs/common';
+
+@Module({
+  providers: [PrismaService],
+  exports: [PrismaService]
+})
+export class PrismaModule {}

apps/api/src/services/rules.service.ts

@@ -1,78 +0,0 @@
-import { Injectable } from '@nestjs/common';
-
-import { Portfolio } from '../models/portfolio';
-import { Rule } from '../models/rule';
-import { AccountClusterRiskCurrentInvestment } from '../models/rules/account-cluster-risk/current-investment';
-import { AccountClusterRiskInitialInvestment } from '../models/rules/account-cluster-risk/initial-investment';
-import { AccountClusterRiskSingleAccount } from '../models/rules/account-cluster-risk/single-account';
-import { CurrencyClusterRiskBaseCurrencyCurrentInvestment } from '../models/rules/currency-cluster-risk/base-currency-current-investment';
-import { CurrencyClusterRiskBaseCurrencyInitialInvestment } from '../models/rules/currency-cluster-risk/base-currency-initial-investment';
-import { CurrencyClusterRiskCurrentInvestment } from '../models/rules/currency-cluster-risk/current-investment';
-import { CurrencyClusterRiskInitialInvestment } from '../models/rules/currency-cluster-risk/initial-investment';
-import { FeeRatioInitialInvestment } from '../models/rules/fees/fee-ratio-initial-investment';
-
-@Injectable()
-export class RulesService {
-  public constructor() {}
-
-  public async evaluate(
-    aPortfolio: Portfolio,
-    aRules: Rule[],
-    aUserSettings: { baseCurrency: string }
-  ) {
-    const defaultSettings = this.getDefaultRuleSettings(aUserSettings);
-    const details = await aPortfolio.getDetails();
-
-    return aRules
-      .filter((rule) => {
-        return defaultSettings[rule.constructor.name]?.isActive;
-      })
-      .map((rule) => {
-        const evaluationResult = rule.evaluate(
-          details,
-          aPortfolio.getFees(),
-          defaultSettings
-        );
-        return { ...evaluationResult, name: rule.getName() };
-      });
-  }
-
-  private getDefaultRuleSettings(aUserSettings: { baseCurrency: string }) {
-    return {
-      [AccountClusterRiskCurrentInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true,
-        threshold: 0.5
-      },
-      [AccountClusterRiskInitialInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true,
-        threshold: 0.5
-      },
-      [AccountClusterRiskSingleAccount.name]: { isActive: true },
-      [CurrencyClusterRiskBaseCurrencyInitialInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true
-      },
-      [CurrencyClusterRiskBaseCurrencyCurrentInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true
-      },
-      [CurrencyClusterRiskCurrentInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true,
-        threshold: 0.5
-      },
-      [CurrencyClusterRiskInitialInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true,
-        threshold: 0.5
-      },
-      [FeeRatioInitialInvestment.name]: {
-        baseCurrency: aUserSettings.baseCurrency,
-        isActive: true,
-        threshold: 0.01
-      }
-    };
-  }
-}

apps/api/src/services/symbol-profile.service.ts

@@ -0,0 +1,64 @@
+import { EnhancedSymbolProfile } from '@ghostfolio/api/services/interfaces/symbol-profile.interface';
+import { PrismaService } from '@ghostfolio/api/services/prisma.service';
+import { UNKNOWN_KEY } from '@ghostfolio/common/config';
+import { Country } from '@ghostfolio/common/interfaces/country.interface';
+import { Sector } from '@ghostfolio/common/interfaces/sector.interface';
+import { Injectable } from '@nestjs/common';
+import { Prisma, SymbolProfile } from '@prisma/client';
+import { continents, countries } from 'countries-list';
+
+@Injectable()
+export class SymbolProfileService {
+  constructor(private readonly prismaService: PrismaService) {}
+
+  public async getSymbolProfiles(
+    symbols: string[]
+  ): Promise<EnhancedSymbolProfile[]> {
+    return this.prismaService.symbolProfile
+      .findMany({
+        where: {
+          symbol: {
+            in: symbols
+          }
+        }
+      })
+      .then((symbolProfiles) => this.getSymbols(symbolProfiles));
+  }
+
+  private getSymbols(symbolProfiles: SymbolProfile[]): EnhancedSymbolProfile[] {
+    return symbolProfiles.map((symbolProfile) => ({
+      ...symbolProfile,
+      countries: this.getCountries(symbolProfile),
+      sectors: this.getSectors(symbolProfile)
+    }));
+  }
+
+  private getCountries(symbolProfile: SymbolProfile): Country[] {
+    return ((symbolProfile?.countries as Prisma.JsonArray) ?? []).map(
+      (country) => {
+        const { code, weight } = country as Prisma.JsonObject;
+
+        return {
+          code: code as string,
+          continent:
+            continents[countries[code as string]?.continent] ?? UNKNOWN_KEY,
+          name: countries[code as string]?.name ?? UNKNOWN_KEY,
+          weight: weight as number
+        };
+      }
+    );
+  }
+
+  private getSectors(symbolProfile: SymbolProfile): Sector[] {
+    return ((symbolProfile?.sectors as Prisma.JsonArray) ?? []).map(
+      (sector) => {
+        const { name, weight } = sector as Prisma.JsonObject;
+
+        return {
+          name: (name as string) ?? UNKNOWN_KEY,
+          weight: weight as number
+        };
+      }
+    );
+  }
+}

apps/client/src/app/app-routing.module.ts

@@ -52,6 +52,41 @@ const routes: Routes = [
     loadChildren: () =>
       import('./pages/home/home-page.module').then((m) => m.HomePageModule)
   },
+  {
+    path: 'portfolio',
+    loadChildren: () =>
+      import('./pages/portfolio/portfolio-page.module').then(
+        (m) => m.PortfolioPageModule
+      )
+  },
+  {
+    path: 'portfolio/allocations',
+    loadChildren: () =>
+      import('./pages/portfolio/allocations/allocations-page.module').then(
+        (m) => m.AllocationsPageModule
+      )
+  },
+  {
+    path: 'portfolio/analysis',
+    loadChildren: () =>
+      import('./pages/portfolio/analysis/analysis-page.module').then(
+        (m) => m.AnalysisPageModule
+      )
+  },
+  {
+    path: 'portfolio/report',
+    loadChildren: () =>
+      import('./pages/portfolio/report/report-page.module').then(
+        (m) => m.ReportPageModule
+      )
+  },
+  {
+    path: 'portfolio/transactions',
+    loadChildren: () =>
+      import('./pages/portfolio/transactions/transactions-page.module').then(
+        (m) => m.TransactionsPageModule
+      )
+  },
   {
     path: 'pricing',
     loadChildren: () =>
@@ -80,32 +115,6 @@ const routes: Routes = [
         (m) => m.LandingPageModule
       )
   },
-  {
-    path: 'tools',
-    loadChildren: () =>
-      import('./pages/tools/tools-page.module').then((m) => m.ToolsPageModule)
-  },
-  {
-    path: 'tools/analysis',
-    loadChildren: () =>
-      import('./pages/tools/analysis/analysis-page.module').then(
-        (m) => m.AnalysisPageModule
-      )
-  },
-  {
-    path: 'tools/report',
-    loadChildren: () =>
-      import('./pages/tools/report/report-page.module').then(
-        (m) => m.ReportPageModule
-      )
-  },
-  {
-    path: 'transactions',
-    loadChildren: () =>
-      import('./pages/transactions/transactions-page.module').then(
-        (m) => m.TransactionsPageModule
-      )
-  },
   {
     path: 'webauthn',
     loadChildren: () =>

apps/client/src/app/components/access-table/access-table.component.html

@@ -10,7 +10,7 @@
     <th *matHeaderCellDef class="px-1" i18n mat-header-cell>Type</th>
     <td *matCellDef="let element" class="px-1" mat-cell>
       <ion-icon class="mr-1" name="lock-closed-outline"></ion-icon>
-      Restricted Access
+      Restricted View
     </td></ng-container
   >
 

apps/client/src/app/components/accounts-table/accounts-table.component.html

@@ -2,7 +2,13 @@
   <ng-container matColumnDef="account">
     <th *matHeaderCellDef class="px-1" i18n mat-header-cell>Name</th>
     <td *matCellDef="let element" class="px-1" mat-cell>
-      {{ element.name }}
+      <gf-symbol-icon
+        *ngIf="element.Platform?.url"
+        class="d-inline d-sm-none mr-1"
+        [tooltip]="element.Platform?.name"
+        [url]="element.Platform?.url"
+      ></gf-symbol-icon>
+      <span>{{ element.name }} </span>
       <span
         *ngIf="element.isDefault"
         class="d-lg-inline-block d-none text-muted"
@@ -12,13 +18,20 @@
   </ng-container>
 
   <ng-container matColumnDef="platform">
-    <th *matHeaderCellDef class="px-1" i18n mat-header-cell>Platform</th>
-    <td *matCellDef="let element" class="px-1" mat-cell>
+    <th
+      *matHeaderCellDef
+      class="d-none d-lg-table-cell px-1"
+      i18n
+      mat-header-cell
+    >
+      Platform
+    </th>
+    <td *matCellDef="let element" class="d-none d-lg-table-cell px-1" mat-cell>
       <div class="d-flex">
         <gf-symbol-icon
           *ngIf="element.Platform?.url"
           class="mr-1"
-          [tooltip]=""
+          [tooltip]="element.Platform?.name"
           [url]="element.Platform?.url"
         ></gf-symbol-icon>
         <span>{{ element.Platform?.name }}</span>
@@ -27,17 +40,20 @@
   </ng-container>
 
   <ng-container matColumnDef="transactions">
-    <th *matHeaderCellDef class="text-right" i18n mat-header-cell>
-      Transactions
+    <th *matHeaderCellDef class="px-1 text-right" mat-header-cell>
+      <span class="d-block d-sm-none">#</span>
+      <span class="d-none d-sm-block" i18n>Transactions</span>
     </th>
-    <td *matCellDef="let element" class="text-right" mat-cell>
-      {{ element.Order?.length }}
+    <td *matCellDef="let element" class="px-1 text-right" mat-cell>
+      {{ element.transactionCount }}
     </td>
   </ng-container>
 
   <ng-container matColumnDef="balance">
-    <th *matHeaderCellDef class="text-right" i18n mat-header-cell>Balance</th>
-    <td *matCellDef="let element" class="text-right" mat-cell>
+    <th *matHeaderCellDef class="px-1 text-right" i18n mat-header-cell>
+      Balance
+    </th>
+    <td *matCellDef="let element" class="px-1 text-right" mat-cell>
       <gf-value
         class="d-inline-block justify-content-end"
         [currency]="element.currency"

apps/client/src/app/components/dialog-header/dialog-header.component.html

@@ -1,9 +1,3 @@
-<gf-symbol-icon
-  *ngIf="symbolUrl"
-  class="mr-1"
-  size="large"
-  [url]="symbolUrl"
-></gf-symbol-icon>
 <span class="flex-grow-1 text-truncate">{{ title }}</span>
 <button
   *ngIf="deviceType !== 'mobile'"

apps/client/src/app/components/dialog-header/dialog-header.component.ts

@@ -16,7 +16,6 @@ import {
 })
 export class DialogHeaderComponent implements OnInit {
   @Input() deviceType: string;
-  @Input() symbolUrl: string;
   @Input() title: string;
 
   @Output() closeButtonClicked = new EventEmitter<void>();