SubMiner/backlog/tasks/task-146 - Forward-overlay-Tab-to-mpv-for-AniSkip.md at f2d6c70019105b4278b307d6726679dbc184549c - SubMiner

mirror of https://github.com/ksyasuda/SubMiner.git synced 2026-03-20 12:11:28 -07:00

Files

chore(backlog): maintain task backlog and add changelog fragments

- Move completed tasks (85, 117, 118, 155) to backlog/completed/
- Delete superseded task files (166 verification, 172 drilldown)
- Add stats dashboard milestone m-1
- Add new tasks (190, 194)
- Update task metadata across remaining backlog items
- Add changelog fragments for stats, mpv args, and subtitle filtering

2026-03-18 02:25:07 -07:00

2.4 KiB

Raw Blame History

id, title, status, assignee, created_date, updated_date, labels, dependencies, ordinal

title

status

assignee

created_date

updated_date

labels

dependencies

ordinal

TASK-146

Forward overlay Tab to mpv for AniSkip

Done

codex

2026-03-09 00:00

2026-03-18 05:28

bug

overlay

aniskip

linux

47500

Description

Fix visible-overlay keyboard handling so bare Tab is forwarded to mpv instead of being consumed by Electron focus navigation. This restores the default AniSkip TAB binding while the overlay has focus, especially on Linux.

Acceptance Criteria

#1 Visible overlay forwards bare Tab to mpv as keypress TAB.
#2 Modal overlays keep their existing local Tab behavior.
#3 Automated regression coverage exists for the input handler and overlay factory wiring.

Implementation Plan

Add a failing regression around visible-overlay before-input-event handling for bare Tab.
Add/extend overlay factory tests so the new mpv-forward callback is wired through runtime construction.
Patch overlay input handling to intercept visible-overlay Tab and send mpv keypress TAB.
Run focused overlay tests, typecheck, and changelog validation.

Implementation Notes

Extracted visible-overlay input handling into src/core/services/overlay-window-input.ts so the Tab forwarding decision can be unit tested without loading Electron window primitives.

Visible overlay before-input-event now intercepts bare Tab, prevents the browser default, and forwards mpv keypress TAB through the existing mpv runtime command path. Modal overlays remain unchanged.

Verification:

bun test src/core/services/overlay-window.test.ts src/main/runtime/overlay-window-factory.test.ts src/main/runtime/overlay-window-factory-main-deps.test.ts src/main/runtime/overlay-window-runtime-handlers.test.ts
bun x tsc --noEmit

Final Summary

Visible overlay focus no longer blocks the default AniSkip Tab binding. Bare Tab is now forwarded straight to mpv while the visible overlay is active, and modal overlays still retain their own normal focus behavior.

Added regression coverage for both the input-routing decision and the runtime plumbing that carries the new mpv forwarder into overlay window creation.

2.4 KiB Raw Blame History