Files
SubMiner/backlog/tasks/task-70 - Overlay-runtime-refactor-remove-invisible-mode-and-bind-visible-overlay-to-mpv-subtitles.md
2026-02-28 21:15:26 -08:00

1.8 KiB

id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal
id title status assignee created_date updated_date labels dependencies references priority ordinal
TASK-70 Overlay runtime refactor: remove invisible mode and bind visible overlay to mpv subtitles Done
2026-02-28 02:38 2026-02-28 22:36
commit:a14c9da
commit:74554a3
commit:75442a4
commit:dde51f8
commit:9e4e588
src/main/overlay-runtime.ts
src/main/runtime/overlay-mpv-sub-visibility.ts
src/renderer/renderer.ts
docs/plans/2026-02-26-secondary-subtitles-main-overlay.md
medium 1000

Description

Scope: Branch-only commits main..HEAD on refactor-overlay (a14c9da through 9e4e588) rebuilt overlay behavior around visible overlay mode and removed legacy invisible overlay paths.

Delivered behavior:

  • Removed renderer invisible overlay layout/offset helpers and main hover-highlight runtime code paths.
  • Added explicit overlay-to-mpv subtitle visibility synchronization so visible overlay state controls primary subtitle visibility consistently.
  • Hardened overlay runtime/bootstrap lifecycle around modal fallback open state and bridge send path edge cases.
  • Updated plugin/config/docs defaults to reflect visible-overlay-first behavior and subtitle binding controls.

Risk/impact context:

  • Large cross-layer refactor touching runtime wiring, renderer event handling, and plugin behavior.
  • Regression coverage added/updated for overlay runtime, mpv protocol handling, renderer cleanup, and subtitle rendering paths.

Final Summary

Completed and validated in branch commit set before merge. Refactor reduces dead overlay modes, centralizes subtitle visibility behavior, and documents new defaults/constraints.