mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-20 12:11:28 -07:00
62 lines
3.2 KiB
Markdown
62 lines
3.2 KiB
Markdown
---
|
|
id: TASK-112
|
|
title: Address Claude review items on PR 15
|
|
status: Done
|
|
assignee:
|
|
- codex
|
|
created_date: '2026-03-08 00:11'
|
|
updated_date: '2026-03-08 00:12'
|
|
labels:
|
|
- pr-review
|
|
- ci
|
|
dependencies: []
|
|
references:
|
|
- .github/workflows/release.yml
|
|
- .github/workflows/ci.yml
|
|
- .gitmodules
|
|
- >-
|
|
backlog/tasks/task-101 -
|
|
Index-AniList-character-alternative-names-in-the-character-dictionary.md
|
|
priority: medium
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Review Claude's PR feedback on PR #15, implement only the technically valid fixes on the current branch, and document which comments are non-actionable or already acceptable.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Validated Claude's concrete PR review items against current branch state and repo conventions
|
|
- [x] #2 Implemented the accepted fixes with regression coverage or verification where applicable
|
|
- [x] #3 Documented which review items are non-blocking or intentionally left unchanged
|
|
<!-- AC:END -->
|
|
|
|
## Implementation Plan
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Validate each Claude review item against current branch files and repo workflow.
|
|
2. Patch release quality-gate to match CI ordering and add explicit typecheck.
|
|
3. Remove duplicate .gitmodules stanza and normalize the TASK-101 reference path through Backlog MCP.
|
|
4. Run relevant verification for workflow/config metadata changes and record which review items remain non-actionable.
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Implementation Notes
|
|
|
|
<!-- SECTION:NOTES:BEGIN -->
|
|
User asked to address Claude PR comments on PR #15 and assess whether any action items remain. Treat review suggestions skeptically; only fix validated defects.
|
|
|
|
Validated Claude's five review items. Fixed release workflow ordering/typecheck, removed the duplicate .gitmodules entry, and normalized TASK-101 references to repo-relative paths via Backlog MCP.
|
|
|
|
Left the vendor/subminer-yomitan branch-pin suggestion unchanged. The committed submodule SHA already controls reproducibility; adding a branch would only affect update ergonomics and was not required to address a concrete defect.
|
|
<!-- SECTION:NOTES:END -->
|
|
|
|
## Final Summary
|
|
|
|
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
|
|
Validated Claude's PR #15 review summary against the current branch and applied the actionable fixes. In `.github/workflows/release.yml`, the release `quality-gate` job now restores the dependency cache before installation, no longer installs twice, and runs `bun run typecheck` before the fast test suite to match CI expectations. In `.gitmodules`, removed the duplicate `vendor/yomitan-jlpt-vocab` stanza with the conflicting duplicate path. Through Backlog MCP, updated `TASK-101` references from an absolute local path to repo-relative paths so the task metadata is portable across contributors.
|
|
|
|
Verification: `git diff --check`, `git config -f .gitmodules --get-regexp '^submodule\..*\.path$'`, `bun run typecheck`, and `bun run test:fast` all passed. `bun run format:check` still fails on many pre-existing unrelated files already present on the branch, including multiple backlog task files and existing source/docs files; this review patch did not attempt a repo-wide formatting sweep.
|
|
<!-- SECTION:FINAL_SUMMARY:END -->
|