mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-04-26 04:19:27 -07:00
1.4 KiB
1.4 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ||
|---|---|---|---|---|---|---|---|---|---|---|
| TASK-294 | Fix annotated subtitle tokens to honor subtitleStyle | Done | 2026-04-25 23:04 | 2026-04-25 23:07 |
|
medium |
Description
Annotated token spans should inherit the configured subtitleStyle typography and only use annotation metadata to change token color.
Acceptance Criteria
- #1 Tokenized/annotated subtitles preserve configured base subtitle typography such as font family, size, weight, line height, letter spacing, text rendering, and text shadow.
- #2 Known/N+1/JLPT/frequency/name-match annotations affect token color only, plus existing token metadata/hover affordances.
- #3 A renderer regression test covers annotated token rendering with custom subtitleStyle.
Final Summary
Updated renderer subtitle annotation CSS so known/N+1/name/JLPT/frequency classes no longer override typography with token-specific shadows, underlines, padding, or hover font-weight. Added regression coverage using the user's custom subtitleStyle shape to verify annotated token spans inherit base typography and annotation CSS changes token color only. Verified with bun test src/renderer/subtitle-render.test.ts, bun run typecheck, and bun run test:fast.