SubMiner/backlog/tasks/task-73 - Consolidate-launcher-mpv-socket-readiness-primitives.md

id, title, status, assignee, created_date, updated_date, labels, dependencies, priority, ordinal

id	title	status	assignee	created_date	updated_date	labels	dependencies	priority	ordinal
TASK-73	Consolidate launcher mpv socket readiness primitives	Done		2026-02-18 11:35	2026-02-22 07:49	launcher mpv refactor		medium	85000

Description

Launcher contains multiple overlapping MPV readiness/polling helpers (waitForSocket, waitForPathExists, waitForUnixSocketReady) with mixed timeout/poll semantics. Consolidation needed for clarity and lower maintenance.

Action Steps

1. Define one canonical socket readiness contract (existence + connectability + timeout).
2. Replace duplicate polling helpers with a single implementation.
3. Update all callsites (mpv status, idle launch flow, subtitle loading dependencies).
4. Keep user-visible behavior and exit codes stable.
5. Add focused tests for timeout and success/failure edge cases.

Acceptance Criteria

• #1 Single canonical MPV socket readiness helper remains
• #2 All launcher callsites use unified helper
• #3 Behavior/exit code compatibility maintained for CLI flows
• #4 Test coverage added for readiness timeout behavior

Definition of Done

• #1 Launcher tests pass
• #2 No dead helper functions remain