mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-30 06:12:06 -07:00
36 lines
1.4 KiB
Markdown
36 lines
1.4 KiB
Markdown
---
|
|
id: TASK-244
|
|
title: 'Assess and address PR #36 latest CodeRabbit review round 2'
|
|
status: Done
|
|
assignee: []
|
|
created_date: '2026-03-29 08:09'
|
|
updated_date: '2026-03-29 08:10'
|
|
labels:
|
|
- code-review
|
|
- pr-36
|
|
dependencies: []
|
|
references:
|
|
- 'https://github.com/ksyasuda/SubMiner/pull/36'
|
|
priority: high
|
|
ordinal: 3610
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Inspect the newest CodeRabbit review round on PR #36, verify the actionable comment against the current branch, implement the confirmed fix, and verify the touched path.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [ ] #1 The actionable review comment is implemented or explicitly deferred with rationale.
|
|
- [ ] #2 Touched path is verified with the smallest sufficient test lane.
|
|
- [ ] #3 Current PR feedback is reduced to resolved or intentionally deferred suggestions.
|
|
<!-- AC:END -->
|
|
|
|
## Final Summary
|
|
|
|
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
|
|
Addressed the actionable latest CodeRabbit comment on PR #36. `src/core/services/immersion-tracker/maintenance.ts` now skips retention deletions when a window is disabled with `Infinity`, so `toDbMs(...)` is only called for finite retention values. Added a regression test in `maintenance.test.ts` that verifies disabled retention windows preserve session events, telemetry, and sessions while returning zero deletions.
|
|
<!-- SECTION:FINAL_SUMMARY:END -->
|