mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-08-07 19:21:32 -07:00
b1bdeabca8
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb - Show visible overlay automatically during Jellyfin playback so subtitleStyle applies - Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus - Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles - Mark ffsubsync unavailable in subsync modal for remote media paths - Drain queued second-instance commands even when onReady throws * fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause - Keep overlay visible during macOS foreground probe after overlay blur - Hold sidebar hover-pause while a Yomitan lookup popup remains open * fix(jellyfin): fix discovery loop, device identity, tray state, and Disc - Derive device identity from OS hostname; remove legacy configurable client/device fields - Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores - Restart stale tray discovery sessions without re-login when server drops SubMiner cast target - Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes - Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads - Fix picker library discovery when log level is above info - Fix config.example.jsonc trailing commas and array formatting * docs(release): trim and consolidate prerelease notes for 0.15.0 - Remove breaking changes section and several redundant bullet points - Consolidate per-platform updater notes into a single entry - Normalize em-dash separators to hyphens in section headers * fix(config): remove trailing commas from config.example.jsonc - Strip trailing commas throughout both config.example.jsonc copies - Reformat inline arrays to multi-line for JSON strictness - Update Jellyfin subtitle preload and playback launch tests and impl * fix(tokenizer): preserve known-word highlight when POS filters suppress - Known-word cache matches now set isKnown=true even for tokens excluded by POS filters - POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate - Jellyfin subtitle preload continues after cleanup failures instead of aborting - Update config docs and option description to document the known-word bypass behavior * fix(jellyfin): send explicit hide/show overlay instead of toggle - Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known - Prevent paused Jellyfin playback from resuming on overlay hide - Fix subtitle cache cleanup to only remove dirs after successful cleanup * fix(jellyfin): fix remote progress sync, seek reporting, and startup sto - arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events - force immediate progress report on seek-like position jumps at the mpv time-pos level - send positionTicks and failed=false in reportStopped payload - remove EventName from HTTP timeline payloads (websocket-only field) - add startup grace window to drop stop events before media finishes loading * fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi - Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift - Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress - Preserve manual hide across Jellyfin path-changing redirects even when media-title drops - Rearm managed subtitle defaults on path-changing redirects - Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC - Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus - Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary - Add stats window layer management so delete/update dialogs appear above stats window - Fix Jellyfin remote progress sync during Linux websocket reconnect windows * Fix CodeRabbit review feedback * fix(jellyfin): subtitle timing, resume progress, and overlay sync - Add per-stream subtitle delay persistence and auto timeline-offset correction - Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload - Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports - Keep Play vs Resume distinct to avoid early seek race on normal play - Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress - Deduplicate show/hide overlay commands using recorded visibility state - Rewrite docs-site Jellyfin page around cast-to-device UX * test: update lifecycle cleanup assertion * fix: clear aborted playback state, fix overlay passthrough, and guard du - Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item - Record visible overlay action only after command succeeds, not before - Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering) - Defer activeParsedSubtitleMediaPath assignment until after prefetch completes - Move autoplay gate release into the hide branch of toggleVisibleOverlay - Clear active Jellyfin playback when stopping media that never loaded - Reset managed subtitle delay and delay key when no external tracks are available - Await async removeDir in subtitle cache cleanup - Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs - Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
273 lines
7.6 KiB
TypeScript
273 lines
7.6 KiB
TypeScript
import test from 'node:test';
|
|
import assert from 'node:assert/strict';
|
|
|
|
import { createSubsyncModal } from './subsync.js';
|
|
|
|
type Listener = () => void;
|
|
|
|
function createClassList() {
|
|
const classes = new Set<string>();
|
|
return {
|
|
add: (...tokens: string[]) => {
|
|
for (const token of tokens) classes.add(token);
|
|
},
|
|
remove: (...tokens: string[]) => {
|
|
for (const token of tokens) classes.delete(token);
|
|
},
|
|
toggle: (token: string, force?: boolean) => {
|
|
if (force === undefined) {
|
|
if (classes.has(token)) classes.delete(token);
|
|
else classes.add(token);
|
|
return classes.has(token);
|
|
}
|
|
if (force) classes.add(token);
|
|
else classes.delete(token);
|
|
return force;
|
|
},
|
|
contains: (token: string) => classes.has(token),
|
|
};
|
|
}
|
|
|
|
function createEventTarget() {
|
|
const listeners = new Map<string, Listener[]>();
|
|
return {
|
|
addEventListener: (event: string, listener: Listener) => {
|
|
const existing = listeners.get(event) ?? [];
|
|
existing.push(listener);
|
|
listeners.set(event, existing);
|
|
},
|
|
dispatch: (event: string) => {
|
|
for (const listener of listeners.get(event) ?? []) {
|
|
listener();
|
|
}
|
|
},
|
|
};
|
|
}
|
|
|
|
function createDeferred<T>() {
|
|
let resolve!: (value: T) => void;
|
|
const promise = new Promise<T>((nextResolve) => {
|
|
resolve = nextResolve;
|
|
});
|
|
return { promise, resolve };
|
|
}
|
|
|
|
function createTestHarness(runSubsyncManual: () => Promise<{ ok: boolean; message: string }>) {
|
|
const overlayClassList = createClassList();
|
|
const modalClassList = createClassList();
|
|
const statusClassList = createClassList();
|
|
const sourceLabelClassList = createClassList();
|
|
const runButtonEvents = createEventTarget();
|
|
const closeButtonEvents = createEventTarget();
|
|
const engineAlassEvents = createEventTarget();
|
|
const engineFfsubsyncEvents = createEventTarget();
|
|
|
|
const sourceOptions: Array<{ value: string; textContent: string }> = [];
|
|
|
|
const runButton = {
|
|
disabled: false,
|
|
addEventListener: runButtonEvents.addEventListener,
|
|
dispatch: runButtonEvents.dispatch,
|
|
};
|
|
|
|
const closeButton = {
|
|
addEventListener: closeButtonEvents.addEventListener,
|
|
dispatch: closeButtonEvents.dispatch,
|
|
};
|
|
|
|
const subsyncEngineAlass = {
|
|
checked: false,
|
|
addEventListener: engineAlassEvents.addEventListener,
|
|
dispatch: engineAlassEvents.dispatch,
|
|
};
|
|
|
|
const subsyncEngineFfsubsync = {
|
|
checked: false,
|
|
disabled: false,
|
|
addEventListener: engineFfsubsyncEvents.addEventListener,
|
|
dispatch: engineFfsubsyncEvents.dispatch,
|
|
};
|
|
|
|
const sourceSelect = {
|
|
innerHTML: '',
|
|
value: '',
|
|
disabled: false,
|
|
appendChild: (option: { value: string; textContent: string }) => {
|
|
sourceOptions.push(option);
|
|
if (!sourceSelect.value) {
|
|
sourceSelect.value = option.value;
|
|
}
|
|
return option;
|
|
},
|
|
};
|
|
|
|
let notifyClosedCalls = 0;
|
|
let notifyOpenedCalls = 0;
|
|
|
|
const previousWindow = (globalThis as { window?: unknown }).window;
|
|
const previousDocument = (globalThis as { document?: unknown }).document;
|
|
|
|
Object.defineProperty(globalThis, 'window', {
|
|
configurable: true,
|
|
value: {
|
|
electronAPI: {
|
|
runSubsyncManual,
|
|
notifyOverlayModalOpened: () => {
|
|
notifyOpenedCalls += 1;
|
|
},
|
|
notifyOverlayModalClosed: () => {
|
|
notifyClosedCalls += 1;
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
Object.defineProperty(globalThis, 'document', {
|
|
configurable: true,
|
|
value: {
|
|
createElement: () => ({ value: '', textContent: '' }),
|
|
},
|
|
});
|
|
|
|
const ctx = {
|
|
dom: {
|
|
overlay: { classList: overlayClassList },
|
|
subsyncModal: {
|
|
classList: modalClassList,
|
|
setAttribute: () => {},
|
|
},
|
|
subsyncCloseButton: closeButton,
|
|
subsyncEngineAlass,
|
|
subsyncEngineFfsubsync,
|
|
subsyncSourceLabel: { classList: sourceLabelClassList },
|
|
subsyncSourceSelect: sourceSelect,
|
|
subsyncRunButton: runButton,
|
|
subsyncStatus: {
|
|
textContent: '',
|
|
classList: statusClassList,
|
|
},
|
|
},
|
|
state: {
|
|
subsyncModalOpen: false,
|
|
subsyncSourceTracks: [],
|
|
subsyncSubmitting: false,
|
|
isOverSubtitle: false,
|
|
},
|
|
};
|
|
|
|
const modal = createSubsyncModal(ctx as never, {
|
|
modalStateReader: {
|
|
isAnyModalOpen: () => false,
|
|
},
|
|
syncSettingsModalSubtitleSuppression: () => {},
|
|
});
|
|
|
|
return {
|
|
ctx,
|
|
modal,
|
|
runButton,
|
|
statusClassList,
|
|
getNotifyClosedCalls: () => notifyClosedCalls,
|
|
getNotifyOpenedCalls: () => notifyOpenedCalls,
|
|
restoreGlobals: () => {
|
|
Object.defineProperty(globalThis, 'window', {
|
|
configurable: true,
|
|
value: previousWindow,
|
|
});
|
|
Object.defineProperty(globalThis, 'document', {
|
|
configurable: true,
|
|
value: previousDocument,
|
|
});
|
|
},
|
|
};
|
|
}
|
|
|
|
async function flushMicrotasks(): Promise<void> {
|
|
await Promise.resolve();
|
|
await Promise.resolve();
|
|
}
|
|
|
|
test('manual subsync failure closes during run, then reopens modal with error', async () => {
|
|
const deferred = createDeferred<{ ok: boolean; message: string }>();
|
|
const harness = createTestHarness(async () => deferred.promise);
|
|
|
|
try {
|
|
harness.modal.wireDomEvents();
|
|
harness.modal.openSubsyncModal({
|
|
sourceTracks: [{ id: 2, label: 'External #2 - eng' }],
|
|
ffsubsyncAvailable: true,
|
|
});
|
|
|
|
harness.runButton.dispatch('click');
|
|
await Promise.resolve();
|
|
|
|
assert.equal(harness.ctx.state.subsyncModalOpen, false);
|
|
assert.equal(harness.getNotifyClosedCalls(), 1);
|
|
assert.equal(harness.getNotifyOpenedCalls(), 0);
|
|
|
|
deferred.resolve({
|
|
ok: false,
|
|
message: 'alass synchronization failed: code=1 stderr: invalid subtitle format',
|
|
});
|
|
await flushMicrotasks();
|
|
|
|
assert.equal(harness.ctx.state.subsyncModalOpen, true);
|
|
assert.equal(
|
|
harness.ctx.dom.subsyncStatus.textContent,
|
|
'alass synchronization failed: code=1 stderr: invalid subtitle format',
|
|
);
|
|
assert.equal(harness.statusClassList.contains('error'), true);
|
|
assert.equal(harness.ctx.dom.subsyncRunButton.disabled, false);
|
|
assert.equal(harness.ctx.dom.subsyncEngineAlass.checked, true);
|
|
assert.equal(harness.ctx.dom.subsyncSourceSelect.value, '2');
|
|
assert.equal(harness.getNotifyClosedCalls(), 1);
|
|
assert.equal(harness.getNotifyOpenedCalls(), 1);
|
|
} finally {
|
|
harness.restoreGlobals();
|
|
}
|
|
});
|
|
|
|
test('subsync modal disables ffsubsync when payload marks it unavailable', () => {
|
|
const harness = createTestHarness(async () => ({ ok: true, message: 'ok' }));
|
|
|
|
try {
|
|
harness.modal.openSubsyncModal({
|
|
sourceTracks: [{ id: 2, label: 'External #2 - eng' }],
|
|
ffsubsyncAvailable: false,
|
|
});
|
|
|
|
assert.equal(harness.ctx.dom.subsyncEngineAlass.checked, true);
|
|
assert.equal(harness.ctx.dom.subsyncEngineFfsubsync.checked, false);
|
|
assert.equal(harness.ctx.dom.subsyncEngineFfsubsync.disabled, true);
|
|
assert.equal(harness.ctx.dom.subsyncStatus.textContent, 'Choose alass source, then run.');
|
|
} finally {
|
|
harness.restoreGlobals();
|
|
}
|
|
});
|
|
|
|
test('subsync modal ignores enter submission when no sync engine is available', async () => {
|
|
let runCalls = 0;
|
|
const harness = createTestHarness(async () => {
|
|
runCalls += 1;
|
|
return { ok: true, message: 'ok' };
|
|
});
|
|
|
|
try {
|
|
harness.modal.openSubsyncModal({
|
|
sourceTracks: [],
|
|
ffsubsyncAvailable: false,
|
|
});
|
|
|
|
harness.modal.handleSubsyncKeydown({
|
|
key: 'Enter',
|
|
preventDefault: () => {},
|
|
} as KeyboardEvent);
|
|
await flushMicrotasks();
|
|
|
|
assert.equal(runCalls, 0);
|
|
assert.equal(harness.ctx.state.subsyncModalOpen, true);
|
|
} finally {
|
|
harness.restoreGlobals();
|
|
}
|
|
});
|