mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-04-01 06:12:07 -07:00
sudacode
6e3f072fdc
- TASK-264: replace axios with native fetch across the project - TASK-265: add remote Postgres backend for immersion tracking and stats - TASK-268: address CodeRabbit review action items for PR #38 (done)
1.6 KiB
1.6 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | |||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-268 | Address CodeRabbit review action items for PR #38 | Done | 2026-04-01 05:35 | 2026-04-01 05:40 |
|
|
medium |
Description
Review unresolved CodeRabbit feedback on PR #38 and implement the actionable fixes without regressing duplicate grouping or popup behavior.
Acceptance Criteria
- #1 All unresolved actionable CodeRabbit review comments on PR #38 are triaged and either fixed in code or explicitly identified as non-actionable or ambiguous.
- #2 Code changes preserve duplicate grouping and popup flow behavior covered by existing or added regression tests.
- #3 Relevant local verification for the affected areas passes.
Final Summary
Addressed all unresolved actionable CodeRabbit comments on PR #38. Fixed duplicate tracking so empty duplicate lists are not persisted after sentence-card creation, sanitized Yomitan add-note noteId values to accept only positive integers, preserved paused playback for configured subtitle-seek keybindings when pause state is unknown, and short-circuited duplicate exact-match scanning for single-result lookups. Added regression tests for each case and verified with bun test on the affected suites plus bun run typecheck, bun run test:fast, bun run test:env, bun run build, and bun run test:smoke:dist.