sudacode
5feed360ca
* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
5.0 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | ordinal | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-201 | Suppress repeated macOS overlay loading OSD during fullscreen tracker flaps | Done |
|
2026-03-19 18:47 | 2026-03-23 03:22 |
|
|
high | 131500 |
Description
Reduce macOS fullscreen annoyance where the visible overlay briefly loses tracking and re-shows the Overlay loading... OSD even though the overlay runtime is already initialized and no new instance is launching. Keep the first startup/loading feedback, but suppress repeat loading notifications caused by subsequent tracker churn during fullscreen enter/leave or focus flaps.
Acceptance Criteria
- #1 The first macOS visible-overlay load still shows the existing
Overlay loading...OSD when tracker data is not yet ready. - #2 Repeated macOS tracker flaps after the overlay has already recovered do not immediately re-show
Overlay loading...on every loss/recovery cycle. - #3 Focused regression tests cover the repeated tracker-loss/recovery path and preserve the initial-load notification behavior.
- #4 The change does not alter overlay runtime bootstrap or single-instance behavior; only notification suppression behavior changes.
Implementation Plan
- Add focused failing regressions in
src/core/services/overlay-visibility.test.tsthat preserve the first macOSOverlay loading...OSD and suppress an immediate second OSD after tracker recovery/loss churn. - Extend the overlay-visibility state/runtime plumbing with a small macOS loading-OSD suppression state so tracker flap retries can be rate-limited without touching overlay bootstrap or single-instance logic.
- Reset the suppression when the user explicitly hides the visible overlay so intentional hide/show retries can still surface first-load feedback.
- Run focused verification for the touched overlay visibility/runtime tests and update the task with results.
Implementation Notes
Added optional loading-OSD suppression hooks to src/core/services/overlay-visibility.ts so macOS can rate-limit repeated Overlay loading... notifications without changing overlay bootstrap behavior.
Implemented service-local suppression state in src/main/overlay-visibility-runtime.ts with a 30s cooldown and explicit reset when the visible overlay is manually hidden, so fullscreen tracker flaps stay quiet but intentional hide/show retries can still show loading feedback.
Added focused regressions in src/core/services/overlay-visibility.test.ts for loss -> recover -> immediate loss suppression and for manual hide resetting suppression.
Verification: bun test src/core/services/overlay-visibility.test.ts; bun test src/main/runtime/overlay-visibility-runtime-main-deps.test.ts src/main/runtime/overlay-visibility-runtime.test.ts; bun run typecheck; bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane runtime-compat src/core/services/overlay-visibility.ts src/main/overlay-visibility-runtime.ts src/core/services/overlay-visibility.test.ts -> passed. Real-runtime lane skipped: change is notification suppression logic and cheap/runtime-compat coverage was sufficient for this scoped behavior change; no live mpv/macOS fullscreen session was run in this turn.
Docs update required: no. Changelog fragment required: yes; added changes/2026-03-19-overlay-loading-osd-fullscreen-flaps.md.
Final Summary
Reduced repeated macOS Overlay loading... popups caused by fullscreen tracker flap churn without touching overlay bootstrap or single-instance behavior. src/core/services/overlay-visibility.ts now accepts optional suppression hooks around the loading OSD path, and src/main/overlay-visibility-runtime.ts uses service-local state to rate-limit that OSD for 30 seconds while resetting the suppression when the visible overlay is explicitly hidden. Added focused regressions in src/core/services/overlay-visibility.test.ts to preserve the first-load notification, suppress immediate repeat notifications after tracker recovery/loss churn, and keep manual hide/show retries able to surface the loading OSD again. Added changelog fragment changes/2026-03-19-overlay-loading-osd-fullscreen-flaps.md. Verification passed with targeted overlay tests, typecheck, and the runtime-compat verifier lane; live macOS/mpv fullscreen runtime validation was not run in this turn.