mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-24 12:11:29 -07:00
sudacode
5feed360ca
* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
47 lines
2.0 KiB
Markdown
47 lines
2.0 KiB
Markdown
---
|
|
id: TASK-199
|
|
title: Forward launcher log level into mpv plugin script opts
|
|
status: Done
|
|
assignee: []
|
|
created_date: '2026-03-18 21:16'
|
|
updated_date: '2026-03-23 03:22'
|
|
labels: []
|
|
dependencies:
|
|
- TASK-198
|
|
references:
|
|
- /home/sudacode/projects/japanese/SubMiner/launcher/aniskip-metadata.ts
|
|
- /home/sudacode/projects/japanese/SubMiner/launcher/mpv.ts
|
|
- /home/sudacode/projects/japanese/SubMiner/launcher/main.test.ts
|
|
- /home/sudacode/projects/japanese/SubMiner/launcher/aniskip-metadata.test.ts
|
|
priority: medium
|
|
ordinal: 134500
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Make `subminer --log-level=debug ...` reach the mpv plugin auto-start path by forwarding the launcher log level into `--script-opts`, so plugin-started overlay and texthooker subprocesses inherit debug logging.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Launcher mpv playback includes `subminer-log_level=<level>` in `--script-opts` when a non-info CLI log level is used.
|
|
- [x] #2 Detached idle mpv launch uses the same script-opt forwarding.
|
|
- [x] #3 Regression tests cover launcher script-opt forwarding.
|
|
<!-- AC:END -->
|
|
|
|
## Implementation Plan
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Add a failing launcher regression test that captures mpv argv and expects `subminer-log_level=debug` inside `--script-opts`.
|
|
2. Extend the shared script-opt builder to accept launcher log level and emit `subminer-log_level` for non-info runs.
|
|
3. Reuse that builder in both normal mpv playback and detached idle mpv launch.
|
|
4. Run focused launcher tests and launcher-plugin verification.
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Outcome
|
|
|
|
<!-- SECTION:OUTCOME:BEGIN -->
|
|
Forwarded launcher log level into mpv plugin script opts via the shared builder and reused that builder for idle mpv launch. `subminer --log-level=debug ...` now gives the plugin `opts.log_level=debug`, so auto-started overlay and texthooker subprocesses include `--log-level debug` and the tokenizer timing logs can actually appear in the app log.
|
|
<!-- SECTION:OUTCOME:END -->
|