mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-24 00:11:27 -07:00
sudacode
5feed360ca
* fix: harden preload argv parsing for popup windows * fix: align youtube playback with shared overlay startup * fix: unwrap mpv youtube streams for anki media mining * docs: update docs for youtube subtitle and mining flow * refactor: unify cli and runtime wiring for startup and youtube flow * feat: update subtitle sidebar overlay behavior * chore: add shared log-file source for diagnostics * fix(ci): add changelog fragment for immersion changes * fix: address CodeRabbit review feedback * fix: persist canonical title from youtube metadata * style: format stats library tab * fix: address latest review feedback * style: format stats library files * test: stub launcher youtube deps in CI * test: isolate launcher youtube flow deps * test: stub launcher youtube deps in failing case * test: force x11 backend in launcher ci harness * test: address latest review feedback * fix(launcher): preserve user YouTube ytdl raw options * docs(backlog): update task tracking notes * fix(immersion): special-case youtube media paths in runtime and tracking * feat(stats): improve YouTube media metadata and picker key handling * fix(ci): format stats media library hook * fix: address latest CodeRabbit review items * docs: update youtube release notes and docs * feat: auto-load youtube subtitles before manual picker * fix: restore app-owned youtube subtitle flow * docs: update youtube playback docs and config copy * refactor: remove legacy youtube launcher mode plumbing * fix: refine youtube subtitle startup binding * docs: clarify youtube subtitle startup behavior * fix: address PR #31 latest review follow-ups * fix: address PR #31 follow-up review comments * test: harden youtube picker test harness * udpate backlog * fix: add timeout to youtube metadata probe * docs: refresh youtube and stats docs * update backlog * update backlog * chore: release v0.9.0
2.2 KiB
2.2 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | dependencies | references | priority | ordinal | ||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-196 | Fix subtitle prefetch cache-key mismatch and active-cue window | Done | 2026-03-18 16:05 | 2026-03-23 03:22 |
|
high | 136500 |
Description
Investigate and fix file-backed subtitle annotation latency where prefetch should warm upcoming lines but live playback still tokenizes each subtitle line. Likely causes: cache-key mismatch between parsed cue text and mpv sub-text, and priority-window selection skipping the currently active cue during mid-line starts/seeks.
Acceptance Criteria
- #1 Prefetched subtitle entries are reused when live subtitle text differs only by normalization details such as ASS
\N, newline collapsing, or surrounding whitespace. - #2 Priority-window selection includes the currently active cue when playback starts or seeks into the middle of a cue.
- #3 Regression tests cover the cache-hit normalization path and active-cue priority-window behavior.
- #4 Verification covers the touched prefetch/controller lane.
Implementation Plan
- Add failing regression tests in
subtitle-processing-controller.test.tsandsubtitle-prefetch.test.ts. - Normalize cache keys in the subtitle processing controller so prefetch/live paths share keys.
- Adjust prefetch priority-window selection to include the active cue.
- Run targeted tests, then SubMiner verification lane for touched files.
Outcome
Normalized subtitle cache keys inside the processing controller so prefetched ASS/VTT/live subtitle text variants reuse the same cache entry, and changed priority-window selection to include the currently active cue based on cue end time. Added regression coverage for both paths and verified the change with the core lane.