mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-20 12:11:28 -07:00
- Move completed tasks (85, 117, 118, 155) to backlog/completed/ - Delete superseded task files (166 verification, 172 drilldown) - Add stats dashboard milestone m-1 - Add new tasks (190, 194) - Update task metadata across remaining backlog items - Add changelog fragments for stats, mpv args, and subtitle filtering
58 lines
2.7 KiB
Markdown
58 lines
2.7 KiB
Markdown
---
|
|
id: TASK-184
|
|
title: Stabilize branch verification gate
|
|
status: Done
|
|
assignee:
|
|
- Codex
|
|
created_date: '2026-03-17 19:28'
|
|
updated_date: '2026-03-18 05:28'
|
|
labels:
|
|
- stabilization
|
|
- ci
|
|
dependencies: []
|
|
references:
|
|
- package.json
|
|
- docs/workflow/verification.md
|
|
priority: medium
|
|
ordinal: 106500
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Bring the current PR branch back to a green verification state by fixing any failing lint/format or test checks required for local handoff.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Repo source formatting checks pass for the current branch.
|
|
- [x] #2 Required local verification checks for this branch pass without introducing new failures.
|
|
- [x] #3 Any code or test adjustments stay scoped to the failing checks and preserve existing branch behavior.
|
|
<!-- AC:END -->
|
|
|
|
## Implementation Plan
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Fix the current source-formatting failures reported by `bun run format:check:src` using the minimal repo-standard Prettier output.
|
|
2. Re-run `bun run format:check:src` to confirm the lint/format gate is green.
|
|
3. Re-run the default handoff gate from `docs/workflow/verification.md`: `bun run typecheck`, `bun run test:fast`, `bun run test:env`, `bun run build`, and `bun run test:smoke:dist`.
|
|
4. Because `docs-site/` is modified on this branch, also run `bun run docs:test` and `bun run docs:build`.
|
|
5. If any verification step fails after formatting, fix only the blocking issue and re-run the relevant lane until green.
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Implementation Notes
|
|
|
|
<!-- SECTION:NOTES:BEGIN -->
|
|
Initial gate snapshot before edits: `typecheck`, `test:fast`, `test:env`, `build`, and `test:smoke:dist` passed; `format:check:src` failed on 15 files.
|
|
|
|
Applied repo-standard Prettier formatting to the 15 files reported by `bun run format:check:src`; no additional logic changes were introduced in this stabilization pass.
|
|
|
|
Verification after formatting: `bun run format:check:src` passed; `bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core --lane runtime-compat --lane docs` passed with artifacts under `.tmp/skill-verification/subminer-verify-20260317-122947-hEInF0`; `bun run test:env` passed separately.
|
|
<!-- SECTION:NOTES:END -->
|
|
|
|
## Final Summary
|
|
|
|
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
|
|
Branch verification gate is green again. Fixed the only failing local gate by applying Prettier formatting to the 15 flagged source files, then re-ran the required verification lanes: source format check, core lane (`typecheck` + `test:fast`), runtime-compat lane (`build`, `test:runtime:compat`, `test:smoke:dist`), docs lane (`docs:test`, `docs:build`), and `test:env`. All passed.
|
|
<!-- SECTION:FINAL_SUMMARY:END -->
|