mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-02-28 06:22:45 -08:00
46 lines
1.8 KiB
Markdown
46 lines
1.8 KiB
Markdown
---
|
|
id: TASK-8
|
|
title: >-
|
|
Reduce MpvIpcClient deps interface and separate protocol from application
|
|
logic
|
|
status: Done
|
|
assignee: []
|
|
created_date: '2026-02-11 08:20'
|
|
updated_date: '2026-02-15 07:00'
|
|
labels:
|
|
- refactor
|
|
- mpv
|
|
- architecture
|
|
milestone: Codebase Clarity & Composability
|
|
dependencies: []
|
|
references:
|
|
- src/core/services/mpv-service.ts
|
|
priority: medium
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
MpvIpcClient (761 lines) in src/core/services/mpv-service.ts has a 22-property `MpvIpcClientDeps` interface that reaches back into main.ts state for application-level concerns (overlay visibility, subtitle timing, media path updates, OSD display).
|
|
|
|
The class mixes two responsibilities:
|
|
1. **IPC Protocol**: Socket connection, JSON message framing, reconnection, property observation
|
|
2. **Application Integration**: Subtitle text broadcasting, overlay visibility sync, timing tracking
|
|
|
|
Separating these would let the protocol layer be simpler and testable, while application-level reactions to mpv events could be handled by listeners/callbacks registered externally.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [ ] #1 MpvIpcClient deps interface reduced to protocol-level concerns only
|
|
- [ ] #2 Application-level reactions (subtitle broadcast, overlay sync, timing) handled via event emitter or external listeners
|
|
- [ ] #3 MpvIpcClient is testable without mocking 22 callbacks
|
|
- [ ] #4 Existing behavior preserved
|
|
<!-- AC:END -->
|
|
|
|
## Final Summary
|
|
|
|
<!-- SECTION:FINAL_SUMMARY:BEGIN -->
|
|
Superseded by TASK-27.4 which absorbed this task's full scope (protocol/application separation, deps interface reduction from 22 properties to protocol-level concerns, event-based app reactions). All acceptance criteria met by TASK-27.4.
|
|
<!-- SECTION:FINAL_SUMMARY:END -->
|