mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-30 06:12:06 -07:00
sudacode
35adf8299c
* chore(backlog): add mining workflow milestone and tasks
* refactor: split character dictionary runtime modules
* refactor: split shared type entrypoints
* refactor: use bun serve for stats server
* feat: add repo-local subminer workflow plugin
* fix: add stats server node fallback
* refactor: split immersion tracker query modules
* chore: update backlog task records
* refactor: migrate shared type imports
* refactor: compose startup and setup window wiring
* Add backlog tasks and launcher time helper tests
- Track follow-up cleanup work in Backlog.md
- Replace Date.now usage with shared nowMs helper
- Add launcher args/parser and core regression tests
* test: increase launcher test timeout for CI stability
* fix: address CodeRabbit review feedback
* refactor(main): extract remaining inline runtime logic from main
* chore(backlog): update task notes and changelog fragment
* refactor: split main boot phases
* test: stabilize bun coverage reporting
* Switch plausible endpoint and harden coverage lane parsing
- update docs-site tracking to use the Plausible capture endpoint
- tighten coverage lane argument and LCOV parsing checks
- make script entrypoint use CommonJS main guard
* Restrict docs analytics and build coverage input
- limit Plausible init to docs.subminer.moe
- build Yomitan before src coverage lane
* fix(ci): normalize Windows shortcut paths for cross-platform tests
* Fix verification and immersion-tracker grouping
- isolate verifier artifacts and lease handling
- switch weekly/monthly tracker cutoffs to calendar boundaries
- tighten boot lifecycle and zip writer tests
* fix: resolve CI type failures in boot and immersion query tests
* fix: remove strict spread usage in Date mocks
* fix: use explicit super args for MockDate constructors
* Factor out mock date helper in tracker tests
- reuse a shared `withMockDate` helper for date-sensitive query tests
- make monthly rollup assertions key off `videoId` instead of row order
* fix: use variadic array type for MockDate constructor args
TS2367: fixed-length tuple made args.length === 0 unreachable.
* refactor: remove unused createMainBootRuntimes/Handlers aggregate functions
These functions were never called by production code — main.ts imports
the individual composeBoot* re-exports directly.
* refactor: remove boot re-export alias layer
main.ts now imports directly from the runtime/composers and runtime/domains
modules, eliminating the intermediate boot/ indirection.
* refactor: consolidate 3 near-identical setup window factories
Extract shared createSetupWindowHandler with a config parameter.
Public API unchanged.
* refactor: parameterize duplicated getAffected*Ids query helpers
Four structurally identical functions collapsed into two parameterized
helpers while preserving the existing public API.
* refactor: inline identity composers (stats-startup, overlay-window)
composeStatsStartupRuntime was a no-op that returned its input.
composeOverlayWindowHandlers was a 1-line delegation.
Both removed in favor of direct usage.
* chore: remove unused token/queue file path constants from main.ts
* fix: replace any types in boot services with proper signatures
* refactor: deduplicate ensureDir into shared/fs-utils
5 copies of mkdir-p-if-not-exists consolidated into one shared module
with ensureDir (directory path) and ensureDirForFile (file path) variants.
* fix: tighten type safety in boot services
- Add AppLifecycleShape and OverlayModalInputStateShape constraints
so TAppLifecycleApp and TOverlayModalInputState generics are bounded
- Remove unsafe `as { handleModalInputStateChange? }` cast — now
directly callable via the constraint
- Use `satisfies AppLifecycleShape` for structural validation on the
appLifecycleApp object literal
- Document Electron App.on incompatibility with simple signatures
* refactor: inline subtitle-prefetch-runtime-composer
The composer was a pure pass-through that destructured an object and
reassembled it with the same fields. Inlined at the call site.
* chore: consolidate duplicate import paths in main.ts
* test: extract mpv composer test fixture factory to reduce duplication
* test: add behavioral assertions to composer tests
Upgrade 8 composer test files from shape-only typeof checks to behavioral
assertions that invoke returned handlers and verify injected dependencies are
actually called, following the mpv-runtime-composer pattern.
* refactor: normalize import extensions in query modules
* refactor: consolidate toDbMs into query-shared.ts
* refactor: remove Node.js fallback from stats-server, use Bun only
* Fix monthly rollup test expectations
- Preserve multi-arg Date construction in mock helper
- Align rollup assertions with the correct videoId
* fix: address PR 36 CodeRabbit follow-ups
* fix: harden coverage lane cleanup
* fix(stats): fallback to node server when Bun.serve unavailable
* fix(ci): restore coverage lane compatibility
* chore(backlog): close TASK-242
* fix: address latest CodeRabbit review round
* fix: guard disabled immersion retention windows
* fix: migrate discord rpc wrapper
* fix(ci): add changelog fragment for PR 36
* fix: stabilize macOS visible overlay toggle
* fix: pin installed mpv plugin to current binary
* fix: strip inline subtitle markup from sidebar cues
* fix(renderer): restore subtitle sidebar mpv passthrough
* feat(discord): add configurable presence style presets
Replace the hardcoded "Mining and crafting (Anki cards)" meme message
with a preset system. New `discordPresence.presenceStyle` option
supports four presets: "default" (clean bilingual), "meme" (the OG
Minecraft joke), "japanese" (fully JP), and "minimal". The default
preset shows "Sentence Mining" with 日本語学習中 as the small image
tooltip. Existing users can set presenceStyle to "meme" to keep the
old behavior.
* fix: finalize v0.10.0 release prep
* docs: add subtitle sidebar guide and release note
* chore(backlog): mark docs task done
* fix: lazily resolve youtube playback socket path
* chore(release): build v0.10.0 changelog
* Revert "chore(release): build v0.10.0 changelog"
This reverts commit 9741c0f020.
142 lines
4.3 KiB
Markdown
142 lines
4.3 KiB
Markdown
---
|
|
name: 'subminer-change-verification'
|
|
description: 'Use when working in the SubMiner repo and you need to verify code changes actually work. Covers targeted regression checks during debugging and pre-handoff verification, with cheap-first lane selection for config, docs, launcher/plugin, runtime-compat, and optional real-runtime escalation.'
|
|
---
|
|
|
|
# SubMiner Change Verification
|
|
|
|
Canonical source: this plugin path.
|
|
|
|
Use this skill for SubMiner code changes. Default to cheap, repo-native verification first. Escalate only when the changed behavior actually depends on Electron, mpv, overlay/window tracking, or other GUI-sensitive runtime behavior.
|
|
|
|
## Scripts
|
|
|
|
- `scripts/classify_subminer_diff.sh`
|
|
- Emits suggested lanes and flags from explicit paths or current git changes.
|
|
- `scripts/verify_subminer_change.sh`
|
|
- Runs selected lanes, captures artifacts, and writes a compact summary.
|
|
|
|
If you need an explicit installed path, use the directory that contains this `SKILL.md`. The helper scripts live under:
|
|
|
|
```bash
|
|
export SUBMINER_VERIFY_SKILL="<path-to-plugin-skill>"
|
|
```
|
|
|
|
## Default workflow
|
|
|
|
1. Inspect the changed files or user-requested area.
|
|
2. Run the classifier unless you already know the right lane.
|
|
3. Run the verifier with the cheapest sufficient lane set.
|
|
4. If the classifier emits `flag:real-runtime-candidate`, do not jump straight to runtime verification. First run the non-runtime lanes.
|
|
5. Escalate to explicit `--lane real-runtime --allow-real-runtime` only when cheaper lanes cannot validate the behavior claim.
|
|
6. Return:
|
|
- verification summary
|
|
- exact commands run
|
|
- artifact paths
|
|
- skipped lanes and blockers
|
|
|
|
## Quick start
|
|
|
|
Plugin-source quick start:
|
|
|
|
```bash
|
|
bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/classify_subminer_diff.sh
|
|
```
|
|
|
|
Installed-skill quick start:
|
|
|
|
```bash
|
|
bash "$SUBMINER_VERIFY_SKILL/scripts/classify_subminer_diff.sh"
|
|
```
|
|
|
|
Compatibility entrypoint:
|
|
|
|
```bash
|
|
bash .agents/skills/subminer-change-verification/scripts/classify_subminer_diff.sh
|
|
```
|
|
|
|
Classify explicit files:
|
|
|
|
```bash
|
|
bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/classify_subminer_diff.sh \
|
|
launcher/main.ts \
|
|
plugin/subminer/lifecycle.lua \
|
|
src/main/runtime/mpv-client-runtime-service.ts
|
|
```
|
|
|
|
Run automatic lane selection:
|
|
|
|
```bash
|
|
bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh
|
|
```
|
|
|
|
Installed-skill form:
|
|
|
|
```bash
|
|
bash "$SUBMINER_VERIFY_SKILL/scripts/verify_subminer_change.sh"
|
|
```
|
|
|
|
Compatibility entrypoint:
|
|
|
|
```bash
|
|
bash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh
|
|
```
|
|
|
|
Run targeted lanes:
|
|
|
|
```bash
|
|
bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh \
|
|
--lane launcher-plugin \
|
|
--lane runtime-compat
|
|
```
|
|
|
|
Dry-run to inspect planned commands and artifact layout:
|
|
|
|
```bash
|
|
bash plugins/subminer-workflow/skills/subminer-change-verification/scripts/verify_subminer_change.sh \
|
|
--dry-run \
|
|
launcher/main.ts \
|
|
src/main.ts
|
|
```
|
|
|
|
## Lane guidance
|
|
|
|
- `docs`
|
|
- For `docs-site/`, `docs/`, and doc-only edits.
|
|
- `config`
|
|
- For `src/config/` and config-template-sensitive edits.
|
|
- `core`
|
|
- For general source changes where `typecheck` + `test:fast` is the best cheap signal.
|
|
- `launcher-plugin`
|
|
- For `launcher/`, `plugin/subminer/`, plugin gating scripts, and wrapper/mpv routing work.
|
|
- `runtime-compat`
|
|
- For `src/main*`, runtime/composer wiring, mpv/overlay services, window trackers, and dist-sensitive behavior.
|
|
- `real-runtime`
|
|
- Only after deliberate escalation.
|
|
|
|
## Real Runtime Escalation
|
|
|
|
Escalate only when the change claim depends on actual runtime behavior, for example:
|
|
|
|
- overlay appears, hides, or tracks a real mpv window
|
|
- mpv launch flags or pause-until-ready behavior
|
|
- plugin/socket/auto-start handshake under a real player
|
|
- macOS/window-tracker/focus-sensitive behavior
|
|
|
|
If the environment cannot support authoritative runtime verification, report the blocker explicitly. Do not silently downgrade a runtime-required claim to a pass.
|
|
|
|
## Artifact contract
|
|
|
|
The verifier writes under `.tmp/skill-verification/<timestamp>/`:
|
|
|
|
- `summary.json`
|
|
- `summary.txt`
|
|
- `classification.txt`
|
|
- `env.txt`
|
|
- `lanes.txt`
|
|
- `steps.tsv`
|
|
- `steps/*.stdout.log`
|
|
- `steps/*.stderr.log`
|
|
|
|
On failure, quote the exact failing command and point at the artifact directory.
|