mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-20 12:11:28 -07:00
sudacode
e59192bbe1
- show a dedicated startup OSD "building" phase for character dictionary sync - forward bare `Tab` from visible overlay to mpv so AniSkip works while focused - fix Windows plugin env override resolution for `SUBMINER_BINARY_PATH`
1.4 KiB
1.4 KiB
id, title, status, assignee, created_date, updated_date, labels, dependencies, priority
| id | title | status | assignee | created_date | updated_date | labels | dependencies | priority | ||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-148 | Fix Windows plugin env binary override resolution | Done |
|
2026-03-09 00:00 | 2026-03-09 00:00 |
|
medium |
Description
Fix the mpv plugin's Windows binary override lookup so SUBMINER_BINARY_PATH still resolves when SUBMINER_APPIMAGE_PATH is unset. The current Lua resolver builds an array with a leading nil, which causes ipairs iteration to stop before the later Windows override candidate.
Acceptance Criteria
- #1
scripts/test-plugin-binary-windows.luapasses the env override regression that expects.exesuffix resolution fromSUBMINER_BINARY_PATH. - #2 Existing plugin start/binary test gate stays green after the fix.
Final Summary
Updated plugin/subminer/binary.lua so env override lookup checks SUBMINER_APPIMAGE_PATH and SUBMINER_BINARY_PATH sequentially instead of via a Lua array literal that truncates at the first nil. This restores Windows .exe suffix resolution for SUBMINER_BINARY_PATH when the AppImage env var is unset.
Verification:
lua scripts/test-plugin-binary-windows.luabun run test:plugin:src