mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-02-27 18:22:41 -08:00
45 lines
1.4 KiB
Markdown
45 lines
1.4 KiB
Markdown
---
|
|
id: TASK-73
|
|
title: Consolidate launcher mpv socket readiness primitives
|
|
status: Done
|
|
assignee: []
|
|
created_date: '2026-02-18 11:35'
|
|
updated_date: '2026-02-21 20:19'
|
|
labels:
|
|
- launcher
|
|
- mpv
|
|
- refactor
|
|
dependencies: []
|
|
priority: medium
|
|
---
|
|
|
|
## Description
|
|
|
|
<!-- SECTION:DESCRIPTION:BEGIN -->
|
|
Launcher contains multiple overlapping MPV readiness/polling helpers (`waitForSocket`, `waitForPathExists`, `waitForUnixSocketReady`) with mixed timeout/poll semantics. Consolidation needed for clarity and lower maintenance.
|
|
<!-- SECTION:DESCRIPTION:END -->
|
|
|
|
## Action Steps
|
|
|
|
<!-- SECTION:PLAN:BEGIN -->
|
|
1. Define one canonical socket readiness contract (existence + connectability + timeout).
|
|
2. Replace duplicate polling helpers with a single implementation.
|
|
3. Update all callsites (`mpv status`, idle launch flow, subtitle loading dependencies).
|
|
4. Keep user-visible behavior and exit codes stable.
|
|
5. Add focused tests for timeout and success/failure edge cases.
|
|
<!-- SECTION:PLAN:END -->
|
|
|
|
## Acceptance Criteria
|
|
<!-- AC:BEGIN -->
|
|
- [x] #1 Single canonical MPV socket readiness helper remains
|
|
- [x] #2 All launcher callsites use unified helper
|
|
- [x] #3 Behavior/exit code compatibility maintained for CLI flows
|
|
- [x] #4 Test coverage added for readiness timeout behavior
|
|
<!-- AC:END -->
|
|
|
|
## Definition of Done
|
|
<!-- DOD:BEGIN -->
|
|
- [x] #1 Launcher tests pass
|
|
- [x] #2 No dead helper functions remain
|
|
<!-- DOD:END -->
|