Files
SubMiner/scripts/test-plugin-binary-windows.lua
T
sudacode b1bdeabca8 fix(jellyfin): show overlay, inject plugin, and fix stats title on playback (#77)
* fix(jellyfin): show overlay, inject plugin, and fix stats title on playb

- Show visible overlay automatically during Jellyfin playback so subtitleStyle applies
- Inject bundled mpv plugin on auto-launch so keybindings work without overlay focus
- Group Jellyfin playback stats under item metadata (jellyfin://host/item/id) instead of stream URLs so episodes merge with matching local titles
- Mark ffsubsync unavailable in subsync modal for remote media paths
- Drain queued second-instance commands even when onReady throws

* fix(overlay): stabilize macOS focus handoff and sidebar Yomitan pause

- Keep overlay visible during macOS foreground probe after overlay blur
- Hold sidebar hover-pause while a Yomitan lookup popup remains open

* fix(jellyfin): fix discovery loop, device identity, tray state, and Disc

- Derive device identity from OS hostname; remove legacy configurable client/device fields
- Prevent discovery playback from reloading active item, misreporting pause state, and duplicate overlay restores
- Restart stale tray discovery sessions without re-login when server drops SubMiner cast target
- Sync tray discovery checkbox state on Linux after CLI/startup/remote-session changes
- Stop Discord presence falling back to stream URLs; prime title before tokenized stream loads
- Fix picker library discovery when log level is above info
- Fix config.example.jsonc trailing commas and array formatting

* docs(release): trim and consolidate prerelease notes for 0.15.0

- Remove breaking changes section and several redundant bullet points
- Consolidate per-platform updater notes into a single entry
- Normalize em-dash separators to hyphens in section headers

* fix(config): remove trailing commas from config.example.jsonc

- Strip trailing commas throughout both config.example.jsonc copies
- Reformat inline arrays to multi-line for JSON strictness
- Update Jellyfin subtitle preload and playback launch tests and impl

* fix(tokenizer): preserve known-word highlight when POS filters suppress

- Known-word cache matches now set isKnown=true even for tokens excluded by POS filters
- POS exclusion gate suppresses N+1, frequency, and JLPT only; known status is computed before the gate
- Jellyfin subtitle preload continues after cleanup failures instead of aborting
- Update config docs and option description to document the known-word bypass behavior

* fix(jellyfin): send explicit hide/show overlay instead of toggle

- Track overlay visibility in plugin state; y-t uses explicit hide/show commands when state is known
- Prevent paused Jellyfin playback from resuming on overlay hide
- Fix subtitle cache cleanup to only remove dirs after successful cleanup

* fix(jellyfin): fix remote progress sync, seek reporting, and startup sto

- arm active playback before loadfile with loadedMediaPath: null to suppress premature stop events
- force immediate progress report on seek-like position jumps at the mpv time-pos level
- send positionTicks and failed=false in reportStopped payload
- remove EventName from HTTP timeline payloads (websocket-only field)
- add startup grace window to drop stop events before media finishes loading

* fix(jellyfin): fix overlay toggle sync, redirect reload, and AppImage bi

- Sync visible-overlay state back to plugin via script messages to avoid toggle/hide drift
- Collapse duplicate toggle events within 250ms to prevent hide-then-show on single keypress
- Preserve manual hide across Jellyfin path-changing redirects even when media-title drops
- Rearm managed subtitle defaults on path-changing redirects
- Route toggleVisibleOverlay session binding through plugin toggle instead of app-side IPC
- Show Linux/Hyprland overlay passively (showInactive) to avoid stealing mpv keyboard focus
- Fix AppImage binary resolution to prefer $APPIMAGE env over mounted inner binary
- Add stats window layer management so delete/update dialogs appear above stats window
- Fix Jellyfin remote progress sync during Linux websocket reconnect windows

* Fix CodeRabbit review feedback

* fix(jellyfin): subtitle timing, resume progress, and overlay sync

- Add per-stream subtitle delay persistence and auto timeline-offset correction
- Strip server-selected subtitle stream from mpv load URL; suppress plugin subtitle rearm and auto-start during app-managed preload
- Fix resume position lost when mpv resets on stop; use last known position for final progress/stopped reports
- Keep Play vs Resume distinct to avoid early seek race on normal play
- Fix discovery resume when remote play sends StartPositionTicks=0 despite saved progress
- Deduplicate show/hide overlay commands using recorded visibility state
- Rewrite docs-site Jellyfin page around cast-to-device UX

* test: update lifecycle cleanup assertion

* fix: clear aborted playback state, fix overlay passthrough, and guard du

- Reset app_managed_playback_pending on lifecycle cleanup to prevent state leak into next item
- Record visible overlay action only after command succeeds, not before
- Non-native passive overlay now always click-through on re-show (fix isNonNativePassiveOverlay ordering)
- Defer activeParsedSubtitleMediaPath assignment until after prefetch completes
- Move autoplay gate release into the hide branch of toggleVisibleOverlay
- Clear active Jellyfin playback when stopping media that never loaded
- Reset managed subtitle delay and delay key when no external tracks are available
- Await async removeDir in subtitle cache cleanup
- Guard duplicate delete clicks in MediaDetailView and SessionsTab with refs
- Escape key in DeleteConfirmDialog now calls stopPropagation and stopImmediatePropagation
2026-05-24 18:40:56 -07:00

249 lines
5.9 KiB
Lua

local function assert_equal(actual, expected, message)
if actual == expected then
return
end
error((message or "assert_equal failed") .. "\nexpected: " .. tostring(expected) .. "\nactual: " .. tostring(actual))
end
local function assert_true(condition, message)
if condition then
return
end
error(message or "assert_true failed")
end
local function with_env(env, callback)
local original_getenv = os.getenv
os.getenv = function(name)
local value = env[name]
if value ~= nil then
return value
end
return original_getenv(name)
end
local ok, result = pcall(callback)
os.getenv = original_getenv
if not ok then
error(result)
end
return result
end
local function create_binary_module(config)
local binary_module = dofile("plugin/subminer/binary.lua")
local entries = config.entries or {}
local binary = binary_module.create({
mp = config.mp,
utils = {
file_info = function(path)
local entry = entries[path]
if entry == "file" then
return { is_dir = false }
end
if entry == "dir" then
return { is_dir = true }
end
return nil
end,
join_path = function(...)
return table.concat({ ... }, "\\")
end,
},
opts = {
binary_path = config.binary_path or "",
},
state = {},
environment = {
is_windows = function()
return config.is_windows == true
end,
},
log = {
subminer_log = function() end,
},
})
return binary
end
do
local appimage_path = "/home/tester/.local/bin/SubMiner.AppImage"
local mounted_binary_path = "/tmp/.mount_SubMiner/SubMiner"
local resolved = with_env({
APPIMAGE = appimage_path,
}, function()
local binary = create_binary_module({
is_windows = false,
binary_path = mounted_binary_path,
entries = {
[appimage_path] = "file",
[mounted_binary_path] = "file",
},
})
return binary.find_binary()
end)
assert_equal(
resolved,
appimage_path,
"linux resolver should prefer APPIMAGE over the mounted AppImage inner binary"
)
end
do
local binary = create_binary_module({
is_windows = true,
binary_path = "C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner",
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
assert_equal(
binary.find_binary(),
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"windows resolver should append .exe for configured binary_path"
)
end
do
local binary = create_binary_module({
is_windows = true,
mp = {
command_native = function(command)
local args = command.args or {}
if args[1] == "powershell.exe" then
return {
status = 0,
stdout = "C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe\n",
stderr = "",
}
end
return {
status = 1,
stdout = "",
stderr = "unexpected command",
}
end,
},
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
assert_equal(
binary.find_binary(),
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"windows resolver should recover binary from running SubMiner process"
)
end
do
local binary = create_binary_module({
is_windows = true,
binary_path = "C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner",
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner"] = "dir",
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
assert_equal(
binary.find_binary(),
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"windows resolver should accept install directory binary_path"
)
end
do
local resolved = with_env({
LOCALAPPDATA = "C:\\Users\\tester\\AppData\\Local",
HOME = "",
USERPROFILE = "C:\\Users\\tester",
ProgramFiles = "C:\\Program Files",
["ProgramFiles(x86)"] = "C:\\Program Files (x86)",
}, function()
local binary = create_binary_module({
is_windows = true,
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
return binary.find_binary()
end)
assert_equal(
resolved,
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"windows auto-detection should probe LOCALAPPDATA install path"
)
end
do
local resolved = with_env({
APPDATA = "C:\\Users\\tester\\AppData\\Roaming",
LOCALAPPDATA = "",
HOME = "",
USERPROFILE = "C:\\Users\\tester",
ProgramFiles = "C:\\Program Files",
["ProgramFiles(x86)"] = "C:\\Program Files (x86)",
}, function()
local binary = create_binary_module({
is_windows = true,
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
return binary.find_binary()
end)
assert_equal(
resolved,
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"windows auto-detection should derive Local install path from APPDATA"
)
end
do
local resolved = with_env({
SUBMINER_BINARY_PATH = "C:\\Portable\\SubMiner\\SubMiner",
}, function()
local binary = create_binary_module({
is_windows = true,
entries = {
["C:\\Portable\\SubMiner\\SubMiner.exe"] = "file",
},
})
return binary.find_binary()
end)
assert_equal(
resolved,
"C:\\Portable\\SubMiner\\SubMiner.exe",
"windows env override should resolve .exe suffix"
)
end
do
local binary = create_binary_module({
is_windows = true,
binary_path = "C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner",
entries = {
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner"] = "dir",
["C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe"] = "file",
},
})
assert_true(binary.ensure_binary_available() == true, "ensure_binary_available should cache discovered windows binary")
assert_equal(
binary.find_binary(),
"C:\\Users\\tester\\AppData\\Local\\Programs\\SubMiner\\SubMiner.exe",
"ensure_binary_available should not break follow-up lookup"
)
end
print("plugin windows binary resolver tests: OK")