mirror of
https://github.com/ksyasuda/SubMiner.git
synced 2026-03-20 12:11:28 -07:00
sudacode
a954f62f55
- Run `subminer stats -b` as a dedicated daemon process, independent from the overlay app - Stop Anki progress spinner before showing final `✓`/`x` mine result so it is not overwritten - Keep grammar/noise subtitle tokens hoverable while stripping annotation metadata
2.9 KiB
2.9 KiB
id, title, status, assignee, created_date, updated_date, labels, milestone, dependencies, references, priority, ordinal
| id | title | status | assignee | created_date | updated_date | labels | milestone | dependencies | references | priority | ordinal | |||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| TASK-195 | Keep final card-mine OSD result from being overwritten by progress spinner | Done |
|
2026-03-18 19:40 | 2026-03-18 19:49 |
|
m-1 |
|
medium | 105610 |
Description
When a card mine finishes, the mpv OSD currently tries to show the final status text but the in-flight Anki progress spinner can immediately overwrite it on the next tick. Stop the spinner first, then show a single-line final result with a success/failure marker and the mined-word notification.
Acceptance Criteria
- #1 Successful mine/update OSD results render after the spinner is stopped and do not get overwritten by a later spinner tick.
- #2 Failure results that replace the spinner show an
xmarker and stay visible on the same OSD line. - #3 Regression coverage locks the spinner teardown/result-notification ordering.
Implementation Plan
- Add a focused failing regression test around the Anki UI-feedback spinner/result helper.
- Add a helper that stops progress before emitting the final OSD result line with
✓/x. - Route mine/update result notifications through that helper, then run targeted verification.
Outcome
Added a dedicated Anki UI-feedback result helper that force-clears the in-flight spinner state before emitting the final OSD result line. Successful card-update notifications now render as ✓ Updated card: ..., and sentence-card creation failures now render as x Sentence card failed: ... without a later spinner tick reclaiming the line.
Verification:
bun test src/anki-integration/ui-feedback.test.tsbun test src/anki-integration/ui-feedback.test.ts src/anki-integration/note-update-workflow.test.ts src/anki-integration.test.ts src/core/services/mining.test.ts src/main/runtime/mining-actions.test.tsbun x prettier --check src/anki-integration/ui-feedback.ts src/anki-integration/ui-feedback.test.ts src/anki-integration.ts src/anki-integration/card-creation.ts "backlog/tasks/task-195 - Keep-final-card-mine-OSD-result-from-being-overwritten-by-progress-spinner.md" changes/2026-03-18-mine-osd-spinner-result.mdbun run changelog:lintbash .agents/skills/subminer-change-verification/scripts/verify_subminer_change.sh --lane core src/anki-integration/ui-feedback.ts src/anki-integration/ui-feedback.test.ts src/anki-integration.ts src/anki-integration/card-creation.ts changes/2026-03-18-mine-osd-spinner-result.md- Verifier artifacts:
.tmp/skill-verification/subminer-verify-20260318-194614-uZMrAx/