refactor: extract config warning log formatter

src/core/services/config-warning-runtime-service.test.ts

@@ -0,0 +1,34 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import {
+  formatConfigWarningRuntimeService,
+  logConfigWarningRuntimeService,
+} from "./config-warning-runtime-service";
+
+test("formatConfigWarningRuntimeService formats warning line", () => {
+  const message = formatConfigWarningRuntimeService({
+    path: "ankiConnect.enabled",
+    value: "oops",
+    fallback: true,
+    message: "invalid type",
+  });
+  assert.equal(
+    message,
+    '[config] ankiConnect.enabled: invalid type value="oops" fallback=true',
+  );
+});
+
+test("logConfigWarningRuntimeService delegates to logger", () => {
+  const logs: string[] = [];
+  logConfigWarningRuntimeService(
+    {
+      path: "x.y",
+      value: 1,
+      fallback: 2,
+      message: "bad",
+    },
+    (line) => logs.push(line),
+  );
+  assert.equal(logs.length, 1);
+  assert.match(logs[0], /^\[config\] x\.y: bad /);
+});

src/core/services/config-warning-runtime-service.ts

@@ -0,0 +1,14 @@
+import { ConfigValidationWarning } from "../../types";
+
+export function formatConfigWarningRuntimeService(
+  warning: ConfigValidationWarning,
+): string {
+  return `[config] ${warning.path}: ${warning.message} value=${JSON.stringify(warning.value)} fallback=${JSON.stringify(warning.fallback)}`;
+}
+
+export function logConfigWarningRuntimeService(
+  warning: ConfigValidationWarning,
+  log: (message: string) => void,
+): void {
+  log(formatConfigWarningRuntimeService(warning));
+}

src/main.ts

@@ -206,6 +206,7 @@ import { runAppShutdownRuntimeService } from "./core/services/app-shutdown-runti
 import { createMpvIpcClientDepsRuntimeService } from "./core/services/mpv-client-deps-runtime-service";
 import { createAppLifecycleDepsRuntimeService } from "./core/services/app-lifecycle-deps-runtime-service";
 import { createRuntimeOptionsManagerRuntimeService } from "./core/services/runtime-options-manager-runtime-service";
+import { logConfigWarningRuntimeService } from "./core/services/config-warning-runtime-service";
 import {
   runSubsyncManualFromIpcRuntimeService,
   triggerSubsyncFromConfigRuntimeService,
@@ -533,9 +534,7 @@ if (initialArgs.generateConfig && !shouldStartApp(initialArgs)) {
         getResolvedConfig: () => getResolvedConfig(),
         getConfigWarnings: () => configService.getWarnings(),
         logConfigWarning: (warning) => {
-          console.warn(
-            `[config] ${warning.path}: ${warning.message} value=${JSON.stringify(warning.value)} fallback=${JSON.stringify(warning.fallback)}`,
-          );
+          logConfigWarningRuntimeService(warning, (line) => console.warn(line));
         },
         initRuntimeOptionsManager: () => {
           runtimeOptionsManager = createRuntimeOptionsManagerRuntimeService({