diff --git a/package.json b/package.json index 869f29d..7f06fee 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "docs:build": "vitepress build docs", "docs:preview": "vitepress preview docs --host 0.0.0.0 --port 4173 --strictPort", "test:config": "pnpm run build && node --test dist/config/config.test.js", - "test:core": "pnpm run build && node --test dist/cli/args.test.js dist/cli/help.test.js dist/core/services/cli-command-service.test.js dist/core/services/numeric-shortcut-session-service.test.js dist/core/services/secondary-subtitle-service.test.js dist/core/services/mpv-render-metrics-service.test.js dist/core/services/mpv-runtime-service.test.js dist/core/services/runtime-options-runtime-service.test.js dist/core/services/overlay-modal-restore-service.test.js dist/core/services/runtime-config-service.test.js dist/core/services/overlay-bridge-runtime-service.test.js dist/core/services/overlay-visibility-facade-service.test.js dist/core/services/overlay-broadcast-runtime-service.test.js dist/core/services/app-ready-runtime-service.test.js dist/core/services/app-shutdown-runtime-service.test.js dist/core/services/mpv-client-deps-runtime-service.test.js dist/core/services/app-lifecycle-deps-runtime-service.test.js dist/core/services/runtime-options-manager-runtime-service.test.js", + "test:core": "pnpm run build && node --test dist/cli/args.test.js dist/cli/help.test.js dist/core/services/cli-command-service.test.js dist/core/services/numeric-shortcut-session-service.test.js dist/core/services/secondary-subtitle-service.test.js dist/core/services/mpv-render-metrics-service.test.js dist/core/services/mpv-runtime-service.test.js dist/core/services/runtime-options-runtime-service.test.js dist/core/services/overlay-modal-restore-service.test.js dist/core/services/runtime-config-service.test.js dist/core/services/overlay-bridge-runtime-service.test.js dist/core/services/overlay-visibility-facade-service.test.js dist/core/services/overlay-broadcast-runtime-service.test.js dist/core/services/app-ready-runtime-service.test.js dist/core/services/app-shutdown-runtime-service.test.js dist/core/services/mpv-client-deps-runtime-service.test.js dist/core/services/app-lifecycle-deps-runtime-service.test.js dist/core/services/runtime-options-manager-runtime-service.test.js dist/core/services/config-warning-runtime-service.test.js", "test:subtitle": "pnpm run build && node --test dist/subtitle/stages.test.js dist/subtitle/pipeline.test.js", "generate:config-example": "pnpm run build && node dist/generate-config-example.js", "start": "pnpm run build && electron . --start", diff --git a/src/core/services/config-warning-runtime-service.test.ts b/src/core/services/config-warning-runtime-service.test.ts new file mode 100644 index 0000000..8181886 --- /dev/null +++ b/src/core/services/config-warning-runtime-service.test.ts @@ -0,0 +1,34 @@ +import test from "node:test"; +import assert from "node:assert/strict"; +import { + formatConfigWarningRuntimeService, + logConfigWarningRuntimeService, +} from "./config-warning-runtime-service"; + +test("formatConfigWarningRuntimeService formats warning line", () => { + const message = formatConfigWarningRuntimeService({ + path: "ankiConnect.enabled", + value: "oops", + fallback: true, + message: "invalid type", + }); + assert.equal( + message, + '[config] ankiConnect.enabled: invalid type value="oops" fallback=true', + ); +}); + +test("logConfigWarningRuntimeService delegates to logger", () => { + const logs: string[] = []; + logConfigWarningRuntimeService( + { + path: "x.y", + value: 1, + fallback: 2, + message: "bad", + }, + (line) => logs.push(line), + ); + assert.equal(logs.length, 1); + assert.match(logs[0], /^\[config\] x\.y: bad /); +}); diff --git a/src/core/services/config-warning-runtime-service.ts b/src/core/services/config-warning-runtime-service.ts new file mode 100644 index 0000000..5cc44bd --- /dev/null +++ b/src/core/services/config-warning-runtime-service.ts @@ -0,0 +1,14 @@ +import { ConfigValidationWarning } from "../../types"; + +export function formatConfigWarningRuntimeService( + warning: ConfigValidationWarning, +): string { + return `[config] ${warning.path}: ${warning.message} value=${JSON.stringify(warning.value)} fallback=${JSON.stringify(warning.fallback)}`; +} + +export function logConfigWarningRuntimeService( + warning: ConfigValidationWarning, + log: (message: string) => void, +): void { + log(formatConfigWarningRuntimeService(warning)); +} diff --git a/src/main.ts b/src/main.ts index 048e123..7031fd7 100644 --- a/src/main.ts +++ b/src/main.ts @@ -206,6 +206,7 @@ import { runAppShutdownRuntimeService } from "./core/services/app-shutdown-runti import { createMpvIpcClientDepsRuntimeService } from "./core/services/mpv-client-deps-runtime-service"; import { createAppLifecycleDepsRuntimeService } from "./core/services/app-lifecycle-deps-runtime-service"; import { createRuntimeOptionsManagerRuntimeService } from "./core/services/runtime-options-manager-runtime-service"; +import { logConfigWarningRuntimeService } from "./core/services/config-warning-runtime-service"; import { runSubsyncManualFromIpcRuntimeService, triggerSubsyncFromConfigRuntimeService, @@ -533,9 +534,7 @@ if (initialArgs.generateConfig && !shouldStartApp(initialArgs)) { getResolvedConfig: () => getResolvedConfig(), getConfigWarnings: () => configService.getWarnings(), logConfigWarning: (warning) => { - console.warn( - `[config] ${warning.path}: ${warning.message} value=${JSON.stringify(warning.value)} fallback=${JSON.stringify(warning.fallback)}`, - ); + logConfigWarningRuntimeService(warning, (line) => console.warn(line)); }, initRuntimeOptionsManager: () => { runtimeOptionsManager = createRuntimeOptionsManagerRuntimeService({