From ff8734cd34dc2461dd0415af2db8e667ff08494d Mon Sep 17 00:00:00 2001 From: Simon Lecoq <22963968+lowlighter@users.noreply.github.com> Date: Fri, 9 Apr 2021 12:09:12 +0200 Subject: [PATCH] Fix "merged" state in activity plugin (#218) --- source/plugins/activity/index.mjs | 4 ++-- source/templates/classic/partials/activity.ejs | 2 +- source/templates/markdown/partials/activity.ejs | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/source/plugins/activity/index.mjs b/source/plugins/activity/index.mjs index 445cd6c8..3793e51e 100644 --- a/source/plugins/activity/index.mjs +++ b/source/plugins/activity/index.mjs @@ -88,8 +88,8 @@ case "PullRequestEvent":{ if (!["opened", "closed"].includes(payload.action)) return null - const {action, pull_request:{user:{login:user}, title, number, additions:added, deletions:deleted, changed_files:changed}} = payload - return {type:"pr", actor, timestamp, repo, action, user, title, number, lines:{added, deleted}, files:{changed}} + const {action, pull_request:{user:{login:user}, title, number, additions:added, deletions:deleted, changed_files:changed, merged}} = payload + return {type:"pr", actor, timestamp, repo, action:(action === "closed")&&(merged) ? "merged" : action, user, title, number, lines:{added, deleted}, files:{changed}} } //Reviewed a pull request case "PullRequestReviewEvent":{ diff --git a/source/templates/classic/partials/activity.ejs b/source/templates/classic/partials/activity.ejs index b758ed90..b20e8d54 100644 --- a/source/templates/classic/partials/activity.ejs +++ b/source/templates/classic/partials/activity.ejs @@ -69,7 +69,7 @@
- <%- event.action === "opened" ? `${_("O")}pened` : `${_("M")}erged` %> #<%= event.number %> <%= event.title %> + <%- event.action === "opened" ? `${_("O")}pened` : event.action === "merged" ? `${_("M")}erged` : `${_("C")}losed` %> #<%= event.number %> <%= event.title %>
diff --git a/source/templates/markdown/partials/activity.ejs b/source/templates/markdown/partials/activity.ejs index 4f070a6e..a8d09c14 100644 --- a/source/templates/markdown/partials/activity.ejs +++ b/source/templates/markdown/partials/activity.ejs @@ -22,7 +22,7 @@ <%_ } else if (type === "issue") { _%> * #️⃣ <%- event.action === "opened" ? "Opened" : event.action === "reopened" ? "Reopened" : "Closed" %> [#<%= event.number %> <%= event.title %>](https://github.com/<%= repo %>/issues/<%= event.number %>) in [<%= repo %>](https://github.com/<%= repo %>) <%_ } else if (type === "pr") { _%> -* 🔃 <%- event.action === "opened" ? "Opened" : "Merged" %> [#<%= event.number %> <%= event.title %>](https://github.com/<%= repo %>/pull/<%= event.number %>) in [<%= repo %>](https://github.com/<%= repo %>) +* 🔃 <%- event.action === "opened" ? "Opened" : event.action === "merged" ? "Merged" : "Closed" %> [#<%= event.number %> <%= event.title %>](https://github.com/<%= repo %>/pull/<%= event.number %>) in [<%= repo %>](https://github.com/<%= repo %>) * <%= event.files.changed %> file<%= s(event.files.changed) %> changed `++<%= event.lines.added %> --<%= event.lines.deleted%>` <%_ } else if (type === "wiki") { _%> * 📝 Updated <%= event.pages.length %> wiki page<%= s(event.pages.length) %> in [<%= repo %>](https://github.com/<%= repo %>/wiki)