sudacode/metrics
1
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Add explicit timeout error message from GitHub API

Browse Source
This commit is contained in:
lowlighter
2021-04-14 13:10:47 +02:00
parent 9899c90520
commit 11a7bed722
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
source/app/web/instance.mjs
View File

@@ -196,6 +196,12 @@
console.debug(`metrics/app/${login} > 404 (user/organization not found)`) console.debug(`metrics/app/${login} > 404 (user/organization not found)`)
return res.status(404).send("Not found: unknown user or organization") return res.status(404).send("Not found: unknown user or organization")
} }
//GitHub failed request
if ((error instanceof Error)&&(/this may be the result of a timeout, or it could be a GitHub bug/i.test(error.errors?.[0]?.message))) {
console.debug(`metrics/app/${login} > 502 (bad gateway from GitHub)`)
const {request} = error.errors[0].message.match(/`(?<request>[\w:]+)`/)?.groups ?? null
return res.status(502).send(`Bad Gateway: GitHub failed to execute request ${request} (this may be the result of a timeout, or it could be a GitHub bug)`)
}
//General error //General error
console.error(error) console.error(error)
return res.status(500).send("Internal Server Error: failed to process metrics correctly") return res.status(500).send("Internal Server Error: failed to process metrics correctly")
@@ -278,6 +284,12 @@
console.debug(`metrics/app/${login} > 400 (bad request)`) console.debug(`metrics/app/${login} > 400 (bad request)`)
return res.status(400).send("Bad request: unsupported template") return res.status(400).send("Bad request: unsupported template")
} }
//GitHub failed request
if ((error instanceof Error)&&(/this may be the result of a timeout, or it could be a GitHub bug/i.test(error.errors?.[0]?.message))) {
console.debug(`metrics/app/${login} > 502 (bad gateway from GitHub)`)
const {request} = error.errors[0].message.match(/`(?<request>[\w:]+)`/)?.groups ?? null
return res.status(502).send(`Bad Gateway: GitHub failed to execute request ${request} (this may be the result of a timeout, or it could be a GitHub bug)`)
}
//General error //General error
console.error(error) console.error(error)
return res.status(500).send("Internal Server Error: failed to process metrics correctly") return res.status(500).send("Internal Server Error: failed to process metrics correctly")

2
source/app/web/statics/about/script.js
View File

@@ -66,7 +66,7 @@
this.metrics = (await axios.get(`/about/query/${this.user}`)).data this.metrics = (await axios.get(`/about/query/${this.user}`)).data
} }
catch (error) { catch (error) {
this.error = error this.error = {code:error.response.status, message:error.response.data}
} }
finally { finally {
this.pending = false this.pending = false