Release 1.79.0 (#485)

* Add value column

* Update changelog

CHANGELOG.md

@@ -5,6 +5,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.79.0 - 21.11.2021
+
+### Added
+
+- Added the value column to the positions table
+- Added support for cryptocurrency _Algorand_
+
+### Changed
+
+- Locked the symbol input in the edit transaction dialog
+- Filtered the account selector by account type (`SECURITIES`) in the create or edit transaction dialog
+
+### Fixed
+
+- Fixed the search functionality for cryptocurrency symbols (do not show unsupported symbols)
+
 ## 1.78.0 - 20.11.2021
 
 ### Added

apps/api/src/services/cryptocurrency/custom-cryptocurrencies.json

@@ -1,5 +1,6 @@
 {
   "1INCH": "1inch",
+  "ALGO": "Algorand",
   "AVAX": "Avalanche",
   "MATIC": "Polygon",
   "SHIB": "Shiba Inu"

apps/api/src/services/data-provider/yahoo-finance/yahoo-finance.service.ts

@@ -197,16 +197,20 @@ export class YahooFinanceService implements DataProviderInterface {
           // filter out undefined symbols
           return quote.symbol;
         })
-        .filter(({ quoteType }) => {
+        .filter(({ quoteType, symbol }) => {
           return (
-            quoteType === 'CRYPTOCURRENCY' ||
+            (quoteType === 'CRYPTOCURRENCY' &&
+              this.cryptocurrencyService.isCrypto(
+                symbol.replace(new RegExp('-USD$'), 'USD').replace('1', '')
+              )) ||
             quoteType === 'EQUITY' ||
             quoteType === 'ETF'
           );
         })
         .filter(({ quoteType, symbol }) => {
           if (quoteType === 'CRYPTOCURRENCY') {
-            // Only allow cryptocurrencies in USD
+            // Only allow cryptocurrencies in USD to avoid having redundancy in the database.
+            // Trades need to be converted manually before to USD (or a UI converter needs to be developed)
             return symbol.includes('USD');
           }
 
@@ -254,14 +258,15 @@ export class YahooFinanceService implements DataProviderInterface {
       if (isCurrency(aSymbol.substring(0, aSymbol.length - 3))) {
         return `${aSymbol}=X`;
       } else if (
-        this.cryptocurrencyService.isCrypto(aSymbol) ||
+        this.cryptocurrencyService.isCrypto(
-        this.cryptocurrencyService.isCrypto(aSymbol.replace('1', ''))
+          aSymbol.replace(new RegExp('-USD$'), 'USD').replace('1', '')
+        )
       ) {
         // Add a dash before the last three characters
         // BTCUSD  -> BTC-USD
         // DOGEUSD -> DOGE-USD
         // SOL1USD -> SOL1-USD
-        return aSymbol.replace('USD', '-USD');
+        return aSymbol.replace(new RegExp('-?USD$'), '-USD');
       }
     }
 

apps/client/src/app/components/positions-table/positions-table.component.html

@@ -15,6 +15,27 @@
     </td>
   </ng-container>
 
+  <ng-container matColumnDef="value">
+    <th
+      *matHeaderCellDef
+      class="d-none d-lg-table-cell justify-content-end px-1"
+      i18n
+      mat-header-cell
+      mat-sort-header
+    >
+      Value
+    </th>
+    <td class="d-none d-lg-table-cell px-1" mat-cell *matCellDef="let element">
+      <div class="d-flex justify-content-end">
+        <gf-value
+          [isCurrency]="true"
+          [locale]="locale"
+          [value]="isLoading ? undefined : element.value"
+        ></gf-value>
+      </div>
+    </td>
+  </ng-container>
+
   <ng-container matColumnDef="performance">
     <th
       *matHeaderCellDef

apps/client/src/app/components/positions-table/positions-table.component.ts

@@ -70,6 +70,7 @@ export class PositionsTableComponent implements OnChanges, OnDestroy, OnInit {
   public ngOnChanges() {
     this.displayedColumns = [
       'symbol',
+      'value',
       'performance',
       'allocationInvestment',
       'allocationCurrent'

apps/client/src/app/pages/landing/landing-page.component.ts

@@ -23,7 +23,7 @@ export class LandingPageComponent implements OnDestroy, OnInit {
     {
       author: 'Onur',
       country: 'Switzerland 🇨🇭',
-      quote: `Ghostfolio looks like the perfect portfolio tracker that I've been searching for all these years.`
+      quote: `Ghostfolio looks like the perfect portfolio tracker I've been searching for all these years.`
     },
     {
       author: 'Ivo',

apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.component.ts

@@ -84,6 +84,10 @@ export class CreateOrUpdateTransactionDialog implements OnDestroy {
         })
       );
 
+    if (this.data.transaction.id) {
+      this.searchSymbolCtrl.disable();
+    }
+
     if (this.data.transaction.symbol) {
       this.dataService
         .fetchSymbolItem({

apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/create-or-update-transaction-dialog.html

@@ -10,9 +10,7 @@
           required
           [(value)]="data.transaction.accountId"
         >
-          <mat-option
+          <mat-option *ngFor="let account of data.accounts" [value]="account.id"
-            *ngFor="let account of data.user?.accounts"
-            [value]="account.id"
             >{{ account.name }}</mat-option
           >
         </mat-select>

apps/client/src/app/pages/portfolio/transactions/create-or-update-transaction-dialog/interfaces/interfaces.ts

@@ -1,8 +1,9 @@
 import { User } from '@ghostfolio/common/interfaces';
-import { Order } from '@prisma/client';
+import { Account, Order } from '@prisma/client';
 
 export interface CreateOrUpdateTransactionDialogParams {
   accountId: string;
+  accounts: Account[];
   transaction: Order;
   user: User;
 }

apps/client/src/app/pages/portfolio/transactions/transactions-page.component.ts

@@ -261,6 +261,9 @@ export class TransactionsPageComponent implements OnDestroy, OnInit {
   }: OrderModel): void {
     const dialogRef = this.dialog.open(CreateOrUpdateTransactionDialog, {
       data: {
+        accounts: this.user.accounts.filter((account) => {
+          return account.accountType === 'SECURITIES';
+        }),
         transaction: {
           accountId,
           currency,
@@ -343,6 +346,9 @@ export class TransactionsPageComponent implements OnDestroy, OnInit {
   private openCreateTransactionDialog(aTransaction?: OrderModel): void {
     const dialogRef = this.dialog.open(CreateOrUpdateTransactionDialog, {
       data: {
+        accounts: this.user.accounts.filter((account) => {
+          return account.accountType === 'SECURITIES';
+        }),
         transaction: {
           accountId: aTransaction?.accountId ?? this.defaultAccountId,
           currency: aTransaction?.currency ?? null,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "ghostfolio",
-  "version": "1.78.0",
+  "version": "1.79.0",
   "homepage": "https://ghostfol.io",
   "license": "AGPL-3.0",
   "scripts": {