Merge branch 'main' of github.com:ghostfolio/ghostfolio

Feature/replace lodash.uniq with Array.from + Set (#4387 )
* Replace lodash.uniq with Array.from + Set * Update chagnelog
2025-03-19 19:08:43 -07:00 · 2025-03-19 21:10:19 +01:00 · 2025-03-19 20:37:30 +01:00 · 2025-03-19 17:26:00 +01:00
19 changed files with 48 additions and 41 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed

 - Improved the symbol validation in the _Yahoo Finance_ service (get asset profiles)
+- Refactored `lodash.uniq` with `Array.from(new Set(...))`
 - Refreshed the cryptocurrencies list

 ### Fixed
--- a/DEVELOPMENT.md
+++ b/DEVELOPMENT.md
@ -60,6 +60,10 @@ Remove permission in `UserService` using `without()`

 Use `@if (user?.settings?.isExperimentalFeatures) {}` in HTML template

+## Component Library (_Storybook_)
+
+https://ghostfol.io/development/storybook
+
 ## Git

 ### Rebase
--- a/apps/api/src/app/portfolio/calculator/portfolio-calculator.ts
+++ b/apps/api/src/app/portfolio/calculator/portfolio-calculator.ts
@ -49,7 +49,7 @@ import {
  min,
  subDays
 } from 'date-fns';
-import { isNumber, sortBy, sum, uniq, uniqBy } from 'lodash';
+import { isNumber, sortBy, sum, uniqBy } from 'lodash';

 export abstract class PortfolioCalculator {
  protected static readonly ENABLE_LOGGING = false;
@ -222,7 +222,7 @@ export abstract class PortfolioCalculator {

    const exchangeRatesByCurrency =
      await this.exchangeRateDataService.getExchangeRatesByCurrency({
-        currencies: uniq(Object.values(currencies)),
+        currencies: Array.from(new Set(Object.values(currencies))),
        endDate: endOfDay(this.endDate),
        startDate: this.startDate,
        targetCurrency: this.currency
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@ -82,7 +82,7 @@ import {
  parseISO,
  set
 } from 'date-fns';
-import { isEmpty, uniq } from 'lodash';
+import { isEmpty } from 'lodash';

 import { PortfolioCalculator } from './calculator/portfolio-calculator';
 import {
@ -2032,14 +2032,16 @@ export class PortfolioService {
        where: { id: filters[0].id }
      });
    } else {
-      const accountIds = uniq(
-        activities
-          .filter(({ accountId }) => {
-            return accountId;
-          })
-          .map(({ accountId }) => {
-            return accountId;
-          })
+      const accountIds = Array.from(
+        new Set(
+          activities
+            .filter(({ accountId }) => {
+              return accountId;
+            })
+            .map(({ accountId }) => {
+              return accountId;
+            })
+        )
      );

      currentAccounts = await this.accountService.accounts({
--- a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
+++ b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts
@ -23,7 +23,7 @@ import {
  isToday,
  subDays
 } from 'date-fns';
-import { isNumber, uniq } from 'lodash';
+import { isNumber } from 'lodash';
 import ms from 'ms';

@Injectable()
@ -515,7 +515,7 @@ export class ExchangeRateDataService {
      }
    }

-    return uniq(currencies).filter(Boolean).sort();
+    return Array.from(new Set(currencies)).filter(Boolean).sort();
  }

  private prepareCurrencyPairs(aCurrencies: string[]) {
--- a/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts
+++ b/apps/client/src/app/components/admin-market-data/create-asset-profile-dialog/create-asset-profile-dialog.component.ts
@ -20,7 +20,6 @@ import {
 } from '@angular/forms';
 import { MatDialogRef } from '@angular/material/dialog';
 import { isISO4217CurrencyCode } from 'class-validator';
-import { uniq } from 'lodash';
 import { Subject, takeUntil } from 'rxjs';

 import { CreateAssetProfileDialogMode } from './interfaces/interfaces';
@ -87,7 +86,9 @@ export class CreateAssetProfileDialog implements OnInit, OnDestroy {
        this.createAssetProfileForm.get('addCurrency').value as string
      ).toUpperCase();

-      const currencies = uniq([...this.customCurrencies, currency]).sort();
+      const currencies = Array.from(
+        new Set([...this.customCurrencies, currency])
+      ).sort();

      this.dataService
        .putAdminSetting(PROPERTY_CURRENCIES, {
--- a/apps/client/src/app/components/user-account-settings/user-account-settings.component.ts
+++ b/apps/client/src/app/components/user-account-settings/user-account-settings.component.ts
@ -24,7 +24,6 @@ import { FormBuilder, Validators } from '@angular/forms';
 import { MatSlideToggleChange } from '@angular/material/slide-toggle';
 import { MatSnackBar } from '@angular/material/snack-bar';
 import { format, parseISO } from 'date-fns';
-import { uniq } from 'lodash';
 import ms from 'ms';
 import { EMPTY, Subject, throwError } from 'rxjs';
 import { catchError, takeUntil } from 'rxjs/operators';
@ -108,7 +107,7 @@ export class UserAccountSettingsComponent implements OnDestroy, OnInit {
          );

          this.locales.push(this.user.settings.locale);
-          this.locales = uniq(this.locales.sort());
+          this.locales = Array.from(new Set(this.locales)).sort();

          this.changeDetectorRef.markForCheck();
        }
--- a/apps/client/src/locales/messages.ca.xlf
+++ b/apps/client/src/locales/messages.ca.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.de.xlf
+++ b/apps/client/src/locales/messages.de.xlf
@ -7589,7 +7589,7 @@
        <target state="translated">KI-Anweisung wurde in die Zwischenablage kopiert</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="translated">Öffne Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.es.xlf
+++ b/apps/client/src/locales/messages.es.xlf
@ -7590,7 +7590,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7686,7 +7686,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.fr.xlf
+++ b/apps/client/src/locales/messages.fr.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.it.xlf
+++ b/apps/client/src/locales/messages.it.xlf
@ -7590,7 +7590,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7686,7 +7686,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.nl.xlf
+++ b/apps/client/src/locales/messages.nl.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.pl.xlf
+++ b/apps/client/src/locales/messages.pl.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.pt.xlf
+++ b/apps/client/src/locales/messages.pt.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.tr.xlf
+++ b/apps/client/src/locales/messages.tr.xlf
@ -7589,7 +7589,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.uk.xlf
+++ b/apps/client/src/locales/messages.uk.xlf
@ -7597,7 +7597,7 @@
        <target state="translated">Запит AI скопійовано в буфер обміну</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="4499ce8c46ad55564b23a42ed752e72984c0248f" datatype="html">
@ -7685,7 +7685,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.xlf
+++ b/apps/client/src/locales/messages.xlf
@ -6867,7 +6867,7 @@
        <source>AI prompt has been copied to the clipboard</source>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -6951,7 +6951,7 @@
        <source>Open Duck.ai</source>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
--- a/apps/client/src/locales/messages.zh.xlf
+++ b/apps/client/src/locales/messages.zh.xlf
@ -7590,7 +7590,7 @@
        <target state="new">AI prompt has been copied to the clipboard</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">170</context>
+          <context context-type="linenumber">173</context>
        </context-group>
      </trans-unit>
      <trans-unit id="1616747898909934803" datatype="html">
@ -7686,7 +7686,7 @@
        <target state="new">Open Duck.ai</target>
        <context-group purpose="location">
          <context context-type="sourcefile">apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts</context>
-          <context context-type="linenumber">171</context>
+          <context context-type="linenumber">174</context>
        </context-group>
      </trans-unit>
      <trans-unit id="70a67e04629f6d412db0a12d51820b480788d795" datatype="html">
Author	SHA1	Message	Date
sudacode	22cde840ea	Merge branch 'main' of github.com:ghostfolio/ghostfolio All checks were successful Docker image CD / build_and_push (push) Successful in 31m18s Details	2025-03-19 19:08:43 -07:00
Szymon Łągiewka	795e4582a8	Feature/replace lodash.uniq with Array.from + Set (#4387 ) * Replace lodash.uniq with Array.from + Set * Update chagnelog	2025-03-19 21:10:19 +01:00
github-actions[bot]	ddc7989280	Feature/update locales (#4460 ) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	2025-03-19 20:37:30 +01:00
Thomas Kaul	82fe2590bf	Feature/add Storybook link to development guide (#4448 ) * Add Storybook	2025-03-19 17:26:00 +01:00