Release 1.119.0

.env

@@ -3,14 +3,14 @@ COMPOSE_PROJECT_NAME=ghostfolio-development
 # CACHE
 REDIS_HOST=localhost
 REDIS_PORT=6379
-REDIS_PASSWORD=<INSERT_REDIS_PASSWORD>
 
 # POSTGRES
 POSTGRES_DB=ghostfolio-db
 POSTGRES_USER=user
-POSTGRES_PASSWORD=<INSERT_POSTGRES_PASSWORD>
+POSTGRES_PASSWORD=password
 
-ACCESS_TOKEN_SALT=<INSERT_RANDOM_STRING>
+ACCESS_TOKEN_SALT=GHOSTFOLIO
 ALPHA_VANTAGE_API_KEY=
 DATABASE_URL=postgresql://${POSTGRES_USER}:${POSTGRES_PASSWORD}@localhost:5432/${POSTGRES_DB}?sslmode=prefer
-JWT_SECRET_KEY=<INSERT_RANDOM_STRING>
+JWT_SECRET_KEY=123456
+PORT=3333

.github/FUNDING.yml

@@ -1 +0,0 @@
-custom: ['https://www.buymeacoffee.com/ghostfolio']

CHANGELOG.md

@@ -5,663 +5,6 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## 1.169.0 - 14.07.2022
-
-### Added
-
-- Added support for the cryptocurrency _Songbird_ (`SGB1-USD`)
-- Added support for the cryptocurrency _Terra 2.0_ (`LUNA2-USD`)
-- Added a blog post
-
-### Changed
-
-- Refreshed the cryptocurrencies list to support more coins by default
-- Upgraded `date-fns` from version `2.22.1` to `2.28.0`
-
-## 1.168.0 - 10.07.2022
-
-### Added
-
-- Extended the investment timeline grouped by month
-
-### Changed
-
-- Handled an occasional currency pair inconsistency in the _Yahoo Finance_ service (`GBP=X` instead of `USDGBP=X`)
-
-### Fixed
-
-- Fixed the content height of the account detail dialog
-
-## 1.167.0 - 07.07.2022
-
-### Added
-
-- Added _Markets_ to the public pages
-
-### Changed
-
-- Improved the _Create Account_ link in the _Live Demo_
-- Upgraded `ngx-markdown` from version `13.0.0` to `14.0.1`
-
-### Fixed
-
-- Fixed an issue in the _Holdings_ section for users without a subscription
-
-## 1.166.0 - 30.06.2022
-
-### Added
-
-- Added an account detail dialog
-
-### Changed
-
-- Improved the label of the (symbol) search
-- Refactored the demo account as a route (`/demo`)
-- Upgraded `nestjs` from version `8.2.3` to `8.4.7`
-- Upgraded `prisma` from version `3.14.0` to `3.15.2`
-- Upgraded `yahoo-finance2` from version `2.3.2` to `2.3.3`
-- Upgraded `zone.js` from version `0.11.4` to `0.11.6`
-
-## 1.165.0 - 25.06.2022
-
-### Added
-
-- Added an icon and name column to the positions table
-- Added a reusable premium indicator component
-
-### Changed
-
-- Moved the positions table to a dedicated section (_Holdings_)
-- Changed the data gathering by symbol endpoint to delete data first
-
-## 1.164.0 - 23.06.2022
-
-### Added
-
-- Added the positions table including performance to the public page
-
-## 1.163.0 - 22.06.2022
-
-### Changed
-
-- Improved the onboarding for iOS
-
-## 1.162.0 - 18.06.2022
-
-### Added
-
-- Added a _Privacy Policy_ page
-
-### Changed
-
-- Simplified the header
-
-### Fixed
-
-- Fixed an issue with the currency inconsistency in the _Yahoo Finance_ service (convert from `ILA` to `ILS`)
-
-## 1.161.1 - 16.06.2022
-
-### Added
-
-- Added the vertical hover line to inspect data points in the performance chart on the home page
-
-### Changed
-
-- Improved the landing page
-- Upgraded `angular` from version `13.3.6` to `14.0.2`
-- Upgraded `Nx` from version `14.1.4` to `14.3.5`
-- Upgraded `storybook` from version `6.4.22` to `6.5.9`
-
-### Fixed
-
-- Improved the error handling of missing market prices
-
-## 1.160.0 - 15.06.2022
-
-### Fixed
-
-- Fixed the `No data provider has been found` error in the search (regression after `envalid` upgrade to `7.3.1` in Ghostfolio `1.157.0`)
-
-## 1.159.0 - 15.06.2022
-
-### Changed
-
-- Changed the default `HOST` to `0.0.0.0`
-- Refactored the endpoint of the public page (filter by equity)
-
-## 1.158.1 - 12.06.2022
-
-### Added
-
-- Extended the queue jobs view in the admin control panel by a data dialog
-
-### Changed
-
-- Exposed the environment variable `HOST`
-- Decreased the number of attempts of queue jobs from `20` to `10` (fail earlier)
-- Improved the message for data provider errors in the client
-- Changed the label from _Balance_ to _Cash Balance_ in the account dialog
-- Restructured the documentation for self-hosting
-
-## 1.157.0 - 11.06.2022
-
-### Added
-
-- Extended the queue jobs view in the admin control panel by the number of attempts and the status
-
-### Changed
-
-- Migrated the historical market data gathering to the queue design pattern
-- Refreshed the cryptocurrencies list to support more coins by default
-- Increased the historical data chart of the _Fear & Greed Index_ (market mood) to 180 days
-- Upgraded `chart.js` from version `3.7.0` to `3.8.0`
-- Upgraded `envalid` from version `7.2.1` to `7.3.1`
-
-### Fixed
-
-- Reloaded the accounts of a user after creating, editing or deleting one
-- Excluded empty items in the activities filter
-
-## 1.156.0 - 05.06.2022
-
-### Added
-
-- Added the user id to the account page
-- Added a new view with jobs of the queue to the admin control panel
-
-### Changed
-
-- Simplified the features page
-- Restructured the _FIRE_ section
-- Upgraded `@simplewebauthn/browser` and `@simplewebauthn/server` from version `4.1.0` to `5.2.1`
-
-### Fixed
-
-- Fixed the `docker-compose` files to resolve variables correctly
-
-## 1.155.0 - 29.05.2022
-
-### Added
-
-- Added `EOD_HISTORICAL_DATA` as a new data source type
-
-### Changed
-
-- Exposed the environment variable `REDIS_PASSWORD`
-
-### Fixed
-
-- Fixed the empty state of the portfolio proportion chart component (with 2 levels)
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.154.0 - 28.05.2022
-
-### Added
-
-- Added a vertical hover line to inspect data points in the line chart component
-
-### Changed
-
-- Improved the tooltips of the chart components (content and style)
-- Simplified the pricing page
-- Improved the rounding numbers in the twitter bot service
-- Removed the dependency `round-to`
-
-## 1.153.0 - 27.05.2022
-
-### Added
-
-- Extended the benchmarks of the markets overview by the current market condition (bear and bull market)
-- Extended the twitter bot service by benchmarks
-- Added value redaction for the impersonation mode in the API response as an interceptor
-
-### Changed
-
-- Changed the twitter bot service to rest on the weekend
-- Upgraded `prisma` from version `3.12.0` to `3.14.0`
-
-### Fixed
-
-- Fixed a styling issue in the benchmark component on mobile
-
-## 1.152.0 - 26.05.2022
-
-### Added
-
-- Added the _Ghostfolio_ trailer to the landing page
-- Extended the markets overview by benchmarks (current change to the all time high)
-
-## 1.151.0 - 24.05.2022
-
-### Added
-
-- Added support to set the base currency as an environment variable (`BASE_CURRENCY`)
-
-### Fixed
-
-- Fixed an issue with the missing conversion of countries in the symbol profile overrides
-
-## 1.150.0 - 21.05.2022
-
-### Changed
-
-- Skipped data enhancer (_Trackinsight_) if data is inaccurate
-
-### Fixed
-
-- Fixed an issue with the currency conversion in the account calculations
-- Fixed an issue with countries in the symbol profile overrides
-
-## 1.149.0 - 16.05.2022
-
-### Added
-
-- Added groups to the activities filter component
-- Added support for filtering by asset class on the allocations page
-
-## 1.148.0 - 14.05.2022
-
-### Added
-
-- Supported enter key press to submit the form of the create or edit transaction dialog
-- Added a _Report Data Glitch_ button to the position detail dialog
-
-### Fixed
-
-- Fixed the date format of the date picker and support manual changes
-- Fixed the state of the account delete button (disable if account contains activities)
-- Fixed an issue in the activities filter component (typing a search term)
-
-## 1.147.0 - 10.05.2022
-
-### Changed
-
-- Improved the allocations page with no filtering (include cash positions)
-
-## 1.146.3 - 08.05.2022
-
-### Added
-
-- Set up a queue for the data gathering jobs
-- Set up _Nx Cloud_
-
-### Changed
-
-- Migrated the asset profile data gathering to the queue design pattern
-- Improved the allocations page with no filtering
-- Harmonized the _No data available_ label in the portfolio proportion chart component
-- Improved the _FIRE_ calculator for the _Live Demo_
-- Simplified the about page
-- Upgraded `angular` from version `13.2.2` to `13.3.6`
-- Upgraded `Nx` from version `13.8.5` to `14.1.4`
-- Upgraded `storybook` from version `6.4.18` to `6.4.22`
-
-### Fixed
-
-- Eliminated the circular dependencies in the `@ghostfolio/common` library
-
-## 1.145.0 - 07.05.2022
-
-### Added
-
-- Added support for filtering by accounts on the allocations page
-- Added support for private equity
-- Extended the form to set the asset and asset sub class for (wealth) items
-
-### Changed
-
-- Refactored the filtering (activities table and allocations page)
-
-### Fixed
-
-- Fixed the tooltip update in the portfolio proportion chart component
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.144.0 - 30.04.2022
-
-### Added
-
-- Added support for commodities (via futures)
-- Added support for real estate
-
-### Changed
-
-- Improved the layout of the position detail dialog
-- Upgraded `yahoo-finance2` from version `2.3.1` to `2.3.2`
-
-### Fixed
-
-- Fixed the import validation for numbers equal 0
-- Fixed the color of the spinner in the activities filter component (dark mode)
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.143.0 - 26.04.2022
-
-### Changed
-
-- Improved the filtering by tags
-
-## 1.142.0 - 25.04.2022
-
-### Added
-
-- Added the tags to the create or edit transaction dialog
-- Added the tags to the position detail dialog
-
-### Changed
-
-- Changed the date to UTC in the data gathering service
-- Reused the value component in the users table of the admin control panel
-
-## 1.141.1 - 24.04.2022
-
-### Added
-
-- Added the database migration
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.141.0 - 24.04.2022
-
-### Added
-
-- Added a tagging system for activities
-
-### Changed
-
-- Extracted the activities table filter to a dedicated component
-- Changed the url of the _Get Started_ link to `https://ghostfol.io` on the public page
-- Simplified `@@id` using multiple fields with `@id` in the database schema of (`Access`, `Order`, `Subscription`)
-- Upgraded `prisma` from version `3.11.1` to `3.12.0`
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.140.2 - 22.04.2022
-
-### Added
-
-- Added support for sub-labels in the value component
-- Added a symbol profile overrides model for manual adjustments
-
-### Changed
-
-- Reused the value component in the _Ghostfolio in Numbers_ section of the about page
-- Persisted the savings rate in the _FIRE_ calculator
-- Upgraded `yahoo-finance2` from version `2.3.0` to `2.3.1`
-
-### Fixed
-
-- Fixed the calculation of the total value for sell and dividend activities in the create or edit transaction dialog
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.139.0 - 18.04.2022
-
-### Added
-
-- Added the total amount to the tooltip in the chart of the _FIRE_ calculator
-
-### Changed
-
-- Beautified the ETF names in the symbol profile
-
-### Fixed
-
-- Fixed an issue with changing the investment horizon in the chart of the _FIRE_ calculator
-- Fixed an issue with the end dates in the `.ics` file of the future activities (drafts) export
-- Fixed the data source of the _Fear & Greed Index_ (market mood)
-
-## 1.138.0 - 16.04.2022
-
-### Added
-
-- Added support to export a single future activity (draft) as an `.ics` file
-- Added the _Boringly Getting Rich_ guide to the resources section
-
-### Changed
-
-- Separated the deposit and savings in the chart of the _FIRE_ calculator
-
-## 1.137.0 - 15.04.2022
-
-### Added
-
-- Added support to export future activities (drafts) as an `.ics` file
-
-### Changed
-
-- Migrated the search functionality to `yahoo-finance2`
-
-### Fixed
-
-- Fixed an issue in the average price / investment calculation for sell activities
-
-## 1.136.0 - 13.04.2022
-
-### Changed
-
-- Changed the _Total_ label to _Total Assets_ in the portfolio summary tab on the home page
-
-### Fixed
-
-- Fixed an issue with the calculation of the projected total amount in the _FIRE_ calculator
-- Fixed an issue with the loading state of the _FIRE_ calculator
-
-## 1.135.0 - 10.04.2022
-
-### Added
-
-- Added a calculator to the _FIRE_ section
-- Added support for the cryptocurrency _Terra_ (`LUNA1-USD`)
-- Added support for the cryptocurrency _THORChain_ (`RUNE-USD`)
-
-## 1.134.0 - 09.04.2022
-
-### Changed
-
-- Switched to the new calculation engine
-- Improved the 4% rule in the _FIRE_ section
-- Changed the background of the header to a solid color
-
-## 1.133.0 - 07.04.2022
-
-### Changed
-
-- Improved the empty state of the portfolio proportion chart component
-
-### Fixed
-
-- Fixed an issue with dates in the value component
-
-## 1.132.1 - 06.04.2022
-
-### Fixed
-
-- Fixed an issue with percentages in the value component
-
-## 1.132.0 - 06.04.2022
-
-### Added
-
-- Added support for localization (date and number format) in user settings
-
-### Changed
-
-- Improved the label of the average price from _Ø Buy Price_ to _Average Unit Price_
-
-## 1.131.1 - 04.04.2022
-
-### Fixed
-
-- Fixed the missing API version in the _Stripe_ success callback url
-
-## 1.131.0 - 02.04.2022
-
-### Added
-
-- Added API versioning
-- Added more durations in the coupon system
-
-### Changed
-
-- Display the value in base currency in the accounts table on mobile
-- Display the value in base currency in the activities table on mobile
-- Renamed `orders` to `activities` in import and export functionality
-- Harmonized the algebraic sign of `currentGrossPerformancePercent` and `currentNetPerformancePercent` with `currentGrossPerformance` and `currentNetPerformance`
-- Improved the pricing page
-- Upgraded `prisma` from version `3.10.0` to `3.11.1`
-- Upgraded `yahoo-finance2` from version `2.2.0` to `2.3.0`
-
-## 1.130.0 - 30.03.2022
-
-### Added
-
-- Added a _FIRE_ (Financial Independence, Retire Early) section including the 4% rule
-- Added more durations in the coupon system
-
-### Fixed
-
-- Fixed an issue with the currency conversion (duplicate) in the account calculations
-
-## 1.129.0 - 26.03.2022
-
-### Added
-
-- Added the calculation for developed vs. emerging markets to the allocations page
-- Added a hover effect to the page tabs
-- Extended the feature overview page by _Bonds_ and _Emergency Fund_
-
-## 1.128.0 - 19.03.2022
-
-### Added
-
-- Added the attribute `defaultMarketPrice` to the scraper configuration to improve the support for bonds
-- Added a hover effect to the table style
-
-### Fixed
-
-- Fixed an issue with the user currency of the public page
-- Fixed an issue of the performance calculation with recent activities in the new calculation engine
-
-## 1.127.0 - 16.03.2022
-
-### Changed
-
-- Improved the error handling in the scraper configuration
-
-### Fixed
-
-- Fixed the support for multiple symbols of the data source `GHOSTFOLIO`
-
-## 1.126.0 - 14.03.2022
-
-### Added
-
-- Added support for bonds
-
-### Changed
-
-- Restructured the portfolio summary tab on the home page
-- Improved the tooltips in the portfolio proportion chart component by introducing multilines
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.125.0 - 12.03.2022
-
-### Added
-
-- Added support for an emergency fund
-- Added the contexts to the logger commands
-
-### Changed
-
-- Upgraded `Nx` from version `13.8.1` to `13.8.5`
-
-## 1.124.0 - 06.03.2022
-
-### Added
-
-- Added support for setting a duration in the coupon system
-
-### Changed
-
-- Upgraded `ngx-skeleton-loader` from version `2.9.1` to `5.0.0`
-- Upgraded `prisma` from version `3.9.1` to `3.10.0`
-- Upgraded `yahoo-finance2` from version `2.1.9` to `2.2.0`
-
-## 1.123.0 - 05.03.2022
-
-### Added
-
-- Included data provider errors in the API response
-
-### Changed
-
-- Removed the redundant attributes (`currency`, `dataSource`, `symbol`) of the activity model
-- Removed the prefix for symbols with the data source `GHOSTFOLIO`
-
-### Fixed
-
-- Improved the account calculations
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.122.0 - 01.03.2022
-
-### Added
-
-- Added support for click in the portfolio proportion chart component
-
-### Fixed
-
-- Fixed an issue with undefined currencies after creating an activity
-
-## 1.121.0 - 27.02.2022
-
-### Added
-
-- Added support for mutual funds
-- Added the url to the symbol profile model
-
-### Changed
-
-- Migrated from `yahoo-finance` to `yahoo-finance2`
-
-### Todo
-
-- Apply data migration (`yarn database:migrate`)
-
-## 1.120.0 - 25.02.2022
-
-### Changed
-
-- Distinguished the labels _Other_ and _Unknown_ in the portfolio proportion chart component
-- Improved the portfolio entry page
-
-### Fixed
-
-- Fixed the _Zen Mode_
-
 ## 1.119.0 - 21.02.2022
 
 ### Added
@@ -714,7 +57,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
-- Upgraded `angular` from version `13.1.2` to `13.2.2`
+- Upgraded `angular` from version `13.1.2` to `13.2.3`
 - Upgraded `Nx` from version `13.4.1` to `13.8.1`
 - Upgraded `storybook` from version `6.4.9` to `6.4.18`
 

Dockerfile

@@ -12,7 +12,7 @@ COPY ./package.json package.json
 COPY ./yarn.lock yarn.lock
 COPY ./prisma/schema.prisma prisma/schema.prisma
 
-RUN apk add --no-cache python3 g++ make openssl git
+RUN apk add --no-cache python3 g++ make openssl
 RUN yarn install
 
 # See https://github.com/nrwl/nx/issues/6586 for further details
@@ -23,7 +23,7 @@ COPY ./angular.json angular.json
 COPY ./nx.json nx.json
 COPY ./replace.build.js replace.build.js
 COPY ./jest.preset.js jest.preset.js
-COPY ./jest.config.ts jest.config.ts
+COPY ./jest.config.js jest.config.js
 COPY ./tsconfig.base.json tsconfig.base.json
 COPY ./libs libs
 COPY ./apps apps

README.md

@@ -9,10 +9,10 @@
 
   <h1>Ghostfolio</h1>
   <p>
-    <strong>Open Source Wealth Management Software</strong>
+    <strong>Open Source Wealth Management Software made for Humans</strong>
   </p>
   <p>
-    <a href="https://ghostfol.io"><strong>Ghostfol.io</strong></a> | <a href="https://ghostfol.io/demo"><strong>Live Demo</strong></a> | <a href="https://ghostfol.io/pricing"><strong>Ghostfolio Premium</strong></a> | <a href="https://ghostfol.io/blog"><strong>Blog</strong></a> | <a href="https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg"><strong>Slack</strong></a> | <a href="https://twitter.com/ghostfolio_"><strong>Twitter</strong></a>
+    <a href="https://ghostfol.io"><strong>Live Demo</strong></a> | <a href="https://ghostfol.io/pricing"><strong>Ghostfolio Premium</strong></a> | <a href="https://ghostfol.io/blog"><strong>Blog</strong></a> | <a href="https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg"><strong>Slack</strong></a> | <a href="https://twitter.com/ghostfolio_"><strong>Twitter</strong></a>
   </p>
   <p>
     <a href="#contributing">
@@ -24,18 +24,17 @@
   </p>
 </div>
 
-**Ghostfolio** is an open source wealth management software built with web technology. The application empowers busy people to keep track of stocks, ETFs or cryptocurrencies and make solid, data-driven investment decisions.
+**Ghostfolio** is an open source wealth management software built with web technology. The application empowers busy people to keep track of their wealth like stocks, ETFs or cryptocurrencies and make solid, data-driven investment decisions.
 
-<div align="center" style="margin-top: 1rem; margin-bottom: 1rem;">
+<div align="center">
-  <a href="https://www.youtube.com/watch?v=yY6ObSQVJZk">
+  <img src="./apps/client/src/assets/images/screenshot.png" width="300">
-    <img src="./apps/client/src/assets/images/video-preview.jpg" width="600"></a>
 </div>
 
 ## Ghostfolio Premium
 
 Our official **[Ghostfolio Premium](https://ghostfol.io/pricing)** cloud offering is the easiest way to get started. Due to the time it saves, this will be the best option for most people. The revenue is used for covering the hosting costs.
 
-If you prefer to run Ghostfolio on your own infrastructure, please find further instructions in the [Self-hosting](#self-hosting) section.
+If you prefer to run Ghostfolio on your own infrastructure (self-hosting), please find further instructions in the section [Run with Docker](#run-with-docker-self-hosting).
 
 ## Why Ghostfolio?
 
@@ -48,7 +47,7 @@ Ghostfolio is for you if you are...
 - 🧘 into minimalism
 - 🧺 caring about diversifying your financial resources
 - 🆓 interested in financial independence
-- 🙅 saying no to spreadsheets in 2022
+- 🙅 saying no to spreadsheets in 2021
 - 😎 still reading this list
 
 ## Features
@@ -63,10 +62,6 @@ Ghostfolio is for you if you are...
 - ✅ Zen Mode
 - ✅ Mobile-first design
 
-<div align="center" style="margin-top: 1rem; margin-bottom: 1rem;">
-  <img src="./apps/client/src/assets/images/screenshot.png" width="300">
-</div>
-
 ## Technology Stack
 
 Ghostfolio is a modern web application written in [TypeScript](https://www.typescriptlang.org) and organized as an [Nx](https://nx.dev) workspace.
@@ -79,50 +74,46 @@ The backend is based on [NestJS](https://nestjs.com) using [PostgreSQL](https://
 
 The frontend is built with [Angular](https://angular.io) and uses [Angular Material](https://material.angular.io) with utility classes from [Bootstrap](https://getbootstrap.com).
 
-## Self-hosting
+## Run with Docker (self-hosting)
 
-### Run with Docker Compose
+### Prerequisites
 
-#### Prerequisites
+- [Docker](https://www.docker.com/products/docker-desktop)
 
-- Basic knowledge of Docker
+### a. Run environment
-- Installation of [Docker](https://www.docker.com/products/docker-desktop)
-- Local copy of this Git repository (clone)
-
-#### a. Run environment
 
 Run the following command to start the Docker images from [Docker Hub](https://hub.docker.com/r/ghostfolio/ghostfolio):
 
 ```bash
-docker-compose --env-file ./.env -f docker/docker-compose.yml up -d
+docker-compose -f docker/docker-compose.yml up -d
 ```
 
-##### Setup Database
+#### Setup Database
 
 Run the following command to setup the database once Ghostfolio is running:
 
 ```bash
-docker-compose --env-file ./.env -f docker/docker-compose.yml exec ghostfolio yarn database:setup
+docker-compose -f docker/docker-compose.yml exec ghostfolio yarn database:setup
 ```
 
-#### b. Build and run environment
+### b. Build and run environment
 
 Run the following commands to build and start the Docker images:
 
 ```bash
-docker-compose --env-file ./.env -f docker/docker-compose.build.yml build
+docker-compose -f docker/docker-compose.build.yml build
-docker-compose --env-file ./.env -f docker/docker-compose.build.yml up -d
+docker-compose -f docker/docker-compose.build.yml up -d
 ```
 
-##### Setup Database
+#### Setup Database
 
 Run the following command to setup the database once Ghostfolio is running:
 
 ```bash
-docker-compose --env-file ./.env -f docker/docker-compose.build.yml exec ghostfolio yarn database:setup
+docker-compose -f docker/docker-compose.build.yml exec ghostfolio yarn database:setup
 ```
 
-#### Fetch Historical Data
+### Fetch Historical Data
 
 Open http://localhost:3333 in your browser and accomplish these steps:
 
@@ -130,15 +121,13 @@ Open http://localhost:3333 in your browser and accomplish these steps:
 1. Go to the _Admin Control Panel_ and click _Gather All Data_ to fetch historical data
 1. Click _Sign out_ and check out the _Live Demo_
 
-#### Upgrade Version
+### Migrate Database
 
-1. Increase the version of the `ghostfolio/ghostfolio` Docker image in `docker/docker-compose.yml`
+With the following command you can keep your database schema in sync after a Ghostfolio version update:
-1. Run the following command to start the new Docker image: `docker-compose --env-file ./.env -f docker/docker-compose.yml up -d`
-1. Then, run the following command to keep your database schema in sync: `docker-compose --env-file ./.env -f docker/docker-compose.yml exec ghostfolio yarn database:migrate`
 
-### Run with _Unraid_ (Community)
+```bash
-
+docker-compose -f docker/docker-compose-build-local.yml exec ghostfolio yarn database:migrate
-Please follow the instructions of the Ghostfolio [Unraid Community App](https://unraid.net/community/apps?q=ghostfolio).
+```
 
 ## Development
 
@@ -147,12 +136,11 @@ Please follow the instructions of the Ghostfolio [Unraid Community App](https://
 - [Docker](https://www.docker.com/products/docker-desktop)
 - [Node.js](https://nodejs.org/en/download) (version 14+)
 - [Yarn](https://yarnpkg.com/en/docs/install)
-- A local copy of this Git repository (clone)
 
 ### Setup
 
 1. Run `yarn install`
-1. Run `docker-compose --env-file ./.env -f docker/docker-compose.dev.yml up -d` to start [PostgreSQL](https://www.postgresql.org) and [Redis](https://redis.io)
+1. Run `docker-compose -f docker/docker-compose.dev.yml up -d` to start [PostgreSQL](https://www.postgresql.org) and [Redis](https://redis.io)
 1. Run `yarn database:setup` to initialize the database schema and populate your database with (example) data
 1. Start the server and the client (see [_Development_](#Development))
 1. Create a new user via _Get Started_ (this first user will get the role `ADMIN`)
@@ -174,92 +162,16 @@ Run `yarn start:client`
 
 Run `yarn start:storybook`
 
-### Migrate Database
-
-With the following command you can keep your database schema in sync:
-
-```bash
-yarn database:push
-```
-
 ## Testing
 
 Run `yarn test`
 
-## Public API
-
-### Import Activities
-
-#### Request
-
-`POST http://localhost:3333/api/v1/import`
-
-#### Authorization: Bearer Token
-
-Set the header as follows:
-
-```
-"Authorization": "Bearer eyJh..."
-```
-
-#### Body
-
-```
-{
-  "activities": [
-    {
-      "currency": "USD",
-      "dataSource": "YAHOO",
-      "date": "2021-09-15T00:00:00.000Z",
-      "fee": 19,
-      "quantity": 5,
-      "symbol": "MSFT"
-      "type": "BUY",
-      "unitPrice": 298.58
-    }
-  ]
-}
-```
-
-| Field      | Type                | Description                                        |
-| ---------- | ------------------- | -------------------------------------------------- |
-| accountId  | string (`optional`) | Id of the account                                  |
-| currency   | string              | `CHF` \| `EUR` \| `USD` etc.                       |
-| dataSource | string              | `MANUAL` (for type `ITEM`) \| `YAHOO`              |
-| date       | string              | Date in the format `ISO-8601`                      |
-| fee        | number              | Fee of the activity                                |
-| quantity   | number              | Quantity of the activity                           |
-| symbol     | string              | Symbol of the activity (suitable for `dataSource`) |
-| type       | string              | `BUY` \| `DIVIDEND` \| `ITEM` \| `SELL`            |
-| unitPrice  | number              | Price per unit of the activity                     |
-
-#### Response
-
-##### Success
-
-`201 Created`
-
-##### Error
-
-`400 Bad Request`
-
-```
-{
-  "error": "Bad Request",
-  "message": [
-    "activities.1 is a duplicate activity"
-  ]
-}
-```
-
 ## Contributing
 
 Ghostfolio is **100% free** and **open source**. We encourage and support an active and healthy community that accepts contributions from the public - including you.
 
 Not sure what to work on? We have got some ideas. Please join the Ghostfolio [Slack channel](https://join.slack.com/t/ghostfolio/shared_invite/zt-vsaan64h-F_I0fEo5M0P88lP9ibCxFg), tweet to [@ghostfolio\_](https://twitter.com/ghostfolio_) or send an e-mail to hi@ghostfol.io. We would love to hear from you.
 
-If you like to support this project, get **[Ghostfolio Premium](https://ghostfol.io/pricing)** or **[Buy me a coffee](https://www.buymeacoffee.com/ghostfolio)**.
-
 ## License
 
 © 2022 [Ghostfolio](https://ghostfol.io)

angular.json

@@ -2,7 +2,6 @@
   "version": 1,
   "projects": {
     "api": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "root": "apps/api",
       "sourceRoot": "apps/api/src",
       "projectType": "application",
@@ -10,7 +9,7 @@
       "schematics": {},
       "architect": {
         "build": {
-          "builder": "@nrwl/node:webpack",
+          "builder": "@nrwl/node:build",
           "options": {
             "outputPath": "dist/apps/api",
             "main": "apps/api/src/main.ts",
@@ -34,7 +33,7 @@
           "outputs": ["{options.outputPath}"]
         },
         "serve": {
-          "builder": "@nrwl/node:node",
+          "builder": "@nrwl/node:execute",
           "options": {
             "buildTarget": "api:build"
           }
@@ -48,7 +47,7 @@
         "test": {
           "builder": "@nrwl/jest:jest",
           "options": {
-            "jestConfig": "apps/api/jest.config.ts",
+            "jestConfig": "apps/api/jest.config.js",
             "passWithNoTests": true
           },
           "outputs": ["coverage/apps/api"]
@@ -57,7 +56,6 @@
       "tags": []
     },
     "client": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "projectType": "application",
       "schematics": {
         "@schematics/angular:component": {
@@ -115,7 +113,7 @@
               }
             ],
             "styles": ["apps/client/src/styles.scss"],
-            "scripts": ["node_modules/marked/marked.min.js"],
+            "scripts": ["node_modules/marked/lib/marked.js"],
             "vendorChunk": true,
             "extractLicenses": false,
             "buildOptimizer": false,
@@ -182,7 +180,7 @@
         "test": {
           "builder": "@nrwl/jest:jest",
           "options": {
-            "jestConfig": "apps/client/jest.config.ts",
+            "jestConfig": "apps/client/jest.config.js",
             "passWithNoTests": true
           },
           "outputs": ["coverage/apps/client"]
@@ -191,7 +189,6 @@
       "tags": []
     },
     "client-e2e": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "root": "apps/client-e2e",
       "sourceRoot": "apps/client-e2e/src",
       "projectType": "application",
@@ -214,7 +211,6 @@
       "implicitDependencies": ["client"]
     },
     "common": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "root": "libs/common",
       "sourceRoot": "libs/common/src",
       "projectType": "library",
@@ -229,7 +225,7 @@
           "builder": "@nrwl/jest:jest",
           "outputs": ["coverage/libs/common"],
           "options": {
-            "jestConfig": "libs/common/jest.config.ts",
+            "jestConfig": "libs/common/jest.config.js",
             "passWithNoTests": true
           }
         }
@@ -237,7 +233,6 @@
       "tags": []
     },
     "ui": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "projectType": "library",
       "schematics": {
         "@schematics/angular:component": {
@@ -252,7 +247,7 @@
           "builder": "@nrwl/jest:jest",
           "outputs": ["coverage/libs/ui"],
           "options": {
-            "jestConfig": "libs/ui/jest.config.ts",
+            "jestConfig": "libs/ui/jest.config.js",
             "passWithNoTests": true
           }
         },
@@ -263,12 +258,14 @@
           }
         },
         "storybook": {
-          "builder": "@storybook/angular:start-storybook",
+          "builder": "@nrwl/storybook:storybook",
           "options": {
+            "uiFramework": "@storybook/angular",
             "port": 4400,
-            "configDir": "libs/ui/.storybook",
+            "config": {
-            "browserTarget": "ui:build-storybook",
+              "configFolder": "libs/ui/.storybook"
-            "compodoc": false
+            },
+            "projectBuildConfig": "ui:build-storybook"
           },
           "configurations": {
             "ci": {
@@ -277,13 +274,15 @@
           }
         },
         "build-storybook": {
-          "builder": "@storybook/angular:build-storybook",
+          "builder": "@nrwl/storybook:build",
           "outputs": ["{options.outputPath}"],
           "options": {
-            "outputDir": "dist/storybook/ui",
+            "uiFramework": "@storybook/angular",
-            "configDir": "libs/ui/.storybook",
+            "outputPath": "dist/storybook/ui",
-            "browserTarget": "ui:build-storybook",
+            "config": {
-            "compodoc": false
+              "configFolder": "libs/ui/.storybook"
+            },
+            "projectBuildConfig": "ui:build-storybook"
           },
           "configurations": {
             "ci": {
@@ -295,7 +294,6 @@
       "tags": []
     },
     "ui-e2e": {
-      "$schema": "../../node_modules/nx/schemas/project-schema.json",
       "root": "apps/ui-e2e",
       "sourceRoot": "apps/ui-e2e/src",
       "projectType": "application",

apps/api/jest.config.js

@@ -1,6 +1,6 @@
-export default {
+module.exports = {
   displayName: 'api',
-
+  preset: '../../jest.preset.js',
   globals: {
     'ts-jest': {
       tsconfig: '<rootDir>/tsconfig.spec.json'
@@ -12,6 +12,5 @@ export default {
   moduleFileExtensions: ['ts', 'js', 'html'],
   coverageDirectory: '../../coverage/apps/api',
   testTimeout: 10000,
-  testEnvironment: 'node',
+  testEnvironment: 'node'
-  preset: '../../jest.preset.js'
 };

apps/api/src/app/access/access.controller.ts

@@ -78,12 +78,8 @@ export class AccessController {
   @Delete(':id')
   @UseGuards(AuthGuard('jwt'))
   public async deleteAccess(@Param('id') id: string): Promise<AccessModule> {
-    const access = await this.accessService.access({ id });
-
     if (
-      !hasPermission(this.request.user.permissions, permissions.deleteAccess) ||
+      !hasPermission(this.request.user.permissions, permissions.deleteAccess)
-      !access ||
-      access.userId !== this.request.user.id
     ) {
       throw new HttpException(
         getReasonPhrase(StatusCodes.FORBIDDEN),
@@ -92,7 +88,10 @@ export class AccessController {
     }
 
     return this.accessService.deleteAccess({
-      id
+      id_userId: {
+        id,
+        userId: this.request.user.id
+      }
     });
   }
 }

apps/api/src/app/account/account.controller.ts

@@ -1,4 +1,4 @@
-import { PortfolioService } from '@ghostfolio/api/app/portfolio/portfolio.service';
+import { PortfolioServiceStrategy } from '@ghostfolio/api/app/portfolio/portfolio-service.strategy';
 import { UserService } from '@ghostfolio/api/app/user/user.service';
 import {
   nullifyValuesInObject,
@@ -7,10 +7,7 @@ import {
 import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
 import { Accounts } from '@ghostfolio/common/interfaces';
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
-import type {
+import type { RequestWithUser } from '@ghostfolio/common/types';
-  AccountWithValue,
-  RequestWithUser
-} from '@ghostfolio/common/types';
 import {
   Body,
   Controller,
@@ -38,7 +35,7 @@ export class AccountController {
   public constructor(
     private readonly accountService: AccountService,
     private readonly impersonationService: ImpersonationService,
-    private readonly portfolioService: PortfolioService,
+    private readonly portfolioServiceStrategy: PortfolioServiceStrategy,
     @Inject(REQUEST) private readonly request: RequestWithUser,
     private readonly userService: UserService
   ) {}
@@ -94,10 +91,9 @@ export class AccountController {
         this.request.user.id
       );
 
-    let accountsWithAggregations =
+    let accountsWithAggregations = await this.portfolioServiceStrategy
-      await this.portfolioService.getAccountsWithAggregations(
+      .get()
-        impersonationUserId || this.request.user.id
+      .getAccountsWithAggregations(impersonationUserId || this.request.user.id);
-      );
 
     if (
       impersonationUserId ||
@@ -105,18 +101,16 @@ export class AccountController {
     ) {
       accountsWithAggregations = {
         ...nullifyValuesInObject(accountsWithAggregations, [
-          'totalBalanceInBaseCurrency',
+          'totalBalance',
-          'totalValueInBaseCurrency'
+          'totalValue'
         ]),
         accounts: nullifyValuesInObjects(accountsWithAggregations.accounts, [
           'balance',
-          'balanceInBaseCurrency',
           'convertedBalance',
           'fee',
           'quantity',
           'unitPrice',
-          'value',
+          'value'
-          'valueInBaseCurrency'
         ])
       };
     }
@@ -126,45 +120,13 @@ export class AccountController {
 
   @Get(':id')
   @UseGuards(AuthGuard('jwt'))
-  public async getAccountById(
+  public async getAccountById(@Param('id') id: string): Promise<AccountModel> {
-    @Headers('impersonation-id') impersonationId,
+    return this.accountService.account({
-    @Param('id') id: string
+      id_userId: {
-  ): Promise<AccountWithValue> {
+        id,
-    const impersonationUserId =
+        userId: this.request.user.id
-      await this.impersonationService.validateImpersonationId(
+      }
-        impersonationId,
+    });
-        this.request.user.id
-      );
-
-    let accountsWithAggregations =
-      await this.portfolioService.getAccountsWithAggregations(
-        impersonationUserId || this.request.user.id,
-        [{ id, type: 'ACCOUNT' }]
-      );
-
-    if (
-      impersonationUserId ||
-      this.userService.isRestrictedView(this.request.user)
-    ) {
-      accountsWithAggregations = {
-        ...nullifyValuesInObject(accountsWithAggregations, [
-          'totalBalanceInBaseCurrency',
-          'totalValueInBaseCurrency'
-        ]),
-        accounts: nullifyValuesInObjects(accountsWithAggregations.accounts, [
-          'balance',
-          'balanceInBaseCurrency',
-          'convertedBalance',
-          'fee',
-          'quantity',
-          'unitPrice',
-          'value',
-          'valueInBaseCurrency'
-        ])
-      };
-    }
-
-    return accountsWithAggregations.accounts[0];
   }
 
   @Post()

apps/api/src/app/account/account.service.ts

@@ -1,10 +1,7 @@
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
-import { Filter } from '@ghostfolio/common/interfaces';
 import { Injectable } from '@nestjs/common';
 import { Account, Order, Platform, Prisma } from '@prisma/client';
-import Big from 'big.js';
-import { groupBy } from 'lodash';
 
 import { CashDetails } from './interfaces/cash-details.interface';
 
@@ -104,51 +101,25 @@ export class AccountService {
     });
   }
 
-  public async getCashDetails({
+  public async getCashDetails(
-    currency,
+    aUserId: string,
-    filters = [],
+    aCurrency: string
-    userId
+  ): Promise<CashDetails> {
-  }: {
+    let totalCashBalance = 0;
-    currency: string;
-    filters?: Filter[];
-    userId: string;
-  }): Promise<CashDetails> {
-    let totalCashBalanceInBaseCurrency = new Big(0);
 
-    const where: Prisma.AccountWhereInput = { userId };
+    const accounts = await this.accounts({
-
+      where: { userId: aUserId }
-    const {
-      ACCOUNT: filtersByAccount,
-      ASSET_CLASS: filtersByAssetClass,
-      TAG: filtersByTag
-    } = groupBy(filters, (filter) => {
-      return filter.type;
     });
 
-    if (filtersByAccount?.length > 0) {
+    accounts.forEach((account) => {
-      where.id = {
+      totalCashBalance += this.exchangeRateDataService.toCurrency(
-        in: filtersByAccount.map(({ id }) => {
+        account.balance,
-          return id;
+        account.currency,
-        })
+        aCurrency
-      };
-    }
-
-    const accounts = await this.accounts({ where });
-
-    for (const account of accounts) {
-      totalCashBalanceInBaseCurrency = totalCashBalanceInBaseCurrency.plus(
-        this.exchangeRateDataService.toCurrency(
-          account.balance,
-          account.currency,
-          currency
-        )
       );
-    }
+    });
 
-    return {
+    return { accounts, balance: totalCashBalance };
-      accounts,
-      balanceInBaseCurrency: totalCashBalanceInBaseCurrency.toNumber()
-    };
   }
 
   public async updateAccount(

apps/api/src/app/account/interfaces/cash-details.interface.ts

@@ -2,5 +2,5 @@ import { Account } from '@prisma/client';
 
 export interface CashDetails {
   accounts: Account[];
-  balanceInBaseCurrency: number;
+  balance: number;
 }

apps/api/src/app/admin/admin.controller.ts

@@ -1,10 +1,6 @@
 import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { MarketDataService } from '@ghostfolio/api/services/market-data.service';
 import { PropertyDto } from '@ghostfolio/api/services/property/property.dto';
-import {
-  GATHER_ASSET_PROFILE_PROCESS,
-  GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-} from '@ghostfolio/common/config';
 import {
   AdminData,
   AdminMarketData,
@@ -60,24 +56,6 @@ export class AdminController {
     return this.adminService.get();
   }
 
-  @Post('gather')
-  @UseGuards(AuthGuard('jwt'))
-  public async gather7Days(): Promise<void> {
-    if (
-      !hasPermission(
-        this.request.user.permissions,
-        permissions.accessAdminControl
-      )
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    this.dataGatheringService.gather7Days();
-  }
-
   @Post('gather/max')
   @UseGuards(AuthGuard('jwt'))
   public async gatherMax(): Promise<void> {
@@ -93,20 +71,10 @@ export class AdminController {
       );
     }
 
-    const uniqueAssets = await this.dataGatheringService.getUniqueAssets();
+    await this.dataGatheringService.gatherProfileData();
-
-    for (const { dataSource, symbol } of uniqueAssets) {
-      await this.dataGatheringService.addJobToQueue(
-        GATHER_ASSET_PROFILE_PROCESS,
-        {
-          dataSource,
-          symbol
-        },
-        GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-      );
-    }
-
     this.dataGatheringService.gatherMax();
+
+    return;
   }
 
   @Post('gather/profile-data')
@@ -124,18 +92,9 @@ export class AdminController {
       );
     }
 
-    const uniqueAssets = await this.dataGatheringService.getUniqueAssets();
+    this.dataGatheringService.gatherProfileData();
 
-    for (const { dataSource, symbol } of uniqueAssets) {
+    return;
-      await this.dataGatheringService.addJobToQueue(
-        GATHER_ASSET_PROFILE_PROCESS,
-        {
-          dataSource,
-          symbol
-        },
-        GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-      );
-    }
   }
 
   @Post('gather/profile-data/:dataSource/:symbol')
@@ -156,14 +115,9 @@ export class AdminController {
       );
     }
 
-    await this.dataGatheringService.addJobToQueue(
+    this.dataGatheringService.gatherProfileData([{ dataSource, symbol }]);
-      GATHER_ASSET_PROFILE_PROCESS,
+
-      {
+    return;
-        dataSource,
-        symbol
-      },
-      GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-    );
   }
 
   @Post('gather/:dataSource/:symbol')

apps/api/src/app/admin/admin.module.ts

@@ -11,7 +11,6 @@ import { Module } from '@nestjs/common';
 
 import { AdminController } from './admin.controller';
 import { AdminService } from './admin.service';
-import { QueueModule } from './queue/queue.module';
 
 @Module({
   imports: [
@@ -22,7 +21,6 @@ import { QueueModule } from './queue/queue.module';
     MarketDataModule,
     PrismaModule,
     PropertyModule,
-    QueueModule,
     SubscriptionModule,
     SymbolProfileModule
   ],

apps/api/src/app/admin/admin.service.ts

@@ -6,22 +6,19 @@ import { MarketDataService } from '@ghostfolio/api/services/market-data.service'
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { PropertyService } from '@ghostfolio/api/services/property/property.service';
 import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
-import { PROPERTY_CURRENCIES } from '@ghostfolio/common/config';
+import { PROPERTY_CURRENCIES, baseCurrency } from '@ghostfolio/common/config';
 import {
   AdminData,
   AdminMarketData,
   AdminMarketDataDetails,
-  AdminMarketDataItem,
+  AdminMarketDataItem
-  UniqueAsset
 } from '@ghostfolio/common/interfaces';
 import { Injectable } from '@nestjs/common';
-import { Property } from '@prisma/client';
+import { DataSource, Property } from '@prisma/client';
 import { differenceInDays } from 'date-fns';
 
 @Injectable()
 export class AdminService {
-  private baseCurrency: string;
-
   public constructor(
     private readonly configurationService: ConfigurationService,
     private readonly dataGatheringService: DataGatheringService,
@@ -31,33 +28,40 @@ export class AdminService {
     private readonly propertyService: PropertyService,
     private readonly subscriptionService: SubscriptionService,
     private readonly symbolProfileService: SymbolProfileService
-  ) {
+  ) {}
-    this.baseCurrency = this.configurationService.get('BASE_CURRENCY');
-  }
 
-  public async deleteProfileData({ dataSource, symbol }: UniqueAsset) {
+  public async deleteProfileData({
+    dataSource,
+    symbol
+  }: {
+    dataSource: DataSource;
+    symbol: string;
+  }) {
     await this.marketDataService.deleteMany({ dataSource, symbol });
     await this.symbolProfileService.delete({ dataSource, symbol });
   }
 
   public async get(): Promise<AdminData> {
     return {
+      dataGatheringProgress:
+        await this.dataGatheringService.getDataGatheringProgress(),
       exchangeRates: this.exchangeRateDataService
         .getCurrencies()
         .filter((currency) => {
-          return currency !== this.baseCurrency;
+          return currency !== baseCurrency;
         })
         .map((currency) => {
           return {
-            label1: this.baseCurrency,
+            label1: baseCurrency,
             label2: currency,
             value: this.exchangeRateDataService.toCurrency(
               1,
-              this.baseCurrency,
+              baseCurrency,
               currency
             )
           };
         }),
+      lastDataGathering: await this.getLastDataGathering(),
       settings: await this.propertyService.get(),
       transactionCount: await this.prismaService.order.count(),
       userCount: await this.prismaService.user.count(),
@@ -133,7 +137,10 @@ export class AdminService {
   public async getMarketDataBySymbol({
     dataSource,
     symbol
-  }: UniqueAsset): Promise<AdminMarketDataDetails> {
+  }: {
+    dataSource: DataSource;
+    symbol: string;
+  }): Promise<AdminMarketDataDetails> {
     return {
       marketData: await this.marketDataService.marketDataItems({
         orderBy: {
@@ -158,11 +165,30 @@ export class AdminService {
 
     if (key === PROPERTY_CURRENCIES) {
       await this.exchangeRateDataService.initialize();
+      await this.dataGatheringService.reset();
     }
 
     return response;
   }
 
+  private async getLastDataGathering() {
+    const lastDataGathering =
+      await this.dataGatheringService.getLastDataGathering();
+
+    if (lastDataGathering) {
+      return lastDataGathering;
+    }
+
+    const dataGatheringInProgress =
+      await this.dataGatheringService.getIsInProgress();
+
+    if (dataGatheringInProgress) {
+      return 'IN_PROGRESS';
+    }
+
+    return undefined;
+  }
+
   private async getUsersWithAnalytics(): Promise<AdminData['users']> {
     const usersWithAnalytics = await this.prismaService.user.findMany({
       orderBy: {

apps/api/src/app/admin/queue/queue.controller.ts

@@ -1,87 +0,0 @@
-import { AdminJobs } from '@ghostfolio/common/interfaces';
-import { hasPermission, permissions } from '@ghostfolio/common/permissions';
-import type { RequestWithUser } from '@ghostfolio/common/types';
-import {
-  Controller,
-  Delete,
-  Get,
-  HttpException,
-  Inject,
-  Param,
-  Query,
-  UseGuards
-} from '@nestjs/common';
-import { REQUEST } from '@nestjs/core';
-import { AuthGuard } from '@nestjs/passport';
-import { JobStatus } from 'bull';
-import { StatusCodes, getReasonPhrase } from 'http-status-codes';
-
-import { QueueService } from './queue.service';
-
-@Controller('admin/queue')
-export class QueueController {
-  public constructor(
-    private readonly queueService: QueueService,
-    @Inject(REQUEST) private readonly request: RequestWithUser
-  ) {}
-
-  @Delete('job')
-  @UseGuards(AuthGuard('jwt'))
-  public async deleteJobs(
-    @Query('status') filterByStatus?: string
-  ): Promise<void> {
-    if (
-      !hasPermission(
-        this.request.user.permissions,
-        permissions.accessAdminControl
-      )
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    const status = <JobStatus[]>filterByStatus?.split(',') ?? undefined;
-    return this.queueService.deleteJobs({ status });
-  }
-
-  @Get('job')
-  @UseGuards(AuthGuard('jwt'))
-  public async getJobs(
-    @Query('status') filterByStatus?: string
-  ): Promise<AdminJobs> {
-    if (
-      !hasPermission(
-        this.request.user.permissions,
-        permissions.accessAdminControl
-      )
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    const status = <JobStatus[]>filterByStatus?.split(',') ?? undefined;
-    return this.queueService.getJobs({ status });
-  }
-
-  @Delete('job/:id')
-  @UseGuards(AuthGuard('jwt'))
-  public async deleteJob(@Param('id') id: string): Promise<void> {
-    if (
-      !hasPermission(
-        this.request.user.permissions,
-        permissions.accessAdminControl
-      )
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    return this.queueService.deleteJob(id);
-  }
-}

apps/api/src/app/admin/queue/queue.module.ts

@@ -1,12 +0,0 @@
-import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
-import { Module } from '@nestjs/common';
-
-import { QueueController } from './queue.controller';
-import { QueueService } from './queue.service';
-
-@Module({
-  controllers: [QueueController],
-  imports: [DataGatheringModule],
-  providers: [QueueService]
-})
-export class QueueModule {}

apps/api/src/app/admin/queue/queue.service.ts

@@ -1,65 +0,0 @@
-import {
-  DATA_GATHERING_QUEUE,
-  QUEUE_JOB_STATUS_LIST
-} from '@ghostfolio/common/config';
-import { AdminJobs } from '@ghostfolio/common/interfaces';
-import { InjectQueue } from '@nestjs/bull';
-import { Injectable, Logger } from '@nestjs/common';
-import { JobStatus, Queue } from 'bull';
-
-@Injectable()
-export class QueueService {
-  public constructor(
-    @InjectQueue(DATA_GATHERING_QUEUE)
-    private readonly dataGatheringQueue: Queue
-  ) {}
-
-  public async deleteJob(aId: string) {
-    return (await this.dataGatheringQueue.getJob(aId))?.remove();
-  }
-
-  public async deleteJobs({
-    status = QUEUE_JOB_STATUS_LIST
-  }: {
-    status?: JobStatus[];
-  }) {
-    const jobs = await this.dataGatheringQueue.getJobs(status);
-
-    for (const job of jobs) {
-      try {
-        await job.remove();
-      } catch (error) {
-        Logger.warn(error, 'QueueService');
-      }
-    }
-  }
-
-  public async getJobs({
-    limit = 1000,
-    status = QUEUE_JOB_STATUS_LIST
-  }: {
-    limit?: number;
-    status?: JobStatus[];
-  }): Promise<AdminJobs> {
-    const jobs = await this.dataGatheringQueue.getJobs(status);
-
-    const jobsWithState = await Promise.all(
-      jobs.slice(0, limit).map(async (job) => {
-        return {
-          attemptsMade: job.attemptsMade + 1,
-          data: job.data,
-          finishedOn: job.finishedOn,
-          id: job.id,
-          name: job.name,
-          stacktrace: job.stacktrace,
-          state: await job.getState(),
-          timestamp: job.timestamp
-        };
-      })
-    );
-
-    return {
-      jobs: jobsWithState
-    };
-  }
-}

apps/api/src/app/app.controller.ts

@@ -1,6 +1,26 @@
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { Controller } from '@nestjs/common';
 
+import { RedisCacheService } from './redis-cache/redis-cache.service';
+
 @Controller()
 export class AppController {
-  public constructor() {}
+  public constructor(
+    private readonly dataGatheringService: DataGatheringService,
+    private readonly redisCacheService: RedisCacheService
+  ) {
+    this.initialize();
+  }
+
+  private async initialize() {
+    this.redisCacheService.reset();
+
+    const isDataGatheringInProgress =
+      await this.dataGatheringService.getIsInProgress();
+
+    if (isDataGatheringInProgress) {
+      // Prepare for automatical data gathering, if hung up in progress state
+      await this.dataGatheringService.reset();
+    }
+  }
 }

apps/api/src/app/app.module.ts

@@ -9,7 +9,6 @@ import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-
 import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-data.module';
 import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { TwitterBotModule } from '@ghostfolio/api/services/twitter-bot/twitter-bot.module';
-import { BullModule } from '@nestjs/bull';
 import { Module } from '@nestjs/common';
 import { ConfigModule } from '@nestjs/config';
 import { ScheduleModule } from '@nestjs/schedule';
@@ -20,7 +19,6 @@ import { AccountModule } from './account/account.module';
 import { AdminModule } from './admin/admin.module';
 import { AppController } from './app.controller';
 import { AuthModule } from './auth/auth.module';
-import { BenchmarkModule } from './benchmark/benchmark.module';
 import { CacheModule } from './cache/cache.module';
 import { ExportModule } from './export/export.module';
 import { ImportModule } from './import/import.module';
@@ -38,14 +36,6 @@ import { UserModule } from './user/user.module';
     AccountModule,
     AuthDeviceModule,
     AuthModule,
-    BenchmarkModule,
-    BullModule.forRoot({
-      redis: {
-        host: process.env.REDIS_HOST,
-        port: parseInt(process.env.REDIS_PORT, 10),
-        password: process.env.REDIS_PASSWORD
-      }
-    }),
     CacheModule,
     ConfigModule.forRoot(),
     ConfigurationModule,

apps/api/src/app/auth/auth.controller.ts

@@ -9,9 +9,7 @@ import {
   Post,
   Req,
   Res,
-  UseGuards,
+  UseGuards
-  VERSION_NEUTRAL,
-  Version
 } from '@nestjs/common';
 import { AuthGuard } from '@nestjs/passport';
 import { StatusCodes, getReasonPhrase } from 'http-status-codes';
@@ -53,7 +51,6 @@ export class AuthController {
 
   @Get('google/callback')
   @UseGuards(AuthGuard('google'))
-  @Version(VERSION_NEUTRAL)
   public googleLoginCallback(@Req() req, @Res() res) {
     // Handles the Google OAuth2 callback
     const jwt: string = req.user.jwt;

apps/api/src/app/auth/google.strategy.ts

@@ -42,7 +42,7 @@ export class GoogleStrategy extends PassportStrategy(Strategy, 'google') {
 
       done(null, user);
     } catch (error) {
-      Logger.error(error, 'GoogleStrategy');
+      Logger.error(error);
       done(error, false);
     }
   }

apps/api/src/app/auth/web-auth.service.ts

@@ -95,7 +95,7 @@ export class WebAuthService {
       };
       verification = await verifyRegistrationResponse(opts);
     } catch (error) {
-      Logger.error(error, 'WebAuthService');
+      Logger.error(error);
       throw new InternalServerErrorException(error.message);
     }
 
@@ -193,7 +193,7 @@ export class WebAuthService {
       };
       verification = verifyAuthenticationResponse(opts);
     } catch (error) {
-      Logger.error(error, 'WebAuthService');
+      Logger.error(error);
       throw new InternalServerErrorException({ error: error.message });
     }
 

apps/api/src/app/benchmark/benchmark.controller.ts

@@ -1,30 +0,0 @@
-import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-request.interceptor';
-import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response.interceptor';
-import { PropertyService } from '@ghostfolio/api/services/property/property.service';
-import { PROPERTY_BENCHMARKS } from '@ghostfolio/common/config';
-import { BenchmarkResponse, UniqueAsset } from '@ghostfolio/common/interfaces';
-import { Controller, Get, UseInterceptors } from '@nestjs/common';
-
-import { BenchmarkService } from './benchmark.service';
-
-@Controller('benchmark')
-export class BenchmarkController {
-  public constructor(
-    private readonly benchmarkService: BenchmarkService,
-    private readonly propertyService: PropertyService
-  ) {}
-
-  @Get()
-  @UseInterceptors(TransformDataSourceInRequestInterceptor)
-  @UseInterceptors(TransformDataSourceInResponseInterceptor)
-  public async getBenchmark(): Promise<BenchmarkResponse> {
-    const benchmarkAssets: UniqueAsset[] =
-      ((await this.propertyService.getByKey(
-        PROPERTY_BENCHMARKS
-      )) as UniqueAsset[]) ?? [];
-
-    return {
-      benchmarks: await this.benchmarkService.getBenchmarks(benchmarkAssets)
-    };
-  }
-}

apps/api/src/app/benchmark/benchmark.module.ts

@@ -1,25 +0,0 @@
-import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
-import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
-import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
-import { MarketDataModule } from '@ghostfolio/api/services/market-data.module';
-import { PropertyModule } from '@ghostfolio/api/services/property/property.module';
-import { SymbolProfileModule } from '@ghostfolio/api/services/symbol-profile.module';
-import { Module } from '@nestjs/common';
-
-import { BenchmarkController } from './benchmark.controller';
-import { BenchmarkService } from './benchmark.service';
-
-@Module({
-  controllers: [BenchmarkController],
-  exports: [BenchmarkService],
-  imports: [
-    ConfigurationModule,
-    DataProviderModule,
-    MarketDataModule,
-    PropertyModule,
-    RedisCacheModule,
-    SymbolProfileModule
-  ],
-  providers: [BenchmarkService]
-})
-export class BenchmarkModule {}

apps/api/src/app/benchmark/benchmark.service.ts

@@ -1,84 +0,0 @@
-import { RedisCacheService } from '@ghostfolio/api/app/redis-cache/redis-cache.service';
-import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
-import { MarketDataService } from '@ghostfolio/api/services/market-data.service';
-import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
-import { BenchmarkResponse, UniqueAsset } from '@ghostfolio/common/interfaces';
-import { Injectable } from '@nestjs/common';
-import Big from 'big.js';
-
-@Injectable()
-export class BenchmarkService {
-  private readonly CACHE_KEY_BENCHMARKS = 'BENCHMARKS';
-
-  public constructor(
-    private readonly dataProviderService: DataProviderService,
-    private readonly marketDataService: MarketDataService,
-    private readonly redisCacheService: RedisCacheService,
-    private readonly symbolProfileService: SymbolProfileService
-  ) {}
-
-  public async getBenchmarks(
-    benchmarkAssets: UniqueAsset[]
-  ): Promise<BenchmarkResponse['benchmarks']> {
-    let benchmarks: BenchmarkResponse['benchmarks'];
-
-    try {
-      benchmarks = JSON.parse(
-        await this.redisCacheService.get(this.CACHE_KEY_BENCHMARKS)
-      );
-
-      if (benchmarks) {
-        return benchmarks;
-      }
-    } catch {}
-
-    const promises: Promise<number>[] = [];
-
-    const [quotes, assetProfiles] = await Promise.all([
-      this.dataProviderService.getQuotes(benchmarkAssets),
-      this.symbolProfileService.getSymbolProfiles(benchmarkAssets)
-    ]);
-
-    for (const benchmarkAsset of benchmarkAssets) {
-      promises.push(this.marketDataService.getMax(benchmarkAsset));
-    }
-
-    const allTimeHighs = await Promise.all(promises);
-
-    benchmarks = allTimeHighs.map((allTimeHigh, index) => {
-      const { marketPrice } = quotes[benchmarkAssets[index].symbol];
-
-      const performancePercentFromAllTimeHigh = new Big(marketPrice)
-        .div(allTimeHigh)
-        .minus(1);
-
-      return {
-        marketCondition: this.getMarketCondition(
-          performancePercentFromAllTimeHigh
-        ),
-        name: assetProfiles.find(({ dataSource, symbol }) => {
-          return (
-            dataSource === benchmarkAssets[index].dataSource &&
-            symbol === benchmarkAssets[index].symbol
-          );
-        })?.name,
-        performances: {
-          allTimeHigh: {
-            performancePercent: performancePercentFromAllTimeHigh.toNumber()
-          }
-        }
-      };
-    });
-
-    await this.redisCacheService.set(
-      this.CACHE_KEY_BENCHMARKS,
-      JSON.stringify(benchmarks)
-    );
-
-    return benchmarks;
-  }
-
-  private getMarketCondition(aPerformanceInPercent: Big) {
-    return aPerformanceInPercent.lte(-0.2) ? 'BEAR_MARKET' : 'NEUTRAL_MARKET';
-  }
-}

apps/api/src/app/cache/cache.controller.ts

@@ -1,39 +1,25 @@
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { RedisCacheService } from '@ghostfolio/api/app/redis-cache/redis-cache.service';
-import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import type { RequestWithUser } from '@ghostfolio/common/types';
-import {
+import { Controller, Inject, Post, UseGuards } from '@nestjs/common';
-  Controller,
-  HttpException,
-  Inject,
-  Post,
-  UseGuards
-} from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { AuthGuard } from '@nestjs/passport';
-import { StatusCodes, getReasonPhrase } from 'http-status-codes';
 
 @Controller('cache')
 export class CacheController {
   public constructor(
+    private readonly cacheService: CacheService,
     private readonly redisCacheService: RedisCacheService,
     @Inject(REQUEST) private readonly request: RequestWithUser
-  ) {}
+  ) {
+    this.redisCacheService.reset();
+  }
 
   @Post('flush')
   @UseGuards(AuthGuard('jwt'))
   public async flushCache(): Promise<void> {
-    if (
+    this.redisCacheService.reset();
-      !hasPermission(
-        this.request.user.permissions,
-        permissions.accessAdminControl
-      )
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
 
-    return this.redisCacheService.reset();
+    return this.cacheService.flush();
   }
 }

apps/api/src/app/cache/cache.module.ts

@@ -1,3 +1,4 @@
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { RedisCacheModule } from '@ghostfolio/api/app/redis-cache/redis-cache.module';
 import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
 import { DataGatheringModule } from '@ghostfolio/api/services/data-gathering.module';
@@ -10,6 +11,7 @@ import { Module } from '@nestjs/common';
 import { CacheController } from './cache.controller';
 
 @Module({
+  exports: [CacheService],
   controllers: [CacheController],
   imports: [
     ConfigurationModule,
@@ -19,6 +21,7 @@ import { CacheController } from './cache.controller';
     PrismaModule,
     RedisCacheModule,
     SymbolProfileModule
-  ]
+  ],
+  providers: [CacheService]
 })
 export class CacheModule {}

apps/api/src/app/cache/cache.service.ts

@@ -0,0 +1,15 @@
+import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
+import { Injectable } from '@nestjs/common';
+
+@Injectable()
+export class CacheService {
+  public constructor(
+    private readonly dataGaterhingService: DataGatheringService
+  ) {}
+
+  public async flush(): Promise<void> {
+    await this.dataGaterhingService.reset();
+
+    return;
+  }
+}

apps/api/src/app/export/export.controller.ts

@@ -1,6 +1,13 @@
 import { Export } from '@ghostfolio/common/interfaces';
 import type { RequestWithUser } from '@ghostfolio/common/types';
-import { Controller, Get, Inject, Query, UseGuards } from '@nestjs/common';
+import {
+  Controller,
+  Get,
+  Headers,
+  Inject,
+  Query,
+  UseGuards
+} from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { AuthGuard } from '@nestjs/passport';
 

apps/api/src/app/export/export.service.ts

@@ -14,10 +14,12 @@ export class ExportService {
     activityIds?: string[];
     userId: string;
   }): Promise<Export> {
-    let activities = await this.prismaService.order.findMany({
+    let orders = await this.prismaService.order.findMany({
       orderBy: { date: 'desc' },
       select: {
         accountId: true,
+        currency: true,
+        dataSource: true,
         date: true,
         fee: true,
         id: true,
@@ -30,19 +32,19 @@ export class ExportService {
     });
 
     if (activityIds) {
-      activities = activities.filter((activity) => {
+      orders = orders.filter((order) => {
-        return activityIds.includes(activity.id);
+        return activityIds.includes(order.id);
       });
     }
 
     return {
       meta: { date: new Date().toISOString(), version: environment.version },
-      activities: activities.map(
+      orders: orders.map(
         ({
           accountId,
+          currency,
           date,
           fee,
-          id,
           quantity,
           SymbolProfile,
           type,
@@ -50,14 +52,13 @@ export class ExportService {
         }) => {
           return {
             accountId,
+            currency,
+            date,
             fee,
-            id,
             quantity,
             type,
             unitPrice,
-            currency: SymbolProfile.currency,
             dataSource: SymbolProfile.dataSource,
-            date: date.toISOString(),
             symbol: type === 'ITEM' ? SymbolProfile.name : SymbolProfile.symbol
           };
         }

apps/api/src/app/import/import-data.dto.ts

@@ -1,4 +1,5 @@
 import { CreateOrderDto } from '@ghostfolio/api/app/order/create-order.dto';
+import { Order } from '@prisma/client';
 import { Type } from 'class-transformer';
 import { IsArray, ValidateNested } from 'class-validator';
 
@@ -6,5 +7,5 @@ export class ImportDataDto {
   @IsArray()
   @Type(() => CreateOrderDto)
   @ValidateNested({ each: true })
-  activities: CreateOrderDto[];
+  orders: Order[];
 }

apps/api/src/app/import/import.controller.ts

@@ -36,11 +36,11 @@ export class ImportController {
 
     try {
       return await this.importService.import({
-        activities: importData.activities,
+        orders: importData.orders,
         userId: this.request.user.id
       });
     } catch (error) {
-      Logger.error(error, ImportController);
+      Logger.error(error);
 
       throw new HttpException(
         {

apps/api/src/app/import/import.service.ts

@@ -1,9 +1,9 @@
 import { AccountService } from '@ghostfolio/api/app/account/account.service';
-import { CreateOrderDto } from '@ghostfolio/api/app/order/create-order.dto';
 import { OrderService } from '@ghostfolio/api/app/order/order.service';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
 import { Injectable } from '@nestjs/common';
+import { Order } from '@prisma/client';
 import { isSameDay, parseISO } from 'date-fns';
 
 @Injectable()
@@ -16,23 +16,23 @@ export class ImportService {
   ) {}
 
   public async import({
-    activities,
+    orders,
     userId
   }: {
-    activities: Partial<CreateOrderDto>[];
+    orders: Partial<Order>[];
     userId: string;
   }): Promise<void> {
-    for (const activity of activities) {
+    for (const order of orders) {
-      if (!activity.dataSource) {
+      if (!order.dataSource) {
-        if (activity.type === 'ITEM') {
+        if (order.type === 'ITEM') {
-          activity.dataSource = 'MANUAL';
+          order.dataSource = 'MANUAL';
         } else {
-          activity.dataSource = this.dataProviderService.getPrimaryDataSource();
+          order.dataSource = this.dataProviderService.getPrimaryDataSource();
         }
       }
     }
 
-    await this.validateActivities({ activities, userId });
+    await this.validateOrders({ orders, userId });
 
     const accountIds = (await this.accountService.getAccounts(userId)).map(
       (account) => {
@@ -50,10 +50,13 @@ export class ImportService {
       symbol,
       type,
       unitPrice
-    } of activities) {
+    } of orders) {
       await this.orderService.createOrder({
+        currency,
+        dataSource,
         fee,
         quantity,
+        symbol,
         type,
         unitPrice,
         userId,
@@ -62,7 +65,6 @@ export class ImportService {
         SymbolProfile: {
           connectOrCreate: {
             create: {
-              currency,
               dataSource,
               symbol
             },
@@ -79,25 +81,24 @@ export class ImportService {
     }
   }
 
-  private async validateActivities({
+  private async validateOrders({
-    activities,
+    orders,
     userId
   }: {
-    activities: Partial<CreateOrderDto>[];
+    orders: Partial<Order>[];
     userId: string;
   }) {
     if (
-      activities?.length > this.configurationService.get('MAX_ORDERS_TO_IMPORT')
+      orders?.length > this.configurationService.get('MAX_ORDERS_TO_IMPORT')
     ) {
       throw new Error(
-        `Too many activities (${this.configurationService.get(
+        `Too many transactions (${this.configurationService.get(
           'MAX_ORDERS_TO_IMPORT'
         )} at most)`
       );
     }
 
-    const existingActivities = await this.orderService.orders({
+    const existingOrders = await this.orderService.orders({
-      include: { SymbolProfile: true },
       orderBy: { date: 'desc' },
       where: { userId }
     });
@@ -105,38 +106,38 @@ export class ImportService {
     for (const [
       index,
       { currency, dataSource, date, fee, quantity, symbol, type, unitPrice }
-    ] of activities.entries()) {
+    ] of orders.entries()) {
-      const duplicateActivity = existingActivities.find((activity) => {
+      const duplicateOrder = existingOrders.find((order) => {
         return (
-          activity.SymbolProfile.currency === currency &&
+          order.currency === currency &&
-          activity.SymbolProfile.dataSource === dataSource &&
+          order.dataSource === dataSource &&
-          isSameDay(activity.date, parseISO(<string>(<unknown>date))) &&
+          isSameDay(order.date, parseISO(<string>(<unknown>date))) &&
-          activity.fee === fee &&
+          order.fee === fee &&
-          activity.quantity === quantity &&
+          order.quantity === quantity &&
-          activity.SymbolProfile.symbol === symbol &&
+          order.symbol === symbol &&
-          activity.type === type &&
+          order.type === type &&
-          activity.unitPrice === unitPrice
+          order.unitPrice === unitPrice
         );
       });
 
-      if (duplicateActivity) {
+      if (duplicateOrder) {
-        throw new Error(`activities.${index} is a duplicate activity`);
+        throw new Error(`orders.${index} is a duplicate transaction`);
       }
 
       if (dataSource !== 'MANUAL') {
-        const quotes = await this.dataProviderService.getQuotes([
+        const result = await this.dataProviderService.get([
           { dataSource, symbol }
         ]);
 
-        if (quotes[symbol] === undefined) {
+        if (result[symbol] === undefined) {
           throw new Error(
-            `activities.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")`
+            `orders.${index}.symbol ("${symbol}") is not valid for the specified data source ("${dataSource}")`
           );
         }
 
-        if (quotes[symbol].currency !== currency) {
+        if (result[symbol].currency !== currency) {
           throw new Error(
-            `activities.${index}.currency ("${currency}") does not match with "${quotes[symbol].currency}"`
+            `orders.${index}.currency ("${currency}") does not match with "${result[symbol].currency}"`
           );
         }
       }

apps/api/src/app/info/info.module.ts

@@ -6,7 +6,6 @@ import { ExchangeRateDataModule } from '@ghostfolio/api/services/exchange-rate-d
 import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { PropertyModule } from '@ghostfolio/api/services/property/property.module';
 import { SymbolProfileModule } from '@ghostfolio/api/services/symbol-profile.module';
-import { TagModule } from '@ghostfolio/api/services/tag/tag.module';
 import { Module } from '@nestjs/common';
 import { JwtModule } from '@nestjs/jwt';
 
@@ -27,8 +26,7 @@ import { InfoService } from './info.service';
     PrismaModule,
     PropertyModule,
     RedisCacheModule,
-    SymbolProfileModule,
+    SymbolProfileModule
-    TagModule
   ],
   providers: [InfoService]
 })

apps/api/src/app/info/info.service.ts

@@ -4,7 +4,6 @@ import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.se
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { PropertyService } from '@ghostfolio/api/services/property/property.service';
-import { TagService } from '@ghostfolio/api/services/tag/tag.service';
 import {
   DEMO_USER_ID,
   PROPERTY_IS_READ_ONLY_MODE,
@@ -34,8 +33,7 @@ export class InfoService {
     private readonly jwtService: JwtService,
     private readonly prismaService: PrismaService,
     private readonly propertyService: PropertyService,
-    private readonly redisCacheService: RedisCacheService,
+    private readonly redisCacheService: RedisCacheService
-    private readonly tagService: TagService
   ) {}
 
   public async get(): Promise<InfoItem> {
@@ -54,17 +52,9 @@ export class InfoService {
     }
 
     if (this.configurationService.get('ENABLE_FEATURE_FEAR_AND_GREED_INDEX')) {
-      if (
+      info.fearAndGreedDataSource = encodeDataSource(
-        this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION') === true
+        ghostfolioFearAndGreedIndexDataSource
-      ) {
+      );
-        info.fearAndGreedDataSource = encodeDataSource(
-          ghostfolioFearAndGreedIndexDataSource
-        );
-      } else {
-        info.fearAndGreedDataSource = ghostfolioFearAndGreedIndexDataSource;
-      }
-
-      globalPermissions.push(permissions.enableFearAndGreedIndex);
     }
 
     if (this.configurationService.get('ENABLE_FEATURE_IMPORT')) {
@@ -105,12 +95,11 @@ export class InfoService {
       isReadOnlyMode,
       platforms,
       systemMessage,
-      baseCurrency: this.configurationService.get('BASE_CURRENCY'),
       currencies: this.exchangeRateDataService.getCurrencies(),
       demoAuthToken: this.getDemoAuthToken(),
+      lastDataGathering: await this.getLastDataGathering(),
       statistics: await this.getStatistics(),
-      subscriptions: await this.getSubscriptions(),
+      subscriptions: await this.getSubscriptions()
-      tags: await this.tagService.get()
     };
   }
 
@@ -155,7 +144,7 @@ export class InfoService {
       const contributors = await get();
       return contributors?.length;
     } catch (error) {
-      Logger.error(error, 'InfoService');
+      Logger.error(error);
 
       return undefined;
     }
@@ -176,7 +165,7 @@ export class InfoService {
       const { stargazers_count } = await get();
       return stargazers_count;
     } catch (error) {
-      Logger.error(error, 'InfoService');
+      Logger.error(error);
 
       return undefined;
     }
@@ -216,6 +205,13 @@ export class InfoService {
     });
   }
 
+  private async getLastDataGathering() {
+    const lastDataGathering =
+      await this.dataGatheringService.getLastDataGathering();
+
+    return lastDataGathering ?? null;
+  }
+
   private async getStatistics() {
     if (!this.configurationService.get('ENABLE_FEATURE_STATISTICS')) {
       return undefined;

apps/api/src/app/order/create-order.dto.ts

@@ -1,4 +1,4 @@
-import { AssetClass, AssetSubClass, DataSource, Type } from '@prisma/client';
+import { DataSource, Type } from '@prisma/client';
 import {
   IsEnum,
   IsISO8601,
@@ -10,22 +10,14 @@ import {
 export class CreateOrderDto {
   @IsString()
   @IsOptional()
-  accountId?: string;
+  accountId: string;
-
-  @IsEnum(AssetClass, { each: true })
-  @IsOptional()
-  assetClass?: AssetClass;
-
-  @IsEnum(AssetSubClass, { each: true })
-  @IsOptional()
-  assetSubClass?: AssetSubClass;
 
   @IsString()
   currency: string;
 
   @IsEnum(DataSource, { each: true })
   @IsOptional()
-  dataSource?: DataSource;
+  dataSource: DataSource;
 
   @IsISO8601()
   date: string;

apps/api/src/app/order/order.controller.ts

@@ -1,10 +1,8 @@
 import { UserService } from '@ghostfolio/api/app/user/user.service';
 import { nullifyValuesInObjects } from '@ghostfolio/api/helper/object.helper';
-import { RedactValuesInResponseInterceptor } from '@ghostfolio/api/interceptors/redact-values-in-response.interceptor';
 import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-request.interceptor';
 import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response.interceptor';
 import { ImpersonationService } from '@ghostfolio/api/services/impersonation.service';
-import { Filter } from '@ghostfolio/common/interfaces';
 import { hasPermission, permissions } from '@ghostfolio/common/permissions';
 import type { RequestWithUser } from '@ghostfolio/common/types';
 import {
@@ -18,7 +16,6 @@ import {
   Param,
   Post,
   Put,
-  Query,
   UseGuards,
   UseInterceptors
 } from '@nestjs/common';
@@ -45,12 +42,8 @@ export class OrderController {
   @Delete(':id')
   @UseGuards(AuthGuard('jwt'))
   public async deleteOrder(@Param('id') id: string): Promise<OrderModel> {
-    const order = await this.orderService.order({ id });
-
     if (
-      !hasPermission(this.request.user.permissions, permissions.deleteOrder) ||
+      !hasPermission(this.request.user.permissions, permissions.deleteOrder)
-      !order ||
-      order.userId !== this.request.user.id
     ) {
       throw new HttpException(
         getReasonPhrase(StatusCodes.FORBIDDEN),
@@ -59,45 +52,19 @@ export class OrderController {
     }
 
     return this.orderService.deleteOrder({
-      id
+      id_userId: {
+        id,
+        userId: this.request.user.id
+      }
     });
   }
 
   @Get()
   @UseGuards(AuthGuard('jwt'))
-  @UseInterceptors(RedactValuesInResponseInterceptor)
   @UseInterceptors(TransformDataSourceInResponseInterceptor)
   public async getAllOrders(
-    @Headers('impersonation-id') impersonationId,
+    @Headers('impersonation-id') impersonationId
-    @Query('accounts') filterByAccounts?: string,
-    @Query('assetClasses') filterByAssetClasses?: string,
-    @Query('tags') filterByTags?: string
   ): Promise<Activities> {
-    const accountIds = filterByAccounts?.split(',') ?? [];
-    const assetClasses = filterByAssetClasses?.split(',') ?? [];
-    const tagIds = filterByTags?.split(',') ?? [];
-
-    const filters: Filter[] = [
-      ...accountIds.map((accountId) => {
-        return <Filter>{
-          id: accountId,
-          type: 'ACCOUNT'
-        };
-      }),
-      ...assetClasses.map((assetClass) => {
-        return <Filter>{
-          id: assetClass,
-          type: 'ASSET_CLASS'
-        };
-      }),
-      ...tagIds.map((tagId) => {
-        return <Filter>{
-          id: tagId,
-          type: 'TAG'
-        };
-      })
-    ];
-
     const impersonationUserId =
       await this.impersonationService.validateImpersonationId(
         impersonationId,
@@ -106,7 +73,6 @@ export class OrderController {
     const userCurrency = this.request.user.Settings.currency;
 
     let activities = await this.orderService.getOrders({
-      filters,
       userCurrency,
       includeDrafts: true,
       userId: impersonationUserId || this.request.user.id
@@ -148,7 +114,6 @@ export class OrderController {
       SymbolProfile: {
         connectOrCreate: {
           create: {
-            currency: data.currency,
             dataSource: data.dataSource,
             symbol: data.symbol
           },
@@ -169,15 +134,23 @@ export class OrderController {
   @UseGuards(AuthGuard('jwt'))
   @UseInterceptors(TransformDataSourceInRequestInterceptor)
   public async update(@Param('id') id: string, @Body() data: UpdateOrderDto) {
+    if (
+      !hasPermission(this.request.user.permissions, permissions.updateOrder)
+    ) {
+      throw new HttpException(
+        getReasonPhrase(StatusCodes.FORBIDDEN),
+        StatusCodes.FORBIDDEN
+      );
+    }
+
     const originalOrder = await this.orderService.order({
-      id
+      id_userId: {
+        id,
+        userId: this.request.user.id
+      }
     });
 
-    if (
+    if (!originalOrder) {
-      !hasPermission(this.request.user.permissions, permissions.updateOrder) ||
-      !originalOrder ||
-      originalOrder.userId !== this.request.user.id
-    ) {
       throw new HttpException(
         getReasonPhrase(StatusCodes.FORBIDDEN),
         StatusCodes.FORBIDDEN
@@ -198,23 +171,13 @@ export class OrderController {
             id_userId: { id: accountId, userId: this.request.user.id }
           }
         },
-        SymbolProfile: {
-          connect: {
-            dataSource_symbol: {
-              dataSource: data.dataSource,
-              symbol: data.symbol
-            }
-          },
-          update: {
-            assetClass: data.assetClass,
-            assetSubClass: data.assetSubClass,
-            name: data.symbol
-          }
-        },
         User: { connect: { id: this.request.user.id } }
       },
       where: {
-        id
+        id_userId: {
+          id,
+          userId: this.request.user.id
+        }
       }
     });
   }

apps/api/src/app/order/order.service.ts

@@ -1,26 +1,14 @@
 import { AccountService } from '@ghostfolio/api/app/account/account.service';
+import { CacheService } from '@ghostfolio/api/app/cache/cache.service';
 import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.service';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
-import {
-  GATHER_ASSET_PROFILE_PROCESS,
-  GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-} from '@ghostfolio/common/config';
-import { Filter } from '@ghostfolio/common/interfaces';
 import { OrderWithAccount } from '@ghostfolio/common/types';
 import { Injectable } from '@nestjs/common';
-import {
+import { DataSource, Order, Prisma, Type as TypeOfOrder } from '@prisma/client';
-  AssetClass,
-  AssetSubClass,
-  DataSource,
-  Order,
-  Prisma,
-  Type as TypeOfOrder
-} from '@prisma/client';
 import Big from 'big.js';
 import { endOfToday, isAfter } from 'date-fns';
-import { groupBy } from 'lodash';
 import { v4 as uuidv4 } from 'uuid';
 
 import { Activity } from './interfaces/activities.interface';
@@ -29,8 +17,9 @@ import { Activity } from './interfaces/activities.interface';
 export class OrderService {
   public constructor(
     private readonly accountService: AccountService,
-    private readonly dataGatheringService: DataGatheringService,
+    private readonly cacheService: CacheService,
     private readonly exchangeRateDataService: ExchangeRateDataService,
+    private readonly dataGatheringService: DataGatheringService,
     private readonly prismaService: PrismaService,
     private readonly symbolProfileService: SymbolProfileService
   ) {}
@@ -64,15 +53,7 @@ export class OrderService {
   }
 
   public async createOrder(
-    data: Prisma.OrderCreateInput & {
+    data: Prisma.OrderCreateInput & { accountId?: string; userId: string }
-      accountId?: string;
-      assetClass?: AssetClass;
-      assetSubClass?: AssetSubClass;
-      currency?: string;
-      dataSource?: DataSource;
-      symbol?: string;
-      userId: string;
-    }
   ): Promise<Order> {
     const defaultAccount = (
       await this.accountService.getAccounts(data.userId)
@@ -90,17 +71,15 @@ export class OrderService {
     };
 
     if (data.type === 'ITEM') {
-      const assetClass = data.assetClass;
+      const currency = data.currency;
-      const assetSubClass = data.assetSubClass;
-      const currency = data.SymbolProfile.connectOrCreate.create.currency;
       const dataSource: DataSource = 'MANUAL';
       const id = uuidv4();
       const name = data.SymbolProfile.connectOrCreate.create.symbol;
 
       Account = undefined;
+      data.dataSource = dataSource;
       data.id = id;
-      data.SymbolProfile.connectOrCreate.create.assetClass = assetClass;
+      data.symbol = null;
-      data.SymbolProfile.connectOrCreate.create.assetSubClass = assetSubClass;
       data.SymbolProfile.connectOrCreate.create.currency = currency;
       data.SymbolProfile.connectOrCreate.create.dataSource = dataSource;
       data.SymbolProfile.connectOrCreate.create.name = name;
@@ -114,34 +93,29 @@ export class OrderService {
         data.SymbolProfile.connectOrCreate.create.symbol.toUpperCase();
     }
 
-    await this.dataGatheringService.addJobToQueue(
-      GATHER_ASSET_PROFILE_PROCESS,
-      {
-        dataSource: data.SymbolProfile.connectOrCreate.create.dataSource,
-        symbol: data.SymbolProfile.connectOrCreate.create.symbol
-      },
-      GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-    );
-
     const isDraft = isAfter(data.date as Date, endOfToday());
 
     if (!isDraft) {
       // Gather symbol data of order in the background, if not draft
       this.dataGatheringService.gatherSymbols([
         {
-          dataSource: data.SymbolProfile.connectOrCreate.create.dataSource,
+          dataSource: data.dataSource,
           date: <Date>data.date,
           symbol: data.SymbolProfile.connectOrCreate.create.symbol
         }
       ]);
     }
 
+    this.dataGatheringService.gatherProfileData([
+      {
+        dataSource: data.dataSource,
+        symbol: data.SymbolProfile.connectOrCreate.create.symbol
+      }
+    ]);
+
+    await this.cacheService.flush();
+
     delete data.accountId;
-    delete data.assetClass;
-    delete data.assetSubClass;
-    delete data.currency;
-    delete data.dataSource;
-    delete data.symbol;
     delete data.userId;
 
     const orderData: Prisma.OrderCreateInput = data;
@@ -170,13 +144,11 @@ export class OrderService {
   }
 
   public async getOrders({
-    filters,
     includeDrafts = false,
     types,
     userCurrency,
     userId
   }: {
-    filters?: Filter[];
     includeDrafts?: boolean;
     types?: TypeOfOrder[];
     userCurrency: string;
@@ -184,64 +156,10 @@ export class OrderService {
   }): Promise<Activity[]> {
     const where: Prisma.OrderWhereInput = { userId };
 
-    const {
-      ACCOUNT: filtersByAccount,
-      ASSET_CLASS: filtersByAssetClass,
-      TAG: filtersByTag
-    } = groupBy(filters, (filter) => {
-      return filter.type;
-    });
-
-    if (filtersByAccount?.length > 0) {
-      where.accountId = {
-        in: filtersByAccount.map(({ id }) => {
-          return id;
-        })
-      };
-    }
-
     if (includeDrafts === false) {
       where.isDraft = false;
     }
 
-    if (filtersByAssetClass?.length > 0) {
-      where.SymbolProfile = {
-        OR: [
-          {
-            AND: [
-              {
-                OR: filtersByAssetClass.map(({ id }) => {
-                  return { assetClass: AssetClass[id] };
-                })
-              },
-              {
-                SymbolProfileOverrides: {
-                  is: null
-                }
-              }
-            ]
-          },
-          {
-            SymbolProfileOverrides: {
-              OR: filtersByAssetClass.map(({ id }) => {
-                return { assetClass: AssetClass[id] };
-              })
-            }
-          }
-        ]
-      };
-    }
-
-    if (filtersByTag?.length > 0) {
-      where.tags = {
-        some: {
-          OR: filtersByTag.map(({ id }) => {
-            return { id };
-          })
-        }
-      };
-    }
-
     if (types) {
       where.OR = types.map((type) => {
         return {
@@ -263,8 +181,7 @@ export class OrderService {
             }
           },
           // eslint-disable-next-line @typescript-eslint/naming-convention
-          SymbolProfile: true,
+          SymbolProfile: true
-          tags: true
         },
         orderBy: { date: 'asc' }
       })
@@ -276,61 +193,49 @@ export class OrderService {
         value,
         feeInBaseCurrency: this.exchangeRateDataService.toCurrency(
           order.fee,
-          order.SymbolProfile.currency,
+          order.currency,
           userCurrency
         ),
         valueInBaseCurrency: this.exchangeRateDataService.toCurrency(
           value,
-          order.SymbolProfile.currency,
+          order.currency,
           userCurrency
         )
       };
     });
   }
 
-  public async updateOrder({
+  public async updateOrder(params: {
-    data,
-    where
-  }: {
-    data: Prisma.OrderUpdateInput & {
-      assetClass?: AssetClass;
-      assetSubClass?: AssetSubClass;
-      currency?: string;
-      dataSource?: DataSource;
-      symbol?: string;
-    };
     where: Prisma.OrderWhereUniqueInput;
+    data: Prisma.OrderUpdateInput;
   }): Promise<Order> {
+    const { data, where } = params;
+
     if (data.Account.connect.id_userId.id === null) {
       delete data.Account;
     }
 
-    let isDraft = false;
-
     if (data.type === 'ITEM') {
-      delete data.SymbolProfile.connect;
+      const name = data.symbol;
-    } else {
-      delete data.SymbolProfile.update;
 
-      isDraft = isAfter(data.date as Date, endOfToday());
+      data.symbol = null;
-
+      data.SymbolProfile = { update: { name } };
-      if (!isDraft) {
-        // Gather symbol data of order in the background, if not draft
-        this.dataGatheringService.gatherSymbols([
-          {
-            dataSource: data.SymbolProfile.connect.dataSource_symbol.dataSource,
-            date: <Date>data.date,
-            symbol: data.SymbolProfile.connect.dataSource_symbol.symbol
-          }
-        ]);
-      }
     }
 
-    delete data.assetClass;
+    const isDraft = isAfter(data.date as Date, endOfToday());
-    delete data.assetSubClass;
+
-    delete data.currency;
+    if (!isDraft) {
-    delete data.dataSource;
+      // Gather symbol data of order in the background, if not draft
-    delete data.symbol;
+      this.dataGatheringService.gatherSymbols([
+        {
+          dataSource: <DataSource>data.dataSource,
+          date: <Date>data.date,
+          symbol: <string>data.symbol
+        }
+      ]);
+    }
+
+    await this.cacheService.flush();
 
     return this.prismaService.order.update({
       data: {

apps/api/src/app/order/update-order.dto.ts

@@ -1,24 +1,10 @@
-import { AssetClass, AssetSubClass, DataSource, Type } from '@prisma/client';
+import { DataSource, Type } from '@prisma/client';
-import {
+import { IsISO8601, IsNumber, IsOptional, IsString } from 'class-validator';
-  IsEnum,
-  IsISO8601,
-  IsNumber,
-  IsOptional,
-  IsString
-} from 'class-validator';
 
 export class UpdateOrderDto {
   @IsOptional()
   @IsString()
-  accountId?: string;
+  accountId: string;
-
-  @IsEnum(AssetClass, { each: true })
-  @IsOptional()
-  assetClass?: AssetClass;
-
-  @IsEnum(AssetSubClass, { each: true })
-  @IsOptional()
-  assetSubClass?: AssetSubClass;
 
   @IsString()
   currency: string;

apps/api/src/app/portfolio/current-rate.service.mock.ts

@@ -1,7 +1,6 @@
 import { parseDate, resetHours } from '@ghostfolio/common/helper';
 import { addDays, endOfDay, isBefore, isSameDay } from 'date-fns';
 
-import { GetValueObject } from './interfaces/get-value-object.interface';
 import { GetValuesParams } from './interfaces/get-values-params.interface';
 
 function mockGetValue(symbol: string, date: Date) {
@@ -21,24 +20,14 @@ function mockGetValue(symbol: string, date: Date) {
 
       return { marketPrice: 0 };
 
-    case 'NOVN.SW':
-      if (isSameDay(parseDate('2022-04-11'), date)) {
-        return { marketPrice: 87.8 };
-      }
-
-      return { marketPrice: 0 };
-
     default:
       return { marketPrice: 0 };
   }
 }
 
 export const CurrentRateServiceMock = {
-  getValues: ({
+  getValues: ({ dataGatheringItems, dateQuery }: GetValuesParams) => {
-    dataGatheringItems,
+    const result = [];
-    dateQuery
-  }: GetValuesParams): Promise<GetValueObject[]> => {
-    const result: GetValueObject[] = [];
     if (dateQuery.lt) {
       for (
         let date = resetHours(dateQuery.gte);
@@ -48,10 +37,8 @@ export const CurrentRateServiceMock = {
         for (const dataGatheringItem of dataGatheringItems) {
           result.push({
             date,
-            marketPriceInBaseCurrency: mockGetValue(
+            marketPrice: mockGetValue(dataGatheringItem.symbol, date)
-              dataGatheringItem.symbol,
+              .marketPrice,
-              date
-            ).marketPrice,
             symbol: dataGatheringItem.symbol
           });
         }
@@ -61,10 +48,8 @@ export const CurrentRateServiceMock = {
         for (const dataGatheringItem of dataGatheringItems) {
           result.push({
             date,
-            marketPriceInBaseCurrency: mockGetValue(
+            marketPrice: mockGetValue(dataGatheringItem.symbol, date)
-              dataGatheringItem.symbol,
+              .marketPrice,
-              date
-            ).marketPrice,
             symbol: dataGatheringItem.symbol
           });
         }

apps/api/src/app/portfolio/current-rate.service.spec.ts

@@ -4,7 +4,6 @@ import { MarketDataService } from '@ghostfolio/api/services/market-data.service'
 import { DataSource, MarketData } from '@prisma/client';
 
 import { CurrentRateService } from './current-rate.service';
-import { GetValueObject } from './interfaces/get-value-object.interface';
 
 jest.mock('@ghostfolio/api/services/market-data.service', () => {
   return {
@@ -74,12 +73,7 @@ describe('CurrentRateService', () => {
 
   beforeAll(async () => {
     dataProviderService = new DataProviderService(null, [], null);
-    exchangeRateDataService = new ExchangeRateDataService(
+    exchangeRateDataService = new ExchangeRateDataService(null, null, null);
-      null,
-      null,
-      null,
-      null
-    );
     marketDataService = new MarketDataService(null);
 
     await exchangeRateDataService.initialize();
@@ -102,15 +96,15 @@ describe('CurrentRateService', () => {
         },
         userCurrency: 'CHF'
       })
-    ).toMatchObject<GetValueObject[]>([
+    ).toMatchObject([
       {
         date: undefined,
-        marketPriceInBaseCurrency: 1841.823902,
+        marketPrice: 1841.823902,
         symbol: 'AMZN'
       },
       {
         date: undefined,
-        marketPriceInBaseCurrency: 1847.839966,
+        marketPrice: 1847.839966,
         symbol: 'AMZN'
       }
     ]);

apps/api/src/app/portfolio/current-rate.service.ts

@@ -28,25 +28,30 @@ export class CurrentRateService {
       (!dateQuery.gte || isBefore(dateQuery.gte, new Date())) &&
       (!dateQuery.in || this.containsToday(dateQuery.in));
 
-    const promises: Promise<GetValueObject[]>[] = [];
+    const promises: Promise<
+      {
+        date: Date;
+        marketPrice: number;
+        symbol: string;
+      }[]
+    >[] = [];
 
     if (includeToday) {
       const today = resetHours(new Date());
       promises.push(
         this.dataProviderService
-          .getQuotes(dataGatheringItems)
+          .get(dataGatheringItems)
           .then((dataResultProvider) => {
-            const result: GetValueObject[] = [];
+            const result = [];
             for (const dataGatheringItem of dataGatheringItems) {
               result.push({
                 date: today,
-                marketPriceInBaseCurrency:
+                marketPrice: this.exchangeRateDataService.toCurrency(
-                  this.exchangeRateDataService.toCurrency(
+                  dataResultProvider?.[dataGatheringItem.symbol]?.marketPrice ??
-                    dataResultProvider?.[dataGatheringItem.symbol]
+                    0,
-                      ?.marketPrice ?? 0,
+                  dataResultProvider?.[dataGatheringItem.symbol]?.currency,
-                    dataResultProvider?.[dataGatheringItem.symbol]?.currency,
+                  userCurrency
-                    userCurrency
+                ),
-                  ),
                 symbol: dataGatheringItem.symbol
               });
             }
@@ -69,12 +74,11 @@ export class CurrentRateService {
           return data.map((marketDataItem) => {
             return {
               date: marketDataItem.date,
-              marketPriceInBaseCurrency:
+              marketPrice: this.exchangeRateDataService.toCurrency(
-                this.exchangeRateDataService.toCurrency(
+                marketDataItem.marketPrice,
-                  marketDataItem.marketPrice,
+                currencies[marketDataItem.symbol],
-                  currencies[marketDataItem.symbol],
+                userCurrency
-                  userCurrency
+              ),
-                ),
               symbol: marketDataItem.symbol
             };
           });

apps/api/src/app/portfolio/interfaces/current-positions.interface.ts

@@ -1,7 +1,8 @@
-import { ResponseError, TimelinePosition } from '@ghostfolio/common/interfaces';
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
 import Big from 'big.js';
 
-export interface CurrentPositions extends ResponseError {
+export interface CurrentPositions {
+  hasErrors: boolean;
   positions: TimelinePosition[];
   grossPerformance: Big;
   grossPerformancePercentage: Big;

apps/api/src/app/portfolio/interfaces/get-value-object.interface.ts

@@ -1,5 +1,5 @@
 export interface GetValueObject {
   date: Date;
-  marketPriceInBaseCurrency: number;
+  marketPrice: number;
   symbol: string;
 }

apps/api/src/app/portfolio/interfaces/portfolio-position-detail.interface.ts

@@ -1,9 +1,5 @@
-import {
+import { EnhancedSymbolProfile } from '@ghostfolio/api/services/interfaces/symbol-profile.interface';
-  EnhancedSymbolProfile,
-  HistoricalDataItem
-} from '@ghostfolio/common/interfaces';
 import { OrderWithAccount } from '@ghostfolio/common/types';
-import { Tag } from '@prisma/client';
 
 export interface PortfolioPositionDetail {
   averagePrice: number;
@@ -20,7 +16,6 @@ export interface PortfolioPositionDetail {
   orders: OrderWithAccount[];
   quantity: number;
   SymbolProfile: EnhancedSymbolProfile;
-  tags: Tag[];
   transactionCount: number;
   value: number;
 }
@@ -30,3 +25,10 @@ export interface HistoricalDataContainer {
   isAllTimeLow: boolean;
   items: HistoricalDataItem[];
 }
+
+export interface HistoricalDataItem {
+  averagePrice?: number;
+  date: string;
+  grossPerformancePercent?: number;
+  value: number;
+}

apps/api/src/app/portfolio/portfolio-calculator-new-baln-buy-and-sell.spec.ts

@@ -3,7 +3,7 @@ import { parseDate } from '@ghostfolio/common/helper';
 import Big from 'big.js';
 
 import { CurrentRateServiceMock } from './current-rate.service.mock';
-import { PortfolioCalculator } from './portfolio-calculator';
+import { PortfolioCalculatorNew } from './portfolio-calculator-new';
 
 jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   return {
@@ -14,7 +14,7 @@ jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   };
 });
 
-describe('PortfolioCalculator', () => {
+describe('PortfolioCalculatorNew', () => {
   let currentRateService: CurrentRateService;
 
   beforeEach(() => {
@@ -23,7 +23,7 @@ describe('PortfolioCalculator', () => {
 
   describe('get current positions', () => {
     it.only('with BALN.SW buy and sell', async () => {
-      const portfolioCalculator = new PortfolioCalculator({
+      const portfolioCalculatorNew = new PortfolioCalculatorNew({
         currentRateService,
         currency: 'CHF',
         orders: [
@@ -52,13 +52,13 @@ describe('PortfolioCalculator', () => {
         ]
       });
 
-      portfolioCalculator.computeTransactionPoints();
+      portfolioCalculatorNew.computeTransactionPoints();
 
       const spy = jest
         .spyOn(Date, 'now')
         .mockImplementation(() => parseDate('2021-12-18').getTime());
 
-      const currentPositions = await portfolioCalculator.getCurrentPositions(
+      const currentPositions = await portfolioCalculatorNew.getCurrentPositions(
         parseDate('2021-11-22')
       );
 
@@ -66,7 +66,6 @@ describe('PortfolioCalculator', () => {
 
       expect(currentPositions).toEqual({
         currentValue: new Big('0'),
-        errors: [],
         grossPerformance: new Big('-12.6'),
         grossPerformancePercentage: new Big('-0.0440867739678096571'),
         hasErrors: false,

apps/api/src/app/portfolio/portfolio-calculator-new-baln-buy.spec.ts

@@ -3,7 +3,7 @@ import { parseDate } from '@ghostfolio/common/helper';
 import Big from 'big.js';
 
 import { CurrentRateServiceMock } from './current-rate.service.mock';
-import { PortfolioCalculator } from './portfolio-calculator';
+import { PortfolioCalculatorNew } from './portfolio-calculator-new';
 
 jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   return {
@@ -14,7 +14,7 @@ jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   };
 });
 
-describe('PortfolioCalculator', () => {
+describe('PortfolioCalculatorNew', () => {
   let currentRateService: CurrentRateService;
 
   beforeEach(() => {
@@ -23,7 +23,7 @@ describe('PortfolioCalculator', () => {
 
   describe('get current positions', () => {
     it.only('with BALN.SW buy', async () => {
-      const portfolioCalculator = new PortfolioCalculator({
+      const portfolioCalculatorNew = new PortfolioCalculatorNew({
         currentRateService,
         currency: 'CHF',
         orders: [
@@ -41,13 +41,13 @@ describe('PortfolioCalculator', () => {
         ]
       });
 
-      portfolioCalculator.computeTransactionPoints();
+      portfolioCalculatorNew.computeTransactionPoints();
 
       const spy = jest
         .spyOn(Date, 'now')
         .mockImplementation(() => parseDate('2021-12-18').getTime());
 
-      const currentPositions = await portfolioCalculator.getCurrentPositions(
+      const currentPositions = await portfolioCalculatorNew.getCurrentPositions(
         parseDate('2021-11-30')
       );
 
@@ -55,7 +55,6 @@ describe('PortfolioCalculator', () => {
 
       expect(currentPositions).toEqual({
         currentValue: new Big('297.8'),
-        errors: [],
         grossPerformance: new Big('24.6'),
         grossPerformancePercentage: new Big('0.09004392386530014641'),
         hasErrors: false,

apps/api/src/app/portfolio/portfolio-calculator-new-no-orders.spec.ts

@@ -3,7 +3,7 @@ import { parseDate } from '@ghostfolio/common/helper';
 import Big from 'big.js';
 
 import { CurrentRateServiceMock } from './current-rate.service.mock';
-import { PortfolioCalculator } from './portfolio-calculator';
+import { PortfolioCalculatorNew } from './portfolio-calculator-new';
 
 jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   return {
@@ -14,7 +14,7 @@ jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
   };
 });
 
-describe('PortfolioCalculator', () => {
+describe('PortfolioCalculatorNew', () => {
   let currentRateService: CurrentRateService;
 
   beforeEach(() => {
@@ -23,19 +23,19 @@ describe('PortfolioCalculator', () => {
 
   describe('get current positions', () => {
     it('with no orders', async () => {
-      const portfolioCalculator = new PortfolioCalculator({
+      const portfolioCalculatorNew = new PortfolioCalculatorNew({
         currentRateService,
         currency: 'CHF',
         orders: []
       });
 
-      portfolioCalculator.computeTransactionPoints();
+      portfolioCalculatorNew.computeTransactionPoints();
 
       const spy = jest
         .spyOn(Date, 'now')
         .mockImplementation(() => parseDate('2021-12-18').getTime());
 
-      const currentPositions = await portfolioCalculator.getCurrentPositions(
+      const currentPositions = await portfolioCalculatorNew.getCurrentPositions(
         new Date()
       );
 

apps/api/src/app/portfolio/portfolio-calculator-new.spec.ts

@@ -0,0 +1,73 @@
+import Big from 'big.js';
+
+import { CurrentRateService } from './current-rate.service';
+import { PortfolioCalculatorNew } from './portfolio-calculator-new';
+
+describe('PortfolioCalculatorNew', () => {
+  let currentRateService: CurrentRateService;
+
+  beforeEach(() => {
+    currentRateService = new CurrentRateService(null, null, null);
+  });
+
+  describe('annualized performance percentage', () => {
+    const portfolioCalculatorNew = new PortfolioCalculatorNew({
+      currentRateService,
+      currency: 'USD',
+      orders: []
+    });
+
+    it('Get annualized performance', async () => {
+      expect(
+        portfolioCalculatorNew
+          .getAnnualizedPerformancePercent({
+            daysInMarket: NaN, // differenceInDays of date-fns returns NaN for the same day
+            netPerformancePercent: new Big(0)
+          })
+          .toNumber()
+      ).toEqual(0);
+
+      expect(
+        portfolioCalculatorNew
+          .getAnnualizedPerformancePercent({
+            daysInMarket: 0,
+            netPerformancePercent: new Big(0)
+          })
+          .toNumber()
+      ).toEqual(0);
+
+      /**
+       * Source: https://www.readyratios.com/reference/analysis/annualized_rate.html
+       */
+      expect(
+        portfolioCalculatorNew
+          .getAnnualizedPerformancePercent({
+            daysInMarket: 65, // < 1 year
+            netPerformancePercent: new Big(0.1025)
+          })
+          .toNumber()
+      ).toBeCloseTo(0.729705);
+
+      expect(
+        portfolioCalculatorNew
+          .getAnnualizedPerformancePercent({
+            daysInMarket: 365, // 1 year
+            netPerformancePercent: new Big(0.05)
+          })
+          .toNumber()
+      ).toBeCloseTo(0.05);
+
+      /**
+       * Source: https://www.investopedia.com/terms/a/annualized-total-return.asp#annualized-return-formula-and-calculation
+       */
+      expect(
+        portfolioCalculatorNew
+          .getAnnualizedPerformancePercent({
+            daysInMarket: 575, // > 1 year
+            netPerformancePercent: new Big(0.2374)
+          })
+          .toNumber()
+      ).toBeCloseTo(0.145);
+    });
+  });
+});

apps/api/src/app/portfolio/portfolio-calculator-new.ts

@@ -0,0 +1,958 @@
+import { TimelineInfoInterface } from '@ghostfolio/api/app/portfolio/interfaces/timeline-info.interface';
+import { IDataGatheringItem } from '@ghostfolio/api/services/interfaces/interfaces';
+import { DATE_FORMAT, parseDate, resetHours } from '@ghostfolio/common/helper';
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
+import { Logger } from '@nestjs/common';
+import { Type as TypeOfOrder } from '@prisma/client';
+import Big from 'big.js';
+import {
+  addDays,
+  addMilliseconds,
+  addMonths,
+  addYears,
+  endOfDay,
+  format,
+  isAfter,
+  isBefore,
+  max,
+  min
+} from 'date-fns';
+import { first, flatten, isNumber, sortBy } from 'lodash';
+
+import { CurrentRateService } from './current-rate.service';
+import { CurrentPositions } from './interfaces/current-positions.interface';
+import { GetValueObject } from './interfaces/get-value-object.interface';
+import { PortfolioOrderItem } from './interfaces/portfolio-calculator.interface';
+import { PortfolioOrder } from './interfaces/portfolio-order.interface';
+import { TimelinePeriod } from './interfaces/timeline-period.interface';
+import {
+  Accuracy,
+  TimelineSpecification
+} from './interfaces/timeline-specification.interface';
+import { TransactionPointSymbol } from './interfaces/transaction-point-symbol.interface';
+import { TransactionPoint } from './interfaces/transaction-point.interface';
+
+export class PortfolioCalculatorNew {
+  private static readonly ENABLE_LOGGING = false;
+
+  private currency: string;
+  private currentRateService: CurrentRateService;
+  private orders: PortfolioOrder[];
+  private transactionPoints: TransactionPoint[];
+
+  public constructor({
+    currency,
+    currentRateService,
+    orders
+  }: {
+    currency: string;
+    currentRateService: CurrentRateService;
+    orders: PortfolioOrder[];
+  }) {
+    this.currency = currency;
+    this.currentRateService = currentRateService;
+    this.orders = orders;
+
+    this.orders.sort((a, b) => a.date.localeCompare(b.date));
+  }
+
+  public computeTransactionPoints() {
+    this.transactionPoints = [];
+    const symbols: { [symbol: string]: TransactionPointSymbol } = {};
+
+    let lastDate: string = null;
+    let lastTransactionPoint: TransactionPoint = null;
+    for (const order of this.orders) {
+      const currentDate = order.date;
+
+      let currentTransactionPointItem: TransactionPointSymbol;
+      const oldAccumulatedSymbol = symbols[order.symbol];
+
+      const factor = this.getFactor(order.type);
+      const unitPrice = new Big(order.unitPrice);
+      if (oldAccumulatedSymbol) {
+        const newQuantity = order.quantity
+          .mul(factor)
+          .plus(oldAccumulatedSymbol.quantity);
+        currentTransactionPointItem = {
+          currency: order.currency,
+          dataSource: order.dataSource,
+          fee: order.fee.plus(oldAccumulatedSymbol.fee),
+          firstBuyDate: oldAccumulatedSymbol.firstBuyDate,
+          investment: newQuantity.eq(0)
+            ? new Big(0)
+            : unitPrice
+                .mul(order.quantity)
+                .mul(factor)
+                .plus(oldAccumulatedSymbol.investment),
+          quantity: newQuantity,
+          symbol: order.symbol,
+          transactionCount: oldAccumulatedSymbol.transactionCount + 1
+        };
+      } else {
+        currentTransactionPointItem = {
+          currency: order.currency,
+          dataSource: order.dataSource,
+          fee: order.fee,
+          firstBuyDate: order.date,
+          investment: unitPrice.mul(order.quantity).mul(factor),
+          quantity: order.quantity.mul(factor),
+          symbol: order.symbol,
+          transactionCount: 1
+        };
+      }
+
+      symbols[order.symbol] = currentTransactionPointItem;
+
+      const items = lastTransactionPoint?.items ?? [];
+      const newItems = items.filter(
+        (transactionPointItem) => transactionPointItem.symbol !== order.symbol
+      );
+      newItems.push(currentTransactionPointItem);
+      newItems.sort((a, b) => a.symbol.localeCompare(b.symbol));
+      if (lastDate !== currentDate || lastTransactionPoint === null) {
+        lastTransactionPoint = {
+          date: currentDate,
+          items: newItems
+        };
+        this.transactionPoints.push(lastTransactionPoint);
+      } else {
+        lastTransactionPoint.items = newItems;
+      }
+      lastDate = currentDate;
+    }
+  }
+
+  public getAnnualizedPerformancePercent({
+    daysInMarket,
+    netPerformancePercent
+  }: {
+    daysInMarket: number;
+    netPerformancePercent: Big;
+  }): Big {
+    if (isNumber(daysInMarket) && daysInMarket > 0) {
+      const exponent = new Big(365).div(daysInMarket).toNumber();
+      return new Big(
+        Math.pow(netPerformancePercent.plus(1).toNumber(), exponent)
+      ).minus(1);
+    }
+
+    return new Big(0);
+  }
+
+  public getTransactionPoints(): TransactionPoint[] {
+    return this.transactionPoints;
+  }
+
+  public setTransactionPoints(transactionPoints: TransactionPoint[]) {
+    this.transactionPoints = transactionPoints;
+  }
+
+  public async getCurrentPositions(start: Date): Promise<CurrentPositions> {
+    if (!this.transactionPoints?.length) {
+      return {
+        currentValue: new Big(0),
+        hasErrors: false,
+        grossPerformance: new Big(0),
+        grossPerformancePercentage: new Big(0),
+        netPerformance: new Big(0),
+        netPerformancePercentage: new Big(0),
+        positions: [],
+        totalInvestment: new Big(0)
+      };
+    }
+
+    const lastTransactionPoint =
+      this.transactionPoints[this.transactionPoints.length - 1];
+
+    // use Date.now() to use the mock for today
+    const today = new Date(Date.now());
+
+    let firstTransactionPoint: TransactionPoint = null;
+    let firstIndex = this.transactionPoints.length;
+    const dates = [];
+    const dataGatheringItems: IDataGatheringItem[] = [];
+    const currencies: { [symbol: string]: string } = {};
+
+    dates.push(resetHours(start));
+    for (const item of this.transactionPoints[firstIndex - 1].items) {
+      dataGatheringItems.push({
+        dataSource: item.dataSource,
+        symbol: item.symbol
+      });
+      currencies[item.symbol] = item.currency;
+    }
+    for (let i = 0; i < this.transactionPoints.length; i++) {
+      if (
+        !isBefore(parseDate(this.transactionPoints[i].date), start) &&
+        firstTransactionPoint === null
+      ) {
+        firstTransactionPoint = this.transactionPoints[i];
+        firstIndex = i;
+      }
+      if (firstTransactionPoint !== null) {
+        dates.push(resetHours(parseDate(this.transactionPoints[i].date)));
+      }
+    }
+
+    dates.push(resetHours(today));
+
+    const marketSymbols = await this.currentRateService.getValues({
+      currencies,
+      dataGatheringItems,
+      dateQuery: {
+        in: dates
+      },
+      userCurrency: this.currency
+    });
+
+    const marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    } = {};
+
+    for (const marketSymbol of marketSymbols) {
+      const date = format(marketSymbol.date, DATE_FORMAT);
+      if (!marketSymbolMap[date]) {
+        marketSymbolMap[date] = {};
+      }
+      if (marketSymbol.marketPrice) {
+        marketSymbolMap[date][marketSymbol.symbol] = new Big(
+          marketSymbol.marketPrice
+        );
+      }
+    }
+
+    const todayString = format(today, DATE_FORMAT);
+
+    if (firstIndex > 0) {
+      firstIndex--;
+    }
+    const initialValues: { [symbol: string]: Big } = {};
+
+    const positions: TimelinePosition[] = [];
+    let hasAnySymbolMetricsErrors = false;
+
+    for (const item of lastTransactionPoint.items) {
+      const marketValue = marketSymbolMap[todayString]?.[item.symbol];
+
+      const {
+        grossPerformance,
+        grossPerformancePercentage,
+        hasErrors,
+        initialValue,
+        netPerformance,
+        netPerformancePercentage
+      } = this.getSymbolMetrics({
+        marketSymbolMap,
+        start,
+        symbol: item.symbol
+      });
+
+      hasAnySymbolMetricsErrors = hasAnySymbolMetricsErrors || hasErrors;
+      initialValues[item.symbol] = initialValue;
+
+      positions.push({
+        averagePrice: item.quantity.eq(0)
+          ? new Big(0)
+          : item.investment.div(item.quantity),
+        currency: item.currency,
+        dataSource: item.dataSource,
+        firstBuyDate: item.firstBuyDate,
+        grossPerformance: !hasErrors ? grossPerformance ?? null : null,
+        grossPerformancePercentage: !hasErrors
+          ? grossPerformancePercentage ?? null
+          : null,
+        investment: item.investment,
+        marketPrice: marketValue?.toNumber() ?? null,
+        netPerformance: !hasErrors ? netPerformance ?? null : null,
+        netPerformancePercentage: !hasErrors
+          ? netPerformancePercentage ?? null
+          : null,
+        quantity: item.quantity,
+        symbol: item.symbol,
+        transactionCount: item.transactionCount
+      });
+    }
+
+    const overall = this.calculateOverallPerformance(positions, initialValues);
+
+    return {
+      ...overall,
+      positions,
+      hasErrors: hasAnySymbolMetricsErrors || overall.hasErrors
+    };
+  }
+
+  public getInvestments(): { date: string; investment: Big }[] {
+    if (this.transactionPoints.length === 0) {
+      return [];
+    }
+
+    return this.transactionPoints.map((transactionPoint) => {
+      return {
+        date: transactionPoint.date,
+        investment: transactionPoint.items.reduce(
+          (investment, transactionPointSymbol) =>
+            investment.plus(transactionPointSymbol.investment),
+          new Big(0)
+        )
+      };
+    });
+  }
+
+  public async calculateTimeline(
+    timelineSpecification: TimelineSpecification[],
+    endDate: string
+  ): Promise<TimelineInfoInterface> {
+    if (timelineSpecification.length === 0) {
+      return {
+        maxNetPerformance: new Big(0),
+        minNetPerformance: new Big(0),
+        timelinePeriods: []
+      };
+    }
+
+    const startDate = timelineSpecification[0].start;
+    const start = parseDate(startDate);
+    const end = parseDate(endDate);
+
+    const timelinePeriodPromises: Promise<TimelineInfoInterface>[] = [];
+    let i = 0;
+    let j = -1;
+    for (
+      let currentDate = start;
+      !isAfter(currentDate, end);
+      currentDate = this.addToDate(
+        currentDate,
+        timelineSpecification[i].accuracy
+      )
+    ) {
+      if (this.isNextItemActive(timelineSpecification, currentDate, i)) {
+        i++;
+      }
+      while (
+        j + 1 < this.transactionPoints.length &&
+        !isAfter(parseDate(this.transactionPoints[j + 1].date), currentDate)
+      ) {
+        j++;
+      }
+
+      let periodEndDate = currentDate;
+      if (timelineSpecification[i].accuracy === 'day') {
+        let nextEndDate = end;
+        if (j + 1 < this.transactionPoints.length) {
+          nextEndDate = parseDate(this.transactionPoints[j + 1].date);
+        }
+        periodEndDate = min([
+          addMonths(currentDate, 3),
+          max([currentDate, nextEndDate])
+        ]);
+      }
+      const timePeriodForDates = this.getTimePeriodForDate(
+        j,
+        currentDate,
+        endOfDay(periodEndDate)
+      );
+      currentDate = periodEndDate;
+      if (timePeriodForDates != null) {
+        timelinePeriodPromises.push(timePeriodForDates);
+      }
+    }
+
+    const timelineInfoInterfaces: TimelineInfoInterface[] = await Promise.all(
+      timelinePeriodPromises
+    );
+    const minNetPerformance = timelineInfoInterfaces
+      .map((timelineInfo) => timelineInfo.minNetPerformance)
+      .filter((performance) => performance !== null)
+      .reduce((minPerformance, current) => {
+        if (minPerformance.lt(current)) {
+          return minPerformance;
+        } else {
+          return current;
+        }
+      });
+
+    const maxNetPerformance = timelineInfoInterfaces
+      .map((timelineInfo) => timelineInfo.maxNetPerformance)
+      .filter((performance) => performance !== null)
+      .reduce((maxPerformance, current) => {
+        if (maxPerformance.gt(current)) {
+          return maxPerformance;
+        } else {
+          return current;
+        }
+      });
+
+    const timelinePeriods = timelineInfoInterfaces.map(
+      (timelineInfo) => timelineInfo.timelinePeriods
+    );
+
+    return {
+      maxNetPerformance,
+      minNetPerformance,
+      timelinePeriods: flatten(timelinePeriods)
+    };
+  }
+
+  private calculateOverallPerformance(
+    positions: TimelinePosition[],
+    initialValues: { [symbol: string]: Big }
+  ) {
+    let currentValue = new Big(0);
+    let grossPerformance = new Big(0);
+    let grossPerformancePercentage = new Big(0);
+    let hasErrors = false;
+    let netPerformance = new Big(0);
+    let netPerformancePercentage = new Big(0);
+    let sumOfWeights = new Big(0);
+    let totalInvestment = new Big(0);
+
+    for (const currentPosition of positions) {
+      if (currentPosition.marketPrice) {
+        currentValue = currentValue.plus(
+          new Big(currentPosition.marketPrice).mul(currentPosition.quantity)
+        );
+      } else {
+        hasErrors = true;
+      }
+
+      totalInvestment = totalInvestment.plus(currentPosition.investment);
+
+      if (currentPosition.grossPerformance) {
+        grossPerformance = grossPerformance.plus(
+          currentPosition.grossPerformance
+        );
+
+        netPerformance = netPerformance.plus(currentPosition.netPerformance);
+      } else if (!currentPosition.quantity.eq(0)) {
+        hasErrors = true;
+      }
+
+      if (currentPosition.grossPerformancePercentage) {
+        // Use the average from the initial value and the current investment as
+        // a weight
+        const weight = (initialValues[currentPosition.symbol] ?? new Big(0))
+          .plus(currentPosition.investment)
+          .div(2);
+
+        sumOfWeights = sumOfWeights.plus(weight);
+
+        grossPerformancePercentage = grossPerformancePercentage.plus(
+          currentPosition.grossPerformancePercentage.mul(weight)
+        );
+
+        netPerformancePercentage = netPerformancePercentage.plus(
+          currentPosition.netPerformancePercentage.mul(weight)
+        );
+      } else if (!currentPosition.quantity.eq(0)) {
+        Logger.warn(
+          `Missing initial value for symbol ${currentPosition.symbol} at ${currentPosition.firstBuyDate}`
+        );
+        hasErrors = true;
+      }
+    }
+
+    if (sumOfWeights.gt(0)) {
+      grossPerformancePercentage = grossPerformancePercentage.div(sumOfWeights);
+      netPerformancePercentage = netPerformancePercentage.div(sumOfWeights);
+    } else {
+      grossPerformancePercentage = new Big(0);
+      netPerformancePercentage = new Big(0);
+    }
+
+    return {
+      currentValue,
+      grossPerformance,
+      grossPerformancePercentage,
+      hasErrors,
+      netPerformance,
+      netPerformancePercentage,
+      totalInvestment
+    };
+  }
+
+  private async getTimePeriodForDate(
+    j: number,
+    startDate: Date,
+    endDate: Date
+  ): Promise<TimelineInfoInterface> {
+    let investment: Big = new Big(0);
+    let fees: Big = new Big(0);
+
+    const marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    } = {};
+    if (j >= 0) {
+      const currencies: { [name: string]: string } = {};
+      const dataGatheringItems: IDataGatheringItem[] = [];
+
+      for (const item of this.transactionPoints[j].items) {
+        currencies[item.symbol] = item.currency;
+        dataGatheringItems.push({
+          dataSource: item.dataSource,
+          symbol: item.symbol
+        });
+        investment = investment.plus(item.investment);
+        fees = fees.plus(item.fee);
+      }
+
+      let marketSymbols: GetValueObject[] = [];
+      if (dataGatheringItems.length > 0) {
+        try {
+          marketSymbols = await this.currentRateService.getValues({
+            currencies,
+            dataGatheringItems,
+            dateQuery: {
+              gte: startDate,
+              lt: endOfDay(endDate)
+            },
+            userCurrency: this.currency
+          });
+        } catch (error) {
+          Logger.error(
+            `Failed to fetch info for date ${startDate} with exception`,
+            error
+          );
+          return null;
+        }
+      }
+
+      for (const marketSymbol of marketSymbols) {
+        const date = format(marketSymbol.date, DATE_FORMAT);
+        if (!marketSymbolMap[date]) {
+          marketSymbolMap[date] = {};
+        }
+        if (marketSymbol.marketPrice) {
+          marketSymbolMap[date][marketSymbol.symbol] = new Big(
+            marketSymbol.marketPrice
+          );
+        }
+      }
+    }
+
+    const results: TimelinePeriod[] = [];
+    let maxNetPerformance: Big = null;
+    let minNetPerformance: Big = null;
+    for (
+      let currentDate = startDate;
+      isBefore(currentDate, endDate);
+      currentDate = addDays(currentDate, 1)
+    ) {
+      let value = new Big(0);
+      const currentDateAsString = format(currentDate, DATE_FORMAT);
+      let invalid = false;
+      if (j >= 0) {
+        for (const item of this.transactionPoints[j].items) {
+          if (
+            !marketSymbolMap[currentDateAsString]?.hasOwnProperty(item.symbol)
+          ) {
+            invalid = true;
+            break;
+          }
+          value = value.plus(
+            item.quantity.mul(marketSymbolMap[currentDateAsString][item.symbol])
+          );
+        }
+      }
+      if (!invalid) {
+        const grossPerformance = value.minus(investment);
+        const netPerformance = grossPerformance.minus(fees);
+        if (
+          minNetPerformance === null ||
+          minNetPerformance.gt(netPerformance)
+        ) {
+          minNetPerformance = netPerformance;
+        }
+        if (
+          maxNetPerformance === null ||
+          maxNetPerformance.lt(netPerformance)
+        ) {
+          maxNetPerformance = netPerformance;
+        }
+
+        const result = {
+          grossPerformance,
+          investment,
+          netPerformance,
+          value,
+          date: currentDateAsString
+        };
+        results.push(result);
+      }
+    }
+
+    return {
+      maxNetPerformance,
+      minNetPerformance,
+      timelinePeriods: results
+    };
+  }
+
+  private getFactor(type: TypeOfOrder) {
+    let factor: number;
+
+    switch (type) {
+      case 'BUY':
+        factor = 1;
+        break;
+      case 'SELL':
+        factor = -1;
+        break;
+      default:
+        factor = 0;
+        break;
+    }
+
+    return factor;
+  }
+
+  private addToDate(date: Date, accuracy: Accuracy): Date {
+    switch (accuracy) {
+      case 'day':
+        return addDays(date, 1);
+      case 'month':
+        return addMonths(date, 1);
+      case 'year':
+        return addYears(date, 1);
+    }
+  }
+
+  private getSymbolMetrics({
+    marketSymbolMap,
+    start,
+    symbol
+  }: {
+    marketSymbolMap: {
+      [date: string]: { [symbol: string]: Big };
+    };
+    start: Date;
+    symbol: string;
+  }) {
+    let orders: PortfolioOrderItem[] = this.orders.filter((order) => {
+      return order.symbol === symbol;
+    });
+
+    if (orders.length <= 0) {
+      return {
+        hasErrors: false,
+        initialValue: new Big(0),
+        netPerformance: new Big(0),
+        netPerformancePercentage: new Big(0),
+        grossPerformance: new Big(0),
+        grossPerformancePercentage: new Big(0)
+      };
+    }
+
+    const dateOfFirstTransaction = new Date(first(orders).date);
+    const endDate = new Date(Date.now());
+
+    const unitPriceAtStartDate =
+      marketSymbolMap[format(start, DATE_FORMAT)]?.[symbol];
+
+    const unitPriceAtEndDate =
+      marketSymbolMap[format(endDate, DATE_FORMAT)]?.[symbol];
+
+    if (
+      !unitPriceAtEndDate ||
+      (!unitPriceAtStartDate && isBefore(dateOfFirstTransaction, start))
+    ) {
+      return {
+        hasErrors: true,
+        initialValue: new Big(0),
+        netPerformance: new Big(0),
+        netPerformancePercentage: new Big(0),
+        grossPerformance: new Big(0),
+        grossPerformancePercentage: new Big(0)
+      };
+    }
+
+    let averagePriceAtEndDate = new Big(0);
+    let averagePriceAtStartDate = new Big(0);
+    let feesAtStartDate = new Big(0);
+    let fees = new Big(0);
+    let grossPerformance = new Big(0);
+    let grossPerformanceAtStartDate = new Big(0);
+    let grossPerformanceFromSells = new Big(0);
+    let initialValue: Big;
+    let lastAveragePrice = new Big(0);
+    let lastTransactionInvestment = new Big(0);
+    let lastValueOfInvestmentBeforeTransaction = new Big(0);
+    let maxTotalInvestment = new Big(0);
+    let timeWeightedGrossPerformancePercentage = new Big(1);
+    let timeWeightedNetPerformancePercentage = new Big(1);
+    let totalInvestment = new Big(0);
+    let totalInvestmentWithGrossPerformanceFromSell = new Big(0);
+    let totalUnits = new Big(0);
+
+    // Add a synthetic order at the start and the end date
+    orders.push({
+      symbol,
+      currency: null,
+      date: format(start, DATE_FORMAT),
+      dataSource: null,
+      fee: new Big(0),
+      itemType: 'start',
+      name: '',
+      quantity: new Big(0),
+      type: TypeOfOrder.BUY,
+      unitPrice: unitPriceAtStartDate
+    });
+
+    orders.push({
+      symbol,
+      currency: null,
+      date: format(endDate, DATE_FORMAT),
+      dataSource: null,
+      fee: new Big(0),
+      itemType: 'end',
+      name: '',
+      quantity: new Big(0),
+      type: TypeOfOrder.BUY,
+      unitPrice: unitPriceAtEndDate
+    });
+
+    // Sort orders so that the start and end placeholder order are at the right
+    // position
+    orders = sortBy(orders, (order) => {
+      let sortIndex = new Date(order.date);
+
+      if (order.itemType === 'start') {
+        sortIndex = addMilliseconds(sortIndex, -1);
+      }
+
+      if (order.itemType === 'end') {
+        sortIndex = addMilliseconds(sortIndex, 1);
+      }
+
+      return sortIndex.getTime();
+    });
+
+    const indexOfStartOrder = orders.findIndex((order) => {
+      return order.itemType === 'start';
+    });
+
+    const indexOfEndOrder = orders.findIndex((order) => {
+      return order.itemType === 'end';
+    });
+
+    for (let i = 0; i < orders.length; i += 1) {
+      const order = orders[i];
+
+      if (order.itemType === 'start') {
+        // Take the unit price of the order as the market price if there are no
+        // orders of this symbol before the start date
+        order.unitPrice =
+          indexOfStartOrder === 0
+            ? orders[i + 1]?.unitPrice
+            : unitPriceAtStartDate;
+      }
+
+      // Calculate the average start price as soon as any units are held
+      if (
+        averagePriceAtStartDate.eq(0) &&
+        i >= indexOfStartOrder &&
+        totalUnits.gt(0)
+      ) {
+        averagePriceAtStartDate = totalInvestment.div(totalUnits);
+      }
+
+      const valueOfInvestmentBeforeTransaction = totalUnits.mul(
+        order.unitPrice
+      );
+
+      const transactionInvestment = order.quantity
+        .mul(order.unitPrice)
+        .mul(this.getFactor(order.type));
+
+      totalInvestment = totalInvestment.plus(transactionInvestment);
+
+      if (totalInvestment.gt(maxTotalInvestment)) {
+        maxTotalInvestment = totalInvestment;
+      }
+
+      if (i === indexOfEndOrder && totalUnits.gt(0)) {
+        averagePriceAtEndDate = totalInvestment.div(totalUnits);
+      }
+
+      if (i >= indexOfStartOrder && !initialValue) {
+        if (
+          i === indexOfStartOrder &&
+          !valueOfInvestmentBeforeTransaction.eq(0)
+        ) {
+          initialValue = valueOfInvestmentBeforeTransaction;
+        } else if (transactionInvestment.gt(0)) {
+          initialValue = transactionInvestment;
+        }
+      }
+
+      fees = fees.plus(order.fee);
+
+      totalUnits = totalUnits.plus(
+        order.quantity.mul(this.getFactor(order.type))
+      );
+
+      const valueOfInvestment = totalUnits.mul(order.unitPrice);
+
+      const grossPerformanceFromSell =
+        order.type === TypeOfOrder.SELL
+          ? order.unitPrice.minus(lastAveragePrice).mul(order.quantity)
+          : new Big(0);
+
+      grossPerformanceFromSells = grossPerformanceFromSells.plus(
+        grossPerformanceFromSell
+      );
+
+      totalInvestmentWithGrossPerformanceFromSell =
+        totalInvestmentWithGrossPerformanceFromSell
+          .plus(transactionInvestment)
+          .plus(grossPerformanceFromSell);
+
+      lastAveragePrice = totalUnits.eq(0)
+        ? new Big(0)
+        : totalInvestmentWithGrossPerformanceFromSell.div(totalUnits);
+
+      const newGrossPerformance = valueOfInvestment
+        .minus(totalInvestmentWithGrossPerformanceFromSell)
+        .plus(grossPerformanceFromSells);
+
+      if (
+        i > indexOfStartOrder &&
+        !lastValueOfInvestmentBeforeTransaction
+          .plus(lastTransactionInvestment)
+          .eq(0)
+      ) {
+        const grossHoldingPeriodReturn = valueOfInvestmentBeforeTransaction
+          .minus(
+            lastValueOfInvestmentBeforeTransaction.plus(
+              lastTransactionInvestment
+            )
+          )
+          .div(
+            lastValueOfInvestmentBeforeTransaction.plus(
+              lastTransactionInvestment
+            )
+          );
+
+        timeWeightedGrossPerformancePercentage =
+          timeWeightedGrossPerformancePercentage.mul(
+            new Big(1).plus(grossHoldingPeriodReturn)
+          );
+
+        const netHoldingPeriodReturn = valueOfInvestmentBeforeTransaction
+          .minus(fees.minus(feesAtStartDate))
+          .minus(
+            lastValueOfInvestmentBeforeTransaction.plus(
+              lastTransactionInvestment
+            )
+          )
+          .div(
+            lastValueOfInvestmentBeforeTransaction.plus(
+              lastTransactionInvestment
+            )
+          );
+
+        timeWeightedNetPerformancePercentage =
+          timeWeightedNetPerformancePercentage.mul(
+            new Big(1).plus(netHoldingPeriodReturn)
+          );
+      }
+
+      grossPerformance = newGrossPerformance;
+
+      lastTransactionInvestment = transactionInvestment;
+
+      lastValueOfInvestmentBeforeTransaction =
+        valueOfInvestmentBeforeTransaction;
+
+      if (order.itemType === 'start') {
+        feesAtStartDate = fees;
+        grossPerformanceAtStartDate = grossPerformance;
+      }
+    }
+
+    timeWeightedGrossPerformancePercentage =
+      timeWeightedGrossPerformancePercentage.minus(1);
+
+    timeWeightedNetPerformancePercentage =
+      timeWeightedNetPerformancePercentage.minus(1);
+
+    const totalGrossPerformance = grossPerformance.minus(
+      grossPerformanceAtStartDate
+    );
+
+    const totalNetPerformance = grossPerformance
+      .minus(grossPerformanceAtStartDate)
+      .minus(fees.minus(feesAtStartDate));
+
+    const grossPerformancePercentage =
+      averagePriceAtStartDate.eq(0) ||
+      averagePriceAtEndDate.eq(0) ||
+      orders[indexOfStartOrder].unitPrice.eq(0)
+        ? totalGrossPerformance.div(maxTotalInvestment)
+        : unitPriceAtEndDate
+            .div(averagePriceAtEndDate)
+            .div(
+              orders[indexOfStartOrder].unitPrice.div(averagePriceAtStartDate)
+            )
+            .minus(1);
+
+    const feesPerUnit = totalUnits.gt(0)
+      ? fees.minus(feesAtStartDate).div(totalUnits)
+      : new Big(0);
+
+    const netPerformancePercentage =
+      averagePriceAtStartDate.eq(0) ||
+      averagePriceAtEndDate.eq(0) ||
+      orders[indexOfStartOrder].unitPrice.eq(0)
+        ? totalNetPerformance.div(maxTotalInvestment)
+        : unitPriceAtEndDate
+            .minus(feesPerUnit)
+            .div(averagePriceAtEndDate)
+            .div(
+              orders[indexOfStartOrder].unitPrice.div(averagePriceAtStartDate)
+            )
+            .minus(1);
+
+    if (PortfolioCalculatorNew.ENABLE_LOGGING) {
+      console.log(
+        `
+        ${symbol}
+        Unit price: ${orders[indexOfStartOrder].unitPrice.toFixed(
+          2
+        )} -> ${unitPriceAtEndDate.toFixed(2)}
+        Average price: ${averagePriceAtStartDate.toFixed(
+          2
+        )} -> ${averagePriceAtEndDate.toFixed(2)}
+        Max. total investment: ${maxTotalInvestment.toFixed(2)}
+        Gross performance: ${totalGrossPerformance.toFixed(
+          2
+        )} / ${grossPerformancePercentage.mul(100).toFixed(2)}%
+        Fees per unit: ${feesPerUnit.toFixed(2)}
+        Net performance: ${totalNetPerformance.toFixed(
+          2
+        )} / ${netPerformancePercentage.mul(100).toFixed(2)}%`
+      );
+    }
+
+    return {
+      initialValue,
+      grossPerformancePercentage,
+      netPerformancePercentage,
+      hasErrors: totalUnits.gt(0) && (!initialValue || !unitPriceAtEndDate),
+      netPerformance: totalNetPerformance,
+      grossPerformance: totalGrossPerformance
+    };
+  }
+
+  private isNextItemActive(
+    timelineSpecification: TimelineSpecification[],
+    currentDate: Date,
+    i: number
+  ) {
+    return (
+      i + 1 < timelineSpecification.length &&
+      !isBefore(currentDate, parseDate(timelineSpecification[i + 1].start))
+    );
+  }
+}

apps/api/src/app/portfolio/portfolio-calculator-novn-buy-and-sell-partially.spec.ts

@@ -1,96 +0,0 @@
-import { CurrentRateService } from '@ghostfolio/api/app/portfolio/current-rate.service';
-import { parseDate } from '@ghostfolio/common/helper';
-import Big from 'big.js';
-
-import { CurrentRateServiceMock } from './current-rate.service.mock';
-import { PortfolioCalculator } from './portfolio-calculator';
-
-jest.mock('@ghostfolio/api/app/portfolio/current-rate.service', () => {
-  return {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
-    CurrentRateService: jest.fn().mockImplementation(() => {
-      return CurrentRateServiceMock;
-    })
-  };
-});
-
-describe('PortfolioCalculator', () => {
-  let currentRateService: CurrentRateService;
-
-  beforeEach(() => {
-    currentRateService = new CurrentRateService(null, null, null);
-  });
-
-  describe('get current positions', () => {
-    it.only('with BALN.SW buy and sell', async () => {
-      const portfolioCalculator = new PortfolioCalculator({
-        currentRateService,
-        currency: 'CHF',
-        orders: [
-          {
-            currency: 'CHF',
-            date: '2022-03-07',
-            dataSource: 'YAHOO',
-            fee: new Big(1.3),
-            name: 'Novartis AG',
-            quantity: new Big(2),
-            symbol: 'NOVN.SW',
-            type: 'BUY',
-            unitPrice: new Big(75.8)
-          },
-          {
-            currency: 'CHF',
-            date: '2022-04-08',
-            dataSource: 'YAHOO',
-            fee: new Big(2.95),
-            name: 'Novartis AG',
-            quantity: new Big(1),
-            symbol: 'NOVN.SW',
-            type: 'SELL',
-            unitPrice: new Big(85.73)
-          }
-        ]
-      });
-
-      portfolioCalculator.computeTransactionPoints();
-
-      const spy = jest
-        .spyOn(Date, 'now')
-        .mockImplementation(() => parseDate('2022-04-11').getTime());
-
-      const currentPositions = await portfolioCalculator.getCurrentPositions(
-        parseDate('2022-03-07')
-      );
-
-      spy.mockRestore();
-
-      expect(currentPositions).toEqual({
-        currentValue: new Big('87.8'),
-        errors: [],
-        grossPerformance: new Big('21.93'),
-        grossPerformancePercentage: new Big('0.14465699208443271768'),
-        hasErrors: false,
-        netPerformance: new Big('17.68'),
-        netPerformancePercentage: new Big('0.11662269129287598945'),
-        positions: [
-          {
-            averagePrice: new Big('75.80'),
-            currency: 'CHF',
-            dataSource: 'YAHOO',
-            firstBuyDate: '2022-03-07',
-            grossPerformance: new Big('21.93'),
-            grossPerformancePercentage: new Big('0.14465699208443271768'),
-            investment: new Big('75.80'),
-            netPerformance: new Big('17.68'),
-            netPerformancePercentage: new Big('0.11662269129287598945'),
-            marketPrice: 87.8,
-            quantity: new Big('1'),
-            symbol: 'NOVN.SW',
-            transactionCount: 2
-          }
-        ],
-        totalInvestment: new Big('75.80')
-      });
-    });
-  });
-});

apps/api/src/app/portfolio/portfolio-calculator.ts

@@ -1,31 +1,27 @@
 import { TimelineInfoInterface } from '@ghostfolio/api/app/portfolio/interfaces/timeline-info.interface';
 import { IDataGatheringItem } from '@ghostfolio/api/services/interfaces/interfaces';
 import { DATE_FORMAT, parseDate, resetHours } from '@ghostfolio/common/helper';
-import { ResponseError, TimelinePosition } from '@ghostfolio/common/interfaces';
+import { TimelinePosition } from '@ghostfolio/common/interfaces';
 import { Logger } from '@nestjs/common';
 import { Type as TypeOfOrder } from '@prisma/client';
 import Big from 'big.js';
 import {
   addDays,
-  addMilliseconds,
   addMonths,
   addYears,
+  differenceInDays,
   endOfDay,
   format,
   isAfter,
   isBefore,
-  isSameMonth,
-  isSameYear,
   max,
-  min,
+  min
-  set
 } from 'date-fns';
-import { first, flatten, isNumber, sortBy } from 'lodash';
+import { flatten, isNumber } from 'lodash';
 
 import { CurrentRateService } from './current-rate.service';
 import { CurrentPositions } from './interfaces/current-positions.interface';
 import { GetValueObject } from './interfaces/get-value-object.interface';
-import { PortfolioOrderItem } from './interfaces/portfolio-calculator.interface';
 import { PortfolioOrder } from './interfaces/portfolio-order.interface';
 import { TimelinePeriod } from './interfaces/timeline-period.interface';
 import {
@@ -36,39 +32,22 @@ import { TransactionPointSymbol } from './interfaces/transaction-point-symbol.in
 import { TransactionPoint } from './interfaces/transaction-point.interface';
 
 export class PortfolioCalculator {
-  private static readonly CALCULATE_PERCENTAGE_PERFORMANCE_WITH_MAX_INVESTMENT =
-    true;
-
-  private static readonly ENABLE_LOGGING = false;
-
-  private currency: string;
-  private currentRateService: CurrentRateService;
-  private orders: PortfolioOrder[];
   private transactionPoints: TransactionPoint[];
 
-  public constructor({
+  public constructor(
-    currency,
+    private currentRateService: CurrentRateService,
-    currentRateService,
+    private currency: string
-    orders
+  ) {}
-  }: {
-    currency: string;
-    currentRateService: CurrentRateService;
-    orders: PortfolioOrder[];
-  }) {
-    this.currency = currency;
-    this.currentRateService = currentRateService;
-    this.orders = orders;
 
-    this.orders.sort((a, b) => a.date?.localeCompare(b.date));
+  public computeTransactionPoints(orders: PortfolioOrder[]) {
-  }
+    orders.sort((a, b) => a.date.localeCompare(b.date));
 
-  public computeTransactionPoints() {
     this.transactionPoints = [];
     const symbols: { [symbol: string]: TransactionPointSymbol } = {};
 
     let lastDate: string = null;
     let lastTransactionPoint: TransactionPoint = null;
-    for (const order of this.orders) {
+    for (const order of orders) {
       const currentDate = order.date;
 
       let currentTransactionPointItem: TransactionPointSymbol;
@@ -80,30 +59,17 @@ export class PortfolioCalculator {
         const newQuantity = order.quantity
           .mul(factor)
           .plus(oldAccumulatedSymbol.quantity);
-
-        let investment = new Big(0);
-
-        if (newQuantity.gt(0)) {
-          if (order.type === 'BUY') {
-            investment = oldAccumulatedSymbol.investment.plus(
-              order.quantity.mul(unitPrice)
-            );
-          } else if (order.type === 'SELL') {
-            const averagePrice = oldAccumulatedSymbol.investment.div(
-              oldAccumulatedSymbol.quantity
-            );
-            investment = oldAccumulatedSymbol.investment.minus(
-              order.quantity.mul(averagePrice)
-            );
-          }
-        }
-
         currentTransactionPointItem = {
-          investment,
           currency: order.currency,
           dataSource: order.dataSource,
           fee: order.fee.plus(oldAccumulatedSymbol.fee),
           firstBuyDate: oldAccumulatedSymbol.firstBuyDate,
+          investment: newQuantity.eq(0)
+            ? new Big(0)
+            : unitPrice
+                .mul(order.quantity)
+                .mul(factor)
+                .plus(oldAccumulatedSymbol.investment),
           quantity: newQuantity,
           symbol: order.symbol,
           transactionCount: oldAccumulatedSymbol.transactionCount + 1
@@ -128,7 +94,7 @@ export class PortfolioCalculator {
         (transactionPointItem) => transactionPointItem.symbol !== order.symbol
       );
       newItems.push(currentTransactionPointItem);
-      newItems.sort((a, b) => a.symbol?.localeCompare(b.symbol));
+      newItems.sort((a, b) => a.symbol.localeCompare(b.symbol));
       if (lastDate !== currentDate || lastTransactionPoint === null) {
         lastTransactionPoint = {
           date: currentDate,
@@ -174,6 +140,7 @@ export class PortfolioCalculator {
         hasErrors: false,
         grossPerformance: new Big(0),
         grossPerformancePercentage: new Big(0),
+        netAnnualizedPerformance: new Big(0),
         netPerformance: new Big(0),
         netPerformancePercentage: new Big(0),
         positions: [],
@@ -228,50 +195,120 @@ export class PortfolioCalculator {
     const marketSymbolMap: {
       [date: string]: { [symbol: string]: Big };
     } = {};
-
     for (const marketSymbol of marketSymbols) {
       const date = format(marketSymbol.date, DATE_FORMAT);
       if (!marketSymbolMap[date]) {
         marketSymbolMap[date] = {};
       }
-      if (marketSymbol.marketPriceInBaseCurrency) {
+      if (marketSymbol.marketPrice) {
         marketSymbolMap[date][marketSymbol.symbol] = new Big(
-          marketSymbol.marketPriceInBaseCurrency
+          marketSymbol.marketPrice
         );
       }
     }
 
+    let hasErrors = false;
+    const startString = format(start, DATE_FORMAT);
+
+    const holdingPeriodReturns: { [symbol: string]: Big } = {};
+    const netHoldingPeriodReturns: { [symbol: string]: Big } = {};
+    const grossPerformance: { [symbol: string]: Big } = {};
+    const netPerformance: { [symbol: string]: Big } = {};
     const todayString = format(today, DATE_FORMAT);
 
     if (firstIndex > 0) {
       firstIndex--;
     }
+    const invalidSymbols = [];
+    const lastInvestments: { [symbol: string]: Big } = {};
+    const lastQuantities: { [symbol: string]: Big } = {};
+    const lastFees: { [symbol: string]: Big } = {};
     const initialValues: { [symbol: string]: Big } = {};
 
-    const positions: TimelinePosition[] = [];
+    for (let i = firstIndex; i < this.transactionPoints.length; i++) {
-    let hasAnySymbolMetricsErrors = false;
+      const currentDate =
+        i === firstIndex ? startString : this.transactionPoints[i].date;
+      const nextDate =
+        i + 1 < this.transactionPoints.length
+          ? this.transactionPoints[i + 1].date
+          : todayString;
 
-    const errors: ResponseError['errors'] = [];
+      const items = this.transactionPoints[i].items;
+      for (const item of items) {
+        if (!marketSymbolMap[nextDate]?.[item.symbol]) {
+          invalidSymbols.push(item.symbol);
+          hasErrors = true;
+          Logger.warn(`Missing value for symbol ${item.symbol} at ${nextDate}`);
+          continue;
+        }
+        let lastInvestment: Big = new Big(0);
+        let lastQuantity: Big = item.quantity;
+        if (lastInvestments[item.symbol] && lastQuantities[item.symbol]) {
+          lastInvestment = item.investment.minus(lastInvestments[item.symbol]);
+          lastQuantity = lastQuantities[item.symbol];
+        }
+
+        const itemValue = marketSymbolMap[currentDate]?.[item.symbol];
+        let initialValue = itemValue?.mul(lastQuantity);
+        let investedValue = itemValue?.mul(item.quantity);
+        const isFirstOrderAndIsStartBeforeCurrentDate =
+          i === firstIndex &&
+          isBefore(parseDate(this.transactionPoints[i].date), start);
+        const lastFee: Big = lastFees[item.symbol] ?? new Big(0);
+        const fee = isFirstOrderAndIsStartBeforeCurrentDate
+          ? new Big(0)
+          : item.fee.minus(lastFee);
+        if (!isAfter(parseDate(currentDate), parseDate(item.firstBuyDate))) {
+          initialValue = item.investment;
+          investedValue = item.investment;
+        }
+        if (i === firstIndex || !initialValues[item.symbol]) {
+          initialValues[item.symbol] = initialValue;
+        }
+        if (!item.quantity.eq(0)) {
+          if (!initialValue) {
+            invalidSymbols.push(item.symbol);
+            hasErrors = true;
+            Logger.warn(
+              `Missing value for symbol ${item.symbol} at ${currentDate}`
+            );
+            continue;
+          }
+
+          const cashFlow = lastInvestment;
+          const endValue = marketSymbolMap[nextDate][item.symbol].mul(
+            item.quantity
+          );
+
+          const holdingPeriodReturn = endValue.div(initialValue.plus(cashFlow));
+          holdingPeriodReturns[item.symbol] = (
+            holdingPeriodReturns[item.symbol] ?? new Big(1)
+          ).mul(holdingPeriodReturn);
+          grossPerformance[item.symbol] = (
+            grossPerformance[item.symbol] ?? new Big(0)
+          ).plus(endValue.minus(investedValue));
+
+          const netHoldingPeriodReturn = endValue.div(
+            initialValue.plus(cashFlow).plus(fee)
+          );
+          netHoldingPeriodReturns[item.symbol] = (
+            netHoldingPeriodReturns[item.symbol] ?? new Big(1)
+          ).mul(netHoldingPeriodReturn);
+          netPerformance[item.symbol] = (
+            netPerformance[item.symbol] ?? new Big(0)
+          ).plus(endValue.minus(investedValue).minus(fee));
+        }
+        lastInvestments[item.symbol] = item.investment;
+        lastQuantities[item.symbol] = item.quantity;
+        lastFees[item.symbol] = item.fee;
+      }
+    }
+
+    const positions: TimelinePosition[] = [];
 
     for (const item of lastTransactionPoint.items) {
       const marketValue = marketSymbolMap[todayString]?.[item.symbol];
-
+      const isValid = invalidSymbols.indexOf(item.symbol) === -1;
-      const {
-        grossPerformance,
-        grossPerformancePercentage,
-        hasErrors,
-        initialValue,
-        netPerformance,
-        netPerformancePercentage
-      } = this.getSymbolMetrics({
-        marketSymbolMap,
-        start,
-        symbol: item.symbol
-      });
-
-      hasAnySymbolMetricsErrors = hasAnySymbolMetricsErrors || hasErrors;
-      initialValues[item.symbol] = initialValue;
-
       positions.push({
         averagePrice: item.quantity.eq(0)
           ? new Big(0)
@@ -279,33 +316,31 @@ export class PortfolioCalculator {
         currency: item.currency,
         dataSource: item.dataSource,
         firstBuyDate: item.firstBuyDate,
-        grossPerformance: !hasErrors ? grossPerformance ?? null : null,
+        grossPerformance: isValid
-        grossPerformancePercentage: !hasErrors
+          ? grossPerformance[item.symbol] ?? null
-          ? grossPerformancePercentage ?? null
           : null,
+        grossPerformancePercentage:
+          isValid && holdingPeriodReturns[item.symbol]
+            ? holdingPeriodReturns[item.symbol].minus(1)
+            : null,
         investment: item.investment,
         marketPrice: marketValue?.toNumber() ?? null,
-        netPerformance: !hasErrors ? netPerformance ?? null : null,
+        netPerformance: isValid ? netPerformance[item.symbol] ?? null : null,
-        netPerformancePercentage: !hasErrors
+        netPerformancePercentage:
-          ? netPerformancePercentage ?? null
+          isValid && netHoldingPeriodReturns[item.symbol]
-          : null,
+            ? netHoldingPeriodReturns[item.symbol].minus(1)
+            : null,
         quantity: item.quantity,
         symbol: item.symbol,
         transactionCount: item.transactionCount
       });
-
-      if (hasErrors) {
-        errors.push({ dataSource: item.dataSource, symbol: item.symbol });
-      }
     }
-
     const overall = this.calculateOverallPerformance(positions, initialValues);
 
     return {
       ...overall,
-      errors,
       positions,
-      hasErrors: hasAnySymbolMetricsErrors || overall.hasErrors
+      hasErrors: hasErrors || overall.hasErrors
     };
   }
 
@@ -326,46 +361,6 @@ export class PortfolioCalculator {
     });
   }
 
-  public getInvestmentsByMonth(): { date: string; investment: Big }[] {
-    if (this.orders.length === 0) {
-      return [];
-    }
-
-    const investments = [];
-    let currentDate = parseDate(this.orders[0].date);
-    let investmentByMonth = new Big(0);
-
-    for (const [index, order] of this.orders.entries()) {
-      if (
-        isSameMonth(parseDate(order.date), currentDate) &&
-        isSameYear(parseDate(order.date), currentDate)
-      ) {
-        investmentByMonth = investmentByMonth.plus(
-          order.quantity.mul(order.unitPrice).mul(this.getFactor(order.type))
-        );
-
-        if (index === this.orders.length - 1) {
-          investments.push({
-            date: format(set(currentDate, { date: 1 }), DATE_FORMAT),
-            investment: investmentByMonth
-          });
-        }
-      } else {
-        investments.push({
-          date: format(set(currentDate, { date: 1 }), DATE_FORMAT),
-          investment: investmentByMonth
-        });
-
-        currentDate = parseDate(order.date);
-        investmentByMonth = order.quantity
-          .mul(order.unitPrice)
-          .mul(this.getFactor(order.type));
-      }
-    }
-
-    return investments;
-  }
-
   public async calculateTimeline(
     timelineSpecification: TimelineSpecification[],
     endDate: string
@@ -463,16 +458,20 @@ export class PortfolioCalculator {
 
   private calculateOverallPerformance(
     positions: TimelinePosition[],
-    initialValues: { [symbol: string]: Big }
+    initialValues: { [p: string]: Big }
   ) {
+    let hasErrors = false;
     let currentValue = new Big(0);
+    let totalInvestment = new Big(0);
     let grossPerformance = new Big(0);
     let grossPerformancePercentage = new Big(0);
-    let hasErrors = false;
     let netPerformance = new Big(0);
     let netPerformancePercentage = new Big(0);
-    let sumOfWeights = new Big(0);
+    let completeInitialValue = new Big(0);
-    let totalInvestment = new Big(0);
+    let netAnnualizedPerformance = new Big(0);
+
+    // use Date.now() to use the mock for today
+    const today = new Date(Date.now());
 
     for (const currentPosition of positions) {
       if (currentPosition.marketPrice) {
@@ -482,50 +481,52 @@ export class PortfolioCalculator {
       } else {
         hasErrors = true;
       }
-
       totalInvestment = totalInvestment.plus(currentPosition.investment);
-
       if (currentPosition.grossPerformance) {
         grossPerformance = grossPerformance.plus(
           currentPosition.grossPerformance
         );
-
         netPerformance = netPerformance.plus(currentPosition.netPerformance);
       } else if (!currentPosition.quantity.eq(0)) {
         hasErrors = true;
       }
 
-      if (currentPosition.grossPerformancePercentage) {
+      if (
-        // Use the average from the initial value and the current investment as
+        currentPosition.grossPerformancePercentage &&
-        // a weight
+        initialValues[currentPosition.symbol]
-        const weight = (initialValues[currentPosition.symbol] ?? new Big(0))
+      ) {
-          .plus(currentPosition.investment)
+        const currentInitialValue = initialValues[currentPosition.symbol];
-          .div(2);
+        completeInitialValue = completeInitialValue.plus(currentInitialValue);
-
-        sumOfWeights = sumOfWeights.plus(weight);
-
         grossPerformancePercentage = grossPerformancePercentage.plus(
-          currentPosition.grossPerformancePercentage.mul(weight)
+          currentPosition.grossPerformancePercentage.mul(currentInitialValue)
+        );
+        netAnnualizedPerformance = netAnnualizedPerformance.plus(
+          this.getAnnualizedPerformancePercent({
+            daysInMarket: differenceInDays(
+              today,
+              parseDate(currentPosition.firstBuyDate)
+            ),
+            netPerformancePercent: currentPosition.netPerformancePercentage
+          }).mul(currentInitialValue)
         );
-
         netPerformancePercentage = netPerformancePercentage.plus(
-          currentPosition.netPerformancePercentage.mul(weight)
+          currentPosition.netPerformancePercentage.mul(currentInitialValue)
         );
       } else if (!currentPosition.quantity.eq(0)) {
         Logger.warn(
-          `Missing initial value for symbol ${currentPosition.symbol} at ${currentPosition.firstBuyDate}`,
+          `Missing initial value for symbol ${currentPosition.symbol} at ${currentPosition.firstBuyDate}`
-          'PortfolioCalculator'
         );
         hasErrors = true;
       }
     }
 
-    if (sumOfWeights.gt(0)) {
+    if (!completeInitialValue.eq(0)) {
-      grossPerformancePercentage = grossPerformancePercentage.div(sumOfWeights);
+      grossPerformancePercentage =
-      netPerformancePercentage = netPerformancePercentage.div(sumOfWeights);
+        grossPerformancePercentage.div(completeInitialValue);
-    } else {
+      netPerformancePercentage =
-      grossPerformancePercentage = new Big(0);
+        netPerformancePercentage.div(completeInitialValue);
-      netPerformancePercentage = new Big(0);
+      netAnnualizedPerformance =
+        netAnnualizedPerformance.div(completeInitialValue);
     }
 
     return {
@@ -533,6 +534,7 @@ export class PortfolioCalculator {
       grossPerformance,
       grossPerformancePercentage,
       hasErrors,
+      netAnnualizedPerformance,
       netPerformance,
       netPerformancePercentage,
       totalInvestment
@@ -579,8 +581,7 @@ export class PortfolioCalculator {
         } catch (error) {
           Logger.error(
             `Failed to fetch info for date ${startDate} with exception`,
-            error,
+            error
-            'PortfolioCalculator'
           );
           return null;
         }
@@ -591,9 +592,9 @@ export class PortfolioCalculator {
         if (!marketSymbolMap[date]) {
           marketSymbolMap[date] = {};
         }
-        if (marketSymbol.marketPriceInBaseCurrency) {
+        if (marketSymbol.marketPrice) {
           marketSymbolMap[date][marketSymbol.symbol] = new Big(
-            marketSymbol.marketPriceInBaseCurrency
+            marketSymbol.marketPrice
           );
         }
       }
@@ -686,356 +687,6 @@ export class PortfolioCalculator {
     }
   }
 
-  private getSymbolMetrics({
-    marketSymbolMap,
-    start,
-    symbol
-  }: {
-    marketSymbolMap: {
-      [date: string]: { [symbol: string]: Big };
-    };
-    start: Date;
-    symbol: string;
-  }) {
-    let orders: PortfolioOrderItem[] = this.orders.filter((order) => {
-      return order.symbol === symbol;
-    });
-
-    if (orders.length <= 0) {
-      return {
-        hasErrors: false,
-        initialValue: new Big(0),
-        netPerformance: new Big(0),
-        netPerformancePercentage: new Big(0),
-        grossPerformance: new Big(0),
-        grossPerformancePercentage: new Big(0)
-      };
-    }
-
-    const dateOfFirstTransaction = new Date(first(orders).date);
-    const endDate = new Date(Date.now());
-
-    const unitPriceAtStartDate =
-      marketSymbolMap[format(start, DATE_FORMAT)]?.[symbol];
-
-    const unitPriceAtEndDate =
-      marketSymbolMap[format(endDate, DATE_FORMAT)]?.[symbol];
-
-    if (
-      !unitPriceAtEndDate ||
-      (!unitPriceAtStartDate && isBefore(dateOfFirstTransaction, start))
-    ) {
-      return {
-        hasErrors: true,
-        initialValue: new Big(0),
-        netPerformance: new Big(0),
-        netPerformancePercentage: new Big(0),
-        grossPerformance: new Big(0),
-        grossPerformancePercentage: new Big(0)
-      };
-    }
-
-    let averagePriceAtEndDate = new Big(0);
-    let averagePriceAtStartDate = new Big(0);
-    let feesAtStartDate = new Big(0);
-    let fees = new Big(0);
-    let grossPerformance = new Big(0);
-    let grossPerformanceAtStartDate = new Big(0);
-    let grossPerformanceFromSells = new Big(0);
-    let initialValue: Big;
-    let investmentAtStartDate: Big;
-    let lastAveragePrice = new Big(0);
-    let lastTransactionInvestment = new Big(0);
-    let lastValueOfInvestmentBeforeTransaction = new Big(0);
-    let maxTotalInvestment = new Big(0);
-    let timeWeightedGrossPerformancePercentage = new Big(1);
-    let timeWeightedNetPerformancePercentage = new Big(1);
-    let totalInvestment = new Big(0);
-    let totalInvestmentWithGrossPerformanceFromSell = new Big(0);
-    let totalUnits = new Big(0);
-    let valueAtStartDate: Big;
-
-    // Add a synthetic order at the start and the end date
-    orders.push({
-      symbol,
-      currency: null,
-      date: format(start, DATE_FORMAT),
-      dataSource: null,
-      fee: new Big(0),
-      itemType: 'start',
-      name: '',
-      quantity: new Big(0),
-      type: TypeOfOrder.BUY,
-      unitPrice: unitPriceAtStartDate
-    });
-
-    orders.push({
-      symbol,
-      currency: null,
-      date: format(endDate, DATE_FORMAT),
-      dataSource: null,
-      fee: new Big(0),
-      itemType: 'end',
-      name: '',
-      quantity: new Big(0),
-      type: TypeOfOrder.BUY,
-      unitPrice: unitPriceAtEndDate
-    });
-
-    // Sort orders so that the start and end placeholder order are at the right
-    // position
-    orders = sortBy(orders, (order) => {
-      let sortIndex = new Date(order.date);
-
-      if (order.itemType === 'start') {
-        sortIndex = addMilliseconds(sortIndex, -1);
-      }
-
-      if (order.itemType === 'end') {
-        sortIndex = addMilliseconds(sortIndex, 1);
-      }
-
-      return sortIndex.getTime();
-    });
-
-    const indexOfStartOrder = orders.findIndex((order) => {
-      return order.itemType === 'start';
-    });
-
-    const indexOfEndOrder = orders.findIndex((order) => {
-      return order.itemType === 'end';
-    });
-
-    for (let i = 0; i < orders.length; i += 1) {
-      const order = orders[i];
-
-      if (order.itemType === 'start') {
-        // Take the unit price of the order as the market price if there are no
-        // orders of this symbol before the start date
-        order.unitPrice =
-          indexOfStartOrder === 0
-            ? orders[i + 1]?.unitPrice
-            : unitPriceAtStartDate;
-      }
-
-      // Calculate the average start price as soon as any units are held
-      if (
-        averagePriceAtStartDate.eq(0) &&
-        i >= indexOfStartOrder &&
-        totalUnits.gt(0)
-      ) {
-        averagePriceAtStartDate = totalInvestment.div(totalUnits);
-      }
-
-      const valueOfInvestmentBeforeTransaction = totalUnits.mul(
-        order.unitPrice
-      );
-
-      if (!investmentAtStartDate && i >= indexOfStartOrder) {
-        investmentAtStartDate = totalInvestment ?? new Big(0);
-        valueAtStartDate = valueOfInvestmentBeforeTransaction;
-      }
-
-      const transactionInvestment = order.quantity
-        .mul(order.unitPrice)
-        .mul(this.getFactor(order.type));
-
-      totalInvestment = totalInvestment.plus(transactionInvestment);
-
-      if (i >= indexOfStartOrder && totalInvestment.gt(maxTotalInvestment)) {
-        maxTotalInvestment = totalInvestment;
-      }
-
-      if (i === indexOfEndOrder && totalUnits.gt(0)) {
-        averagePriceAtEndDate = totalInvestment.div(totalUnits);
-      }
-
-      if (i >= indexOfStartOrder && !initialValue) {
-        if (
-          i === indexOfStartOrder &&
-          !valueOfInvestmentBeforeTransaction.eq(0)
-        ) {
-          initialValue = valueOfInvestmentBeforeTransaction;
-        } else if (transactionInvestment.gt(0)) {
-          initialValue = transactionInvestment;
-        }
-      }
-
-      fees = fees.plus(order.fee);
-
-      totalUnits = totalUnits.plus(
-        order.quantity.mul(this.getFactor(order.type))
-      );
-
-      const valueOfInvestment = totalUnits.mul(order.unitPrice);
-
-      const grossPerformanceFromSell =
-        order.type === TypeOfOrder.SELL
-          ? order.unitPrice.minus(lastAveragePrice).mul(order.quantity)
-          : new Big(0);
-
-      grossPerformanceFromSells = grossPerformanceFromSells.plus(
-        grossPerformanceFromSell
-      );
-
-      totalInvestmentWithGrossPerformanceFromSell =
-        totalInvestmentWithGrossPerformanceFromSell
-          .plus(transactionInvestment)
-          .plus(grossPerformanceFromSell);
-
-      lastAveragePrice = totalUnits.eq(0)
-        ? new Big(0)
-        : totalInvestmentWithGrossPerformanceFromSell.div(totalUnits);
-
-      const newGrossPerformance = valueOfInvestment
-        .minus(totalInvestmentWithGrossPerformanceFromSell)
-        .plus(grossPerformanceFromSells);
-
-      if (
-        i > indexOfStartOrder &&
-        !lastValueOfInvestmentBeforeTransaction
-          .plus(lastTransactionInvestment)
-          .eq(0)
-      ) {
-        const grossHoldingPeriodReturn = valueOfInvestmentBeforeTransaction
-          .minus(
-            lastValueOfInvestmentBeforeTransaction.plus(
-              lastTransactionInvestment
-            )
-          )
-          .div(
-            lastValueOfInvestmentBeforeTransaction.plus(
-              lastTransactionInvestment
-            )
-          );
-
-        timeWeightedGrossPerformancePercentage =
-          timeWeightedGrossPerformancePercentage.mul(
-            new Big(1).plus(grossHoldingPeriodReturn)
-          );
-
-        const netHoldingPeriodReturn = valueOfInvestmentBeforeTransaction
-          .minus(fees.minus(feesAtStartDate))
-          .minus(
-            lastValueOfInvestmentBeforeTransaction.plus(
-              lastTransactionInvestment
-            )
-          )
-          .div(
-            lastValueOfInvestmentBeforeTransaction.plus(
-              lastTransactionInvestment
-            )
-          );
-
-        timeWeightedNetPerformancePercentage =
-          timeWeightedNetPerformancePercentage.mul(
-            new Big(1).plus(netHoldingPeriodReturn)
-          );
-      }
-
-      grossPerformance = newGrossPerformance;
-
-      lastTransactionInvestment = transactionInvestment;
-
-      lastValueOfInvestmentBeforeTransaction =
-        valueOfInvestmentBeforeTransaction;
-
-      if (order.itemType === 'start') {
-        feesAtStartDate = fees;
-        grossPerformanceAtStartDate = grossPerformance;
-      }
-    }
-
-    timeWeightedGrossPerformancePercentage =
-      timeWeightedGrossPerformancePercentage.minus(1);
-
-    timeWeightedNetPerformancePercentage =
-      timeWeightedNetPerformancePercentage.minus(1);
-
-    const totalGrossPerformance = grossPerformance.minus(
-      grossPerformanceAtStartDate
-    );
-
-    const totalNetPerformance = grossPerformance
-      .minus(grossPerformanceAtStartDate)
-      .minus(fees.minus(feesAtStartDate));
-
-    const maxInvestmentBetweenStartAndEndDate = valueAtStartDate.plus(
-      maxTotalInvestment.minus(investmentAtStartDate)
-    );
-
-    const grossPerformancePercentage =
-      PortfolioCalculator.CALCULATE_PERCENTAGE_PERFORMANCE_WITH_MAX_INVESTMENT ||
-      averagePriceAtStartDate.eq(0) ||
-      averagePriceAtEndDate.eq(0) ||
-      orders[indexOfStartOrder].unitPrice.eq(0)
-        ? maxInvestmentBetweenStartAndEndDate.gt(0)
-          ? totalGrossPerformance.div(maxInvestmentBetweenStartAndEndDate)
-          : new Big(0)
-        : // This formula has the issue that buying more units with a price
-          // lower than the average buying price results in a positive
-          // performance even if the market price stays constant
-          unitPriceAtEndDate
-            .div(averagePriceAtEndDate)
-            .div(
-              orders[indexOfStartOrder].unitPrice.div(averagePriceAtStartDate)
-            )
-            .minus(1);
-
-    const feesPerUnit = totalUnits.gt(0)
-      ? fees.minus(feesAtStartDate).div(totalUnits)
-      : new Big(0);
-
-    const netPerformancePercentage =
-      PortfolioCalculator.CALCULATE_PERCENTAGE_PERFORMANCE_WITH_MAX_INVESTMENT ||
-      averagePriceAtStartDate.eq(0) ||
-      averagePriceAtEndDate.eq(0) ||
-      orders[indexOfStartOrder].unitPrice.eq(0)
-        ? maxInvestmentBetweenStartAndEndDate.gt(0)
-          ? totalNetPerformance.div(maxInvestmentBetweenStartAndEndDate)
-          : new Big(0)
-        : // This formula has the issue that buying more units with a price
-          // lower than the average buying price results in a positive
-          // performance even if the market price stays constant
-          unitPriceAtEndDate
-            .minus(feesPerUnit)
-            .div(averagePriceAtEndDate)
-            .div(
-              orders[indexOfStartOrder].unitPrice.div(averagePriceAtStartDate)
-            )
-            .minus(1);
-
-    if (PortfolioCalculator.ENABLE_LOGGING) {
-      console.log(
-        `
-        ${symbol}
-        Unit price: ${orders[indexOfStartOrder].unitPrice.toFixed(
-          2
-        )} -> ${unitPriceAtEndDate.toFixed(2)}
-        Average price: ${averagePriceAtStartDate.toFixed(
-          2
-        )} -> ${averagePriceAtEndDate.toFixed(2)}
-        Max. total investment: ${maxTotalInvestment.toFixed(2)}
-        Gross performance: ${totalGrossPerformance.toFixed(
-          2
-        )} / ${grossPerformancePercentage.mul(100).toFixed(2)}%
-        Fees per unit: ${feesPerUnit.toFixed(2)}
-        Net performance: ${totalNetPerformance.toFixed(
-          2
-        )} / ${netPerformancePercentage.mul(100).toFixed(2)}%`
-      );
-    }
-
-    return {
-      initialValue,
-      grossPerformancePercentage,
-      netPerformancePercentage,
-      hasErrors: totalUnits.gt(0) && (!initialValue || !unitPriceAtEndDate),
-      netPerformance: totalNetPerformance,
-      grossPerformance: totalGrossPerformance
-    };
-  }
-
   private isNextItemActive(
     timelineSpecification: TimelineSpecification[],
     currentDate: Date,

apps/api/src/app/portfolio/portfolio-service.strategy.ts

@@ -0,0 +1,25 @@
+import type { RequestWithUser } from '@ghostfolio/common/types';
+import { Inject, Injectable } from '@nestjs/common';
+import { REQUEST } from '@nestjs/core';
+
+import { PortfolioService } from './portfolio.service';
+import { PortfolioServiceNew } from './portfolio.service-new';
+
+@Injectable()
+export class PortfolioServiceStrategy {
+  public constructor(
+    private readonly portfolioService: PortfolioService,
+    private readonly portfolioServiceNew: PortfolioServiceNew,
+    @Inject(REQUEST) private readonly request: RequestWithUser
+  ) {}
+
+  public get() {
+    if (
+      this.request.user?.Settings?.settings?.['isNewCalculationEngine'] === true
+    ) {
+      return this.portfolioServiceNew;
+    }
+
+    return this.portfolioService;
+  }
+}

apps/api/src/app/portfolio/portfolio.controller.ts

@@ -4,28 +4,22 @@ import {
   hasNotDefinedValuesInObject,
   nullifyValuesInObject
 } from '@ghostfolio/api/helper/object.helper';
-import { RedactValuesInResponseInterceptor } from '@ghostfolio/api/interceptors/redact-values-in-response.interceptor';
 import { TransformDataSourceInRequestInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-request.interceptor';
 import { TransformDataSourceInResponseInterceptor } from '@ghostfolio/api/interceptors/transform-data-source-in-response.interceptor';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { baseCurrency } from '@ghostfolio/common/config';
 import { parseDate } from '@ghostfolio/common/helper';
 import {
-  Filter,
   PortfolioChart,
   PortfolioDetails,
   PortfolioInvestments,
-  PortfolioPerformanceResponse,
+  PortfolioPerformance,
   PortfolioPublicDetails,
   PortfolioReport,
   PortfolioSummary
 } from '@ghostfolio/common/interfaces';
-import { InvestmentItem } from '@ghostfolio/common/interfaces/investment-item.interface';
+import type { RequestWithUser } from '@ghostfolio/common/types';
-import type {
-  DateRange,
-  GroupBy,
-  RequestWithUser
-} from '@ghostfolio/common/types';
 import {
   Controller,
   Get,
@@ -39,27 +33,22 @@ import {
 } from '@nestjs/common';
 import { REQUEST } from '@nestjs/core';
 import { AuthGuard } from '@nestjs/passport';
-import { ViewMode } from '@prisma/client';
 import { StatusCodes, getReasonPhrase } from 'http-status-codes';
 
 import { PortfolioPositionDetail } from './interfaces/portfolio-position-detail.interface';
 import { PortfolioPositions } from './interfaces/portfolio-positions.interface';
-import { PortfolioService } from './portfolio.service';
+import { PortfolioServiceStrategy } from './portfolio-service.strategy';
 
 @Controller('portfolio')
 export class PortfolioController {
-  private baseCurrency: string;
-
   public constructor(
     private readonly accessService: AccessService,
     private readonly configurationService: ConfigurationService,
     private readonly exchangeRateDataService: ExchangeRateDataService,
-    private readonly portfolioService: PortfolioService,
+    private readonly portfolioServiceStrategy: PortfolioServiceStrategy,
     @Inject(REQUEST) private readonly request: RequestWithUser,
     private readonly userService: UserService
-  ) {
+  ) {}
-    this.baseCurrency = this.configurationService.get('BASE_CURRENCY');
-  }
 
   @Get('chart')
   @UseGuards(AuthGuard('jwt'))
@@ -67,10 +56,9 @@ export class PortfolioController {
     @Headers('impersonation-id') impersonationId: string,
     @Query('range') range
   ): Promise<PortfolioChart> {
-    const historicalDataContainer = await this.portfolioService.getChart(
+    const historicalDataContainer = await this.portfolioServiceStrategy
-      impersonationId,
+      .get()
-      range
+      .getChart(impersonationId, range);
-    );
 
     let chartData = historicalDataContainer.items;
 
@@ -112,49 +100,27 @@ export class PortfolioController {
 
   @Get('details')
   @UseGuards(AuthGuard('jwt'))
-  @UseInterceptors(RedactValuesInResponseInterceptor)
   @UseInterceptors(TransformDataSourceInResponseInterceptor)
   public async getDetails(
     @Headers('impersonation-id') impersonationId: string,
-    @Query('accounts') filterByAccounts?: string,
+    @Query('range') range
-    @Query('assetClasses') filterByAssetClasses?: string,
-    @Query('range') range?: DateRange,
-    @Query('tags') filterByTags?: string
   ): Promise<PortfolioDetails & { hasError: boolean }> {
+    if (
+      this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION') &&
+      this.request.user.subscription.type === 'Basic'
+    ) {
+      throw new HttpException(
+        getReasonPhrase(StatusCodes.FORBIDDEN),
+        StatusCodes.FORBIDDEN
+      );
+    }
+
     let hasError = false;
 
-    const accountIds = filterByAccounts?.split(',') ?? [];
-    const assetClasses = filterByAssetClasses?.split(',') ?? [];
-    const tagIds = filterByTags?.split(',') ?? [];
-
-    const filters: Filter[] = [
-      ...accountIds.map((accountId) => {
-        return <Filter>{
-          id: accountId,
-          type: 'ACCOUNT'
-        };
-      }),
-      ...assetClasses.map((assetClass) => {
-        return <Filter>{
-          id: assetClass,
-          type: 'ASSET_CLASS'
-        };
-      }),
-      ...tagIds.map((tagId) => {
-        return <Filter>{
-          id: tagId,
-          type: 'TAG'
-        };
-      })
-    ];
-
     const { accounts, holdings, hasErrors } =
-      await this.portfolioService.getDetails(
+      await this.portfolioServiceStrategy
-        impersonationId,
+        .get()
-        this.request.user.id,
+        .getDetails(impersonationId, this.request.user.id, range);
-        range,
-        filters
-      );
 
     if (hasErrors || hasNotDefinedValuesInObject(holdings)) {
       hasError = true;
@@ -195,35 +161,13 @@ export class PortfolioController {
       }
     }
 
-    let hasDetails = true;
+    return { accounts, hasError, holdings };
-    if (this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION')) {
-      hasDetails = this.request.user.subscription.type === 'Premium';
-    }
-
-    for (const [symbol, portfolioPosition] of Object.entries(holdings)) {
-      holdings[symbol] = {
-        ...portfolioPosition,
-        assetClass: hasDetails ? portfolioPosition.assetClass : undefined,
-        assetSubClass: hasDetails ? portfolioPosition.assetSubClass : undefined,
-        countries: hasDetails ? portfolioPosition.countries : [],
-        currency: hasDetails ? portfolioPosition.currency : undefined,
-        markets: hasDetails ? portfolioPosition.markets : undefined,
-        sectors: hasDetails ? portfolioPosition.sectors : []
-      };
-    }
-
-    return {
-      accounts,
-      hasError,
-      holdings
-    };
   }
 
   @Get('investments')
   @UseGuards(AuthGuard('jwt'))
   public async getInvestments(
-    @Headers('impersonation-id') impersonationId: string,
+    @Headers('impersonation-id') impersonationId: string
-    @Query('groupBy') groupBy?: GroupBy
   ): Promise<PortfolioInvestments> {
     if (
       this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION') &&
@@ -235,16 +179,9 @@ export class PortfolioController {
       );
     }
 
-    let investments: InvestmentItem[];
+    let investments = await this.portfolioServiceStrategy
-
+      .get()
-    if (groupBy === 'month') {
+      .getInvestments(impersonationId);
-      investments = await this.portfolioService.getInvestments(
-        impersonationId,
-        'month'
-      );
-    } else {
-      investments = await this.portfolioService.getInvestments(impersonationId);
-    }
 
     if (
       impersonationId ||
@@ -266,19 +203,16 @@ export class PortfolioController {
 
   @Get('performance')
   @UseGuards(AuthGuard('jwt'))
-  @UseInterceptors(TransformDataSourceInResponseInterceptor)
   public async getPerformance(
     @Headers('impersonation-id') impersonationId: string,
     @Query('range') range
-  ): Promise<PortfolioPerformanceResponse> {
+  ): Promise<{ hasErrors: boolean; performance: PortfolioPerformance }> {
-    const performanceInformation = await this.portfolioService.getPerformance(
+    const performanceInformation = await this.portfolioServiceStrategy
-      impersonationId,
+      .get()
-      range
+      .getPerformance(impersonationId, range);
-    );
 
     if (
       impersonationId ||
-      this.request.user.Settings.viewMode === ViewMode.ZEN ||
       this.userService.isRestrictedView(this.request.user)
     ) {
       performanceInformation.performance = nullifyValuesInObject(
@@ -297,10 +231,9 @@ export class PortfolioController {
     @Headers('impersonation-id') impersonationId: string,
     @Query('range') range
   ): Promise<PortfolioPositions> {
-    const result = await this.portfolioService.getPositions(
+    const result = await this.portfolioServiceStrategy
-      impersonationId,
+      .get()
-      range
+      .getPositions(impersonationId, range);
-    );
 
     if (
       impersonationId ||
@@ -340,12 +273,9 @@ export class PortfolioController {
       hasDetails = user.subscription.type === 'Premium';
     }
 
-    const { holdings } = await this.portfolioService.getDetails(
+    const { holdings } = await this.portfolioServiceStrategy
-      access.userId,
+      .get()
-      access.userId,
+      .getDetails(access.userId, access.userId);
-      'max',
-      [{ id: 'EQUITY', type: 'ASSET_CLASS' }]
-    );
 
     const portfolioPublicDetails: PortfolioPublicDetails = {
       hasDetails,
@@ -353,28 +283,29 @@ export class PortfolioController {
     };
 
     const totalValue = Object.values(holdings)
+      .filter((holding) => {
+        return holding.assetClass === 'EQUITY';
+      })
       .map((portfolioPosition) => {
         return this.exchangeRateDataService.toCurrency(
           portfolioPosition.quantity * portfolioPosition.marketPrice,
           portfolioPosition.currency,
-          this.request.user?.Settings?.currency ?? this.baseCurrency
+          this.request.user?.Settings?.currency ?? baseCurrency
         );
       })
       .reduce((a, b) => a + b, 0);
 
     for (const [symbol, portfolioPosition] of Object.entries(holdings)) {
-      portfolioPublicDetails.holdings[symbol] = {
+      if (portfolioPosition.assetClass === 'EQUITY') {
-        allocationCurrent: portfolioPosition.value / totalValue,
+        portfolioPublicDetails.holdings[symbol] = {
-        countries: hasDetails ? portfolioPosition.countries : [],
+          allocationCurrent: portfolioPosition.allocationCurrent,
-        currency: hasDetails ? portfolioPosition.currency : undefined,
+          countries: hasDetails ? portfolioPosition.countries : [],
-        markets: hasDetails ? portfolioPosition.markets : undefined,
+          currency: portfolioPosition.currency,
-        name: portfolioPosition.name,
+          name: portfolioPosition.name,
-        netPerformancePercent: portfolioPosition.netPerformancePercent,
+          sectors: hasDetails ? portfolioPosition.sectors : [],
-        sectors: hasDetails ? portfolioPosition.sectors : [],
+          value: portfolioPosition.value / totalValue
-        symbol: portfolioPosition.symbol,
+        };
-        url: portfolioPosition.url,
+      }
-        value: portfolioPosition.value / totalValue
-      };
     }
 
     return portfolioPublicDetails;
@@ -385,17 +316,9 @@ export class PortfolioController {
   public async getSummary(
     @Headers('impersonation-id') impersonationId
   ): Promise<PortfolioSummary> {
-    if (
+    let summary = await this.portfolioServiceStrategy
-      this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION') &&
+      .get()
-      this.request.user.subscription.type === 'Basic'
+      .getSummary(impersonationId);
-    ) {
-      throw new HttpException(
-        getReasonPhrase(StatusCodes.FORBIDDEN),
-        StatusCodes.FORBIDDEN
-      );
-    }
-
-    let summary = await this.portfolioService.getSummary(impersonationId);
 
     if (
       impersonationId ||
@@ -408,7 +331,6 @@ export class PortfolioController {
         'currentNetPerformance',
         'currentValue',
         'dividend',
-        'emergencyFund',
         'fees',
         'items',
         'netWorth',
@@ -429,11 +351,9 @@ export class PortfolioController {
     @Param('dataSource') dataSource,
     @Param('symbol') symbol
   ): Promise<PortfolioPositionDetail> {
-    let position = await this.portfolioService.getPosition(
+    let position = await this.portfolioServiceStrategy
-      dataSource,
+      .get()
-      impersonationId,
+      .getPosition(dataSource, impersonationId, symbol);
-      symbol
-    );
 
     if (position) {
       if (
@@ -474,6 +394,6 @@ export class PortfolioController {
       );
     }
 
-    return await this.portfolioService.getReport(impersonationId);
+    return await this.portfolioServiceStrategy.get().getReport(impersonationId);
   }
 }

apps/api/src/app/portfolio/portfolio.module.ts

@@ -13,13 +13,15 @@ import { SymbolProfileModule } from '@ghostfolio/api/services/symbol-profile.mod
 import { Module } from '@nestjs/common';
 
 import { CurrentRateService } from './current-rate.service';
+import { PortfolioServiceStrategy } from './portfolio-service.strategy';
 import { PortfolioController } from './portfolio.controller';
 import { PortfolioService } from './portfolio.service';
+import { PortfolioServiceNew } from './portfolio.service-new';
 import { RulesService } from './rules.service';
 
 @Module({
   controllers: [PortfolioController],
-  exports: [PortfolioService],
+  exports: [PortfolioServiceStrategy],
   imports: [
     AccessModule,
     ConfigurationModule,
@@ -37,6 +39,8 @@ import { RulesService } from './rules.service';
     AccountService,
     CurrentRateService,
     PortfolioService,
+    PortfolioServiceNew,
+    PortfolioServiceStrategy,
     RulesService
   ]
 })

apps/api/src/app/redis-cache/redis-cache.module.ts

@@ -14,7 +14,6 @@ import { RedisCacheService } from './redis-cache.service';
       useFactory: async (configurationService: ConfigurationService) => ({
         host: configurationService.get('REDIS_HOST'),
         max: configurationService.get('MAX_ITEM_IN_CACHE'),
-        password: configurationService.get('REDIS_PASSWORD'),
         port: configurationService.get('REDIS_PORT'),
         store: redisStore,
         ttl: configurationService.get('CACHE_TTL')

apps/api/src/app/subscription/subscription.controller.ts

@@ -46,25 +46,22 @@ export class SubscriptionController {
       ((await this.propertyService.getByKey(PROPERTY_COUPONS)) as Coupon[]) ??
       [];
 
-    const coupon = coupons.find((currentCoupon) => {
+    const isValid = coupons.some((coupon) => {
-      return currentCoupon.code === couponCode;
+      return coupon.code === couponCode;
     });
 
-    if (coupon === undefined) {
+    if (!isValid) {
       throw new HttpException(
         getReasonPhrase(StatusCodes.BAD_REQUEST),
         StatusCodes.BAD_REQUEST
       );
     }
 
-    await this.subscriptionService.createSubscription({
+    await this.subscriptionService.createSubscription(this.request.user.id);
-      duration: coupon.duration,
-      userId: this.request.user.id
-    });
 
     // Destroy coupon
-    coupons = coupons.filter((currentCoupon) => {
+    coupons = coupons.filter((coupon) => {
-      return currentCoupon.code !== couponCode;
+      return coupon.code !== couponCode;
     });
     await this.propertyService.put({
       key: PROPERTY_COUPONS,
@@ -72,8 +69,7 @@ export class SubscriptionController {
     });
 
     Logger.log(
-      `Subscription for user '${this.request.user.id}' has been created with a coupon for ${coupon.duration}`,
+      `Subscription for user '${this.request.user.id}' has been created with coupon`
-      'SubscriptionController'
     );
 
     return {
@@ -88,10 +84,7 @@ export class SubscriptionController {
       req.query.checkoutSessionId
     );
 
-    Logger.log(
+    Logger.log(`Subscription for user '${userId}' has been created via Stripe`);
-      `Subscription for user '${userId}' has been created via Stripe`,
-      'SubscriptionController'
-    );
 
     res.redirect(`${this.configurationService.get('ROOT_URL')}/account`);
   }
@@ -108,7 +101,7 @@ export class SubscriptionController {
         userId: this.request.user.id
       });
     } catch (error) {
-      Logger.error(error, 'SubscriptionController');
+      Logger.error(error);
 
       throw new HttpException(
         getReasonPhrase(StatusCodes.BAD_REQUEST),

apps/api/src/app/subscription/subscription.service.ts

@@ -2,9 +2,8 @@ import { ConfigurationService } from '@ghostfolio/api/services/configuration.ser
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { SubscriptionType } from '@ghostfolio/common/types/subscription.type';
 import { Injectable, Logger } from '@nestjs/common';
-import { Subscription } from '@prisma/client';
+import { Subscription, User } from '@prisma/client';
-import { addMilliseconds, isBefore } from 'date-fns';
+import { addDays, isBefore } from 'date-fns';
-import ms, { StringValue } from 'ms';
 import Stripe from 'stripe';
 
 @Injectable()
@@ -45,7 +44,7 @@ export class SubscriptionService {
       payment_method_types: ['card'],
       success_url: `${this.configurationService.get(
         'ROOT_URL'
-      )}/api/v1/subscription/stripe/callback?checkoutSessionId={CHECKOUT_SESSION_ID}`
+      )}/api/subscription/stripe/callback?checkoutSessionId={CHECKOUT_SESSION_ID}`
     };
 
     if (couponId) {
@@ -65,19 +64,13 @@ export class SubscriptionService {
     };
   }
 
-  public async createSubscription({
+  public async createSubscription(aUserId: string) {
-    duration = '1 year',
-    userId
-  }: {
-    duration?: StringValue;
-    userId: string;
-  }) {
     await this.prismaService.subscription.create({
       data: {
-        expiresAt: addMilliseconds(new Date(), ms(duration)),
+        expiresAt: addDays(new Date(), 365),
         User: {
           connect: {
-            id: userId
+            id: aUserId
           }
         }
       }
@@ -90,7 +83,7 @@ export class SubscriptionService {
         aCheckoutSessionId
       );
 
-      await this.createSubscription({ userId: session.client_reference_id });
+      await this.createSubscription(session.client_reference_id);
 
       await this.stripe.customers.update(session.customer as string, {
         description: session.client_reference_id
@@ -98,7 +91,7 @@ export class SubscriptionService {
 
       return session.client_reference_id;
     } catch (error) {
-      Logger.error(error, 'SubscriptionService');
+      Logger.error(error);
     }
   }
 

apps/api/src/app/symbol/interfaces/symbol-item.interface.ts

@@ -1,7 +1,9 @@
-import { HistoricalDataItem, UniqueAsset } from '@ghostfolio/common/interfaces';
+import { HistoricalDataItem } from '@ghostfolio/api/app/portfolio/interfaces/portfolio-position-detail.interface';
+import { DataSource } from '@prisma/client';
 
-export interface SymbolItem extends UniqueAsset {
+export interface SymbolItem {
   currency: string;
+  dataSource: DataSource;
   historicalData: HistoricalDataItem[];
   marketPrice: number;
 }

apps/api/src/app/symbol/symbol.controller.ts

@@ -46,6 +46,7 @@ export class SymbolController {
    * Must be after /lookup
    */
   @Get(':dataSource/:symbol')
+  @UseGuards(AuthGuard('jwt'))
   @UseInterceptors(TransformDataSourceInRequestInterceptor)
   @UseInterceptors(TransformDataSourceInResponseInterceptor)
   public async getSymbolData(

apps/api/src/app/symbol/symbol.service.ts

@@ -1,3 +1,4 @@
+import { HistoricalDataItem } from '@ghostfolio/api/app/portfolio/interfaces/portfolio-position-detail.interface';
 import { DataProviderService } from '@ghostfolio/api/services/data-provider/data-provider.service';
 import {
   IDataGatheringItem,
@@ -5,7 +6,6 @@ import {
 } from '@ghostfolio/api/services/interfaces/interfaces';
 import { MarketDataService } from '@ghostfolio/api/services/market-data.service';
 import { DATE_FORMAT } from '@ghostfolio/common/helper';
-import { HistoricalDataItem } from '@ghostfolio/common/interfaces';
 import { Injectable, Logger } from '@nestjs/common';
 import { DataSource } from '@prisma/client';
 import { format, subDays } from 'date-fns';
@@ -27,10 +27,8 @@ export class SymbolService {
     dataGatheringItem: IDataGatheringItem;
     includeHistoricalData?: number;
   }): Promise<SymbolItem> {
-    const quotes = await this.dataProviderService.getQuotes([
+    const response = await this.dataProviderService.get([dataGatheringItem]);
-      dataGatheringItem
+    const { currency, marketPrice } = response[dataGatheringItem.symbol] ?? {};
-    ]);
-    const { currency, marketPrice } = quotes[dataGatheringItem.symbol] ?? {};
 
     if (dataGatheringItem.dataSource && marketPrice) {
       let historicalData: HistoricalDataItem[] = [];
@@ -55,8 +53,7 @@ export class SymbolService {
         currency,
         historicalData,
         marketPrice,
-        dataSource: dataGatheringItem.dataSource,
+        dataSource: dataGatheringItem.dataSource
-        symbol: dataGatheringItem.symbol
       };
     }
 
@@ -96,7 +93,7 @@ export class SymbolService {
       results.items = items;
       return results;
     } catch (error) {
-      Logger.error(error, 'SymbolService');
+      Logger.error(error);
 
       throw error;
     }

apps/api/src/app/user/interfaces/access.interface.ts

@@ -0,0 +1,4 @@
+export interface Access {
+  alias?: string;
+  id: string;
+}

apps/api/src/app/user/interfaces/user-settings.interface.ts

@@ -1,5 +1,3 @@
 export interface UserSettings {
-  emergencyFund?: number;
-  locale?: string;
   isRestrictedView?: boolean;
 }

apps/api/src/app/user/update-user-setting.dto.ts

@@ -1,19 +1,11 @@
-import { IsBoolean, IsNumber, IsOptional, IsString } from 'class-validator';
+import { IsBoolean, IsOptional } from 'class-validator';
 
 export class UpdateUserSettingDto {
-  @IsNumber()
+  @IsBoolean()
   @IsOptional()
-  emergencyFund?: number;
+  isNewCalculationEngine?: boolean;
 
   @IsBoolean()
   @IsOptional()
   isRestrictedView?: boolean;
-
-  @IsString()
-  @IsOptional()
-  locale?: string;
-
-  @IsNumber()
-  @IsOptional()
-  savingsRate?: number;
 }

apps/api/src/app/user/user.controller.ts

@@ -2,14 +2,17 @@ import { ConfigurationService } from '@ghostfolio/api/services/configuration.ser
 import { PropertyService } from '@ghostfolio/api/services/property/property.service';
 import { PROPERTY_IS_READ_ONLY_MODE } from '@ghostfolio/common/config';
 import { User } from '@ghostfolio/common/interfaces';
-import { hasPermission, permissions } from '@ghostfolio/common/permissions';
+import {
+  hasPermission,
+  hasRole,
+  permissions
+} from '@ghostfolio/common/permissions';
 import type { RequestWithUser } from '@ghostfolio/common/types';
 import {
   Body,
   Controller,
   Delete,
   Get,
-  Headers,
   HttpException,
   Inject,
   Param,
@@ -20,6 +23,7 @@ import {
 import { REQUEST } from '@nestjs/core';
 import { JwtService } from '@nestjs/jwt';
 import { AuthGuard } from '@nestjs/passport';
+import { Provider, Role } from '@prisma/client';
 import { User as UserModel } from '@prisma/client';
 import { StatusCodes, getReasonPhrase } from 'http-status-codes';
 
@@ -34,7 +38,7 @@ import { UserService } from './user.service';
 export class UserController {
   public constructor(
     private readonly configurationService: ConfigurationService,
-    private readonly jwtService: JwtService,
+    private jwtService: JwtService,
     private readonly propertyService: PropertyService,
     @Inject(REQUEST) private readonly request: RequestWithUser,
     private readonly userService: UserService
@@ -60,13 +64,8 @@ export class UserController {
 
   @Get()
   @UseGuards(AuthGuard('jwt'))
-  public async getUser(
+  public async getUser(@Param('id') id: string): Promise<User> {
-    @Headers('accept-language') acceptLanguage: string
+    return this.userService.getUser(this.request.user);
-  ): Promise<User> {
-    return this.userService.getUser(
-      this.request.user,
-      acceptLanguage?.split(',')?.[0]
-    );
   }
 
   @Post()
@@ -120,7 +119,7 @@ export class UserController {
     };
 
     for (const key in userSettings) {
-      if (userSettings[key] === false || userSettings[key] === null) {
+      if (userSettings[key] === false) {
         delete userSettings[key];
       }
     }

apps/api/src/app/user/user.module.ts

@@ -2,7 +2,6 @@ import { SubscriptionModule } from '@ghostfolio/api/app/subscription/subscriptio
 import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
 import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { PropertyModule } from '@ghostfolio/api/services/property/property.module';
-import { TagModule } from '@ghostfolio/api/services/tag/tag.module';
 import { Module } from '@nestjs/common';
 import { JwtModule } from '@nestjs/jwt';
 
@@ -20,8 +19,7 @@ import { UserService } from './user.service';
     }),
     PrismaModule,
     PropertyModule,
-    SubscriptionModule,
+    SubscriptionModule
-    TagModule
   ],
   providers: [UserService]
 })

apps/api/src/app/user/user.service.ts

@@ -2,17 +2,20 @@ import { SubscriptionService } from '@ghostfolio/api/app/subscription/subscripti
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { PropertyService } from '@ghostfolio/api/services/property/property.service';
-import { TagService } from '@ghostfolio/api/services/tag/tag.service';
+import {
-import { PROPERTY_IS_READ_ONLY_MODE, locale } from '@ghostfolio/common/config';
+  PROPERTY_IS_READ_ONLY_MODE,
+  baseCurrency,
+  locale
+} from '@ghostfolio/common/config';
 import { User as IUser, UserWithSettings } from '@ghostfolio/common/interfaces';
 import {
   getPermissions,
   hasRole,
   permissions
 } from '@ghostfolio/common/permissions';
+import { SubscriptionType } from '@ghostfolio/common/types/subscription.type';
 import { Injectable } from '@nestjs/common';
-import { Prisma, Role, User, ViewMode } from '@prisma/client';
+import { Prisma, Provider, Role, User, ViewMode } from '@prisma/client';
-import { sortBy } from 'lodash';
 
 import { UserSettingsParams } from './interfaces/user-settings-params.interface';
 import { UserSettings } from './interfaces/user-settings.interface';
@@ -23,29 +26,21 @@ const crypto = require('crypto');
 export class UserService {
   public static DEFAULT_CURRENCY = 'USD';
 
-  private baseCurrency: string;
-
   public constructor(
     private readonly configurationService: ConfigurationService,
     private readonly prismaService: PrismaService,
     private readonly propertyService: PropertyService,
-    private readonly subscriptionService: SubscriptionService,
+    private readonly subscriptionService: SubscriptionService
-    private readonly tagService: TagService
+  ) {}
-  ) {
-    this.baseCurrency = this.configurationService.get('BASE_CURRENCY');
-  }
 
-  public async getUser(
+  public async getUser({
-    {
+    Account,
-      Account,
+    alias,
-      alias,
+    id,
-      id,
+    permissions,
-      permissions,
+    Settings,
-      Settings,
+    subscription
-      subscription
+  }: UserWithSettings): Promise<IUser> {
-    }: UserWithSettings,
-    aLocale = locale
-  ): Promise<IUser> {
     const access = await this.prismaService.access.findMany({
       include: {
         User: true
@@ -53,21 +48,12 @@ export class UserService {
       orderBy: { User: { alias: 'asc' } },
       where: { GranteeUser: { id } }
     });
-    let tags = await this.tagService.getByUser(id);
-
-    if (
-      this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION') &&
-      subscription.type === 'Basic'
-    ) {
-      tags = [];
-    }
 
     return {
       alias,
       id,
       permissions,
       subscription,
-      tags,
       access: access.map((accessItem) => {
         return {
           alias: accessItem.User.alias,
@@ -77,8 +63,8 @@ export class UserService {
       accounts: Account,
       settings: {
         ...(<UserSettings>Settings.settings),
+        locale,
         baseCurrency: Settings?.currency ?? UserService.DEFAULT_CURRENCY,
-        locale: (<UserSettings>Settings.settings)?.locale ?? aLocale,
         viewMode: Settings?.viewMode ?? ViewMode.DEFAULT
       }
     };
@@ -103,63 +89,17 @@ export class UserService {
   public async user(
     userWhereUniqueInput: Prisma.UserWhereUniqueInput
   ): Promise<UserWithSettings | null> {
-    const {
+    const userFromDatabase = await this.prismaService.user.findUnique({
-      accessToken,
-      Account,
-      alias,
-      authChallenge,
-      createdAt,
-      id,
-      provider,
-      role,
-      Settings,
-      Subscription,
-      thirdPartyId,
-      updatedAt
-    } = await this.prismaService.user.findUnique({
       include: { Account: true, Settings: true, Subscription: true },
       where: userWhereUniqueInput
     });
 
-    const user: UserWithSettings = {
+    const user: UserWithSettings = userFromDatabase;
-      accessToken,
-      Account,
-      alias,
-      authChallenge,
-      createdAt,
-      id,
-      provider,
-      role,
-      Settings,
-      thirdPartyId,
-      updatedAt
-    };
 
-    if (user?.Settings) {
+    let currentPermissions = getPermissions(userFromDatabase.role);
-      if (!user.Settings.currency) {
-        // Set default currency if needed
-        user.Settings.currency = UserService.DEFAULT_CURRENCY;
-      }
-    } else if (user) {
-      // Set default settings if needed
-      user.Settings = {
-        currency: UserService.DEFAULT_CURRENCY,
-        settings: null,
-        updatedAt: new Date(),
-        userId: user?.id,
-        viewMode: ViewMode.DEFAULT
-      };
-    }
 
-    if (this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION')) {
+    if (this.configurationService.get('ENABLE_FEATURE_FEAR_AND_GREED_INDEX')) {
-      user.subscription =
+      currentPermissions.push(permissions.accessFearAndGreedIndex);
-        this.subscriptionService.getSubscription(Subscription);
-    }
-
-    let currentPermissions = getPermissions(user.role);
-
-    if (user.subscription?.type === 'Premium') {
-      currentPermissions.push(permissions.reportDataGlitch);
     }
 
     if (this.configurationService.get('ENABLE_FEATURE_READ_ONLY_MODE')) {
@@ -182,10 +122,36 @@ export class UserService {
       }
     }
 
-    user.Account = sortBy(user.Account, (account) => {
+    user.permissions = currentPermissions;
-      return account.name;
+
-    });
+    if (userFromDatabase?.Settings) {
-    user.permissions = currentPermissions.sort();
+      if (!userFromDatabase.Settings.currency) {
+        // Set default currency if needed
+        userFromDatabase.Settings.currency = UserService.DEFAULT_CURRENCY;
+      }
+    } else if (userFromDatabase) {
+      // Set default settings if needed
+      userFromDatabase.Settings = {
+        currency: UserService.DEFAULT_CURRENCY,
+        settings: null,
+        updatedAt: new Date(),
+        userId: userFromDatabase?.id,
+        viewMode: ViewMode.DEFAULT
+      };
+    }
+
+    if (this.configurationService.get('ENABLE_FEATURE_SUBSCRIPTION')) {
+      user.subscription = this.subscriptionService.getSubscription(
+        userFromDatabase?.Subscription
+      );
+
+      if (user.subscription.type === SubscriptionType.Basic) {
+        user.permissions = user.permissions.filter((permission) => {
+          return permission !== permissions.updateViewMode;
+        });
+        user.Settings.viewMode = ViewMode.ZEN;
+      }
+    }
 
     return user;
   }
@@ -224,14 +190,14 @@ export class UserService {
         ...data,
         Account: {
           create: {
-            currency: this.baseCurrency,
+            currency: baseCurrency,
             isDefault: true,
             name: 'Default Account'
           }
         },
         Settings: {
           create: {
-            currency: this.baseCurrency
+            currency: baseCurrency
           }
         }
       }

apps/api/src/assets/countries/developed-markets.json

@@ -1,26 +0,0 @@
-[
-  "AT",
-  "AU",
-  "BE",
-  "CA",
-  "CH",
-  "DE",
-  "DK",
-  "ES",
-  "FI",
-  "FR",
-  "GB",
-  "HK",
-  "IE",
-  "IL",
-  "IT",
-  "JP",
-  "LU",
-  "NL",
-  "NO",
-  "NZ",
-  "PT",
-  "SE",
-  "SG",
-  "US"
-]

apps/api/src/assets/countries/emerging-markets.json

@@ -1,28 +0,0 @@
-[
-  "AE",
-  "BR",
-  "CL",
-  "CN",
-  "CO",
-  "CY",
-  "CZ",
-  "EG",
-  "GR",
-  "HK",
-  "HU",
-  "ID",
-  "IN",
-  "KR",
-  "KW",
-  "MX",
-  "MY",
-  "PE",
-  "PH",
-  "PL",
-  "QA",
-  "SA",
-  "TH",
-  "TR",
-  "TW",
-  "ZA"
-]

apps/api/src/assets/cryptocurrencies/custom.json

@@ -1,6 +0,0 @@
-{
-  "LUNA1": "Terra",
-  "LUNA2": "Terra",
-  "SGB1": "Songbird",
-  "UNI1": "Uniswap"
-}

apps/api/src/interceptors/redact-values-in-response.interceptor.ts

@@ -1,50 +0,0 @@
-import { Activity } from '@ghostfolio/api/app/order/interfaces/activities.interface';
-import {
-  CallHandler,
-  ExecutionContext,
-  Injectable,
-  NestInterceptor
-} from '@nestjs/common';
-import { Observable } from 'rxjs';
-import { map } from 'rxjs/operators';
-
-@Injectable()
-export class RedactValuesInResponseInterceptor<T>
-  implements NestInterceptor<T, any>
-{
-  public constructor() {}
-
-  public intercept(
-    context: ExecutionContext,
-    next: CallHandler<T>
-  ): Observable<any> {
-    return next.handle().pipe(
-      map((data: any) => {
-        const request = context.switchToHttp().getRequest();
-        const hasImpersonationId = !!request.headers?.['impersonation-id'];
-
-        if (hasImpersonationId) {
-          if (data.accounts) {
-            for (const accountId of Object.keys(data.accounts)) {
-              if (data.accounts[accountId]?.balance !== undefined) {
-                data.accounts[accountId].balance = null;
-              }
-            }
-          }
-
-          if (data.activities) {
-            data.activities = data.activities.map((activity: Activity) => {
-              if (activity.Account?.balance !== undefined) {
-                activity.Account.balance = null;
-              }
-
-              return activity;
-            });
-          }
-        }
-
-        return data;
-      })
-    );
-  }
-}

apps/api/src/interceptors/transform-data-source-in-response.interceptor.ts

@@ -32,6 +32,7 @@ export class TransformDataSourceInResponseInterceptor<T>
               activity.SymbolProfile.dataSource = encodeDataSource(
                 activity.SymbolProfile.dataSource
               );
+              activity.dataSource = encodeDataSource(activity.dataSource);
               return activity;
             });
           }
@@ -40,14 +41,6 @@ export class TransformDataSourceInResponseInterceptor<T>
             data.dataSource = encodeDataSource(data.dataSource);
           }
 
-          if (data.errors) {
-            for (const error of data.errors) {
-              if (error.dataSource) {
-                error.dataSource = encodeDataSource(error.dataSource);
-              }
-            }
-          }
-
           if (data.holdings) {
             for (const symbol of Object.keys(data.holdings)) {
               if (data.holdings[symbol].dataSource) {
@@ -65,6 +58,13 @@ export class TransformDataSourceInResponseInterceptor<T>
             });
           }
 
+          if (data.orders) {
+            data.orders.map((order) => {
+              order.dataSource = encodeDataSource(order.dataSource);
+              return order;
+            });
+          }
+
           if (data.positions) {
             data.positions.map((position) => {
               position.dataSource = encodeDataSource(position.dataSource);

apps/api/src/main.ts

@@ -1,4 +1,4 @@
-import { Logger, ValidationPipe, VersioningType } from '@nestjs/common';
+import { Logger, ValidationPipe } from '@nestjs/common';
 import { NestFactory } from '@nestjs/core';
 
 import { AppModule } from './app/app.module';
@@ -7,11 +7,8 @@ import { environment } from './environments/environment';
 async function bootstrap() {
   const app = await NestFactory.create(AppModule);
   app.enableCors();
-  app.enableVersioning({
+  const globalPrefix = 'api';
-    defaultVersion: '1',
+  app.setGlobalPrefix(globalPrefix);
-    type: VersioningType.URI
-  });
-  app.setGlobalPrefix('api');
   app.useGlobalPipes(
     new ValidationPipe({
       forbidNonWhitelisted: true,
@@ -20,11 +17,10 @@ async function bootstrap() {
     })
   );
 
-  const host = process.env.HOST || '0.0.0.0';
   const port = process.env.PORT || 3333;
-  await app.listen(port, host, () => {
+  await app.listen(port, () => {
     logLogo();
-    Logger.log(`Listening at http://${host}:${port}`);
+    Logger.log(`Listening at http://localhost:${port}`);
     Logger.log('');
   });
 }

apps/api/src/models/rules/account-cluster-risk/initial-investment.ts

@@ -1,10 +1,10 @@
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import {
   PortfolioDetails,
   PortfolioPosition
 } from '@ghostfolio/common/interfaces';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/models/rules/account-cluster-risk/single-account.ts

@@ -1,7 +1,7 @@
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
 import { PortfolioDetails } from '@ghostfolio/common/interfaces';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/models/rules/currency-cluster-risk/base-currency-initial-investment.ts

@@ -1,7 +1,7 @@
 import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/models/rules/currency-cluster-risk/current-investment.ts

@@ -1,7 +1,7 @@
 import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/models/rules/currency-cluster-risk/initial-investment.ts

@@ -1,7 +1,7 @@
 import { CurrentPositions } from '@ghostfolio/api/app/portfolio/interfaces/current-positions.interface';
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/models/rules/fees/fee-ratio-initial-investment.ts

@@ -1,6 +1,6 @@
 import { RuleSettings } from '@ghostfolio/api/models/interfaces/rule-settings.interface';
 import { UserSettings } from '@ghostfolio/api/models/interfaces/user-settings.interface';
-import { ExchangeRateDataService } from '@ghostfolio/api/services/exchange-rate-data.service';
+import { ExchangeRateDataService } from 'apps/api/src/services/exchange-rate-data.service';
 
 import { Rule } from '../../rule';
 

apps/api/src/services/configuration.service.ts

@@ -12,10 +12,9 @@ export class ConfigurationService {
     this.environmentConfiguration = cleanEnv(process.env, {
       ACCESS_TOKEN_SALT: str(),
       ALPHA_VANTAGE_API_KEY: str({ default: '' }),
-      BASE_CURRENCY: str({ default: 'USD' }),
       CACHE_TTL: num({ default: 1 }),
       DATA_SOURCE_PRIMARY: str({ default: DataSource.YAHOO }),
-      DATA_SOURCES: json({ default: [DataSource.YAHOO] }),
+      DATA_SOURCES: json({ default: JSON.stringify([DataSource.YAHOO]) }),
       ENABLE_FEATURE_BLOG: bool({ default: false }),
       ENABLE_FEATURE_CUSTOM_SYMBOLS: bool({ default: false }),
       ENABLE_FEATURE_FEAR_AND_GREED_INDEX: bool({ default: false }),
@@ -25,20 +24,17 @@ export class ConfigurationService {
       ENABLE_FEATURE_STATISTICS: bool({ default: false }),
       ENABLE_FEATURE_SUBSCRIPTION: bool({ default: false }),
       ENABLE_FEATURE_SYSTEM_MESSAGE: bool({ default: false }),
-      EOD_HISTORICAL_DATA_API_KEY: str({ default: '' }),
       GOOGLE_CLIENT_ID: str({ default: 'dummyClientId' }),
       GOOGLE_SECRET: str({ default: 'dummySecret' }),
       GOOGLE_SHEETS_ACCOUNT: str({ default: '' }),
       GOOGLE_SHEETS_ID: str({ default: '' }),
       GOOGLE_SHEETS_PRIVATE_KEY: str({ default: '' }),
-      HOST: host({ default: '0.0.0.0' }),
       JWT_SECRET_KEY: str({}),
       MAX_ITEM_IN_CACHE: num({ default: 9999 }),
       MAX_ORDERS_TO_IMPORT: num({ default: Number.MAX_SAFE_INTEGER }),
       PORT: port({ default: 3333 }),
       RAKUTEN_RAPID_API_KEY: str({ default: '' }),
-      REDIS_HOST: host({ default: 'localhost' }),
+      REDIS_HOST: str({ default: 'localhost' }),
-      REDIS_PASSWORD: str({ default: '' }),
       REDIS_PORT: port({ default: 6379 }),
       ROOT_URL: str({ default: 'http://localhost:4200' }),
       STRIPE_PUBLIC_KEY: str({ default: '' }),

apps/api/src/services/cron.service.ts

@@ -1,7 +1,3 @@
-import {
-  GATHER_ASSET_PROFILE_PROCESS,
-  GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-} from '@ghostfolio/common/config';
 import { Injectable } from '@nestjs/common';
 import { Cron, CronExpression } from '@nestjs/schedule';
 
@@ -17,8 +13,8 @@ export class CronService {
     private readonly twitterBotService: TwitterBotService
   ) {}
 
-  @Cron(CronExpression.EVERY_HOUR)
+  @Cron(CronExpression.EVERY_MINUTE)
-  public async runEveryHour() {
+  public async runEveryMinute() {
     await this.dataGatheringService.gather7Days();
   }
 
@@ -34,17 +30,6 @@ export class CronService {
 
   @Cron(CronExpression.EVERY_WEEKEND)
   public async runEveryWeekend() {
-    const uniqueAssets = await this.dataGatheringService.getUniqueAssets();
+    await this.dataGatheringService.gatherProfileData();
-
-    for (const { dataSource, symbol } of uniqueAssets) {
-      await this.dataGatheringService.addJobToQueue(
-        GATHER_ASSET_PROFILE_PROCESS,
-        {
-          dataSource,
-          symbol
-        },
-        GATHER_ASSET_PROFILE_PROCESS_OPTIONS
-      );
-    }
   }
 }

apps/api/src/services/cryptocurrency/cryptocurrency.service.ts

@@ -1,7 +1,8 @@
 import { Injectable } from '@nestjs/common';
 
-const cryptocurrencies = require('../../assets/cryptocurrencies/cryptocurrencies.json');
+const cryptocurrencies = require('cryptocurrencies');
-const customCryptocurrencies = require('../../assets/cryptocurrencies/custom.json');
+
+const customCryptocurrencies = require('./custom-cryptocurrencies.json');
 
 @Injectable()
 export class CryptocurrencyService {
@@ -17,7 +18,7 @@ export class CryptocurrencyService {
   private getCryptocurrencies() {
     if (!this.combinedCryptocurrencies) {
       this.combinedCryptocurrencies = [
-        ...Object.keys(cryptocurrencies),
+        ...cryptocurrencies.symbols(),
         ...Object.keys(customCryptocurrencies)
       ];
     }

apps/api/src/services/cryptocurrency/custom-cryptocurrencies.json

@@ -0,0 +1,12 @@
+{
+  "1INCH": "1inch",
+  "ALGO": "Algorand",
+  "ATOM": "Cosmos",
+  "AVAX": "Avalanche",
+  "DOT": "Polkadot",
+  "MATIC": "Polygon",
+  "MINA": "Mina Protocol",
+  "SHIB": "Shiba Inu",
+  "SOL": "Solana",
+  "UNI3": "Uniswap"
+}

apps/api/src/services/data-gathering.module.ts

@@ -3,34 +3,21 @@ import { DataGatheringService } from '@ghostfolio/api/services/data-gathering.se
 import { DataEnhancerModule } from '@ghostfolio/api/services/data-provider/data-enhancer/data-enhancer.module';
 import { DataProviderModule } from '@ghostfolio/api/services/data-provider/data-provider.module';
 import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
-import { DATA_GATHERING_QUEUE } from '@ghostfolio/common/config';
-import { BullModule } from '@nestjs/bull';
 import { Module } from '@nestjs/common';
-import ms from 'ms';
 
-import { DataGatheringProcessor } from './data-gathering.processor';
 import { ExchangeRateDataModule } from './exchange-rate-data.module';
-import { MarketDataModule } from './market-data.module';
 import { SymbolProfileModule } from './symbol-profile.module';
 
 @Module({
   imports: [
-    BullModule.registerQueue({
-      limiter: {
-        duration: ms('5 seconds'),
-        max: 1
-      },
-      name: DATA_GATHERING_QUEUE
-    }),
     ConfigurationModule,
     DataEnhancerModule,
     DataProviderModule,
     ExchangeRateDataModule,
-    MarketDataModule,
     PrismaModule,
     SymbolProfileModule
   ],
-  providers: [DataGatheringProcessor, DataGatheringService],
+  providers: [DataGatheringService],
-  exports: [BullModule, DataEnhancerModule, DataGatheringService]
+  exports: [DataEnhancerModule, DataGatheringService]
 })
 export class DataGatheringModule {}

apps/api/src/services/data-gathering.processor.ts

@@ -1,128 +0,0 @@
-import {
-  DATA_GATHERING_QUEUE,
-  GATHER_ASSET_PROFILE_PROCESS,
-  GATHER_HISTORICAL_MARKET_DATA_PROCESS
-} from '@ghostfolio/common/config';
-import { DATE_FORMAT } from '@ghostfolio/common/helper';
-import { UniqueAsset } from '@ghostfolio/common/interfaces';
-import { Process, Processor } from '@nestjs/bull';
-import { Injectable, Logger } from '@nestjs/common';
-import { Job } from 'bull';
-import {
-  format,
-  getDate,
-  getMonth,
-  getYear,
-  isBefore,
-  parseISO
-} from 'date-fns';
-
-import { DataGatheringService } from './data-gathering.service';
-import { DataProviderService } from './data-provider/data-provider.service';
-import { IDataGatheringItem } from './interfaces/interfaces';
-import { PrismaService } from './prisma.service';
-
-@Injectable()
-@Processor(DATA_GATHERING_QUEUE)
-export class DataGatheringProcessor {
-  public constructor(
-    private readonly dataGatheringService: DataGatheringService,
-    private readonly dataProviderService: DataProviderService,
-    private readonly prismaService: PrismaService
-  ) {}
-
-  @Process(GATHER_ASSET_PROFILE_PROCESS)
-  public async gatherAssetProfile(job: Job<UniqueAsset>) {
-    try {
-      await this.dataGatheringService.gatherAssetProfiles([job.data]);
-    } catch (error) {
-      Logger.error(
-        error,
-        `DataGatheringProcessor (${GATHER_ASSET_PROFILE_PROCESS})`
-      );
-
-      throw new Error(error);
-    }
-  }
-
-  @Process(GATHER_HISTORICAL_MARKET_DATA_PROCESS)
-  public async gatherHistoricalMarketData(job: Job<IDataGatheringItem>) {
-    try {
-      const { dataSource, date, symbol } = job.data;
-
-      const historicalData = await this.dataProviderService.getHistoricalRaw(
-        [{ dataSource, symbol }],
-        parseISO(<string>(<unknown>date)),
-        new Date()
-      );
-
-      let currentDate = parseISO(<string>(<unknown>date));
-      let lastMarketPrice: number;
-
-      while (
-        isBefore(
-          currentDate,
-          new Date(
-            Date.UTC(
-              getYear(new Date()),
-              getMonth(new Date()),
-              getDate(new Date()),
-              0
-            )
-          )
-        )
-      ) {
-        if (
-          historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
-            ?.marketPrice
-        ) {
-          lastMarketPrice =
-            historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
-              ?.marketPrice;
-        }
-
-        if (lastMarketPrice) {
-          try {
-            await this.prismaService.marketData.create({
-              data: {
-                dataSource,
-                symbol,
-                date: new Date(
-                  Date.UTC(
-                    getYear(currentDate),
-                    getMonth(currentDate),
-                    getDate(currentDate),
-                    0
-                  )
-                ),
-                marketPrice: lastMarketPrice
-              }
-            });
-          } catch {}
-        }
-
-        // Count month one up for iteration
-        currentDate = new Date(
-          Date.UTC(
-            getYear(currentDate),
-            getMonth(currentDate),
-            getDate(currentDate) + 1,
-            0
-          )
-        );
-      }
-
-      Logger.log(
-        `Historical market data gathering has been completed for ${symbol} (${dataSource}).`,
-        `DataGatheringProcessor (${GATHER_HISTORICAL_MARKET_DATA_PROCESS})`
-      );
-    } catch (error) {
-      Logger.error(
-        error,
-        `DataGatheringProcessor (${GATHER_HISTORICAL_MARKET_DATA_PROCESS})`
-      );
-
-      throw new Error(error);
-    }
-  }
-}

apps/api/src/services/data-gathering.service.ts

@@ -1,72 +1,181 @@
 import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
 import {
-  DATA_GATHERING_QUEUE,
+  PROPERTY_LAST_DATA_GATHERING,
-  GATHER_HISTORICAL_MARKET_DATA_PROCESS,
+  PROPERTY_LOCKED_DATA_GATHERING
-  GATHER_HISTORICAL_MARKET_DATA_PROCESS_OPTIONS,
-  QUEUE_JOB_STATUS_LIST
 } from '@ghostfolio/common/config';
 import { DATE_FORMAT, resetHours } from '@ghostfolio/common/helper';
-import { UniqueAsset } from '@ghostfolio/common/interfaces';
-import { InjectQueue } from '@nestjs/bull';
 import { Inject, Injectable, Logger } from '@nestjs/common';
 import { DataSource } from '@prisma/client';
-import { JobOptions, Queue } from 'bull';
+import {
-import { format, subDays } from 'date-fns';
+  differenceInHours,
+  format,
+  getDate,
+  getMonth,
+  getYear,
+  isBefore,
+  subDays
+} from 'date-fns';
 
 import { DataProviderService } from './data-provider/data-provider.service';
 import { DataEnhancerInterface } from './data-provider/interfaces/data-enhancer.interface';
 import { ExchangeRateDataService } from './exchange-rate-data.service';
 import { IDataGatheringItem } from './interfaces/interfaces';
-import { MarketDataService } from './market-data.service';
 import { PrismaService } from './prisma.service';
 
 @Injectable()
 export class DataGatheringService {
+  private dataGatheringProgress: number;
+
   public constructor(
     @Inject('DataEnhancers')
     private readonly dataEnhancers: DataEnhancerInterface[],
-    @InjectQueue(DATA_GATHERING_QUEUE)
-    private readonly dataGatheringQueue: Queue,
     private readonly dataProviderService: DataProviderService,
     private readonly exchangeRateDataService: ExchangeRateDataService,
-    private readonly marketDataService: MarketDataService,
     private readonly prismaService: PrismaService,
     private readonly symbolProfileService: SymbolProfileService
   ) {}
 
-  public async addJobToQueue(name: string, data: any, options?: JobOptions) {
+  public async gather7Days() {
-    const hasJob = await this.hasJob(name, data);
+    const isDataGatheringNeeded = await this.isDataGatheringNeeded();
 
-    if (hasJob) {
+    if (isDataGatheringNeeded) {
-      Logger.log(
+      Logger.log('7d data gathering has been started.');
-        `Job ${name} with data ${JSON.stringify(data)} already exists.`,
+      console.time('data-gathering-7d');
-        'DataGatheringService'
+
-      );
+      await this.prismaService.property.create({
-    } else {
+        data: {
-      return this.dataGatheringQueue.add(name, data, options);
+          key: PROPERTY_LOCKED_DATA_GATHERING,
+          value: new Date().toISOString()
+        }
+      });
+
+      const symbols = await this.getSymbols7D();
+
+      try {
+        await this.gatherSymbols(symbols);
+
+        await this.prismaService.property.upsert({
+          create: {
+            key: PROPERTY_LAST_DATA_GATHERING,
+            value: new Date().toISOString()
+          },
+          update: { value: new Date().toISOString() },
+          where: { key: PROPERTY_LAST_DATA_GATHERING }
+        });
+      } catch (error) {
+        Logger.error(error);
+      }
+
+      await this.prismaService.property.delete({
+        where: {
+          key: PROPERTY_LOCKED_DATA_GATHERING
+        }
+      });
+
+      Logger.log('7d data gathering has been completed.');
+      console.timeEnd('data-gathering-7d');
     }
   }
 
-  public async gather7Days() {
-    const dataGatheringItems = await this.getSymbols7D();
-    await this.gatherSymbols(dataGatheringItems);
-  }
-
   public async gatherMax() {
-    const dataGatheringItems = await this.getSymbolsMax();
+    const isDataGatheringLocked = await this.prismaService.property.findUnique({
-    await this.gatherSymbols(dataGatheringItems);
+      where: { key: PROPERTY_LOCKED_DATA_GATHERING }
+    });
+
+    if (!isDataGatheringLocked) {
+      Logger.log('Max data gathering has been started.');
+      console.time('data-gathering-max');
+
+      await this.prismaService.property.create({
+        data: {
+          key: PROPERTY_LOCKED_DATA_GATHERING,
+          value: new Date().toISOString()
+        }
+      });
+
+      const symbols = await this.getSymbolsMax();
+
+      try {
+        await this.gatherSymbols(symbols);
+
+        await this.prismaService.property.upsert({
+          create: {
+            key: PROPERTY_LAST_DATA_GATHERING,
+            value: new Date().toISOString()
+          },
+          update: { value: new Date().toISOString() },
+          where: { key: PROPERTY_LAST_DATA_GATHERING }
+        });
+      } catch (error) {
+        Logger.error(error);
+      }
+
+      await this.prismaService.property.delete({
+        where: {
+          key: PROPERTY_LOCKED_DATA_GATHERING
+        }
+      });
+
+      Logger.log('Max data gathering has been completed.');
+      console.timeEnd('data-gathering-max');
+    }
   }
 
-  public async gatherSymbol({ dataSource, symbol }: UniqueAsset) {
+  public async gatherSymbol({
-    await this.marketDataService.deleteMany({ dataSource, symbol });
+    dataSource,
-
+    symbol
-    const symbols = (await this.getSymbolsMax()).filter((dataGatheringItem) => {
+  }: {
-      return (
+    dataSource: DataSource;
-        dataGatheringItem.dataSource === dataSource &&
+    symbol: string;
-        dataGatheringItem.symbol === symbol
+  }) {
-      );
+    const isDataGatheringLocked = await this.prismaService.property.findUnique({
+      where: { key: PROPERTY_LOCKED_DATA_GATHERING }
     });
-    await this.gatherSymbols(symbols);
+
+    if (!isDataGatheringLocked) {
+      Logger.log(`Symbol data gathering for ${symbol} has been started.`);
+      console.time('data-gathering-symbol');
+
+      await this.prismaService.property.create({
+        data: {
+          key: PROPERTY_LOCKED_DATA_GATHERING,
+          value: new Date().toISOString()
+        }
+      });
+
+      const symbols = (await this.getSymbolsMax()).filter(
+        (dataGatheringItem) => {
+          return (
+            dataGatheringItem.dataSource === dataSource &&
+            dataGatheringItem.symbol === symbol
+          );
+        }
+      );
+
+      try {
+        await this.gatherSymbols(symbols);
+
+        await this.prismaService.property.upsert({
+          create: {
+            key: PROPERTY_LAST_DATA_GATHERING,
+            value: new Date().toISOString()
+          },
+          update: { value: new Date().toISOString() },
+          where: { key: PROPERTY_LAST_DATA_GATHERING }
+        });
+      } catch (error) {
+        Logger.error(error);
+      }
+
+      await this.prismaService.property.delete({
+        where: {
+          key: PROPERTY_LOCKED_DATA_GATHERING
+        }
+      });
+
+      Logger.log(`Symbol data gathering for ${symbol} has been completed.`);
+      console.timeEnd('data-gathering-symbol');
+    }
   }
 
   public async gatherSymbolForDate({
@@ -101,48 +210,42 @@ export class DataGatheringService {
         });
       }
     } catch (error) {
-      Logger.error(error, 'DataGatheringService');
+      Logger.error(error);
     } finally {
       return undefined;
     }
   }
 
-  public async gatherAssetProfiles(aUniqueAssets?: UniqueAsset[]) {
+  public async gatherProfileData(aDataGatheringItems?: IDataGatheringItem[]) {
-    let uniqueAssets = aUniqueAssets?.filter((dataGatheringItem) => {
+    Logger.log('Profile data gathering has been started.');
-      return dataGatheringItem.dataSource !== 'MANUAL';
+    console.time('data-gathering-profile');
-    });
 
-    if (!uniqueAssets) {
+    let dataGatheringItems = aDataGatheringItems;
-      uniqueAssets = await this.getUniqueAssets();
+
+    if (!dataGatheringItems) {
+      dataGatheringItems = await this.getSymbolsProfileData();
     }
 
-    const assetProfiles = await this.dataProviderService.getAssetProfiles(
+    const currentData = await this.dataProviderService.get(dataGatheringItems);
-      uniqueAssets
+    const symbolProfiles = await this.symbolProfileService.getSymbolProfiles(
+      dataGatheringItems.map(({ symbol }) => {
+        return symbol;
+      })
     );
-    const symbolProfiles =
-      await this.symbolProfileService.getSymbolProfilesBySymbols(
-        uniqueAssets.map(({ symbol }) => {
-          return symbol;
-        })
-      );
 
-    for (const [symbol, assetProfile] of Object.entries(assetProfiles)) {
+    for (const [symbol, response] of Object.entries(currentData)) {
       const symbolMapping = symbolProfiles.find((symbolProfile) => {
         return symbolProfile.symbol === symbol;
       })?.symbolMapping;
 
       for (const dataEnhancer of this.dataEnhancers) {
         try {
-          assetProfiles[symbol] = await dataEnhancer.enhance({
+          currentData[symbol] = await dataEnhancer.enhance({
-            response: assetProfile,
+            response,
             symbol: symbolMapping?.[dataEnhancer.getName()] ?? symbol
           });
         } catch (error) {
-          Logger.error(
+          Logger.error(`Failed to enhance data for symbol ${symbol}`, error);
-            `Failed to enhance data for symbol ${symbol} by ${dataEnhancer.getName()}`,
-            error,
-            'DataGatheringService'
-          );
         }
       }
 
@@ -153,9 +256,8 @@ export class DataGatheringService {
         currency,
         dataSource,
         name,
-        sectors,
+        sectors
-        url
+      } = currentData[symbol];
-      } = assetProfiles[symbol];
 
       try {
         await this.prismaService.symbolProfile.upsert({
@@ -167,8 +269,7 @@ export class DataGatheringService {
             dataSource,
             name,
             sectors,
-            symbol,
+            symbol
-            url
           },
           update: {
             assetClass,
@@ -176,8 +277,7 @@ export class DataGatheringService {
             countries,
             currency,
             name,
-            sectors,
+            sectors
-            url
           },
           where: {
             dataSource_symbol: {
@@ -187,40 +287,132 @@ export class DataGatheringService {
           }
         });
       } catch (error) {
-        Logger.error(
+        Logger.error(`${symbol}: ${error?.meta?.cause}`);
-          `${symbol}: ${error?.meta?.cause}`,
-          error,
-          'DataGatheringService'
-        );
       }
     }
 
-    Logger.log(
+    Logger.log('Profile data gathering has been completed.');
-      `Asset profile data gathering has been completed for ${uniqueAssets
+    console.timeEnd('data-gathering-profile');
-        .map(({ dataSource, symbol }) => {
-          return `${symbol} (${dataSource})`;
-        })
-        .join(',')}.`,
-      'DataGatheringService'
-    );
   }
 
   public async gatherSymbols(aSymbolsWithStartDate: IDataGatheringItem[]) {
+    let hasError = false;
+    let symbolCounter = 0;
+
     for (const { dataSource, date, symbol } of aSymbolsWithStartDate) {
-      if (dataSource === 'MANUAL') {
+      this.dataGatheringProgress = symbolCounter / aSymbolsWithStartDate.length;
-        continue;
+
+      try {
+        const historicalData = await this.dataProviderService.getHistoricalRaw(
+          [{ dataSource, symbol }],
+          date,
+          new Date()
+        );
+
+        let currentDate = date;
+        let lastMarketPrice: number;
+
+        while (
+          isBefore(
+            currentDate,
+            new Date(
+              Date.UTC(
+                getYear(new Date()),
+                getMonth(new Date()),
+                getDate(new Date()),
+                0
+              )
+            )
+          )
+        ) {
+          if (
+            historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
+              ?.marketPrice
+          ) {
+            lastMarketPrice =
+              historicalData[symbol]?.[format(currentDate, DATE_FORMAT)]
+                ?.marketPrice;
+          }
+
+          if (lastMarketPrice) {
+            try {
+              await this.prismaService.marketData.create({
+                data: {
+                  dataSource,
+                  symbol,
+                  date: currentDate,
+                  marketPrice: lastMarketPrice
+                }
+              });
+            } catch {}
+          } else {
+            Logger.warn(
+              `Failed to gather data for symbol ${symbol} at ${format(
+                currentDate,
+                DATE_FORMAT
+              )}.`
+            );
+          }
+
+          // Count month one up for iteration
+          currentDate = new Date(
+            Date.UTC(
+              getYear(currentDate),
+              getMonth(currentDate),
+              getDate(currentDate) + 1,
+              0
+            )
+          );
+        }
+      } catch (error) {
+        hasError = true;
+        Logger.error(error);
       }
 
-      await this.addJobToQueue(
+      if (symbolCounter > 0 && symbolCounter % 100 === 0) {
-        GATHER_HISTORICAL_MARKET_DATA_PROCESS,
+        Logger.log(
-        {
+          `Data gathering progress: ${(
-          dataSource,
+            this.dataGatheringProgress * 100
-          date,
+          ).toFixed(2)}%`
-          symbol
+        );
-        },
+      }
-        GATHER_HISTORICAL_MARKET_DATA_PROCESS_OPTIONS
+
-      );
+      symbolCounter += 1;
     }
+
+    await this.exchangeRateDataService.initialize();
+
+    if (hasError) {
+      throw '';
+    }
+  }
+
+  public async getDataGatheringProgress() {
+    const isInProgress = await this.getIsInProgress();
+
+    if (isInProgress) {
+      return this.dataGatheringProgress;
+    }
+
+    return undefined;
+  }
+
+  public async getIsInProgress() {
+    return await this.prismaService.property.findUnique({
+      where: { key: PROPERTY_LOCKED_DATA_GATHERING }
+    });
+  }
+
+  public async getLastDataGathering() {
+    const lastDataGathering = await this.prismaService.property.findUnique({
+      where: { key: PROPERTY_LAST_DATA_GATHERING }
+    });
+
+    if (lastDataGathering?.value) {
+      return new Date(lastDataGathering.value);
+    }
+
+    return undefined;
   }
 
   public async getSymbolsMax(): Promise<IDataGatheringItem[]> {
@@ -270,25 +462,17 @@ export class DataGatheringService {
     return [...currencyPairsToGather, ...symbolProfilesToGather];
   }
 
-  public async getUniqueAssets(): Promise<UniqueAsset[]> {
+  public async reset() {
-    const symbolProfiles = await this.prismaService.symbolProfile.findMany({
+    Logger.log('Data gathering has been reset.');
-      orderBy: [{ symbol: 'asc' }]
-    });
 
-    return symbolProfiles
+    await this.prismaService.property.deleteMany({
-      .filter(({ dataSource }) => {
+      where: {
-        return (
+        OR: [
-          dataSource !== DataSource.GHOSTFOLIO &&
+          { key: PROPERTY_LAST_DATA_GATHERING },
-          dataSource !== DataSource.MANUAL &&
+          { key: PROPERTY_LOCKED_DATA_GATHERING }
-          dataSource !== DataSource.RAKUTEN
+        ]
-        );
+      }
-      })
+    });
-      .map(({ dataSource, symbol }) => {
-        return {
-          dataSource,
-          symbol
-        };
-      });
   }
 
   private async getSymbols7D(): Promise<IDataGatheringItem[]> {
@@ -314,7 +498,6 @@ export class DataGatheringService {
       await this.prismaService.marketData.groupBy({
         _count: true,
         by: ['symbol'],
-        orderBy: [{ symbol: 'asc' }],
         where: {
           date: { gt: startDate }
         }
@@ -354,17 +537,31 @@ export class DataGatheringService {
     return [...currencyPairsToGather, ...symbolProfilesToGather];
   }
 
-  private async hasJob(name: string, data: any) {
+  private async getSymbolsProfileData(): Promise<IDataGatheringItem[]> {
-    const jobs = await this.dataGatheringQueue.getJobs(
+    const distinctOrders = await this.prismaService.order.findMany({
-      QUEUE_JOB_STATUS_LIST.filter((status) => {
+      distinct: ['symbol'],
-        return status !== 'completed';
+      orderBy: [{ symbol: 'asc' }],
-      })
+      select: { dataSource: true, symbol: true }
-    );
+    });
 
-    return jobs.some((job) => {
+    return distinctOrders.filter((distinctOrder) => {
       return (
-        job.name === name && JSON.stringify(job.data) === JSON.stringify(data)
+        distinctOrder.dataSource !== DataSource.GHOSTFOLIO &&
+        distinctOrder.dataSource !== DataSource.MANUAL &&
+        distinctOrder.dataSource !== DataSource.RAKUTEN
       );
     });
   }
+
+  private async isDataGatheringNeeded() {
+    const lastDataGathering = await this.getLastDataGathering();
+
+    const isDataGatheringLocked = await this.prismaService.property.findUnique({
+      where: { key: PROPERTY_LOCKED_DATA_GATHERING }
+    });
+
+    const diffInHours = differenceInHours(new Date(), lastDataGathering);
+
+    return (diffInHours >= 1 || !lastDataGathering) && !isDataGatheringLocked;
+  }
 }

apps/api/src/services/data-provider/alpha-vantage/alpha-vantage.service.ts

@@ -1,16 +1,16 @@
 import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
 import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataProviderInterface } from '@ghostfolio/api/services/data-provider/interfaces/data-provider.interface';
-import {
-  IDataProviderHistoricalResponse,
-  IDataProviderResponse
-} from '@ghostfolio/api/services/interfaces/interfaces';
 import { DATE_FORMAT } from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Injectable, Logger } from '@nestjs/common';
-import { DataSource, SymbolProfile } from '@prisma/client';
+import { DataSource } from '@prisma/client';
-import { format, isAfter, isBefore, parse } from 'date-fns';
+import { isAfter, isBefore, parse } from 'date-fns';
 
+import {
+  IDataProviderHistoricalResponse,
+  IDataProviderResponse
+} from '../../interfaces/interfaces';
+import { DataProviderInterface } from '../interfaces/data-provider.interface';
 import { IAlphaVantageHistoricalResponse } from './interfaces/interfaces';
 
 @Injectable()
@@ -29,23 +29,25 @@ export class AlphaVantageService implements DataProviderInterface {
     return !!this.configurationService.get('ALPHA_VANTAGE_API_KEY');
   }
 
-  public async getAssetProfile(
+  public async get(
-    aSymbol: string
+    aSymbols: string[]
-  ): Promise<Partial<SymbolProfile>> {
+  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    return {
+    return {};
-      dataSource: this.getName()
-    };
   }
 
   public async getHistorical(
-    aSymbol: string,
+    aSymbols: string[],
     aGranularity: Granularity = 'day',
     from: Date,
     to: Date
   ): Promise<{
     [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
   }> {
-    const symbol = aSymbol;
+    if (aSymbols.length <= 0) {
+      return {};
+    }
+
+    const symbol = aSymbols[0];
 
     try {
       const historicalData: {
@@ -76,12 +78,9 @@ export class AlphaVantageService implements DataProviderInterface {
 
       return response;
     } catch (error) {
-      throw new Error(
+      Logger.error(error, symbol);
-        `Could not get historical market data for ${aSymbol} (${this.getName()}) from ${format(
+
-          from,
+      return {};
-          DATE_FORMAT
-        )} to ${format(to, DATE_FORMAT)}: [${error.name}] ${error.message}`
-      );
     }
   }
 
@@ -89,12 +88,6 @@ export class AlphaVantageService implements DataProviderInterface {
     return DataSource.ALPHA_VANTAGE;
   }
 
-  public async getQuotes(
-    aSymbols: string[]
-  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    return {};
-  }
-
   public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
     const result = await this.alphaVantage.data.search(aQuery);
 

apps/api/src/services/data-provider/data-enhancer/trackinsight/trackinsight.service.ts

@@ -1,7 +1,5 @@
 import { DataEnhancerInterface } from '@ghostfolio/api/services/data-provider/interfaces/data-enhancer.interface';
-import { Country } from '@ghostfolio/common/interfaces/country.interface';
+import { IDataProviderResponse } from '@ghostfolio/api/services/interfaces/interfaces';
-import { Sector } from '@ghostfolio/common/interfaces/sector.interface';
-import { SymbolProfile } from '@prisma/client';
 import bent from 'bent';
 
 const getJSON = bent('json');
@@ -23,16 +21,16 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
     response,
     symbol
   }: {
-    response: Partial<SymbolProfile>;
+    response: IDataProviderResponse;
     symbol: string;
-  }): Promise<Partial<SymbolProfile>> {
+  }): Promise<IDataProviderResponse> {
     if (
       !(response.assetClass === 'EQUITY' && response.assetSubClass === 'ETF')
     ) {
       return response;
     }
 
-    const result = await getJSON(
+    const holdings = await getJSON(
       `${TrackinsightDataEnhancerService.baseUrl}/${symbol}.json`
     ).catch(() => {
       return getJSON(
@@ -42,17 +40,9 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
       );
     });
 
-    if (result.weight < 0.95) {
+    if (!response.countries || response.countries.length === 0) {
-      // Skip if data is inaccurate
-      return response;
-    }
-
-    if (
-      !response.countries ||
-      (response.countries as unknown as Country[]).length === 0
-    ) {
       response.countries = [];
-      for (const [name, value] of Object.entries<any>(result.countries)) {
+      for (const [name, value] of Object.entries<any>(holdings.countries)) {
         let countryCode: string;
 
         for (const [key, country] of Object.entries<any>(
@@ -75,12 +65,9 @@ export class TrackinsightDataEnhancerService implements DataEnhancerInterface {
       }
     }
 
-    if (
+    if (!response.sectors || response.sectors.length === 0) {
-      !response.sectors ||
-      (response.sectors as unknown as Sector[]).length === 0
-    ) {
       response.sectors = [];
-      for (const [name, value] of Object.entries<any>(result.sectors)) {
+      for (const [name, value] of Object.entries<any>(holdings.sectors)) {
         response.sectors.push({
           name: TrackinsightDataEnhancerService.sectorsMapping[name] ?? name,
           weight: value.weight

apps/api/src/services/data-provider/data-provider.module.ts

@@ -1,7 +1,5 @@
 import { ConfigurationModule } from '@ghostfolio/api/services/configuration.module';
 import { CryptocurrencyModule } from '@ghostfolio/api/services/cryptocurrency/cryptocurrency.module';
-import { AlphaVantageService } from '@ghostfolio/api/services/data-provider/alpha-vantage/alpha-vantage.service';
-import { EodHistoricalDataService } from '@ghostfolio/api/services/data-provider/eod-historical-data/eod-historical-data.service';
 import { GhostfolioScraperApiService } from '@ghostfolio/api/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service';
 import { GoogleSheetsService } from '@ghostfolio/api/services/data-provider/google-sheets/google-sheets.service';
 import { ManualService } from '@ghostfolio/api/services/data-provider/manual/manual.service';
@@ -11,6 +9,7 @@ import { PrismaModule } from '@ghostfolio/api/services/prisma.module';
 import { SymbolProfileModule } from '@ghostfolio/api/services/symbol-profile.module';
 import { Module } from '@nestjs/common';
 
+import { AlphaVantageService } from './alpha-vantage/alpha-vantage.service';
 import { DataProviderService } from './data-provider.service';
 
 @Module({
@@ -23,7 +22,6 @@ import { DataProviderService } from './data-provider.service';
   providers: [
     AlphaVantageService,
     DataProviderService,
-    EodHistoricalDataService,
     GhostfolioScraperApiService,
     GoogleSheetsService,
     ManualService,
@@ -32,7 +30,6 @@ import { DataProviderService } from './data-provider.service';
     {
       inject: [
         AlphaVantageService,
-        EodHistoricalDataService,
         GhostfolioScraperApiService,
         GoogleSheetsService,
         ManualService,
@@ -42,7 +39,6 @@ import { DataProviderService } from './data-provider.service';
       provide: 'DataProviderInterfaces',
       useFactory: (
         alphaVantageService,
-        eodHistoricalDataService,
         ghostfolioScraperApiService,
         googleSheetsService,
         manualService,
@@ -50,7 +46,6 @@ import { DataProviderService } from './data-provider.service';
         yahooFinanceService
       ) => [
         alphaVantageService,
-        eodHistoricalDataService,
         ghostfolioScraperApiService,
         googleSheetsService,
         manualService,

apps/api/src/services/data-provider/data-provider.service.ts

@@ -10,7 +10,7 @@ import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { DATE_FORMAT } from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Inject, Injectable, Logger } from '@nestjs/common';
-import { DataSource, MarketData, SymbolProfile } from '@prisma/client';
+import { DataSource, MarketData } from '@prisma/client';
 import { format, isValid } from 'date-fns';
 import { groupBy, isEmpty } from 'lodash';
 
@@ -23,6 +23,42 @@ export class DataProviderService {
     private readonly prismaService: PrismaService
   ) {}
 
+  public async get(items: IDataGatheringItem[]): Promise<{
+    [symbol: string]: IDataProviderResponse;
+  }> {
+    const response: {
+      [symbol: string]: IDataProviderResponse;
+    } = {};
+
+    const itemsGroupedByDataSource = groupBy(items, (item) => item.dataSource);
+
+    const promises = [];
+
+    for (const [dataSource, dataGatheringItems] of Object.entries(
+      itemsGroupedByDataSource
+    )) {
+      const symbols = dataGatheringItems.map((dataGatheringItem) => {
+        return dataGatheringItem.symbol;
+      });
+
+      const promise = Promise.resolve(
+        this.getDataProvider(DataSource[dataSource]).get(symbols)
+      );
+
+      promises.push(
+        promise.then((result) => {
+          for (const [symbol, dataProviderResponse] of Object.entries(result)) {
+            response[symbol] = dataProviderResponse;
+          }
+        })
+      );
+    }
+
+    await Promise.all(promises);
+
+    return response;
+  }
+
   public async getHistorical(
     aItems: IDataGatheringItem[],
     aGranularity: Granularity = 'month',
@@ -82,7 +118,7 @@ export class DataProviderService {
         return r;
       }, {});
     } catch (error) {
-      Logger.error(error, 'DataProviderService');
+      Logger.error(error);
     } finally {
       return response;
     }
@@ -108,7 +144,7 @@ export class DataProviderService {
       if (dataProvider.canHandle(symbol)) {
         promises.push(
           dataProvider
-            .getHistorical(symbol, undefined, from, to)
+            .getHistorical([symbol], undefined, from, to)
             .then((data) => ({ data: data?.[symbol], symbol }))
         );
       }
@@ -122,82 +158,6 @@ export class DataProviderService {
     return result;
   }
 
-  public getPrimaryDataSource(): DataSource {
-    return DataSource[this.configurationService.get('DATA_SOURCE_PRIMARY')];
-  }
-
-  public async getAssetProfiles(items: IDataGatheringItem[]): Promise<{
-    [symbol: string]: Partial<SymbolProfile>;
-  }> {
-    const response: {
-      [symbol: string]: Partial<SymbolProfile>;
-    } = {};
-
-    const itemsGroupedByDataSource = groupBy(items, (item) => item.dataSource);
-
-    const promises = [];
-
-    for (const [dataSource, dataGatheringItems] of Object.entries(
-      itemsGroupedByDataSource
-    )) {
-      const symbols = dataGatheringItems.map((dataGatheringItem) => {
-        return dataGatheringItem.symbol;
-      });
-
-      for (const symbol of symbols) {
-        const promise = Promise.resolve(
-          this.getDataProvider(DataSource[dataSource]).getAssetProfile(symbol)
-        );
-
-        promises.push(
-          promise.then((symbolProfile) => {
-            response[symbol] = symbolProfile;
-          })
-        );
-      }
-    }
-
-    await Promise.all(promises);
-
-    return response;
-  }
-
-  public async getQuotes(items: IDataGatheringItem[]): Promise<{
-    [symbol: string]: IDataProviderResponse;
-  }> {
-    const response: {
-      [symbol: string]: IDataProviderResponse;
-    } = {};
-
-    const itemsGroupedByDataSource = groupBy(items, (item) => item.dataSource);
-
-    const promises = [];
-
-    for (const [dataSource, dataGatheringItems] of Object.entries(
-      itemsGroupedByDataSource
-    )) {
-      const symbols = dataGatheringItems.map((dataGatheringItem) => {
-        return dataGatheringItem.symbol;
-      });
-
-      const promise = Promise.resolve(
-        this.getDataProvider(DataSource[dataSource]).getQuotes(symbols)
-      );
-
-      promises.push(
-        promise.then((result) => {
-          for (const [symbol, dataProviderResponse] of Object.entries(result)) {
-            response[symbol] = dataProviderResponse;
-          }
-        })
-      );
-    }
-
-    await Promise.all(promises);
-
-    return response;
-  }
-
   public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
     const promises: Promise<{ items: LookupItem[] }>[] = [];
     let lookupItems: LookupItem[] = [];
@@ -224,6 +184,10 @@ export class DataProviderService {
     };
   }
 
+  public getPrimaryDataSource(): DataSource {
+    return DataSource[this.configurationService.get('DATA_SOURCE_PRIMARY')];
+  }
+
   private getDataProvider(providerName: DataSource) {
     for (const dataProviderInterface of this.dataProviderInterfaces) {
       if (dataProviderInterface.getName() === providerName) {

apps/api/src/services/data-provider/eod-historical-data/eod-historical-data.service.ts

@@ -1,141 +0,0 @@
-import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.interface';
-import { ConfigurationService } from '@ghostfolio/api/services/configuration.service';
-import { DataProviderInterface } from '@ghostfolio/api/services/data-provider/interfaces/data-provider.interface';
-import {
-  IDataProviderHistoricalResponse,
-  IDataProviderResponse
-} from '@ghostfolio/api/services/interfaces/interfaces';
-import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
-import { DATE_FORMAT } from '@ghostfolio/common/helper';
-import { Granularity } from '@ghostfolio/common/types';
-import { Injectable, Logger } from '@nestjs/common';
-import { DataSource, SymbolProfile } from '@prisma/client';
-import bent from 'bent';
-import { format } from 'date-fns';
-
-@Injectable()
-export class EodHistoricalDataService implements DataProviderInterface {
-  private apiKey: string;
-  private readonly URL = 'https://eodhistoricaldata.com/api';
-
-  public constructor(
-    private readonly configurationService: ConfigurationService,
-    private readonly symbolProfileService: SymbolProfileService
-  ) {
-    this.apiKey = this.configurationService.get('EOD_HISTORICAL_DATA_API_KEY');
-  }
-
-  public canHandle(symbol: string) {
-    return true;
-  }
-
-  public async getAssetProfile(
-    aSymbol: string
-  ): Promise<Partial<SymbolProfile>> {
-    return {
-      dataSource: this.getName()
-    };
-  }
-
-  public async getHistorical(
-    aSymbol: string,
-    aGranularity: Granularity = 'day',
-    from: Date,
-    to: Date
-  ): Promise<{
-    [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
-  }> {
-    try {
-      const get = bent(
-        `${this.URL}/eod/${aSymbol}?api_token=${
-          this.apiKey
-        }&fmt=json&from=${format(from, DATE_FORMAT)}&to=${format(
-          to,
-          DATE_FORMAT
-        )}&period={aGranularity}`,
-        'GET',
-        'json',
-        200
-      );
-
-      const response = await get();
-
-      return response.reduce(
-        (result, historicalItem, index, array) => {
-          result[aSymbol][historicalItem.date] = {
-            marketPrice: historicalItem.close,
-            performance: historicalItem.open - historicalItem.close
-          };
-
-          return result;
-        },
-        { [aSymbol]: {} }
-      );
-    } catch (error) {
-      throw new Error(
-        `Could not get historical market data for ${aSymbol} (${this.getName()}) from ${format(
-          from,
-          DATE_FORMAT
-        )} to ${format(to, DATE_FORMAT)}: [${error.name}] ${error.message}`
-      );
-    }
-  }
-
-  public getName(): DataSource {
-    return DataSource.EOD_HISTORICAL_DATA;
-  }
-
-  public async getQuotes(
-    aSymbols: string[]
-  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    if (aSymbols.length <= 0) {
-      return {};
-    }
-
-    try {
-      const get = bent(
-        `${this.URL}/real-time/${aSymbols[0]}?api_token=${
-          this.apiKey
-        }&fmt=json&s=${aSymbols.join(',')}`,
-        'GET',
-        'json',
-        200
-      );
-
-      const [response, symbolProfiles] = await Promise.all([
-        get(),
-        this.symbolProfileService.getSymbolProfiles(
-          aSymbols.map((symbol) => {
-            return {
-              symbol,
-              dataSource: DataSource.EOD_HISTORICAL_DATA
-            };
-          })
-        )
-      ]);
-
-      const quotes = aSymbols.length === 1 ? [response] : response;
-
-      return quotes.reduce((result, item, index, array) => {
-        result[item.code] = {
-          currency: symbolProfiles.find((symbolProfile) => {
-            return symbolProfile.symbol === item.code;
-          })?.currency,
-          dataSource: DataSource.EOD_HISTORICAL_DATA,
-          marketPrice: item.close,
-          marketState: 'delayed'
-        };
-
-        return result;
-      }, {});
-    } catch (error) {
-      Logger.error(error, 'EodHistoricalDataService');
-    }
-
-    return {};
-  }
-
-  public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
-    return { items: [] };
-  }
-}

apps/api/src/services/data-provider/ghostfolio-scraper-api/ghostfolio-scraper-api.service.ts

@@ -2,17 +2,22 @@ import { LookupItem } from '@ghostfolio/api/app/symbol/interfaces/lookup-item.in
 import { DataProviderInterface } from '@ghostfolio/api/services/data-provider/interfaces/data-provider.interface';
 import {
   IDataProviderHistoricalResponse,
-  IDataProviderResponse
+  IDataProviderResponse,
+  MarketState
 } from '@ghostfolio/api/services/interfaces/interfaces';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
-import { DATE_FORMAT, getYesterday } from '@ghostfolio/common/helper';
+import {
+  DATE_FORMAT,
+  getYesterday,
+  isGhostfolioScraperApiSymbol
+} from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Injectable, Logger } from '@nestjs/common';
-import { DataSource, SymbolProfile } from '@prisma/client';
+import { DataSource } from '@prisma/client';
-import bent from 'bent';
+import * as bent from 'bent';
 import * as cheerio from 'cheerio';
-import { addDays, format, isBefore } from 'date-fns';
+import { format } from 'date-fns';
 
 @Injectable()
 export class GhostfolioScraperApiService implements DataProviderInterface {
@@ -24,60 +29,73 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
   ) {}
 
   public canHandle(symbol: string) {
-    return true;
+    return isGhostfolioScraperApiSymbol(symbol);
   }
 
-  public async getAssetProfile(
+  public async get(
-    aSymbol: string
+    aSymbols: string[]
-  ): Promise<Partial<SymbolProfile>> {
+  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    return {
+    if (aSymbols.length <= 0) {
-      dataSource: this.getName()
+      return {};
-    };
+    }
+
+    try {
+      const [symbol] = aSymbols;
+      const [symbolProfile] = await this.symbolProfileService.getSymbolProfiles(
+        [symbol]
+      );
+
+      const { marketPrice } = await this.prismaService.marketData.findFirst({
+        orderBy: {
+          date: 'desc'
+        },
+        where: {
+          symbol
+        }
+      });
+
+      return {
+        [symbol]: {
+          marketPrice,
+          currency: symbolProfile?.currency,
+          dataSource: this.getName(),
+          marketState: MarketState.delayed
+        }
+      };
+    } catch (error) {
+      Logger.error(error);
+    }
+
+    return {};
   }
 
   public async getHistorical(
-    aSymbol: string,
+    aSymbols: string[],
     aGranularity: Granularity = 'day',
     from: Date,
     to: Date
   ): Promise<{
     [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
   }> {
+    if (aSymbols.length <= 0) {
+      return {};
+    }
+
     try {
-      const symbol = aSymbol;
+      const [symbol] = aSymbols;
+      const [symbolProfile] = await this.symbolProfileService.getSymbolProfiles(
+        [symbol]
+      );
+      const scraperConfiguration = symbolProfile?.scraperConfiguration;
 
-      const [symbolProfile] =
+      const get = bent(scraperConfiguration?.url, 'GET', 'string', 200, {});
-        await this.symbolProfileService.getSymbolProfilesBySymbols([symbol]);
-      const { defaultMarketPrice, selector, url } =
-        symbolProfile.scraperConfiguration;
-
-      if (defaultMarketPrice) {
-        const historical: {
-          [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
-        } = {
-          [symbol]: {}
-        };
-        let date = from;
-
-        while (isBefore(date, to)) {
-          historical[symbol][format(date, DATE_FORMAT)] = {
-            marketPrice: defaultMarketPrice
-          };
-
-          date = addDays(date, 1);
-        }
-
-        return historical;
-      } else if (selector === undefined || url === undefined) {
-        return {};
-      }
-
-      const get = bent(url, 'GET', 'string', 200, {});
 
       const html = await get();
       const $ = cheerio.load(html);
 
-      const value = this.extractNumberFromString($(selector).text());
+      const value = this.extractNumberFromString(
+        $(scraperConfiguration?.selector).text()
+      );
 
       return {
         [symbol]: {
@@ -87,64 +105,16 @@ export class GhostfolioScraperApiService implements DataProviderInterface {
         }
       };
     } catch (error) {
-      throw new Error(
+      Logger.error(error);
-        `Could not get historical market data for ${aSymbol} (${this.getName()}) from ${format(
-          from,
-          DATE_FORMAT
-        )} to ${format(to, DATE_FORMAT)}: [${error.name}] ${error.message}`
-      );
     }
+
+    return {};
   }
 
   public getName(): DataSource {
     return DataSource.GHOSTFOLIO;
   }
 
-  public async getQuotes(
-    aSymbols: string[]
-  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    const response: { [symbol: string]: IDataProviderResponse } = {};
-
-    if (aSymbols.length <= 0) {
-      return response;
-    }
-
-    try {
-      const symbolProfiles =
-        await this.symbolProfileService.getSymbolProfilesBySymbols(aSymbols);
-
-      const marketData = await this.prismaService.marketData.findMany({
-        distinct: ['symbol'],
-        orderBy: {
-          date: 'desc'
-        },
-        take: aSymbols.length,
-        where: {
-          symbol: {
-            in: aSymbols
-          }
-        }
-      });
-
-      for (const symbolProfile of symbolProfiles) {
-        response[symbolProfile.symbol] = {
-          currency: symbolProfile.currency,
-          dataSource: this.getName(),
-          marketPrice: marketData.find((marketDataItem) => {
-            return marketDataItem.symbol === symbolProfile.symbol;
-          }).marketPrice,
-          marketState: 'delayed'
-        };
-      }
-
-      return response;
-    } catch (error) {
-      Logger.error(error, 'GhostfolioScraperApiService');
-    }
-
-    return {};
-  }
-
   public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
     const items = await this.prismaService.symbolProfile.findMany({
       select: {

apps/api/src/services/data-provider/ghostfolio-scraper-api/interfaces/scraper-configuration.interface.ts

@@ -1,5 +1,4 @@
 export interface ScraperConfiguration {
-  defaultMarketPrice?: number;
   selector: string;
   url: string;
 }

apps/api/src/services/data-provider/google-sheets/google-sheets.service.ts

@@ -3,14 +3,15 @@ import { ConfigurationService } from '@ghostfolio/api/services/configuration.ser
 import { DataProviderInterface } from '@ghostfolio/api/services/data-provider/interfaces/data-provider.interface';
 import {
   IDataProviderHistoricalResponse,
-  IDataProviderResponse
+  IDataProviderResponse,
+  MarketState
 } from '@ghostfolio/api/services/interfaces/interfaces';
 import { PrismaService } from '@ghostfolio/api/services/prisma.service';
 import { SymbolProfileService } from '@ghostfolio/api/services/symbol-profile.service';
 import { DATE_FORMAT, parseDate } from '@ghostfolio/common/helper';
 import { Granularity } from '@ghostfolio/common/types';
 import { Injectable, Logger } from '@nestjs/common';
-import { DataSource, SymbolProfile } from '@prisma/client';
+import { DataSource } from '@prisma/client';
 import { format } from 'date-fns';
 import { GoogleSpreadsheet } from 'google-spreadsheet';
 
@@ -26,24 +27,65 @@ export class GoogleSheetsService implements DataProviderInterface {
     return true;
   }
 
-  public async getAssetProfile(
+  public async get(
-    aSymbol: string
+    aSymbols: string[]
-  ): Promise<Partial<SymbolProfile>> {
+  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    return {
+    if (aSymbols.length <= 0) {
-      dataSource: this.getName()
+      return {};
-    };
+    }
+
+    try {
+      const response: { [symbol: string]: IDataProviderResponse } = {};
+
+      const symbolProfiles = await this.symbolProfileService.getSymbolProfiles(
+        aSymbols
+      );
+
+      const sheet = await this.getSheet({
+        sheetId: this.configurationService.get('GOOGLE_SHEETS_ID'),
+        symbol: 'Overview'
+      });
+
+      const rows = await sheet.getRows();
+
+      for (const row of rows) {
+        const marketPrice = parseFloat(row['marketPrice']);
+        const symbol = row['symbol'];
+
+        if (aSymbols.includes(symbol)) {
+          response[symbol] = {
+            marketPrice,
+            currency: symbolProfiles.find((symbolProfile) => {
+              return symbolProfile.symbol === symbol;
+            })?.currency,
+            dataSource: this.getName(),
+            marketState: MarketState.delayed
+          };
+        }
+      }
+
+      return response;
+    } catch (error) {
+      Logger.error(error);
+    }
+
+    return {};
   }
 
   public async getHistorical(
-    aSymbol: string,
+    aSymbols: string[],
     aGranularity: Granularity = 'day',
     from: Date,
     to: Date
   ): Promise<{
     [symbol: string]: { [date: string]: IDataProviderHistoricalResponse };
   }> {
+    if (aSymbols.length <= 0) {
+      return {};
+    }
+
     try {
-      const symbol = aSymbol;
+      const [symbol] = aSymbols;
 
       const sheet = await this.getSheet({
         symbol,
@@ -71,63 +113,16 @@ export class GoogleSheetsService implements DataProviderInterface {
         [symbol]: historicalData
       };
     } catch (error) {
-      throw new Error(
+      Logger.error(error);
-        `Could not get historical market data for ${aSymbol} (${this.getName()}) from ${format(
-          from,
-          DATE_FORMAT
-        )} to ${format(to, DATE_FORMAT)}: [${error.name}] ${error.message}`
-      );
     }
+
+    return {};
   }
 
   public getName(): DataSource {
     return DataSource.GOOGLE_SHEETS;
   }
 
-  public async getQuotes(
-    aSymbols: string[]
-  ): Promise<{ [symbol: string]: IDataProviderResponse }> {
-    if (aSymbols.length <= 0) {
-      return {};
-    }
-
-    try {
-      const response: { [symbol: string]: IDataProviderResponse } = {};
-
-      const symbolProfiles =
-        await this.symbolProfileService.getSymbolProfilesBySymbols(aSymbols);
-
-      const sheet = await this.getSheet({
-        sheetId: this.configurationService.get('GOOGLE_SHEETS_ID'),
-        symbol: 'Overview'
-      });
-
-      const rows = await sheet.getRows();
-
-      for (const row of rows) {
-        const marketPrice = parseFloat(row['marketPrice']);
-        const symbol = row['symbol'];
-
-        if (aSymbols.includes(symbol)) {
-          response[symbol] = {
-            marketPrice,
-            currency: symbolProfiles.find((symbolProfile) => {
-              return symbolProfile.symbol === symbol;
-            })?.currency,
-            dataSource: this.getName(),
-            marketState: 'delayed'
-          };
-        }
-      }
-
-      return response;
-    } catch (error) {
-      Logger.error(error, 'GoogleSheetsService');
-    }
-
-    return {};
-  }
-
   public async search(aQuery: string): Promise<{ items: LookupItem[] }> {
     const items = await this.prismaService.symbolProfile.findMany({
       select: {

apps/api/src/services/data-provider/interfaces/data-enhancer.interface.ts

@@ -1,13 +1,13 @@
-import { SymbolProfile } from '@prisma/client';
+import { IDataProviderResponse } from '@ghostfolio/api/services/interfaces/interfaces';
 
 export interface DataEnhancerInterface {
   enhance({
     response,
     symbol
   }: {
-    response: Partial<SymbolProfile>;
+    response: IDataProviderResponse;
     symbol: string;
-  }): Promise<Partial<SymbolProfile>>;
+  }): Promise<IDataProviderResponse>;
 
   getName(): string;
 }