sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/improve form of import dividends dialog (#1582)

Browse Source 
* Disable while loading

* Update changelog
This commit is contained in:
Thomas Kaul 2023-01-10 20:43:48 +01:00 committed by GitHub
parent f3c8ec27cb
commit fc8e23a9c8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -9,7 +9,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Improved the deprecated `~` in _Sass_ imports - Improved the form of the import dividends dialog (disable while loading)
- Removed the deprecated `~` in _Sass_ imports
## 1.225.0 - 2023-01-07 ## 1.225.0 - 2023-01-07

4
apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.component.ts
View File

@ -56,6 +56,7 @@ export class ImportActivitiesDialog implements OnDestroy {
this.data?.activityTypes?.[0] === 'DIVIDEND' this.data?.activityTypes?.[0] === 'DIVIDEND'
) { ) {
this.mode = 'DIVIDEND'; this.mode = 'DIVIDEND';
this.uniqueAssetForm.controls['uniqueAsset'].disable();
this.dataService this.dataService
.fetchPositions({ .fetchPositions({
@ -72,6 +73,7 @@ export class ImportActivitiesDialog implements OnDestroy {
this.holdings = sortBy(positions, ({ name }) => { this.holdings = sortBy(positions, ({ name }) => {
return name.toLowerCase(); return name.toLowerCase();
}); });
this.uniqueAssetForm.controls['uniqueAsset'].enable();
this.changeDetectorRef.markForCheck(); this.changeDetectorRef.markForCheck();
}); });
@ -111,6 +113,8 @@ export class ImportActivitiesDialog implements OnDestroy {
} }
public onLoadDividends() { public onLoadDividends() {
this.uniqueAssetForm.controls['uniqueAsset'].disable();
const { dataSource, symbol } = const { dataSource, symbol } =
this.uniqueAssetForm.controls['uniqueAsset'].value; this.uniqueAssetForm.controls['uniqueAsset'].value;