sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix exception in scraper configuration (#4196)

Browse Source 
* Fix exception in scraper configuration

* Update changelog
This commit is contained in:
Thomas Kaul 2025-01-15 20:28:04 +01:00 committed by GitHub
parent 9fe19868b9
commit ec79a9efb6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 26 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed an issue with the renaming of activities with type `FEE`, `INTEREST`, `ITEM` or `LIABILITY` - Fixed an issue with the renaming of activities with type `FEE`, `INTEREST`, `ITEM` or `LIABILITY`
- Handled an exception in the scraper configuration introduced by the migration from `got` to `fetch`
## 2.133.1 - 2025-01-09 ## 2.133.1 - 2025-01-09

8
apps/api/src/services/data-provider/manual/manual.service.ts
View File

@ -273,8 +273,8 @@ export class ManualService implements DataProviderInterface {
private async scrape( private async scrape(
scraperConfiguration: ScraperConfiguration scraperConfiguration: ScraperConfiguration
): Promise<number> { ): Promise<number> {
try {
let locale = scraperConfiguration.locale; let locale = scraperConfiguration.locale;
const response = await fetch(scraperConfiguration.url, { const response = await fetch(scraperConfiguration.url, {
headers: scraperConfiguration.headers as HeadersInit, headers: scraperConfiguration.headers as HeadersInit,
signal: AbortSignal.timeout( signal: AbortSignal.timeout(
@ -282,8 +282,9 @@ export class ManualService implements DataProviderInterface {
) )
}); });
if (response.headers['content-type'].includes('application/json')) { if (response.headers['content-type']?.includes('application/json')) {
const data = await response.json(); const data = await response.json();
const value = String( const value = String(
jsonpath.query(data, scraperConfiguration.selector)[0] jsonpath.query(data, scraperConfiguration.selector)[0]
); );
@ -303,8 +304,5 @@ export class ManualService implements DataProviderInterface {
value: $(scraperConfiguration.selector).first().text() value: $(scraperConfiguration.selector).first().text()
}); });
} }
} catch (error) {
throw error;
}
} }
} }