sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Fix get quotes in CoinGecko service (#2595)

Browse Source 
* Fix get quotes in CoinGecko service

* Update changelog

---------

Co-authored-by: Thomas <4159106+dtslvr@users.noreply.github.com>
This commit is contained in:
Lukas Möller 2023-11-05 11:52:09 +01:00 committed by GitHub
parent 45510702d0
commit e8e1bb83bf
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed an issue to get quotes in the _CoinGecko_ service
- Loosened the validation in the activities import (expects values greater than or equal to 0 for `fee`, `quantity` and `unitPrice`) - Loosened the validation in the activities import (expects values greater than or equal to 0 for `fee`, `quantity` and `unitPrice`)
- Handled an issue with a failing database query (`account.findMany()`) related to activities without account - Handled an issue with a failing database query (`account.findMany()`) related to activities without account

20
apps/api/src/services/data-provider/coingecko/coingecko.service.ts
View File

@ -152,7 +152,7 @@ export class CoinGeckoService implements DataProviderInterface {
abortController.abort(); abortController.abort();
}, DEFAULT_REQUEST_TIMEOUT); }, DEFAULT_REQUEST_TIMEOUT);
const response = await got( const quotes = await got(
`${this.URL}/simple/price?ids=${symbols.join( `${this.URL}/simple/price?ids=${symbols.join(
',' ','
)}&vs_currencies=${DEFAULT_CURRENCY.toLowerCase()}`, )}&vs_currencies=${DEFAULT_CURRENCY.toLowerCase()}`,
@ -162,16 +162,14 @@ export class CoinGeckoService implements DataProviderInterface {
} }
).json<any>(); ).json<any>();
for (const symbol in response) { for (const symbol in quotes) {
if (Object.prototype.hasOwnProperty.call(response, symbol)) { response[symbol] = {
response[symbol] = { currency: DEFAULT_CURRENCY,
currency: DEFAULT_CURRENCY, dataProviderInfo: this.getDataProviderInfo(),
dataProviderInfo: this.getDataProviderInfo(), dataSource: DataSource.COINGECKO,
dataSource: DataSource.COINGECKO, marketPrice: quotes[symbol][DEFAULT_CURRENCY.toLowerCase()],
marketPrice: response[symbol][DEFAULT_CURRENCY.toLowerCase()], marketState: 'open'
marketState: 'open' };
};
}
} }
} catch (error) { } catch (error) {
Logger.error(error, 'CoinGeckoService'); Logger.error(error, 'CoinGeckoService');