sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/clean up all time high and low from performance endpoint (#551)

Browse Source 
* Remove isAllTimeHigh / isAllTimeLow

* Update changelog
This commit is contained in:
Thomas Kaul 2021-12-18 09:20:42 +01:00 committed by GitHub
parent eff807dd9a
commit e518bc3779
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## Unreleased ## Unreleased
### Changed
- Removed the redundant all time high and all time low from the performance endpoint
### Fixed ### Fixed
- Fixed the symbol conversion from _Yahoo Finance_ including a hyphen - Fixed the symbol conversion from _Yahoo Finance_ including a hyphen

8
apps/api/src/app/portfolio/portfolio.service.ts
View File

@ -693,9 +693,7 @@ export class PortfolioService {
currentGrossPerformancePercent: 0, currentGrossPerformancePercent: 0,
currentNetPerformance: 0, currentNetPerformance: 0,
currentNetPerformancePercent: 0, currentNetPerformancePercent: 0,
currentValue: 0, currentValue: 0
isAllTimeHigh: false,
isAllTimeLow: false
} }
}; };
} }
@ -728,9 +726,7 @@ export class PortfolioService {
currentGrossPerformancePercent, currentGrossPerformancePercent,
currentNetPerformance, currentNetPerformance,
currentNetPerformancePercent, currentNetPerformancePercent,
currentValue, currentValue
isAllTimeHigh: true,
isAllTimeLow: false
} }
}; };
} }

2
libs/common/src/lib/interfaces/portfolio-performance.interface.ts
View File

@ -5,6 +5,4 @@ export interface PortfolioPerformance {
currentNetPerformance: number; currentNetPerformance: number;
currentNetPerformancePercent: number; currentNetPerformancePercent: number;
currentValue: number; currentValue: number;
isAllTimeHigh: boolean;
isAllTimeLow: boolean;
} }