sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix issue on buy date in position detail dialog (#297)

Browse Source 
* Fix issue on buy date

* Update changelog
This commit is contained in:
Thomas Kaul 2021-08-17 21:31:32 +02:00 committed by GitHub
parent 408e08d43c
commit e17b217032
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed the node engine version mismatch in `package.json` - Fixed the node engine version mismatch in `package.json`
- Fixed an issue on the buy date in the position detail dialog
## 1.39.0 - 16.08.2021 ## 1.39.0 - 16.08.2021

6
apps/api/src/app/portfolio/portfolio.service.ts
View File

@ -337,10 +337,10 @@ export class PortfolioService {
); );
const historicalDataArray: HistoricalDataItem[] = []; const historicalDataArray: HistoricalDataItem[] = [];
let maxPrice = orders[0].unitPrice; let maxPrice = Math.max(orders[0].unitPrice, marketPrice);
let minPrice = orders[0].unitPrice; let minPrice = Math.min(orders[0].unitPrice, marketPrice);
if (!historicalData[aSymbol][firstBuyDate]) { if (!historicalData?.[aSymbol]?.[firstBuyDate]) {
// Add historical entry for buy date, if no historical data available // Add historical entry for buy date, if no historical data available
historicalDataArray.push({ historicalDataArray.push({
averagePrice: orders[0].unitPrice, averagePrice: orders[0].unitPrice,