sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix issue with import of activities with type FEE (#4187)

Browse Source 
* Fix import of activity with type FEE

* Update changelog
This commit is contained in:
Ivan Kruglov 2025-01-15 20:34:03 +01:00 committed by GitHub
parent e4968dbea7
commit d5e64eaed4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -20,6 +20,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed ### Fixed
- Fixed an issue with the import of activities with type `FEE` (where unit price is `0`)
- Fixed an issue with the renaming of activities with type `FEE`, `INTEREST`, `ITEM` or `LIABILITY` - Fixed an issue with the renaming of activities with type `FEE`, `INTEREST`, `ITEM` or `LIABILITY`
- Handled an exception in the scraper configuration introduced by the migration from `got` to `fetch` - Handled an exception in the scraper configuration introduced by the migration from `got` to `fetch`

4
apps/api/src/app/import/import.service.ts
View File

@ -30,7 +30,7 @@ import { Injectable } from '@nestjs/common';
import { DataSource, Prisma, SymbolProfile } from '@prisma/client'; import { DataSource, Prisma, SymbolProfile } from '@prisma/client';
import { Big } from 'big.js'; import { Big } from 'big.js';
import { endOfToday, format, isAfter, isSameSecond, parseISO } from 'date-fns'; import { endOfToday, format, isAfter, isSameSecond, parseISO } from 'date-fns';
import { uniqBy } from 'lodash'; import { isNumber, uniqBy } from 'lodash';
import { v4 as uuidv4 } from 'uuid'; import { v4 as uuidv4 } from 'uuid';
@Injectable() @Injectable()
@ -328,7 +328,7 @@ export class ImportService {
date date
); );
if (!unitPrice) { if (!isNumber(unitPrice)) {
throw new Error( throw new Error(
`activities.${index} historical exchange rate at ${format( `activities.${index} historical exchange rate at ${format(
date, date,