Feature/increase decimal places for cryptocurrencies (#462)

* Calculate quantity precision

* Update changelog
This commit is contained in:
Thomas Kaul
2021-11-11 21:21:37 +01:00
committed by GitHub
parent 7425ba94f1
commit cd76f89902
5 changed files with 34 additions and 3 deletions

View File

@@ -9,6 +9,7 @@ import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
import { DataService } from '@ghostfolio/client/services/data.service';
import { DATE_FORMAT } from '@ghostfolio/common/helper';
import { LineChartItem } from '@ghostfolio/ui/line-chart/interfaces/line-chart.interface';
import { AssetSubClass } from '@prisma/client';
import { format, isSameMonth, isToday, parseISO } from 'date-fns';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
@@ -23,6 +24,7 @@ import { PositionDetailDialogParams } from './interfaces/interfaces';
styleUrls: ['./position-detail-dialog.component.scss']
})
export class PositionDetailDialog implements OnDestroy {
public assetSubClass: AssetSubClass;
public averagePrice: number;
public benchmarkDataItems: LineChartItem[];
public currency: string;
@@ -38,6 +40,7 @@ export class PositionDetailDialog implements OnDestroy {
public netPerformance: number;
public netPerformancePercent: number;
public quantity: number;
public quantityPrecision = 2;
public symbol: string;
public transactionCount: number;
@@ -54,6 +57,7 @@ export class PositionDetailDialog implements OnDestroy {
.pipe(takeUntil(this.unsubscribeSubject))
.subscribe(
({
assetSubClass,
averagePrice,
currency,
firstBuyDate,
@@ -71,6 +75,7 @@ export class PositionDetailDialog implements OnDestroy {
symbol,
transactionCount
}) => {
this.assetSubClass = assetSubClass;
this.averagePrice = averagePrice;
this.benchmarkDataItems = [];
this.currency = currency;
@@ -146,6 +151,18 @@ export class PositionDetailDialog implements OnDestroy {
this.benchmarkDataItems[0].value = this.averagePrice;
}
if (Number.isInteger(this.quantity)) {
this.quantityPrecision = 0;
} else if (assetSubClass === 'CRYPTOCURRENCY') {
if (this.quantity < 1) {
this.quantityPrecision = 7;
} else if (this.quantity < 1000) {
this.quantityPrecision = 5;
} else if (this.quantity > 10000000) {
this.quantityPrecision = 0;
}
}
this.changeDetectorRef.markForCheck();
}
);

View File

@@ -82,7 +82,7 @@
label="Quantity"
size="medium"
[locale]="data.locale"
[precision]="2"
[precision]="quantityPrecision"
[value]="quantity"
></gf-value>
</div>