From ba979cbae25997caba2fbf48ff5e22fd439b41ef Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Mon, 24 Jun 2024 21:24:03 +0200 Subject: [PATCH] Bugfix/fix addition of manual asset without market data (#3516) * Provide default value * Update changelog --- CHANGELOG.md | 1 + .../src/services/data-provider/manual/manual.service.ts | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d9fa9863..fc7e4378 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Fixed - Changed the mechanism of the `INTRADAY` data gathering to persist data only if the market state is `OPEN` +- Fixed the creation of activities with `MANUAL` data source (with no historical market data) ## 2.90.0 - 2024-06-22 diff --git a/apps/api/src/services/data-provider/manual/manual.service.ts b/apps/api/src/services/data-provider/manual/manual.service.ts index 5066a4d3..d2e5bca8 100644 --- a/apps/api/src/services/data-provider/manual/manual.service.ts +++ b/apps/api/src/services/data-provider/manual/manual.service.ts @@ -167,9 +167,10 @@ export class ManualService implements DataProviderInterface { }); for (const { currency, symbol } of symbolProfiles) { - let marketPrice = marketData.find((marketDataItem) => { - return marketDataItem.symbol === symbol; - })?.marketPrice; + let marketPrice = + marketData.find((marketDataItem) => { + return marketDataItem.symbol === symbol; + })?.marketPrice ?? 0; response[symbol] = { currency,