From b89bf1d5e80b4c17c7e110ecd88fdc56cabcb122 Mon Sep 17 00:00:00 2001 From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com> Date: Sun, 31 Dec 2023 10:23:56 +0100 Subject: [PATCH] Feature/increase timeout to load currencies (#2800) * Increase timeout * Update changelog --- CHANGELOG.md | 1 + .../services/exchange-rate-data/exchange-rate-data.service.ts | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 05ad3599..744f3f6f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ### Changed - Changed the performance calculation to a time-weighted approach +- Increased the timeout to load currencies in the exchange rate data service - Exposed the environment variable `REQUEST_TIMEOUT` - Used the `HasPermission` annotation in endpoints - Improved the language localization for German (`de`) diff --git a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts index cf61786c..9eecd400 100644 --- a/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts +++ b/apps/api/src/services/exchange-rate-data/exchange-rate-data.service.ts @@ -11,6 +11,7 @@ import { DATE_FORMAT, getYesterday } from '@ghostfolio/common/helper'; import { Injectable, Logger } from '@nestjs/common'; import { format, isToday } from 'date-fns'; import { isNumber, uniq } from 'lodash'; +import ms from 'ms'; @Injectable() export class ExchangeRateDataService { @@ -75,7 +76,8 @@ export class ExchangeRateDataService { const quotes = await this.dataProviderService.getQuotes({ items: this.currencyPairs.map(({ dataSource, symbol }) => { return { dataSource, symbol }; - }) + }), + requestTimeout: ms('30 seconds') }); for (const symbol of Object.keys(quotes)) {