sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix duplicated tags in position detail dialog (#3224)

Browse Source 
* Fix duplicated tags

* Update changelog
This commit is contained in:
Thomas Kaul 2024-04-01 09:22:35 +02:00 committed by GitHub
parent 1b81409b35
commit b8533050b0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the usability of the date range support by specific years (`2023`, `2022`, `2021`, etc.) in the assistant (experimental) - Improved the usability of the date range support by specific years (`2023`, `2022`, `2021`, etc.) in the assistant (experimental)
- Introduced a factory for the portfolio calculations to support different algorithms in future - Introduced a factory for the portfolio calculations to support different algorithms in future
### Fixed
- Fixed the duplicated tags in the position detail dialog
## 2.69.0 - 2024-03-30 ## 2.69.0 - 2024-03-30
### Added ### Added

4
apps/api/src/app/portfolio/portfolio.service.ts
View File

@ -719,8 +719,6 @@ export class PortfolioService {
{ dataSource: aDataSource, symbol: aSymbol } { dataSource: aDataSource, symbol: aSymbol }
]); ]);
tags = uniqBy(tags, 'id');
const portfolioCalculator = this.calculatorFactory.createCalculator({ const portfolioCalculator = this.calculatorFactory.createCalculator({
activities: orders.filter((order) => { activities: orders.filter((order) => {
tags = tags.concat(order.tags); tags = tags.concat(order.tags);
@ -731,6 +729,8 @@ export class PortfolioService {
currency: userCurrency currency: userCurrency
}); });
tags = uniqBy(tags, 'id');
const portfolioStart = portfolioCalculator.getStartDate(); const portfolioStart = portfolioCalculator.getStartDate();
const transactionPoints = portfolioCalculator.getTransactionPoints(); const transactionPoints = portfolioCalculator.getTransactionPoints();