sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

add error handling to performance aggregation

Browse Source
This commit is contained in:
Valentin Zickner 2021-07-27 23:04:31 +02:00 committed by Thomas
parent 409afac2a9
commit b779964adb
1 changed files with 14 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
apps/api/src/app/portfolio/portfolio.service.ts
View File

@ -468,16 +468,23 @@ export class PortfolioService {
let currentValue = new Big(0); let currentValue = new Big(0);
let grossPerformance = new Big(0); let grossPerformance = new Big(0);
let grossPerformancePercentage = new Big(1); let grossPerformancePercentage = new Big(1);
let hasErrors = false;
for (const currentPosition of currentPositions.positions) { for (const currentPosition of currentPositions.positions) {
currentValue = currentValue.add( currentValue = currentValue.add(
new Big(currentPosition.marketPrice).mul(currentPosition.quantity) new Big(currentPosition.marketPrice).mul(currentPosition.quantity)
); );
grossPerformance = grossPerformance.plus( if (currentPosition.grossPerformance) {
currentPosition.grossPerformance hasErrors = true;
); grossPerformance = grossPerformance.plus(
grossPerformancePercentage = grossPerformancePercentage.mul( currentPosition.grossPerformance
currentPosition.grossPerformancePercentage.plus(1) );
); }
if (currentPosition.grossPerformancePercentage) {
hasErrors = true;
grossPerformancePercentage = grossPerformancePercentage.mul(
currentPosition.grossPerformancePercentage.plus(1)
);
}
} }
const currentGrossPerformance = grossPerformance.toNumber(); const currentGrossPerformance = grossPerformance.toNumber();
@ -485,7 +492,7 @@ export class PortfolioService {
.minus(1) .minus(1)
.toNumber(); .toNumber();
return { return {
hasErrors: currentPositions.hasErrors, hasErrors: currentPositions.hasErrors || hasErrors,
performance: { performance: {
currentGrossPerformance, currentGrossPerformance,
currentGrossPerformancePercent, currentGrossPerformancePercent,