sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/improve validation of currency management (#2761)

Browse Source 
* Improve validation

* Update changelog
This commit is contained in:
Thomas Kaul 2023-12-20 11:53:40 +01:00 committed by GitHub
parent 80e899a5d3
commit aa72d9b730
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Set the select column of the lazy-loaded activities table to stick at the end (experimental) - Set the select column of the lazy-loaded activities table to stick at the end (experimental)
- Improved the validation of the currency management in the admin control panel
- Improved the performance of the value redaction interceptor for the impersonation mode by eliminating `cloneDeep` - Improved the performance of the value redaction interceptor for the impersonation mode by eliminating `cloneDeep`
### Fixed ### Fixed

8
apps/client/src/app/components/admin-overview/admin-overview.component.ts
View File

@ -119,8 +119,12 @@ export class AdminOverviewComponent implements OnDestroy, OnInit {
const currency = prompt($localize`Please add a currency:`); const currency = prompt($localize`Please add a currency:`);
if (currency) { if (currency) {
const currencies = uniq([...this.customCurrencies, currency]); if (currency.length === 3) {
this.putAdminSetting({ key: PROPERTY_CURRENCIES, value: currencies }); const currencies = uniq([...this.customCurrencies, currency]);
this.putAdminSetting({ key: PROPERTY_CURRENCIES, value: currencies });
} else {
alert($localize`${currency} is an invalid currency!`);
}
} }
} }