From a0f377e8eb0886226415bf645e9f5a8b00411f80 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Mon, 19 May 2025 23:27:52 +0200
Subject: [PATCH] Feature/refactor ordersCount to activityCount (#4688)

* Refactor ordersCount to activityCount
---
 apps/api/src/app/portfolio/portfolio.service.ts  | 16 ++++++++--------
 apps/api/src/helper/object.helper.spec.ts        |  4 ++--
 .../portfolio-summary.component.html             |  6 +++---
 .../interfaces/portfolio-summary.interface.ts    |  2 +-
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/apps/api/src/app/portfolio/portfolio.service.ts b/apps/api/src/app/portfolio/portfolio.service.ts
index c580ce14..7e373c4c 100644
--- a/apps/api/src/app/portfolio/portfolio.service.ts
+++ b/apps/api/src/app/portfolio/portfolio.service.ts
@@ -1249,7 +1249,7 @@ export class PortfolioService {
 
     const rules: PortfolioReportResponse['rules'] = {
       accountClusterRisk:
-        summary.ordersCount > 0
+        summary.activityCount > 0
           ? await this.rulesService.evaluate(
               [
                 new AccountClusterRiskCurrentInvestment(
@@ -1265,7 +1265,7 @@ export class PortfolioService {
             )
           : undefined,
       assetClassClusterRisk:
-        summary.ordersCount > 0
+        summary.activityCount > 0
           ? await this.rulesService.evaluate(
               [
                 new AssetClassClusterRiskEquity(
@@ -1281,7 +1281,7 @@ export class PortfolioService {
             )
           : undefined,
       currencyClusterRisk:
-        summary.ordersCount > 0
+        summary.activityCount > 0
           ? await this.rulesService.evaluate(
               [
                 new CurrencyClusterRiskBaseCurrencyCurrentInvestment(
@@ -1297,7 +1297,7 @@ export class PortfolioService {
             )
           : undefined,
       economicMarketClusterRisk:
-        summary.ordersCount > 0
+        summary.activityCount > 0
           ? await this.rulesService.evaluate(
               [
                 new EconomicMarketClusterRiskDevelopedMarkets(
@@ -1338,7 +1338,7 @@ export class PortfolioService {
         userSettings
       ),
       regionalMarketClusterRisk:
-        summary.ordersCount > 0
+        summary.activityCount > 0
           ? await this.rulesService.evaluate(
               [
                 new RegionalMarketClusterRiskAsiaPacific(
@@ -1981,6 +1981,9 @@ export class PortfolioService {
       netPerformanceWithCurrencyEffect,
       totalBuy,
       totalSell,
+      activityCount: activities.filter(({ type }) => {
+        return ['BUY', 'SELL'].includes(type);
+      }).length,
       committedFunds: committedFunds.toNumber(),
       currentValueInBaseCurrency: currentValueInBaseCurrency.toNumber(),
       dividendInBaseCurrency: dividendInBaseCurrency.toNumber(),
@@ -2008,9 +2011,6 @@ export class PortfolioService {
       interest: interest.toNumber(),
       items: valuables.toNumber(),
       liabilities: liabilities.toNumber(),
-      ordersCount: activities.filter(({ type }) => {
-        return ['BUY', 'SELL'].includes(type);
-      }).length,
       totalInvestment: totalInvestment.toNumber(),
       totalValueInBaseCurrency: netWorth
     };
diff --git a/apps/api/src/helper/object.helper.spec.ts b/apps/api/src/helper/object.helper.spec.ts
index b0370fa3..d7caf9bc 100644
--- a/apps/api/src/helper/object.helper.spec.ts
+++ b/apps/api/src/helper/object.helper.spec.ts
@@ -1515,6 +1515,7 @@ describe('redactAttributes', () => {
             }
           },
           summary: {
+            activityCount: 29,
             annualizedPerformancePercent: 0.16690880197786,
             annualizedPerformancePercentWithCurrencyEffect: 0.1694019484552876,
             cash: null,
@@ -1538,7 +1539,6 @@ describe('redactAttributes', () => {
             interest: null,
             items: null,
             liabilities: null,
-            ordersCount: 29,
             totalInvestment: null,
             totalValueInBaseCurrency: null,
             currentNetWorth: null
@@ -3018,6 +3018,7 @@ describe('redactAttributes', () => {
         }
       },
       summary: {
+        activityCount: 29,
         annualizedPerformancePercent: 0.16690880197786,
         annualizedPerformancePercentWithCurrencyEffect: 0.1694019484552876,
         cash: null,
@@ -3041,7 +3042,6 @@ describe('redactAttributes', () => {
         interest: null,
         items: null,
         liabilities: null,
-        ordersCount: 29,
         totalInvestment: null,
         totalValueInBaseCurrency: null,
         currentNetWorth: null
diff --git a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
index 1a52bd64..265904b8 100644
--- a/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
+++ b/apps/client/src/app/components/portfolio-summary/portfolio-summary.component.html
@@ -7,11 +7,11 @@
   </div>
   <div
     class="flex-nowrap px-3 py-1 row"
-    [hidden]="summary?.ordersCount === null"
+    [hidden]="summary?.activityCount === null"
   >
     <div class="d-flex flex-grow-1 ml-3 text-truncate">
-      {{ summary?.ordersCount }}
-      <ng-container i18n>{summary?.ordersCount, plural,
+      {{ summary?.activityCount }}
+      <ng-container i18n>{summary?.activityCount, plural,
         =1 {activity}
         other {activities}
       }</ng-container>
diff --git a/libs/common/src/lib/interfaces/portfolio-summary.interface.ts b/libs/common/src/lib/interfaces/portfolio-summary.interface.ts
index 42496b22..4030b900 100644
--- a/libs/common/src/lib/interfaces/portfolio-summary.interface.ts
+++ b/libs/common/src/lib/interfaces/portfolio-summary.interface.ts
@@ -1,6 +1,7 @@
 import { PortfolioPerformance } from './portfolio-performance.interface';
 
 export interface PortfolioSummary extends PortfolioPerformance {
+  activityCount: number;
   annualizedPerformancePercent: number;
   annualizedPerformancePercentWithCurrencyEffect: number;
   cash: number;
@@ -21,7 +22,6 @@ export interface PortfolioSummary extends PortfolioPerformance {
   interest: number;
   items: number;
   liabilities: number;
-  ordersCount: number;
   totalBuy: number;
   totalSell: number;
   totalValueInBaseCurrency?: number;