sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/improve usability of create or update access dialog (#3791)

Browse Source 
* Improve usability

* Dialog height
* Always show permission selector

* Update changelog
This commit is contained in:
Thomas Kaul 2024-09-21 10:35:41 +02:00 committed by GitHub
parent 7761e4d712
commit 9b07b19523
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Improved the usability of the create or update access dialog
- Improved the loading indicator of the accounts table - Improved the loading indicator of the accounts table
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)
- Improved the language localization for Polish (`pl`) - Improved the language localization for Polish (`pl`)

3
apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.component.ts
View File

@ -52,13 +52,12 @@ export class CreateOrUpdateAccessDialog implements OnDestroy {
if (accessType === 'PRIVATE') { if (accessType === 'PRIVATE') {
granteeUserIdControl.setValidators(Validators.required); granteeUserIdControl.setValidators(Validators.required);
permissionsControl.setValidators(Validators.required);
} else { } else {
granteeUserIdControl.clearValidators(); granteeUserIdControl.clearValidators();
permissionsControl.setValue(this.data.access.permissions[0]);
} }
granteeUserIdControl.updateValueAndValidity(); granteeUserIdControl.updateValueAndValidity();
permissionsControl.updateValueAndValidity();
this.changeDetectorRef.markForCheck(); this.changeDetectorRef.markForCheck();
}); });

22
apps/client/src/app/components/user-account-access/create-or-update-access-dialog/create-or-update-access-dialog.html
View File

@ -27,18 +27,18 @@
</mat-form-field> </mat-form-field>
</div> </div>
@if (accessForm.get('type').value === 'PRIVATE') { <div>
<div> <mat-form-field appearance="outline" class="w-100">
<mat-form-field appearance="outline" class="w-100"> <mat-label i18n>Permission</mat-label>
<mat-label i18n>Permission</mat-label> <mat-select formControlName="permissions">
<mat-select formControlName="permissions"> <mat-option i18n value="READ_RESTRICTED">Restricted view</mat-option>
<mat-option i18n value="READ_RESTRICTED" @if (accessForm.get('type').value === 'PRIVATE') {
>Restricted view</mat-option
>
<mat-option i18n value="READ">View</mat-option> <mat-option i18n value="READ">View</mat-option>
</mat-select> }
</mat-form-field> </mat-select>
</div> </mat-form-field>
</div>
@if (accessForm.get('type').value === 'PRIVATE') {
<div> <div>
<mat-form-field appearance="outline" class="w-100"> <mat-form-field appearance="outline" class="w-100">
<mat-label> <mat-label>

2
apps/client/src/app/components/user-account-access/user-account-access.component.ts
View File

@ -111,7 +111,7 @@ export class UserAccountAccessComponent implements OnDestroy, OnInit {
type: 'PRIVATE' type: 'PRIVATE'
} }
}, },
height: this.deviceType === 'mobile' ? '97.5vh' : '80vh', height: this.deviceType === 'mobile' ? '97.5vh' : undefined,
width: this.deviceType === 'mobile' ? '100vw' : '50rem' width: this.deviceType === 'mobile' ? '100vw' : '50rem'
}); });