From 8ad64924779dbef9e5e087f39d56503c8f2f7873 Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Thu, 5 Oct 2023 20:31:00 +0200
Subject: [PATCH] Feature/various improvements in client (#2434)

* Various improvements

* Update changelog
---
 CHANGELOG.md                                              | 4 ++++
 apps/client/src/app/app.module.ts                         | 5 +++--
 .../src/app/components/admin-overview/admin-overview.html | 4 ++--
 .../src/app/components/header/header.component.html       | 2 +-
 .../src/app/components/home-market/home-market.html       | 4 ++--
 .../portfolio-performance/portfolio-performance.module.ts | 5 +++--
 .../position-detail-dialog/position-detail-dialog.html    | 8 ++++----
 .../import-activities-dialog.html                         | 2 +-
 apps/client/src/app/pages/public/public-page.html         | 2 +-
 .../app/pages/user-account/user-account-page.module.ts    | 5 +++--
 10 files changed, 24 insertions(+), 17 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 49419da3..41fa38bc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Added the application version to the endpoint `GET api/v1/admin`
 
+### Fixed
+
+- Fixed the style of the active features page in the navigation on desktop
+
 ## 2.8.0 - 2023-10-03
 
 ### Added
diff --git a/apps/client/src/app/app.module.ts b/apps/client/src/app/app.module.ts
index a5f0d755..608ba010 100644
--- a/apps/client/src/app/app.module.ts
+++ b/apps/client/src/app/app.module.ts
@@ -1,6 +1,6 @@
 import { Platform } from '@angular/cdk/platform';
 import { HttpClientModule } from '@angular/common/http';
-import { NgModule } from '@angular/core';
+import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatAutocompleteModule } from '@angular/material/autocomplete';
 import { MatChipsModule } from '@angular/material/chips';
 import {
@@ -35,6 +35,7 @@ export function NgxStripeFactory(): string {
 }
 
 @NgModule({
+  bootstrap: [AppComponent],
   declarations: [AppComponent],
   imports: [
     AppRoutingModule,
@@ -72,6 +73,6 @@ export function NgxStripeFactory(): string {
       useFactory: NgxStripeFactory
     }
   ],
-  bootstrap: [AppComponent]
+  schemas: [CUSTOM_ELEMENTS_SCHEMA]
 })
 export class AppModule {}
diff --git a/apps/client/src/app/components/admin-overview/admin-overview.html b/apps/client/src/app/components/admin-overview/admin-overview.html
index 2739547b..e54f8f27 100644
--- a/apps/client/src/app/components/admin-overview/admin-overview.html
+++ b/apps/client/src/app/components/admin-overview/admin-overview.html
@@ -11,8 +11,8 @@
             <div class="w-50" i18n>User Count</div>
             <div class="w-50">
               <gf-value
-                precision="0"
                 [locale]="user?.settings?.locale"
+                [precision]="0"
                 [value]="userCount"
               ></gf-value>
             </div>
@@ -21,8 +21,8 @@
             <div class="w-50" i18n>Activity Count</div>
             <div class="w-50">
               <gf-value
-                precision="0"
                 [locale]="user?.settings?.locale"
+                [precision]="0"
                 [value]="transactionCount"
               ></gf-value>
               <div *ngIf="transactionCount && userCount">
diff --git a/apps/client/src/app/components/header/header.component.html b/apps/client/src/app/components/header/header.component.html
index 2c56cb74..a2c69245 100644
--- a/apps/client/src/app/components/header/header.component.html
+++ b/apps/client/src/app/components/header/header.component.html
@@ -272,7 +272,7 @@
           mat-flat-button
           [ngClass]="{
             'font-weight-bold': currentRoute === routeFeatures,
-            'text-decoration-underline': currentRoute === routeFeatuers
+            'text-decoration-underline': currentRoute === routeFeatures
           }"
           [routerLink]="routerLinkFeatures"
           >Features</a
diff --git a/apps/client/src/app/components/home-market/home-market.html b/apps/client/src/app/components/home-market/home-market.html
index 377050e4..43f560d8 100644
--- a/apps/client/src/app/components/home-market/home-market.html
+++ b/apps/client/src/app/components/home-market/home-market.html
@@ -8,15 +8,15 @@
       <gf-line-chart
         class="mb-3"
         symbol="Fear & Greed Index"
-        yMax="100"
-        yMin="0"
         [colorScheme]="user?.settings?.colorScheme"
         [historicalDataItems]="historicalDataItems"
         [isAnimated]="true"
         [locale]="user?.settings?.locale"
         [showXAxis]="true"
         [showYAxis]="true"
+        [yMax]="100"
         [yMaxLabel]="greedLabel"
+        [yMin]="0"
         [yMinLabel]="fearLabel"
       ></gf-line-chart>
       <gf-fear-and-greed-index
diff --git a/apps/client/src/app/components/portfolio-performance/portfolio-performance.module.ts b/apps/client/src/app/components/portfolio-performance/portfolio-performance.module.ts
index 9b2da846..5d46daf0 100644
--- a/apps/client/src/app/components/portfolio-performance/portfolio-performance.module.ts
+++ b/apps/client/src/app/components/portfolio-performance/portfolio-performance.module.ts
@@ -1,5 +1,5 @@
 import { CommonModule } from '@angular/common';
-import { NgModule } from '@angular/core';
+import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { GfValueModule } from '@ghostfolio/ui/value';
 import { NgxSkeletonLoaderModule } from 'ngx-skeleton-loader';
 
@@ -8,6 +8,7 @@ import { PortfolioPerformanceComponent } from './portfolio-performance.component
 @NgModule({
   declarations: [PortfolioPerformanceComponent],
   exports: [PortfolioPerformanceComponent],
-  imports: [CommonModule, GfValueModule, NgxSkeletonLoaderModule]
+  imports: [CommonModule, GfValueModule, NgxSkeletonLoaderModule],
+  schemas: [CUSTOM_ELEMENTS_SCHEMA]
 })
 export class GfPortfolioPerformanceModule {}
diff --git a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
index 379250fc..6756cd50 100644
--- a/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
+++ b/apps/client/src/app/components/position/position-detail-dialog/position-detail-dialog.html
@@ -213,11 +213,11 @@
           <div class="col-md-6 mb-3">
             <div class="h5" i18n>Sectors</div>
             <gf-portfolio-proportion-chart
-              [baseCurrency]="user?.settings?.baseCurrency"
+              [baseCurrency]="data.baseCurrency"
               [colorScheme]="data.colorScheme"
               [isInPercent]="true"
               [keys]="['name']"
-              [locale]="user?.settings?.locale"
+              [locale]="data.locale"
               [maxItems]="10"
               [positions]="sectors"
             ></gf-portfolio-proportion-chart>
@@ -225,11 +225,11 @@
           <div class="col-md-6 mb-3">
             <div class="h5" i18n>Countries</div>
             <gf-portfolio-proportion-chart
-              [baseCurrency]="user?.settings?.baseCurrency"
+              [baseCurrency]="data.baseCurrency"
               [colorScheme]="data.colorScheme"
               [isInPercent]="true"
               [keys]="['name']"
-              [locale]="user?.settings?.locale"
+              [locale]="data.locale"
               [maxItems]="10"
               [positions]="countries"
             ></gf-portfolio-proportion-chart>
diff --git a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.html b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.html
index 06cadad8..eab62642 100644
--- a/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.html
+++ b/apps/client/src/app/pages/portfolio/activities/import-activities-dialog/import-activities-dialog.html
@@ -8,7 +8,7 @@
 <div class="flex-grow-1" mat-dialog-content>
   <mat-stepper
     #stepper
-    [animationDuration]="0"
+    animationDuration="0"
     [linear]="true"
     [orientation]="stepperOrientation"
     [selectedIndex]="importStep"
diff --git a/apps/client/src/app/pages/public/public-page.html b/apps/client/src/app/pages/public/public-page.html
index 7d8eacf9..d7f73e19 100644
--- a/apps/client/src/app/pages/public/public-page.html
+++ b/apps/client/src/app/pages/public/public-page.html
@@ -131,9 +131,9 @@
   <div class="row">
     <div class="col-lg">
       <gf-holdings-table
-        pageSize="7"
         [deviceType]="deviceType"
         [hasPermissionToShowValues]="false"
+        [pageSize]="7"
         [positions]="positionsArray"
       ></gf-holdings-table>
     </div>
diff --git a/apps/client/src/app/pages/user-account/user-account-page.module.ts b/apps/client/src/app/pages/user-account/user-account-page.module.ts
index 3c6670af..5ec76717 100644
--- a/apps/client/src/app/pages/user-account/user-account-page.module.ts
+++ b/apps/client/src/app/pages/user-account/user-account-page.module.ts
@@ -1,5 +1,5 @@
 import { CommonModule } from '@angular/common';
-import { NgModule } from '@angular/core';
+import { CUSTOM_ELEMENTS_SCHEMA, NgModule } from '@angular/core';
 import { MatTabsModule } from '@angular/material/tabs';
 import { GfUserAccountAccessModule } from '@ghostfolio/client/components/user-account-access/user-account-access.module';
 import { GfUserAccountMembershipModule } from '@ghostfolio/client/components/user-account-membership/user-account-membership.module';
@@ -17,6 +17,7 @@ import { UserAccountPageComponent } from './user-account-page.component';
     GfUserAccountSettingsModule,
     MatTabsModule,
     UserAccountPageRoutingModule
-  ]
+  ],
+  schemas: [CUSTOM_ELEMENTS_SCHEMA]
 })
 export class UserAccountPageModule {}