sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix import for activities of type fee and interest (#2474)

Browse Source 
* Fix import for activities of type fee and interest

* Update changelog
This commit is contained in:
Thomas Kaul 2023-10-13 19:51:02 +02:00 committed by GitHub
parent 8634463597
commit 827270704a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -17,6 +17,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)
- Upgraded `prisma` from version `5.3.1` to `5.4.2` - Upgraded `prisma` from version `5.3.1` to `5.4.2`
### Fixed
- Fixed `FEE` and `INTEREST` types in the activities import of `csv` files
## 2.10.0 - 2023-10-09 ## 2.10.0 - 2023-10-09
### Added ### Added

4
apps/client/src/app/services/import-activities.service.ts
View File

@ -337,6 +337,10 @@ export class ImportActivitiesService {
return Type.BUY; return Type.BUY;
case 'dividend': case 'dividend':
return Type.DIVIDEND; return Type.DIVIDEND;
case 'fee':
return Type.FEE;
case 'interest':
return Type.INTEREST;
case 'item': case 'item':
return Type.ITEM; return Type.ITEM;
case 'liability': case 'liability':

11
test/import/ok.csv
View File

@ -1,5 +1,6 @@
Date,Code,Currency,Price,Quantity,Action,Fee,Note Date,Code,DataSource,Currency,Price,Quantity,Action,Fee,Note
16-09-2021,MSFT,USD,298.580,5,buy,19.00,My first order 🤓 01-09-2021,Account Opening Fee,MANUAL,USD,0,0,fee,49,
17/11/2021,MSFT,USD,0.62,5,dividend,0.00 16-09-2021,MSFT,YAHOO,USD,298.580,5,buy,19.00,My first order 🤓
01.01.2022,Penthouse Apartment,USD,500000.0,1,item,0.00 17/11/2021,MSFT,YAHOO,USD,0.62,5,dividend,0.00
20500606,MSFT,USD,0.00,0,buy,0.00 01.01.2022,Penthouse Apartment,MANUAL,USD,500000.0,1,item,0.00
20500606,MSFT,YAHOO,USD,0.00,0,buy,0.00

1 Date,Code,Currency,Price,Quantity,Action,Fee,Note Date,Code,DataSource,Currency,Price,Quantity,Action,Fee,Note
2 16-09-2021,MSFT,USD,298.580,5,buy,19.00,My first order 🤓 01-09-2021,Account Opening Fee,MANUAL,USD,0,0,fee,49,
3 17/11/2021,MSFT,USD,0.62,5,dividend,0.00 16-09-2021,MSFT,YAHOO,USD,298.580,5,buy,19.00,My first order 🤓
4 01.01.2022,Penthouse Apartment,USD,500000.0,1,item,0.00 17/11/2021,MSFT,YAHOO,USD,0.62,5,dividend,0.00
5 20500606,MSFT,USD,0.00,0,buy,0.00 01.01.2022,Penthouse Apartment,MANUAL,USD,500000.0,1,item,0.00
6 20500606,MSFT,YAHOO,USD,0.00,0,buy,0.00