sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix exception in portfolio details endpoint (#3896)

Browse Source 
* Fix exception caused by markets and marketsAdvanced

* Update changelog
This commit is contained in:
Thomas Kaul 2024-10-10 20:27:33 +02:00 committed by GitHub
parent 98957d282e
commit 73cd2f9cb7
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -16,6 +16,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Moved the tags from the info to the user service - Moved the tags from the info to the user service
- Switched the `prefer-const` rule from `warn` to `error` in the `eslint` configuration - Switched the `prefer-const` rule from `warn` to `error` in the `eslint` configuration
### Fixed
- Fixed an exception in the portfolio details endpoint caused by a calculation of the allocations by market
## 2.113.0 - 2024-10-06 ## 2.113.0 - 2024-10-06
### Added ### Added

2
apps/api/src/app/endpoints/public/public.controller.ts
View File

@ -76,7 +76,7 @@ export class PublicController {
}) })
]); ]);
Object.values(markets).forEach((market) => { Object.values(markets ?? {}).forEach((market) => {
delete market.valueInBaseCurrency; delete market.valueInBaseCurrency;
}); });

4
apps/api/src/app/portfolio/portfolio.controller.ts
View File

@ -172,10 +172,10 @@ export class PortfolioController {
}) || }) ||
isRestrictedView(this.request.user) isRestrictedView(this.request.user)
) { ) {
Object.values(markets).forEach((market) => { Object.values(markets ?? {}).forEach((market) => {
delete market.valueInBaseCurrency; delete market.valueInBaseCurrency;
}); });
Object.values(marketsAdvanced).forEach((market) => { Object.values(marketsAdvanced ?? {}).forEach((market) => {
delete market.valueInBaseCurrency; delete market.valueInBaseCurrency;
}); });