sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/fix gaps in portfolio performance charts (#3311)

Browse Source 
* Fix gaps in charts

* Update changelog
This commit is contained in:
Thomas Kaul 2024-04-20 15:40:59 +02:00 committed by GitHub
parent 895c4fe299
commit 551b83a6e3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -19,6 +19,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Upgraded `angular` from version `17.3.3` to `17.3.5` - Upgraded `angular` from version `17.3.3` to `17.3.5`
- Upgraded `Nx` from version `18.2.3` to `18.3.3` - Upgraded `Nx` from version `18.2.3` to `18.3.3`
### Fixed
- Fixed gaps in the portfolio performance charts by considering `BUY` and `SELL` activities
## 2.73.0 - 2024-04-17 ## 2.73.0 - 2024-04-17
### Added ### Added

6
apps/api/src/app/portfolio/calculator/twr/portfolio-calculator.ts
View File

@ -334,8 +334,10 @@ export class TWRPortfolioCalculator extends PortfolioCalculator {
if (isChartMode) { if (isChartMode) {
const datesWithOrders = {}; const datesWithOrders = {};
for (const order of orders) { for (const { date, type } of orders) {
datesWithOrders[order.date] = true; if (['BUY', 'SELL'].includes(type)) {
datesWithOrders[date] = true;
}
} }
while (isBefore(day, end)) { while (isBefore(day, end)) {