sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Feature/improve generation of random strings (#3196)

Browse Source 
* Replace Math.random() with crypto.randomBytes()

* Update changelog
This commit is contained in:
Thomas Kaul 2024-03-26 17:43:42 +01:00 committed by GitHub
parent a33f8d5bed
commit 50391e199a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed ### Changed
- Replaced `Math.random()` with `crypto.randomBytes()` for generating cryptographically secure random strings
- Upgraded `ionicons` from version `7.1.0` to `7.3.0` - Upgraded `ionicons` from version `7.1.0` to `7.3.0`
- Upgraded `yahoo-finance2` from version `2.10.0` to `2.11.0` - Upgraded `yahoo-finance2` from version `2.10.0` to `2.11.0`
- Upgraded `zone.js` from version `0.14.3` to `0.14.4` - Upgraded `zone.js` from version `0.14.3` to `0.14.4`

7
apps/api/src/app/user/user.service.ts
View File

@ -452,14 +452,15 @@ export class UserService {
} }
private getRandomString(length: number) { private getRandomString(length: number) {
const bytes = crypto.randomBytes(length);
const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789'; const characters = 'ABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
const result = []; const result = [];
for (let i = 0; i < length; i++) { for (let i = 0; i < length; i++) {
result.push( const randomByte = bytes[i];
characters.charAt(Math.floor(Math.random() * characters.length)) result.push(characters[randomByte % characters.length]);
);
} }
return result.join(''); return result.join('');
} }
} }