From 448cea0b6999ac34fc4c029a027d4f0ec060ce8a Mon Sep 17 00:00:00 2001
From: Thomas Kaul <4159106+dtslvr@users.noreply.github.com>
Date: Sun, 18 Feb 2024 10:18:53 +0100
Subject: [PATCH] Feature/improve usability of holdings table (#3017)

* Improve usability

* Update changelog
---
 CHANGELOG.md                                          |  1 +
 .../account-detail-dialog/account-detail-dialog.html  |  1 +
 apps/client/src/app/pages/public/public-page.html     |  1 +
 .../lib/holdings-table/holdings-table.component.html  |  5 ++---
 .../lib/holdings-table/holdings-table.component.ts    | 11 +++++++----
 5 files changed, 12 insertions(+), 7 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9fe813c5..65a386ed 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Improved the usability of the holdings table
 - Improved the language localization for German (`de`)
 - Upgraded `ng-extract-i18n-merge` from version `2.9.1` to `2.10.0`
 
diff --git a/apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html b/apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html
index 9cae03e2..23875bfd 100644
--- a/apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html
+++ b/apps/client/src/app/components/account-detail-dialog/account-detail-dialog.html
@@ -77,6 +77,7 @@
         <gf-holdings-table
           [baseCurrency]="user?.settings?.baseCurrency"
           [deviceType]="data.deviceType"
+          [hasPermissionToOpenDetails]="false"
           [holdings]="holdings"
           [locale]="user?.settings?.locale"
         />
diff --git a/apps/client/src/app/pages/public/public-page.html b/apps/client/src/app/pages/public/public-page.html
index 71cb2ec2..bac3189b 100644
--- a/apps/client/src/app/pages/public/public-page.html
+++ b/apps/client/src/app/pages/public/public-page.html
@@ -132,6 +132,7 @@
     <div class="col-lg">
       <gf-holdings-table
         [deviceType]="deviceType"
+        [hasPermissionToOpenDetails]="false"
         [hasPermissionToShowValues]="false"
         [holdings]="holdings"
         [pageSize]="7"
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.html b/libs/ui/src/lib/holdings-table/holdings-table.component.html
index f60b11f0..164c5e74 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.html
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.html
@@ -137,12 +137,11 @@
       mat-row
       [ngClass]="{
         'cursor-pointer':
-          hasPermissionToShowValues &&
+          hasPermissionToOpenDetails &&
           !ignoreAssetSubClasses.includes(row.assetSubClass)
       }"
       (click)="
-        hasPermissionToShowValues &&
-          !ignoreAssetSubClasses.includes(row.assetSubClass) &&
+        !ignoreAssetSubClasses.includes(row.assetSubClass) &&
           onOpenPositionDialog({
             dataSource: row.dataSource,
             symbol: row.symbol
diff --git a/libs/ui/src/lib/holdings-table/holdings-table.component.ts b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
index 94516b71..7c965f7d 100644
--- a/libs/ui/src/lib/holdings-table/holdings-table.component.ts
+++ b/libs/ui/src/lib/holdings-table/holdings-table.component.ts
@@ -26,6 +26,7 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
   @Input() baseCurrency: string;
   @Input() deviceType: string;
   @Input() hasPermissionToCreateActivity: boolean;
+  @Input() hasPermissionToOpenDetails = true;
   @Input() hasPermissionToShowValues = true;
   @Input() holdings: PortfolioPosition[];
   @Input() locale: string;
@@ -68,10 +69,12 @@ export class HoldingsTableComponent implements OnChanges, OnDestroy, OnInit {
     }
   }
 
-  public onOpenPositionDialog({ dataSource, symbol }: UniqueAsset): void {
-    this.router.navigate([], {
-      queryParams: { dataSource, symbol, positionDetailDialog: true }
-    });
+  public onOpenPositionDialog({ dataSource, symbol }: UniqueAsset) {
+    if (this.hasPermissionToOpenDetails) {
+      this.router.navigate([], {
+        queryParams: { dataSource, symbol, positionDetailDialog: true }
+      });
+    }
   }
 
   public onShowAllPositions() {