sudacode/ghostfolio
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases Activity

Bugfix/remove holdings with incomplete data from top3 bottom3 performers (#2921)

Browse Source 
* Remove holdings with incomplete data

* Update changelog
This commit is contained in:
Thomas Kaul 2024-01-26 08:35:23 +01:00 committed by GitHub
parent bbde86c66e
commit 2c10cd7edf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG.md
View File

@ -15,6 +15,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved the language localization for German (`de`) - Improved the language localization for German (`de`)
### Fixed
- Removed holdings with incomplete data from the _Top 3_ and _Bottom 3_ performers on the analysis page
## 2.44.0 - 2024-01-24 ## 2.44.0 - 2024-01-24
### Fixed ### Fixed

4
apps/client/src/app/pages/portfolio/analysis/analysis-page.component.ts
View File

@ -379,7 +379,9 @@ export class AnalysisPageComponent implements OnDestroy, OnInit {
.pipe(takeUntil(this.unsubscribeSubject)) .pipe(takeUntil(this.unsubscribeSubject))
.subscribe(({ positions }) => { .subscribe(({ positions }) => {
const positionsSorted = sortBy( const positionsSorted = sortBy(
positions, positions.filter(({ netPerformancePercentage }) => {
return isNumber(netPerformancePercentage);
}),
'netPerformancePercentage' 'netPerformancePercentage'
).reverse(); ).reverse();